| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If this change breaks some bots, please try restarting the
bot before reverting it. http://crrev.com/264460 may not be
effective yet until restarting.
See the bug and http://crrev.com/255129 for the details.
BUG=345554
Review URL: https://codereview.chromium.org/258433005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The current test also matches the CMake generator.
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/235943009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
runhooks does toolchain update, saving relevant information to
build/win_toolchain.json, and during generation this is loaded
and used. This worked almost the same previously, however update
was called at generation time and the .json was deleted after
it was used. This speeds up generation time by a few seconds.
(In preference to https://codereview.chromium.org/228093002/)
R=dpranke@chromium.org
BUG=360878
Review URL: https://codereview.chromium.org/226643011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
going away.
Since it's no longer necessary to source envsetup, having a bitness check in
here isn't very useful.
Let build/gyp_chromium always pass --check for android so that it behaves the
same as android_gyp and let android_gyp print a note that it'll disappear
eventually.
BUG=330631
NOTRY=true
Review URL: https://codereview.chromium.org/222203005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
We are no longer persuing the hybrid mode.
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/203813003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Pull out some code from gyp_chromium for less clutter, and easier to
share with GN build files this way.
R=brettw@chromium.org
BUG=297677
Review URL: https://codereview.chromium.org/203463014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This deletes the hooks and running GN to produce GYP files while the project is on hold.
BUG=350974
TBR=jam
Review URL: https://codereview.chromium.org/193053003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change is to add a new build option 'use_allocator' which will
replace 'linux_use_tcmalloc' in the future. It doesn't change the
behavior immediately. The migration plan is as follows:
1) (this change)
... Add 'use_allocator' and set its default to "see_use_tcmalloc".
... Change allocator conditions to check use_allocator firstly.
... Use linux_use_tcmalloc if use_allocator=="see_use_tcmalloc".
... NO IMPACT without specifying use_allocator explicitly.
2) Change Blink to accept use_allocator. http://crrev.com/177053003/
3) Change gyp to accept use_allocator. http://crrev.com/178643004/
4) PSA the transition period to chromium-dev@.
5) (after the PSA-ed transition period)
... Make 'use_allocator' to "tcmalloc" or "none" (it depends) by default.
... Remove all linux_use_tcmalloc.
... Assert in gyp_chromium to check if linux_use_tcmalloc is not specified.
At the point of this change (1), linux_use_tcmalloc is still used by default
because 'use_allocator%': "see_use_tcmalloc".
As written in http://crbug.com/345554, linux_use_tcmalloc would
be confusing to have more options about allocators. We plan to:
A) enable gperftools' heap-profiler with non-tcmalloc allocator,
B) add a new memory allocator instead of tcmalloc.
BUG=345554, 339604, 341349
R=agl@chromium.org, brettw@chromium.org, dgarrett@chromium.org, jam@chromium.org, jamesr@chromium.org, joi@chromium.org, miket@chromium.org, nick@chromium.org, rsleevi@chromium.org, scherkus@chromium.org, sergeyu@chromium.org, shess@chromium.org, sievers@chromium.org, sky@chromium.org, vitalybuka@chromium.org, willchan@chromium.org
Review URL: https://codereview.chromium.org/177353002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
While here, consistently use a single 'if' statement to set this
environment variable.
BUG=
Review URL: https://codereview.chromium.org/176843005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Provide a friendly error message in gyp_chromium.
R=thakis@chromium.org
BUG=348686
Review URL: https://codereview.chromium.org/184823011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moves the new Visual Studio 2013 toolchain logic and
download into a helper function. That way it can easily be used
by client projects that have their own gyp_* files.
See http://review.webrtc.org/7759004/ for an example.
NOTRY=True
TEST=Successful local execution on Mac and Windows.
Review URL: https://codereview.chromium.org/185623004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Not working for some reason and makes the output confusing, so
revert for now.
> Add free space print to see how near edge bots are
>
> Temporarily for trybots to see how close to the edge they are.
>
> TBR=iannucci@chromium.org
> BUG=348350
>
> Review URL: https://codereview.chromium.org/183923014
TBR=scottmg@chromium.org
Review URL: https://codereview.chromium.org/183833015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Not working for some reason, and makes the output confusing, so revert
for now.
> Another attempt at getting free space on win bots
TBR=scottmg@chromium.org
Review URL: https://codereview.chromium.org/185393013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Temporarily for trybots to see how close to the edge they are.
TBR=iannucci@chromium.org
BUG=348350
Review URL: https://codereview.chromium.org/183923014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Switch the default toolchain to VS2013, attempt N.
There will be WebKit image diffs on Windows, but they appear to be all
rebaseline-able minor changes.
TBR=cpu@chromium.org
BUG=309197
Review URL: https://codereview.chromium.org/185203002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254340 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Checking whether this caused several hundred Win 7 layout test image diffs.
> Default to VS2013 on Windows
>
> This switches the default toolchain on Windows to VS2013.
>
> TBR=cpu@chromium.org
> BUG=323300,309197
>
> Review URL: https://codereview.chromium.org/178263005
TBR=scottmg@chromium.org
Review URL: https://codereview.chromium.org/183993005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This switches the default toolchain on Windows to VS2013.
TBR=cpu@chromium.org
BUG=323300,309197
Review URL: https://codereview.chromium.org/178263005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
> default 2013 to on
TBR=scottmg@chromium.org
Review URL: https://codereview.chromium.org/178663006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In order to keep from needing to system-install VS runtime DLLs
for debug builds, we put them in the output directory. This
mostly works, except in the case of nacl64 it requires the x64
CRT, but builds into the x86 output directory. The OS loader will
ignore the x86 ones, and continue searching the PATH, so before
launching nacl64.exe, append to PATH to the location of the x64
CRT DLLs.
See linked bug for more details and investigation.
R=cpu@chromium.org, mseaborn@chromium.org
BUG=346034
Review URL: https://codereview.chromium.org/180223004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253504 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes the -D defines for the default desktop Linux build of re2 in GN match that of GYP.
This moves the SSL configuration stuff into the root build directory. It's better to match the GYP build exactly for ease of landing even though this is a stupid dependency.
Fixes the help text that still references the implicit "gen" command (I removed this).
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/170533003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> trial run of vs2013 with iterator debugging off to see if browser_tests are timing-related
>
> BUG=
>
> Review URL: https://codereview.chromium.org/165693005
TBR=scottmg@chromium.org
Review URL: https://codereview.chromium.org/176203003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
timing-related
BUG=
Review URL: https://codereview.chromium.org/165693005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=iannucci@chromium.org
BUG=323300,309197
Review URL: https://codereview.chromium.org/176143002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moved out of depot_tools here: https://codereview.chromium.org/168603004/
The control is in src/ now, but logic for de-duplication is still in depot_tools.
This changes the default, so that VS2013 will be the default toolchain.
R=iannucci@chromium.org
BUG=323300,309197
Review URL: https://codereview.chromium.org/175573004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Then envsetup doesn't need to set it, and the chromium.gyp_env files
used in the ios build no longer has to set this either.
BUG=330631
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/175683002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This accomplishes three things:
- simple switch back to 2010 temporarily, if necessary
- making sure that all bots don't switch at exactly the same time (almost all have GYP_MSVS_VERSION=2010 in their settings)
- in particular, not having Official builders switch
Unfortunately, this will need to be merged on to the 34 branch, as it has the current "auto-use" code, so otherwise it'd switch to 2013 as soon as depot_tools starts updating the toolchain (previously, the only check was whether the toolchain exists on the local hard drive).
R=maruel@chromium.org
BUG=323300
Review URL: https://codereview.chromium.org/174143003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome/src.
gclient runhooks runs gyp_chromium from the chrome/ dir, but the script
was looking for out/ relative to that.
BUG=323300
Review URL: https://codereview.chromium.org/174063005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252500 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This shrinks the dependency of depot_tools to only Windows and Cygwin, and allows those on other OSes to just build tarballs of sources without also having the depot_tools.
BUG=none
Review URL: https://codereview.chromium.org/171513010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Most people don't use this parameter and get arm binaries. This is
still the default, so this change shouldn't affect most people.
Folks should instead pass -Dtarget_arch to gyp. (Or, soon, envsetup will stop
clobbering GYP_DEFINES, then you can just add target_arch to your GYP_DEFINES.)
Note that in gyp land, 'mips' is called 'mipsel' and 'x86' is called 'ia32'.
'arm' stays 'arm'.
So for example, instead of running
. build/android/envsetup.sh --target-arch=mips
android_gyp
you'd run
. build/android/envsetup.sh
android_gyp -Dtarget_arch=mipsel
I updated the bots I was able to find to pass the -D flag in addition to
--target-arch. After this CL here is in, I'll update the bots to stop passing
--target-arch, and then I'll make --target-arch a hard error in this script for
a while, to make sure nobody still uses it.
BUG=330631,34476
R=torne@chromium.org
TBR=yfriedman
Review URL: https://codereview.chromium.org/171903002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, we checked that GYP_GENERATORS was "ninja", but this
broke when using GYP_GENERATORS=ninja,msvs-ninja. As there are no
other supported genearators than those two now, there's no need
to check that we're using ninja at all, so just remove that
branch of the if.
BUG=323300
R=jschuh@chromium.org
Review URL: https://codereview.chromium.org/167373004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This properly sets the DEPLOYMENT_TARGET in the generated GYP file (previously this value wa salways hardcoded to empty -- whoops!).
Sets the simulator properly. Previously when not using an explicit SDK the Xcode generator would still end up with a simulator build. This turns the flag into a tri-state so gyp_chromium can set it explicitly when an SDK is specified, but otherwise we can trigger default behavior based on Xcode/Ninja.
TBR=scottmg
Review URL: https://codereview.chromium.org/155983003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This ensures that the environment that's passed to gyp is the one that
landmines.py uses to determine when to set landmines.
Also, fix '2013e' not being detected as a 2013 switch.
BUG=309197, 323300
R=iannucci@chromium.org
Review URL: https://codereview.chromium.org/153073004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
When using the automatic toolchain for vs2013, they won't necessarily
be system-installed, so copy them next to the output binaries.
R=dpranke@chromium.org
BUG=326357
Review URL: https://codereview.chromium.org/149113004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Pick up setting for Express 2013 to get WDK_DIR set (required
for ATL with Express).
Add additional "or 2013e" to build/common.gypi, but exclude
unneeded workaround for intsafe.h.
R=dpranke@chromium.org
BUG=323300, 340358
Review URL: https://codereview.chromium.org/153143002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Separates out some "SDK" related setup on Mac land Linux like we do on Windows. I'm trying to make the "compiler" BUILD file just compiler warnings and CPU options, and have system library stuff on the platform directories.
This adds the capability for GN to produce GYP files on Mac that vary according
to the GYP generator as well as target-vs-host. I added a bunch of logic to the
GN iOS build to set up stuff accordingly based on my current knowledge of
what's required.
Sadly, this means we now have an 8-way GN build (all combinations of
debug/release, host/target, and xcode/ninja). I did some refactoring of the GYP
code in GN to make this less unreasonable.
I checked that the GYP files look the way I want, but I didn't actually test
the resulting builds yet. There is still likely to be some conditions wrong or
things not being set properly. I'm going to follow up with a second pass based on actual testing.
I believe, however, that with this new GYP generator code in GN, we can express
in the .gn files what we need to do the iOS build.
Review URL: https://codereview.chromium.org/149163005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=340055
R=halyavin@google.com
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/144573004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=326230
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/145073004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=GYP_DEFINES=msan=1 build/gyp_chromium works.
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/136973012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246188 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This supports specifying the output_dir generator flag in the gn-generating-gyp
mode. The value of the output_dir flag is mapped to a gyp variable called gyp_output_dir
and a GN argument by the same name. References from gyp to gn-generated gyp files must
use this variable and references from BUILD.gn files must use the gn argument.
BUG=335760
TBR=brettw for build/config/BUILDCONFIG.gn (looked at in person)
Review URL: https://codereview.chromium.org/142223002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
No real functionality change (except for people who have " or $ in their gomadir,
but since that didn't work up until this change nobody does that).
R=brettw@chromium.org
Review URL: https://codereview.chromium.org/140123003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/141143008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
depot_tools/python276_bin.
BUG=335180
TEST=gclient runhooks works again on Cygwin
R=maruel@chromium.org
Review URL: https://codereview.chromium.org/141563007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This generalizes the GCC iterator debugging flag to now be platform-independent.
R=scottmg@chromium.org
TBR=scottmg
Review URL: https://codereview.chromium.org/139783012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Previously this was ignored in the GN build but disabling the plugin is used on some buildbots.
BUG=http://crbug.com/330298
R=thakis@chromium.org, thakis
Review URL: https://codereview.chromium.org/142053002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245602 0039d316-1c4b-4281-b951-d872f2087c98
|