| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
For historical reasons gyp_chromium.py was launcher script
for gyp_chromium and the python logic lived in the
gyp_chromium. This change moves python code into the
.py file makes the extension-free gyp_chromium a launcher
for gyp_chromium.py.
Review URL: https://codereview.chromium.org/1216863010
Cr-Commit-Position: refs/heads/master@{#342887}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
//ios unit tests will soon required access to packed resources (both theme
and strings) so add steps required to repack data.
Those steps only pack what is required by //ios unit tests and thus pack to
repack_ios to avoid collision with downstream packing steps. Eventually the
upstream and downstream repack steps will be merged.
This forks some steps from //chrome since //ios cannot depends on //chrome
and those steps are too specific to Chrome to be moved higher in //build.
BUG=429756,475514
Review URL: https://codereview.chromium.org/1164983004
Cr-Commit-Position: refs/heads/master@{#333229}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reinstates the duplicate basename check, on Mac only.
$ git log 0bb67471b..29e94a328 --date=short --format='%ad %ae %s'
2015-05-21 scottmg Avoid lint presubmit error in dump_dependency_json
2015-05-21 scottmg Update shared_library test after c0cf1f22eb
2015-05-21 scottmg Revert "Stop checking for duplicate basenames"
2015-05-14 scottmg Added msvs_application_type_revision for winrt compilation
2015-05-12 torne Remove the Android generator.
R=thakis@chromium.org
BUG=490824, gyp:384, 472772
Review URL: https://codereview.chromium.org/1152323002
Cr-Commit-Position: refs/heads/master@{#331626}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use subprocess.call() rather than Popen + communicate.
The shell argument to Popen defaults to False so was
redundant.
Use any() rather than explicit loop.
Review URL: https://codereview.chromium.org/1144383002
Cr-Commit-Position: refs/heads/master@{#330854}
|
|
|
|
|
|
|
|
|
|
| |
It's very easy to get into a situation where components.gyp depends on content_shell_and_tests.gyp which depends on components.gyp. This CL gets rid of the check on Mac. The dependency check is now only performed on iOS.
BUG=none
Review URL: https://codereview.chromium.org/1106283004
Cr-Commit-Position: refs/heads/master@{#327826}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A change in the native_client/build/find_depot_tools, which
was presumably intended to be only for that project, got
picked up because the path creation puts that directory ahead
of the general tools directory. This change makes sure that
"tools" modules always take precedence.
BUG=477848
Review URL: https://codereview.chromium.org/1090013002
Cr-Commit-Position: refs/heads/master@{#325851}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This changes includes all the locale .pak files into the
WebView apk when building it from the chromium tree,
similarly to what we're doing when building it from the
Android tree, see android_webview/Android.mk.
BUG=405035
TESTED=Manual. Verified that the set of locales in the
downstream and upstream SystemWebViewGoogle.apk is the same.
Review URL: https://codereview.chromium.org/868673003
Cr-Commit-Position: refs/heads/master@{#315001}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Handle -G output_dir=foo as well as -Goutput_dir=foo.
I'm not sure how common this case is but we have
NaCl SDK bot that do this.
Getting this wrong results in windows toolchain being
installed in 'out/' (which doesn't necessarily exist)
rather than the output_dir tree and gyp uses.
Add unittests for the affected parts of gyp_chromium.
BUG=454594
Review URL: https://codereview.chromium.org/896663002
Cr-Commit-Position: refs/heads/master@{#314381}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This generator hasn't worked for a long time, but it's not obvious
that it doesn't work which can be confusing.
R=thakis@chromium.org
BUG=446912
Review URL: https://codereview.chromium.org/797373004
Cr-Commit-Position: refs/heads/master@{#310421}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows us to override the settings in common.gypi, as
well as other include files. Only accepts one string, not an
array. Limitation of gyp_helper.
BUG=
Review URL: https://codereview.chromium.org/705663002
Cr-Commit-Position: refs/heads/master@{#302841}
|
|
|
|
|
|
|
|
|
|
|
| |
This adds a new build rule for generating Java constants for C++ enums.
BUG=405532
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/484603004
Cr-Commit-Position: refs/heads/master@{#294153}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Python always does reference counting and that handles most of the
objects used by GYP. The GC is used to detect and drop circular
references. If GC is turned off then the heap scanning can be skipped
to save some CPU cycles, and the memory leaked due to circular
references isn't noticeable.
This saves about 1 second out of 16 on Linux in a Z620 workstation.
BUG=None
Review URL: https://codereview.chromium.org/495993002
Cr-Commit-Position: refs/heads/master@{#291287}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows for Chromecast's locale repack script (based off the
implementation in chrome/) to specificy Chromecast-specific files.
R=lcwu@chromium.org
BUG=403104
Review URL: https://codereview.chromium.org/466133003
Cr-Commit-Position: refs/heads/master@{#289699}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moves (some of) gyp environment setup out of gyp_chromium into separate
module, and shares that between gyp_chromium and landmines.py.
landmines.py is added as the first entry in DEPS hooks so that it can
clobber the entire build directory before running other hooks that
extract/generate into the build dir.
Reland with fix for ios, and for clean pull.
R=iannucci@chromium.org
BUG=400011
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289099
Review URL: https://codereview.chromium.org/457003004
Cr-Commit-Position: refs/heads/master@{#289546}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289546 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/457003004/)
Reason for revert:
Apparently this requires win_toolchain.json to exist, but I'm not sure how it's supposed to get there (as seen on a clobber build):
Traceback (most recent call last):
File "src/build/landmines.py", line 132, in <module>
sys.exit(main())
File "src/build/landmines.py", line 119, in main
gyp_environment.SetEnvironment()
File "C:\b\build\slave\win_trunk\build\src\build\gyp_environment.py", line 33, in SetEnvironment
vs_toolchain.SetEnvironmentAndGetRuntimeDllDirs()
File "C:\b\build\slave\win_trunk\build\src\build\vs_toolchain.py", line 33, in SetEnvironmentAndGetRuntimeDllDirs
with open(json_data_file, 'r') as tempf:
IOError: [Errno 2] No such file or directory: 'C:\\b\\build\\slave\\win_trunk\\build\\src\\build\\win_toolchain.json'
Original issue's description:
> Make landmines work on local builds too
>
> Moves (some of) gyp environment setup out of gyp_chromium into separate
> module, and shares that between gyp_chromium and landmines.py.
>
> landmines.py is added as the first entry in DEPS hooks so that it can
> clobber the entire build directory before running other hooks that
> extract/generate into the build dir.
>
> R=iannucci@chromium.org
> BUG=400011
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289099
TBR=scottmg@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=400011
Review URL: https://codereview.chromium.org/469623002
Cr-Commit-Position: refs/heads/master@{#289158}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moves (some of) gyp environment setup out of gyp_chromium into separate
module, and shares that between gyp_chromium and landmines.py.
landmines.py is added as the first entry in DEPS hooks so that it can
clobber the entire build directory before running other hooks that
extract/generate into the build dir.
R=iannucci@chromium.org
BUG=400011
Review URL: https://codereview.chromium.org/457003004
Cr-Commit-Position: refs/heads/master@{#289099}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289099 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Analyze exceptions have been centralized, so I can remove the
exceptions from each of the trybot files.
--analyzer2 is no longer used by the recipes.
BUG=109173
TEST=none
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/463193002
Cr-Commit-Position: refs/heads/master@{#289094}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Then I can convert recipes back to --analyzer and finally remove
--analyzer2. Oy!
BUG=109173
TEST=none
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/447183006
Cr-Commit-Position: refs/heads/master@{#288360}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I was going to output to stdout, but I think that's a bad idea. Now we
specify a path.
BUG=398118
TEST=none
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/426323002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is temporary while I migrate recipes over to the new
switches. I'll remove analyzer2 once that is done.
BUG=398118
TEST=none
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/426783002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286307 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Analyzer is going to be used to determine if a set of files effects
any of the dependencies for a bot.
BUG=383609
TEST=none
Review URL: https://codereview.chromium.org/337903004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=machenbach@chromium.org
BUG=none
Review URL: https://codereview.chromium.org/314933004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If this change breaks some bots, please try restarting the
bot before reverting it. http://crrev.com/264460 may not be
effective yet until restarting.
See the bug and http://crrev.com/255129 for the details.
BUG=345554
Review URL: https://codereview.chromium.org/258433005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The current test also matches the CMake generator.
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/235943009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
runhooks does toolchain update, saving relevant information to
build/win_toolchain.json, and during generation this is loaded
and used. This worked almost the same previously, however update
was called at generation time and the .json was deleted after
it was used. This speeds up generation time by a few seconds.
(In preference to https://codereview.chromium.org/228093002/)
R=dpranke@chromium.org
BUG=360878
Review URL: https://codereview.chromium.org/226643011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
going away.
Since it's no longer necessary to source envsetup, having a bitness check in
here isn't very useful.
Let build/gyp_chromium always pass --check for android so that it behaves the
same as android_gyp and let android_gyp print a note that it'll disappear
eventually.
BUG=330631
NOTRY=true
Review URL: https://codereview.chromium.org/222203005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
We are no longer persuing the hybrid mode.
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/203813003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Pull out some code from gyp_chromium for less clutter, and easier to
share with GN build files this way.
R=brettw@chromium.org
BUG=297677
Review URL: https://codereview.chromium.org/203463014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This deletes the hooks and running GN to produce GYP files while the project is on hold.
BUG=350974
TBR=jam
Review URL: https://codereview.chromium.org/193053003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change is to add a new build option 'use_allocator' which will
replace 'linux_use_tcmalloc' in the future. It doesn't change the
behavior immediately. The migration plan is as follows:
1) (this change)
... Add 'use_allocator' and set its default to "see_use_tcmalloc".
... Change allocator conditions to check use_allocator firstly.
... Use linux_use_tcmalloc if use_allocator=="see_use_tcmalloc".
... NO IMPACT without specifying use_allocator explicitly.
2) Change Blink to accept use_allocator. http://crrev.com/177053003/
3) Change gyp to accept use_allocator. http://crrev.com/178643004/
4) PSA the transition period to chromium-dev@.
5) (after the PSA-ed transition period)
... Make 'use_allocator' to "tcmalloc" or "none" (it depends) by default.
... Remove all linux_use_tcmalloc.
... Assert in gyp_chromium to check if linux_use_tcmalloc is not specified.
At the point of this change (1), linux_use_tcmalloc is still used by default
because 'use_allocator%': "see_use_tcmalloc".
As written in http://crbug.com/345554, linux_use_tcmalloc would
be confusing to have more options about allocators. We plan to:
A) enable gperftools' heap-profiler with non-tcmalloc allocator,
B) add a new memory allocator instead of tcmalloc.
BUG=345554, 339604, 341349
R=agl@chromium.org, brettw@chromium.org, dgarrett@chromium.org, jam@chromium.org, jamesr@chromium.org, joi@chromium.org, miket@chromium.org, nick@chromium.org, rsleevi@chromium.org, scherkus@chromium.org, sergeyu@chromium.org, shess@chromium.org, sievers@chromium.org, sky@chromium.org, vitalybuka@chromium.org, willchan@chromium.org
Review URL: https://codereview.chromium.org/177353002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
While here, consistently use a single 'if' statement to set this
environment variable.
BUG=
Review URL: https://codereview.chromium.org/176843005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Provide a friendly error message in gyp_chromium.
R=thakis@chromium.org
BUG=348686
Review URL: https://codereview.chromium.org/184823011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moves the new Visual Studio 2013 toolchain logic and
download into a helper function. That way it can easily be used
by client projects that have their own gyp_* files.
See http://review.webrtc.org/7759004/ for an example.
NOTRY=True
TEST=Successful local execution on Mac and Windows.
Review URL: https://codereview.chromium.org/185623004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Not working for some reason and makes the output confusing, so
revert for now.
> Add free space print to see how near edge bots are
>
> Temporarily for trybots to see how close to the edge they are.
>
> TBR=iannucci@chromium.org
> BUG=348350
>
> Review URL: https://codereview.chromium.org/183923014
TBR=scottmg@chromium.org
Review URL: https://codereview.chromium.org/183833015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Not working for some reason, and makes the output confusing, so revert
for now.
> Another attempt at getting free space on win bots
TBR=scottmg@chromium.org
Review URL: https://codereview.chromium.org/185393013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Temporarily for trybots to see how close to the edge they are.
TBR=iannucci@chromium.org
BUG=348350
Review URL: https://codereview.chromium.org/183923014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Switch the default toolchain to VS2013, attempt N.
There will be WebKit image diffs on Windows, but they appear to be all
rebaseline-able minor changes.
TBR=cpu@chromium.org
BUG=309197
Review URL: https://codereview.chromium.org/185203002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254340 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Checking whether this caused several hundred Win 7 layout test image diffs.
> Default to VS2013 on Windows
>
> This switches the default toolchain on Windows to VS2013.
>
> TBR=cpu@chromium.org
> BUG=323300,309197
>
> Review URL: https://codereview.chromium.org/178263005
TBR=scottmg@chromium.org
Review URL: https://codereview.chromium.org/183993005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This switches the default toolchain on Windows to VS2013.
TBR=cpu@chromium.org
BUG=323300,309197
Review URL: https://codereview.chromium.org/178263005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
> default 2013 to on
TBR=scottmg@chromium.org
Review URL: https://codereview.chromium.org/178663006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In order to keep from needing to system-install VS runtime DLLs
for debug builds, we put them in the output directory. This
mostly works, except in the case of nacl64 it requires the x64
CRT, but builds into the x86 output directory. The OS loader will
ignore the x86 ones, and continue searching the PATH, so before
launching nacl64.exe, append to PATH to the location of the x64
CRT DLLs.
See linked bug for more details and investigation.
R=cpu@chromium.org, mseaborn@chromium.org
BUG=346034
Review URL: https://codereview.chromium.org/180223004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253504 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes the -D defines for the default desktop Linux build of re2 in GN match that of GYP.
This moves the SSL configuration stuff into the root build directory. It's better to match the GYP build exactly for ease of landing even though this is a stupid dependency.
Fixes the help text that still references the implicit "gen" command (I removed this).
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/170533003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> trial run of vs2013 with iterator debugging off to see if browser_tests are timing-related
>
> BUG=
>
> Review URL: https://codereview.chromium.org/165693005
TBR=scottmg@chromium.org
Review URL: https://codereview.chromium.org/176203003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
timing-related
BUG=
Review URL: https://codereview.chromium.org/165693005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=iannucci@chromium.org
BUG=323300,309197
Review URL: https://codereview.chromium.org/176143002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252738 0039d316-1c4b-4281-b951-d872f2087c98
|