summaryrefslogtreecommitdiffstats
path: root/build/linux
Commit message (Collapse)AuthorAgeFilesLines
* Use PKG_CONFIG_LIBDIR to force pkg-config to use sysroot onlysbc2016-01-132-13/+10
| | | | | | | | | | | | | | Previously we were using PKG_CONFIG_PATH to tell pkg-config to search the sysroot directories. However the default libpath is always added to this path, so pkg-config would fall back to looking in the system directories. Using PKG_CONFIG_LIBDIR instead overrides the default libdir which makes the build more hermetic and forces the sysroot to provide all the required .pc files. Review URL: https://codereview.chromium.org/1580643002 Cr-Commit-Position: refs/heads/master@{#369224}
* Update linux sysroot imagessbc2016-01-121-8/+8
| | | | | | | | | | | | | This change bring is in following change to sysroot contents: 82063a2: Add chromeos-specific packages to linux sysroot image 34a5998: Add more packages to the Wheezy sysroot BUG=576807 Review URL: https://codereview.chromium.org/1576293002 Cr-Commit-Position: refs/heads/master@{#369012}
* Add chromeos-specific packages to linux sysroot imagesbc2016-01-125-0/+10
| | | | | | | | | | | This will allow the chromeos=1 build to work against the wheezy sysroot BUG=576807 Review URL: https://codereview.chromium.org/1578313002 Cr-Commit-Position: refs/heads/master@{#368977}
* Add more packages to the Wheezy sysroot.raphael.kubo.da.costa2016-01-045-0/+10
| | | | | | | | | | | | | | | x11proto-xinerama-dev is needed by libxinerama-dev, libxdmcp-dev is used by xcb. With this change (and after regenerating the sysroot), it is possible to run gn and configure the build without having a single pkg-config in the host system (tested on amd64). R=sbc@chromium.org,dpranke@chromium.org Review URL: https://codereview.chromium.org/1539393002 Cr-Commit-Position: refs/heads/master@{#367302}
* Download sysroot from "commondatastorage.googleapis.com"b.kelemen2015-12-211-1/+1
| | | | | | | | | | For some reason our intranet here is blocking googleapis.com. Actually other tools that are updated via runhooks are using that alias url already (e.g. clang). Review URL: https://codereview.chromium.org/1534873002 Cr-Commit-Position: refs/heads/master@{#366481}
* move libevent into basetfarina2015-12-192-2/+2
| | | | | | | | | | | | | | | This simplifies the process of bootstrapping gn standalone. And libevent is not really used outside of base. base is actually its only client. BUG=569352 TEST=See CL for details for how to reproduce this. R=thestig@chromium.org TBR=cpu@chromium.org Review URL: https://codereview.chromium.org/1531573008 Cr-Commit-Position: refs/heads/master@{#366282}
* gyp: always use pkg-config wrappersbc2015-12-171-21/+21
| | | | | | | | | | | Without this the sysroot is not honored and pkg-config always finds the host's .pc file. BUG=569947 Review URL: https://codereview.chromium.org/1529883004 Cr-Commit-Position: refs/heads/master@{#365707}
* Update linux sysroot imagessbc2015-12-161-8/+8
| | | | | | | | | | | | This brings in the following changes to the sysroot: - d746383 Include /usr/share/pkgconfig files in sysroot image - 475c72a Add libpthread-stubs0-dev to sysroot image BUG=569947 Review URL: https://codereview.chromium.org/1536433003 Cr-Commit-Position: refs/heads/master@{#365655}
* Include /usr/share/pkgconfig files in sysroot imagesbc2015-12-161-13/+19
| | | | | | | | | | | | | | The whole of /usr/share was previously being excluded which meant that our sysroot builds were relying on .pc files from the host environment in some cases. This change requires https://codereview.chromium.org/1531513002 BUG=569947 Review URL: https://codereview.chromium.org/1531513002 Cr-Commit-Position: refs/heads/master@{#365570}
* GN: Don't default to using lib64 in PKG_CONFIG_PATHsbc2015-12-161-7/+0
| | | | | | | | | | | | | | | | | | | | | | This change makes gn's pkg-config.py match more closely the behavior of pkg-config-wrapper. pkg-config-wrapper is always run with the third argument set to '<(system_libdir)', which defaults to 'lib', which means that gyp never using lib64 in practice. Even though system_libdir is supported in gyp, there is currently no equivalent that I can find in gn, so I left a TODO. This change is required before we can land the sysroot change that populates /usr/lib/pkgconfig: https://codereview.chromium.org/1531513002 BUG=569947 Review URL: https://codereview.chromium.org/1530723002 Cr-Commit-Position: refs/heads/master@{#365415}
* Add libpthread-stubs0-dev to sysroot imagesbc2015-12-155-0/+5
| | | | | | | | | | | | This is required by the xcb pkg-config file but has gone unnoticed since most host systems have this installed. BUG=569949 Review URL: https://codereview.chromium.org/1530683003 Cr-Commit-Position: refs/heads/master@{#365384}
* Always install host sysroot when running install-sysroot.pysbc2015-12-091-62/+74
| | | | | | | | | | | | The gn bots require both host and target sysrot images installed. This change is needed to convert the Linux ARM bot gn. BUG=564059 Review URL: https://codereview.chromium.org/1499313002 Cr-Commit-Position: refs/heads/master@{#363916}
* Fix Linux unbundled zlib.gyp's duplicate target.thestig2015-12-081-19/+0
| | | | | | | | | | | | | | The target already exists in third_party/zlib/google/zip.gyp. Also: - Remove stale reference to use_system_zlib - Fix build warnings in spdy_framer.cc. TBR=bnc@chromium.org Review URL: https://codereview.chromium.org/1414393011 Cr-Commit-Position: refs/heads/master@{#363834}
* Make //device pass "gn check"brettw2015-12-041-1/+1
| | | | | | Review URL: https://codereview.chromium.org/1484643002 Cr-Commit-Position: refs/heads/master@{#363307}
* Always install default host sysroots from gclient runhooksagrieve2015-12-041-19/+16
| | | | | | | | | | | This removes some of the smarts that relied on GYP_DEFINES being set. With the move to GN, GYP_DEFINES will often not be set. BUG=564869 Review URL: https://codereview.chromium.org/1493913002 Cr-Commit-Position: refs/heads/master@{#363218}
* Reland of Use sysroot by default for all linux builds (patchset #1 id:1 of ↵sbc2015-11-241-26/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1473363002/ ) Reason for revert: Couldn't reproduce the failure. Original issue's description: > Revert of Use sysroot by default for all linux builds (patchset #7 id:120001 of https://codereview.chromium.org/1464983003/ ) > > Reason for revert: > Seems to have caused issues with goma: https://code.google.com/p/chromium/issues/detail?id=560973 > > Original issue's description: > > Use sysroot by default for all linux builds > > > > Using a sysroot was already the default for official > > build and when cross compiling (e.g. arm, mips, x86-32). > > This change makes it the default in all cases. > > > > The old behavior of building against local > > system libraries can still be achieved by > > setting use_sysroot=0 > > > > BUG=504446 > > > > Committed: https://crrev.com/a931efd5dc8d8783ce73a64fc641627866b6869d > > Cr-Commit-Position: refs/heads/master@{#361197} > > TBR=dpranke@chromium.org,thestig@chromium.org,thakis@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=504446 > > Committed: https://crrev.com/05373dc078f0d5d3f2fb1398db9a4008a55d9016 > Cr-Commit-Position: refs/heads/master@{#361405} TBR=dpranke@chromium.org,thestig@chromium.org,thakis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=504446 Review URL: https://codereview.chromium.org/1472873004 Cr-Commit-Position: refs/heads/master@{#361411}
* Revert of Use sysroot by default for all linux builds (patchset #7 id:120001 ↵sbc2015-11-241-4/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | of https://codereview.chromium.org/1464983003/ ) Reason for revert: Seems to have caused issues with goma: https://code.google.com/p/chromium/issues/detail?id=560973 Original issue's description: > Use sysroot by default for all linux builds > > Using a sysroot was already the default for official > build and when cross compiling (e.g. arm, mips, x86-32). > This change makes it the default in all cases. > > The old behavior of building against local > system libraries can still be achieved by > setting use_sysroot=0 > > BUG=504446 > > Committed: https://crrev.com/a931efd5dc8d8783ce73a64fc641627866b6869d > Cr-Commit-Position: refs/heads/master@{#361197} TBR=dpranke@chromium.org,thestig@chromium.org,thakis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=504446 Review URL: https://codereview.chromium.org/1473363002 Cr-Commit-Position: refs/heads/master@{#361405}
* Use sysroot by default for all linux buildssbc2015-11-231-26/+4
| | | | | | | | | | | | | | | | Using a sysroot was already the default for official build and when cross compiling (e.g. arm, mips, x86-32). This change makes it the default in all cases. The old behavior of building against local system libraries can still be achieved by setting use_sysroot=0 BUG=504446 Review URL: https://codereview.chromium.org/1464983003 Cr-Commit-Position: refs/heads/master@{#361197}
* Update linux sysroot imagesbc2015-11-231-8/+8
| | | | | | | | | | | | | This adds libffi-dev and libdrm-dev to the image which were recently added with: https://codereview.chromium.org/1464123002 R=thestig@chromium.org BUG=559062 Review URL: https://codereview.chromium.org/1466383002 Cr-Commit-Position: refs/heads/master@{#361129}
* Add libffi-dev and libdrm-dev to linux sysroot imagesbc2015-11-227-444/+637
| | | | | | | | | | | | | Also, the extra libdrm dependencies needed. The packagelists were updated by running: ./sysroot-creator-wheezy.sh UpdatePackageListsAll BUG=559062 Review URL: https://codereview.chromium.org/1464123002 Cr-Commit-Position: refs/heads/master@{#361035}
* Add Roboto fonts and update Noto fonts in install-chromeos-fonts.py.dzhioev2015-11-151-11/+23
| | | | | | | | | | | notofonts: 20150706 robotofonts: 20150625 BUG=none Review URL: https://codereview.chromium.org/1449563004 Cr-Commit-Position: refs/heads/master@{#359769}
* third_party: Add wayland library.reveman2015-11-141-0/+21
| | | | | | | | | | | | This adds the wayland library to third_party and libffi as a build dependency on linux. libffi is already a run-time dependency as libgobject depends on it. BUG=549782 Review URL: https://codereview.chromium.org/1426583009 Cr-Commit-Position: refs/heads/master@{#359701}
* Install both 32 and 64 bit x86 sysroots when arm is the target_cpuagrieve2015-11-121-20/+47
| | | | | | | | | | | This is required by Android since it builds both 64 and 32 bit v8 snapshots, which need to be built on the host by toolchains with the matching bit-width. BUG=552040 Review URL: https://codereview.chromium.org/1430143002 Cr-Commit-Position: refs/heads/master@{#359212}
* headless: Add gn setting headless modeskyostil2015-11-111-1/+1
| | | | | | | | | | | | | | The is_headless setting configures the build in the same way as the embedded flag in gyp. Contributions by Alexander Timin <altimin@chromium.org> and Alex Clarke <alexclarke@chromium.org>. BUG=546953,318413 Review URL: https://codereview.chromium.org/1410883007 Cr-Commit-Position: refs/heads/master@{#359096}
* remove_bundled_libraries.py: preserve .gn and .gni filesPaweł Hajdan, Jr2015-11-061-0/+4
| | | | | | | | | BUG=551343 R=tandrii@chromium.org Review URL: https://codereview.chromium.org/1419843007 . Cr-Commit-Position: refs/heads/master@{#358320}
* [Chromecast] Replace 'fontconfig' GN target with dynamic dependency.slan2015-09-251-0/+12
| | | | | | | | | | | | | Chromecast needs to be able to optionally use //third_party/fontconfig instead of system headers. This CL acheives parity with the GYP build for this feature: https://code.google.com/p/chromium/codesearch#chromium/src/build/linux/system.gyp&l=748 BUG=516899 Review URL: https://codereview.chromium.org/1366653003 Cr-Commit-Position: refs/heads/master@{#350711}
* Copy libvpx from DEPS to srcjohannkoenig2015-09-181-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Leaves the previous version in place but updates BUILD.gn and libvpx.gn to point to the new version. This allows decoupling the WebRTC update which is also in DEPS. libvpx DEPS changes ac1772e:0d6551 https://codereview.chromium.org/1339033002 https://chromium-review.googlesource.com/299759 https://codereview.chromium.org/1350853003 https://codereview.chromium.org/1353433003 Copy directory to libvpx_new to avoid breaking bisecting. This allows the user to move between and older and newer revision. A followup to rename libvpx_new to libvpx will come in some ~months because there are additional complications if one tries to sync directly from pre-move to post-rename or the other way around. Remove WATCHLISTS and codereview.settings from _new and use the parent versions. Add DEPS file to enumerate the #include paths. Check out third_party/libvpx_new/source/libvpx directly from upstream project Update all the easy clients of libvpx to depend on the new tree directly. https://chromium.googlesource.com/chromium/deps/libvpx/+/ac1772e3db5c885b554f6a72ca9dbac4245cb0e2 BUG=481034 R=tomfinegan@chromium.org,brettw@chromium.org,phajdan.jr@chromium.org Review URL: https://codereview.chromium.org/1323333002 Cr-Commit-Position: refs/heads/master@{#349789}
* Always expose libdrm dependency when chromeos==1Michael Spang2015-09-161-1/+1
| | | | | | | | | | | | | This fixes a build break for linux chromeos: gyp: Dependency '/b/build/slave/linux_chromeos/build/src/build/linux/system.gyp:libdrm#target' not found while trying to load target /b/build/slave/linux_chromeos/build/src/content/content_shell_and_tests.gyp:vaapi_jpeg_decoder_unittest#target BUG=531814 TEST=gclient runhooks with "use_ozone=1 chromeos=1" Review URL: https://codereview.chromium.org/1346003002 . Cr-Commit-Position: refs/heads/master@{#349057}
* ozone: Remove the "drm" software composited platformspang2015-09-151-1/+1
| | | | | | | | | | | | | | | | | This is a software-only platform that was used early in the process of bringing up the Chrome OS ozone/freon (no X11) build. It's time to remove it because it now requires not only scary flags to get it going, but also a patch (https://codereview.chromium.org/1216303004/). If we need a build with software rasterization let's use vgem+swrast like our VMtests do. BUG=531814 TEST=link still works fine with platform=gbm Review URL: https://codereview.chromium.org/1345703002 Cr-Commit-Position: refs/heads/master@{#349012}
* Add Chrome OS's minigbm library to third_partyspang2015-09-141-21/+0
| | | | | | | | | | | | | | | | | | | | | | | | | This library is used by Chrome on Chrome OS to allocate accelerated graphics buffers. The version avaiable on Ubuntu is too old, and as a result we can't run unit tests for the gbm platform code on developer workstations or on the waterfall. This adds the library to third_party and fixes up the build files to use either the OS copy (for Chrome OS release builds) or gardened copy (for testing on the waterfall) depending on the value of "use_system_minigbm". BUG=530712 TEST= GYP_DEFINES="use_ozone=1 chromeos=1 ozone_platform_gbm=1 use_system_minigbm=0" gclient runhooks ninja -C out/Release ozone_unittests ./out/Release/ozone_unittests gn gen out_gn_ozone --args='target_os="chromeos" use_ozone=true ozone_platform_gbm=true use_system_minigbm=false' ninja -C out_gn_ozone ozone_unittests ./out_gn_ozone/Release/ozone_unittests Review URL: https://codereview.chromium.org/1341473003 Cr-Commit-Position: refs/heads/master@{#348758}
* Reland of Fix typo in install-sysroot.py (patchset #1 id:1 of ↵akuegel2015-09-091-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1315773003/ ) Reason for revert: The check_licenses script has been fixed, and it cycled green: https://build.chromium.org/p/chromium/builders/Linux/builds/66708 Original issue's description: > Revert of Fix typo in install-sysroot.py (patchset #2 id:20001 of https://codereview.chromium.org/1317973005/ ) > > Reason for revert: > Caused check_licenses to fail: > > https://build.chromium.org/p/chromium/builders/Linux/builds/66701 > > Original issue's description: > > Fix typo in install-sysroot.py > > > > install-sysroot.py was intended to default to installing > > the sysroot ia32, but within this script 'i386' is used to > > refer to this architecture. > > > > This most likely went unnoticed since the ia32 builder > > either use branding=Official, or explicitly set > > use_sysroot=1, or have a complete set of packages for > > cross building on the host system. > > > > BUG=504446 > > > > Committed: https://crrev.com/1d62049b4c176fbd43bed90fc9a76273b11ad406 > > Cr-Commit-Position: refs/heads/master@{#347821} > > TBR=dpranke@chromium.org,sbc@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=504446 > > Committed: https://crrev.com/3b27a2de111759359162bcad49753e17ee1cf002 > Cr-Commit-Position: refs/heads/master@{#347839} TBR=dpranke@chromium.org,sbc@chromium.org,chrishtr@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=504446 Review URL: https://codereview.chromium.org/1324853005 Cr-Commit-Position: refs/heads/master@{#347901}
* Revert of Fix typo in install-sysroot.py (patchset #2 id:20001 of ↵chrishtr2015-09-081-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1317973005/ ) Reason for revert: Caused check_licenses to fail: https://build.chromium.org/p/chromium/builders/Linux/builds/66701 Original issue's description: > Fix typo in install-sysroot.py > > install-sysroot.py was intended to default to installing > the sysroot ia32, but within this script 'i386' is used to > refer to this architecture. > > This most likely went unnoticed since the ia32 builder > either use branding=Official, or explicitly set > use_sysroot=1, or have a complete set of packages for > cross building on the host system. > > BUG=504446 > > Committed: https://crrev.com/1d62049b4c176fbd43bed90fc9a76273b11ad406 > Cr-Commit-Position: refs/heads/master@{#347821} TBR=dpranke@chromium.org,sbc@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=504446 Review URL: https://codereview.chromium.org/1315773003 Cr-Commit-Position: refs/heads/master@{#347839}
* Fix typo in install-sysroot.pysbc2015-09-081-1/+1
| | | | | | | | | | | | | | | | | install-sysroot.py was intended to default to installing the sysroot ia32, but within this script 'i386' is used to refer to this architecture. This most likely went unnoticed since the ia32 builder either use branding=Official, or explicitly set use_sysroot=1, or have a complete set of packages for cross building on the host system. BUG=504446 Review URL: https://codereview.chromium.org/1317973005 Cr-Commit-Position: refs/heads/master@{#347821}
* Make gtk2/gtk3 compile time switchable.erg2015-09-011-2/+70
| | | | | | | | | | | This adds a "use_gtk3" gyp/gn flag, along with a separate gtk2/gtk3 targets in system.gyp and //build/config/linux/gtk[23] in gn. BUG=132847 Review URL: https://codereview.chromium.org/1293073006 Cr-Commit-Position: refs/heads/master@{#346742}
* Move loader stub libraries out of //build/config/linuxdpranke2015-08-281-0/+105
| | | | | | | | | | | | | | | | | | The //build/config/linux library defined a number of targets built through the generate_library_loader target. All of these are fairly chrome-specific, so having them defined in the //build/config/linux file made it harder to reuse that file in non-chrome GN builds (like native_client). This CL moves the targets out to a new //build/linux directory and updates the callers accordingly. R=brettw@chromium.org BUG= Review URL: https://codereview.chromium.org/1314163005 Cr-Commit-Position: refs/heads/master@{#346242}
* Explicit declare drm library directorykalyan.kondapally2015-08-061-0/+3
| | | | | | | | | | | I found this issue, while trying to use libdrm with some custom changes and not installed in the default system path. We are already checking drm system library and cflags using pkg, this patch extends it for the directory too. Review URL: https://codereview.chromium.org/1254133009 Cr-Commit-Position: refs/heads/master@{#342229}
* content: Remove unused speex related code.tfarina2015-07-282-46/+0
| | | | | | | | | | | | | | | With the discussion of third_party/speex/OWNERS in chromium-dev mailing list we ended up turning out that this code was actually not used. https://groups.google.com/a/chromium.org/d/topic/chromium-dev/tBiPPpqfku4/discussion BUG=513929 TEST=content_unittests R=philip@opera.com,brettw@chromium.org Review URL: https://codereview.chromium.org/1257923002 Cr-Commit-Position: refs/heads/master@{#340637}
* Cleanup logic for deciding when to install linux sysrootsbc2015-07-171-11/+23
| | | | | | | | | | | | The only semantic change here is that the sysroot will be installed for ia32 cross builds by default, like it is for arm and mips already. BUG=504446 Review URL: https://codereview.chromium.org/1240123004 Cr-Commit-Position: refs/heads/master@{#339343}
* [Ozone] Remove deprecated DRI platform namednicoara2015-07-141-1/+1
| | | | | | | | | | | The platform was renamed to DRM. The DRI name was left in place until the ChromeOS changes were done. BUG=none Review URL: https://codereview.chromium.org/1198573002 Cr-Commit-Position: refs/heads/master@{#338753}
* Move linux sysroots from chrome/installer/linux to build/linuxsbc2015-06-3010-0/+1906
| | | | | | | | | | | | | | | | | | | | | | The sysroot are generally useful (for example when cross compiling) and not limited to use in the installer or official releases. Another reason to move this is that it would allow other projects to more easily share chromium's build setup without depending on chrome/. Also, rename the install script to simply install-sysroot. This way the script can keep the same name and support multiple different debian releases without needing to duplicate the script (e.g. when we switch to jessie). BUG=504446 TEST=cross build chromium for arm and ia32 Review URL: https://codereview.chromium.org/1141003002 Cr-Commit-Position: refs/heads/master@{#336843}
* Fix some build symbol configuration.brettw2015-06-192-36/+29
| | | | | | | | | | | | | | | | Remove -gdwarf-4 from GYP build. This is the default for GCC 4.8 which is now required, so this command-line argument is redundant. Only set use_debug_fission in the GN build in debug mode. This matches GYP. Release mode symbols will be non-fission. Implement linux_symbols target in GN. Convert dump_app_syms from sh to Python for better GN usability, and it's more readable for normal programmers on the team. Reland of https://codereview.chromium.org/1182663007/ Reland of https://codereview.chromium.org/1179393004/ TBR=thakis@chromium.org Review URL: https://codereview.chromium.org/1197793002 Cr-Commit-Position: refs/heads/master@{#335370}
* Revert of Fix some build symbol configuration. (patchset #2 id:20001 of ↵brettw2015-06-162-29/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1182663007/) Reason for revert: Broke Linux clobber: https://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20Clobber/builds/1307/steps/compile/logs/stdio Original issue's description: > Fix some build symbol configuration. > > Remove -gdwarf-4 from GYP build. This is the default for GCC 4.8 which is now required, so this command-line argument is redundant. > > Only set use_debug_fission in the GN build in debug mode. This matches GYP. Release mode symbols will be non-fission. > > Implement linux_symbols target in GN. Convert dump_app_syms from sh to Python for better GN usability, and it's more readable for normal programmers on the team. > > Reland of https://codereview.chromium.org/1179393004/ > > TBR=thakis@chromium.org > > Committed: https://crrev.com/07d847b1c5451748f16f4e7973ce8ef9078d47a2 > Cr-Commit-Position: refs/heads/master@{#334690} TBR=thakis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1187233002 Cr-Commit-Position: refs/heads/master@{#334744}
* Fix some build symbol configuration.brettw2015-06-162-36/+29
| | | | | | | | | | | | | | | | Remove -gdwarf-4 from GYP build. This is the default for GCC 4.8 which is now required, so this command-line argument is redundant. Only set use_debug_fission in the GN build in debug mode. This matches GYP. Release mode symbols will be non-fission. Implement linux_symbols target in GN. Convert dump_app_syms from sh to Python for better GN usability, and it's more readable for normal programmers on the team. Reland of https://codereview.chromium.org/1179393004/ TBR=thakis@chromium.org Review URL: https://codereview.chromium.org/1182663007 Cr-Commit-Position: refs/heads/master@{#334690}
* Revert of Fix some build symbol configuration. (patchset #3 id:40001 of ↵thestig2015-06-162-29/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1179393004/) Reason for revert: Broke the Linux GN Clobber bot: http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20Clobber/builds/1271/steps/compile/logs/stdio ninja: error: '../../build/linux/dump_app_syms', needed by 'obj/chrome/linux_symbols.inputdeps.stamp', missing and no known rule to make it Original issue's description: > Fix some build symbol configuration. > > Remove -gdwarf-4 from GYP build. This is the default for GCC 4.8 which is now required, so this command-line argument is redundant. > > Only set use_debug_fission in the GN build in debug mode. This matches GYP. Release mode symbols will be non-fission. > > Implement linux_symbols target in GN. Convert dump_app_syms from sh to Python for better GN usability, and it's more readable for normal programmers on the team. > > BUG= > > Committed: https://crrev.com/950889c01dd934acf28bce29ea6db75610a8c441 > Cr-Commit-Position: refs/heads/master@{#334510} TBR=thakis@chromium.org,brettw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1182783006 Cr-Commit-Position: refs/heads/master@{#334522}
* Fix some build symbol configuration.brettw2015-06-162-36/+29
| | | | | | | | | | | | | | Remove -gdwarf-4 from GYP build. This is the default for GCC 4.8 which is now required, so this command-line argument is redundant. Only set use_debug_fission in the GN build in debug mode. This matches GYP. Release mode symbols will be non-fission. Implement linux_symbols target in GN. Convert dump_app_syms from sh to Python for better GN usability, and it's more readable for normal programmers on the team. BUG= Review URL: https://codereview.chromium.org/1179393004 Cr-Commit-Position: refs/heads/master@{#334510}
* Fix use of 'sysroot' variable in harfbuzz.gypsbc2015-06-051-8/+0
| | | | | | | | | | | | | | | | | | | | | | | | The sysroot variable is set conditionally in common.gypi but not at the nesting level required for other conditional to depend on it like the one in hardbuzz does. This means that sysroot always appeared to be empty to harfbuzz.gyp, and hence the special handling for ARM linux was required. This change moves the setting of 'sysroot' up one level of nesting and defines 'pkg-config' in common.gypi so it can be shared. This is the third attempt at a landing. First attempt was reverted: https://codereview.chromium.org/1151753002 This is a re-land of the second attempt which was reverted speculatively (wrongly as it turned out): https://codereview.chromium.org/1158283003 TBR=cpu Review URL: https://codereview.chromium.org/1146303007 Cr-Commit-Position: refs/heads/master@{#332982}
* Speculative revert to fix ChromeOS PFQ mips buildersbc2015-06-041-0/+8
| | | | | | | | | | | | | | | | | | | The original change is suspected of breaking the build and the second one is followup that needs to be reverted along with it. Revert "Fix use of 'sysroot' variable in harfbuzz.gyp" https://codereview.chromium.org/1158283003 Revert "Fix common.gypi when run with target_arch=mips" https://codereview.chromium.org/1166523004 TBR=cpu BUG=496462 Review URL: https://codereview.chromium.org/1159083004 Cr-Commit-Position: refs/heads/master@{#332766}
* Fix use of 'sysroot' variable in harfbuzz.gypsbc2015-06-021-8/+0
| | | | | | | | | | | | | | | | | | | | | The sysroot variable is set conditionally in common.gypi but not at the nesting level required for other conditional to depend on it like the one in hardbuzz does. This means that sysroot always appeared to be empty to harfbuzz.gyp, and hence the special handling for ARM linux was required. This change moves the setting of 'sysroot' up one level of nesting and defines 'pkg-config' in common.gypi so it can be shared. Second attempt at landing this. First attempt was here: https://codereview.chromium.org/1151753002 TBR=cpu Review URL: https://codereview.chromium.org/1158283003 Cr-Commit-Position: refs/heads/master@{#332311}
* Revert of Fix use of 'sysroot' variable in harfbuzz.gyp (patchset #6 ↵spang2015-05-271-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | id:100001 of https://codereview.chromium.org/1151753002/) Reason for revert: Breaks GYP for Chrome OS builds. Repro steps: cros chrome-sdk --board=amd64-generic gclient runhooks Updating projects from gyp files... /bin/sh: /build/amd64-generic/build/bin/pkg-config: No such file or directory gyp: Call to '/build/amd64-generic/build/bin/pkg-config --libs-only-l nss | sed -e "s/-lssl3//"' returned exit status 0. /bin/sh: /build/amd64-generic/build/bin/pkg-config: No such file or directory gyp: Call to '/build/amd64-generic/build/bin/pkg-config --libs libcras' returned exit status 127. /bin/sh: /build/amd64-generic/build/bin/pkg-config: No such file or directory gyp: Call to '/build/amd64-generic/build/bin/pkg-config --cflags x11' returned exit status 127. Error: Command /usr/bin/python src/build/gyp_chromium returned non-zero exit status 1 in /ssd/src/chromium TEST=cros chrome-sdk --board=amd64-generic && gclient runhooks Original issue's description: > Fix use of 'sysroot' variable in harfbuzz.gyp > > The sysroot variable is set conditionally in common.gypi > but not at the nesting level required for other conditional > to depend on it like the one in hardbuzz does. This means > that sysroot always appeared to be empty to harfbuzz.gyp, > and hence the special handling for ARM linux was required. > > This change moves the setting of 'sysroot' up one level of > nesting and defines 'pkg-config' in common.gypi so it can > be shared. > > Committed: https://crrev.com/6a80b32f309490f44347f2925589a6f0fc23c3ff > Cr-Commit-Position: refs/heads/master@{#331506} TBR=mazda@chromium.org,dpranke@chromium.org,cpu@chromium.org,sbc@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1154213004 Cr-Commit-Position: refs/heads/master@{#331642}
* Fix use of 'sysroot' variable in harfbuzz.gypsbc2015-05-271-8/+0
| | | | | | | | | | | | | | | | The sysroot variable is set conditionally in common.gypi but not at the nesting level required for other conditional to depend on it like the one in hardbuzz does. This means that sysroot always appeared to be empty to harfbuzz.gyp, and hence the special handling for ARM linux was required. This change moves the setting of 'sysroot' up one level of nesting and defines 'pkg-config' in common.gypi so it can be shared. Review URL: https://codereview.chromium.org/1151753002 Cr-Commit-Position: refs/heads/master@{#331506}