| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
This also makes the opus_demo app in the GYP build compile and link (which I discovered when tracking down why the GN version of this gives warnings).
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/507753002
Cr-Commit-Position: refs/heads/master@{#291961}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mostly just a refactoring of build rules to support prebuilt jars.
Adds support for proguard preprocessing of both prebuilt and
non-prebuilt java libraries.
Adds definitions of all (but for android.jar) of the prebuilt jars that
we need from the sdk.
BUG=359249
Review URL: https://codereview.chromium.org/484813002
Cr-Commit-Position: refs/heads/master@{#291464}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, if you specified an empty resource ID file in the grit template in the GN build, it would send "-f" with no argument to grit, and this would cause the command line parsing to get messed up and it wouldn't generate any files.
This patch just omits the "-f" argument in this case.
R=jam@chromium.org
Review URL: https://codereview.chromium.org/495183002
Cr-Commit-Position: refs/heads/master@{#291173}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This directory contains a GN build file that defines a dummy "ui"
component target that does not really do anything that matters.
ui/ targets are almost finished at this time, so there is no point in
keeping this ui/ BUILD file in build/secondary.
BUG=None
TEST=None
R=brettw@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/451553002
Cr-Commit-Position: refs/heads/master@{#290188}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290188 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This resolves collisions if two grit targets with the same name (often
"resources") end up in the same output directory.
This reverts 289283 and replaces it with the unique output names rather than
the duplicative target names. The original problem was from 289264.
BUG=
R=joaodasilva@chromium.org
Review URL: https://codereview.chromium.org/469893002
Cr-Commit-Position: refs/heads/master@{#289691}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This matches the gyp build and is important for parts of the code that
guard their API with UNIT_TEST. For instance,
chrome/browser/ui/views/omnibox/omnibox_view_views.h has a GetRenderText
function guarded by #if UNIT_TEST that shadows a protected function
GetRenderText from its parent class views::Textfield, but with different
const-ness. If c/b/u/v/o/omnibox_view_views.cc is compiled with UNIT_TEST
set, it attempts to use the guarded member function instead of the base
class which fails to compile.
R=brettw@chromium.org
Review URL: https://codereview.chromium.org/464503003
Cr-Commit-Position: refs/heads/master@{#288988}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These DEPS have not been updated for ~2 years, so there is a good chance
something will blow up. Due to interdependancy between the repos,
rolling gtest required gmock also be rolled.
This CL was originally landed as 288164 and reverted as 288239 because it allows
more aggressive LTO in MSVS. This resulted in the compiler noticing an
intentional arithmetic overflow and warning about it.
BUG=401761
Review URL: https://codereview.chromium.org/425333002
Cr-Commit-Position: refs/heads/master@{#288505}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288505 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Suspected to have broken the Chrome Win build:
c:\b\build\slave\google-chrome-rel-win\build\src\base\numerics\safe_numerics_unittest.cc(577) : error C2220: warning treated as error - no 'object' file generated
c:\b\build\slave\google-chrome-rel-win\build\src\base\numerics\safe_numerics_unittest.cc(577) : warning C4756: overflow in constant arithmetic
> Roll gtest and gmock DEPS.
>
> These DEPS have not been updated for ~2 years, so there is a good chance
> something will blow up. Due to interdependancy between the repos,
> rolling gtest required gmock also be rolled.
>
> BUG=none
>
> Review URL: https://codereview.chromium.org/425333002
TBR=ncbray@chromium.org
Review URL: https://codereview.chromium.org/454823002
Cr-Commit-Position: refs/heads/master@{#288239}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
These DEPS have not been updated for ~2 years, so there is a good chance
something will blow up. Due to interdependancy between the repos,
rolling gtest required gmock also be rolled.
BUG=none
Review URL: https://codereview.chromium.org/425333002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This should prevent problems such as described in
[chromium-dev] PSA: clobber build needed for IDR_INSPECTOR_*
compile errors in blink_platform_impl.cc
Depends on https://codereview.chromium.org/431883002
BUG=400860
TBR=brettw
Review URL: https://codereview.chromium.org/430083002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Blink now has the real implementations of these files in their repo:
platform -> https://src.chromium.org/viewvc/blink?view=rev&revision=172998
wtf -> https://src.chromium.org/viewvc/blink?view=rev&revision=172321
BUG=None
TEST=trybots
R=brettw@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/420113002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Put the .d file in the same directory as the output from grit. Currently it
uses the default location for the .d file all the time, even in cases where the
output directory is overridden and the rest of the files go somewhere else.
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/450483004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
These are included in the gyp build, but not in All. They also don't
compile on Windows for the gyp build.
R=brettw@chromium.org
BUG=354261
Review URL: https://codereview.chromium.org/425373002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds GN rules for google_toolbox_for_mac and generate_localize as
well as fixing up various source issues that show up on the mac build.
With this chrome/{browser,common,renderer} compile on mac (but probably
don't fully link).
R=brettw@chromium.org
Review URL: https://codereview.chromium.org/407093015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It doesn't run yet. This disables WebRTC since that's not done yet.
Libvpx isn't done either. This patch exports the disable flag for this from media to dependent targets like the GYP build does. It adds one extra check for this flag in Pepper. I assume everybody that compiles without libvpx also disables plugins so this has never come up before.
Disable some warnings in Mesa.
The resulting binary does not yet run.
R=jamesr@chromium.org
Review URL: https://codereview.chromium.org/419913003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix the devtools resources target to use the grit template.
Fix the grit template to use the correct output directory for the expected files if one is specified
R=viettrungluu@chromium.org
Review URL: https://codereview.chromium.org/414973002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Previously this rule had a lot of custom stuff to work around the fact that the grit rule couldn't run at GN time to get the inputs and outputs. Now that the inputs are lazy, we can use the template.
R=viettrungluu@chromium.org
Review URL: https://codereview.chromium.org/414623002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This finishes the rest of the Grit outputs that was started in a previous pass, and removes the ability to optionally deduce outputs at GN-time (which is slow so we don't want to do it).
R=viettrungluu@chromium.org
Review URL: https://codereview.chromium.org/411543005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds the missing conditions to the chrome/common GN build file (previously
only the basic files were there). Some refactoring of the GYP file to make this
possible.
Renames the enable_printing flag to printing_mode since this is an integer
tri-state.
Minor improvements to chrome/renderer
TBR=jamesr@chromium.org
Original review=https://codereview.chromium.org/400243003/
BUG=
Review URL: https://codereview.chromium.org/409683003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284783 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Pull grit 171 to get the new deps fixes required to implement this.
This removes the call to grit for querying inputs completely, and enables depfile writing to enable automatic rebuilds when things are out-of-date.
Adds a new outputs variable that bypasses querying grit for outputs. This will assert that the given files exist in grit. This version allows outputs to be empty in which case it will revert to the old dynamic behavior. I'm going to land this with just the worst cases fixed to make landing easier. Then followup with converting the rest of the grit targets and removing the dynamic option.
R=viettrungluu@chromium.org
Review URL: https://codereview.chromium.org/407653003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> GN chrome/common build, rename enable_printing.
>
> This adds the missing conditions to the chrome/common GN build file (previously
> only the basic files were there). Some refactoring of the GYP file to make this
> possible.
>
> Renames the enable_printing flag to printing_mode since this is an integer
> tri-state.
>
> Minor improvements to chrome/renderer
>
> R=jamesr@chromium.org
>
> Review URL: https://codereview.chromium.org/400243003
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/409543008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds the missing conditions to the chrome/common GN build file (previously
only the basic files were there). Some refactoring of the GYP file to make this
possible.
Renames the enable_printing flag to printing_mode since this is an integer
tri-state.
Minor improvements to chrome/renderer
R=jamesr@chromium.org
Review URL: https://codereview.chromium.org/400243003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284508 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The ICU update does the following among other things:
- Update EUC-JP (no more JIS X 212 round-trip coverage) per WHATWG
encoding spec.
- Add CP866
- Add far better/more extensive support for plural, format, etc
- Numerous locale data update
- Khmer/Lao line/word-breaking support
- More compact Chinese/Japanese dictionary (now a part of the upstream
instead of our local patch)
- Better plural support that we plan to use right away.
- Update icu/BUILD.gn : file list update, new defines, etc.
- Update tests
a. icu_string_conversions_unittests : drop iscii (nobody uses it) and
remove JIS X 212 code points from the round-trip test
b. l10n_util_unittests: Display names for zh-*.
c. ThaiSnippet's expected result. (due to a Unicode grapheme definition change).
d. Update Expected results in file_manager_browsertest/test_util.js
(see http://crbug.com/383930)
- Update SpellcheckerWordIterator
a. Add U+0027 back to MidNumLet
b. Add Lao and Khmer scripts to the list of scripts requiring dictionary-based
word-breaking.
- l10n_util : alias 'tl' to 'fil' (Tagalog to Filipino)
- Update IdentityInternalsSingleTokenWebUITest.verifyGetters (DateTimeFormat-Full
has 'at' before time, which is not handled by Date.parse()
- update license.py because we don't have a separate Chinese/Japanese
dictionary any more. It's now a part of ICU
Note to Sheriff :
1. 140 ~ 200 kB size increase is expected for all platforms.
This size increase was singed off by laforge@.
The expected size has to be updated with both reva/revb pointing to the
revision corresponding to this CL.
2. http://codereview.chromium.org/348913002 has to be applied before running make_expectations.py to update tools/perf_expectations/perf_expectations.json
after this CL is landed.
BUG=132145,277023,136148,360433,364072
TEST=base_unittests:*ICU*, net_unittests:*IDN*, ui_unittests:*Lang*,
browser_tests (encoding related, Iden*verifyGet*),
unit_tests:Ext*L10*, unit_tests:*Lang*, component_tests:*Snipp*,
layout tests (encoding, date/calendar, line breaking, and others),
build 'base_i18n_nacl', GN build bots.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277111
R=arv@chromium.org, brettw@chromium.org, fgorski@chromium.org, groby@chromium.org, hirono@chromium.org, tony@chromium.org, toyoshim@chromium.org
Review URL: https://codereview.chromium.org/265613002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284167 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds support for android resources to gn.
Two new templates are introduced:
java_string_grd: This is like gyp's build/java_strings_grd.gypi. It runs
grit and generates Android strings.xml files and then zips them
together.
android_resources: This is the target for android resources. It is
mostly a wrapper around process_resources.py. This is *not part* of
android_library (like it is in gyp). Making these two things separate is
more like facebook's BUCK and google's internal build rules (and gyp's
java.gypi and java_apk.gypi have gotten way too big and complicated).
Changes to the actual build scripts are very minor except for the added
support for andoid_resources to write_build_config.py. Building
resources requires getting all the transitive resource dependencies, and
so this reuses the simple sorted transitive dependency thing from
write_ordered_libraries.py.
TBR=rch@chromium.org
BUG=359249
Review URL: https://codereview.chromium.org/361633002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283293 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This uses the proto file directory for the generated files rather than the directory of the BUILD file. This makes it more natural when you have a BUILD file in a different directory than the proto files.
Fixes a search-and-replace error that accidentally changed the fallback source_prereqs code to use "inputs".
Fix ozone build.
BUG=
R=ajwong@chromium.org
Review URL: https://codereview.chromium.org/386943006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Ports over more gyp logic for the icu target. Doesn't correctly account
for host toolchains yet, but it's closer.
All hail GN. oRZ
BUG=none
Review URL: https://codereview.chromium.org/377113002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
A BUILD.gn file was checked into the real location so this secondary-tree file is unused.
R=tfarina@chromium.org
Review URL: https://codereview.chromium.org/378633005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This variable changed name.
R=jamesr@chromium.org
Review URL: https://codereview.chromium.org/375873006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fills out a number of ui targets and does some changes to the resources to match the GYP build. In particular, we had a number of different ui/resources targets that were depended on independently. The GYP build has only one, so I combined them into a meta "ui/resources" target.
Adds a grit repack template.
TBR=ajwong
Review URL: https://codereview.chromium.org/369603004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
components/autofill
components/metrics
components/policy
components/variations
third_party/libphonenumber
third_party/mt19937ar
ui/gfx/ipc
These are all requried to compile chrome/browser in some form or another.
Fills out all grit_defines (also required for chrome/browser) and adds associated flags for them.
Add the ability for generated_extensions_api to not generate a bundle.
Remove mt19937ar from .gitignore (it's just checked into the tree)
R=ajwong@chromium.org
Review URL: https://codereview.chromium.org/365793002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These deps are some of those required to compile chrome/browser (so mostly those containing resources and protobufs that have generated headers). chrome/browser still has some dependencies left.
Add third_party libs libaddressinput and dom_distiller_js.
Add components dom_distiller and policy.
Separate the generate_library_loader into a separate .gni file.
Rename components_strings to just strings.
R=ajwong@chromium.org
Review URL: https://codereview.chromium.org/362583002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/363473003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Removing build/secondary/third_party/ots/BUILD.gn because ots has the file in its repository.
BUG=324187
Review URL: https://codereview.chromium.org/359723002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds a lot of global enable flags for various features used by the browser.
It is not turned on because it does not compile yet. It needs some include directories and generated sources from dependencies that aren't done yet.
It is basically a line-by-line translation of the current chrome_browser.gypi. As such, it looks pretty ugly but I think keeping these in sync will be easiest.
I put in the obvious names of the GN deps. There are surely a bunch that exist in the GN build that aren't here yet but I'm going to save this for later passes.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/356303002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Includes several fixes for WebGL tests, large arrays in shaders,
and regression on older nVidia drivers.
BUG=384420,380353,379799
Review URL: https://codereview.chromium.org/344203006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that we rolled the DEPS for speex library, we can use the GN BUILD
file directory from src/third_party/speex.
BUG=None
TEST=gn gen out/Debug_gn && ninja -C out/Debug_gn speex
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/343943003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278531 0039d316-1c4b-4281-b951-d872f2087c98
|
|
It's a goodness to sequester build configuration in the build/
directory. The gn secondary_source stuff was under tools/gn for
historical reasons, so move it to a more appropriate place.
BUG=None
TEST=do a gn build of base_unittests, run said unittests.
Review URL: https://codereview.chromium.org/340153004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278355 0039d316-1c4b-4281-b951-d872f2087c98
|