summaryrefslogtreecommitdiffstats
path: root/build/util
Commit message (Collapse)AuthorAgeFilesLines
* Fix lastchange.py when running on native win32 pythonscottmg@google.com2012-02-011-3/+1
| | | | | | | | | | | | | | When running as runhooks, it's not run via cygwin like it was when run in the build, and isn't able to find git. I believe the test that checked for both cygwin and win32 before was incorrect (but was always run via cygwin before so didn't matter). Additionally, when runhooks runs it, it's from above src/, so the cwd isn't in the repo. So, pass in the directory of the script itself so that git can find its repo. BUG=112264 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120089 Review URL: https://chromiumcodereview.appspot.com/9317037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120110 0039d316-1c4b-4281-b951-d872f2087c98
* Fix lastchange.py when running on native win32 pythonscottmg@google.com2012-02-011-4/+8
| | | | | | | | | | | | When running as runhooks, it's not run via cygwin like it was when run in the build, and isn't able to find git. I believe the test that checked for both cygwin and win32 before was incorrect (but was always run via cygwin before so didn't matter). Additionally, when runhooks runs it, it's from above src/, so the cwd isn't in the repo. So, pass in the directory of the script itself so that git can find its repo. BUG=112264 Review URL: https://chromiumcodereview.appspot.com/9317037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120089 0039d316-1c4b-4281-b951-d872f2087c98
* Instead of always running the LASTCHANGE extractor, run it with regular file ↵scottmg@google.com2012-01-311-2/+1
| | | | | | | | | | | | | | dependencies. During gclient runhooks, update LASTCHANGE so that it will be updated at least as often as runhooks is run (i.e. for every sync). LASTCHANGE moved to build/util rather than SHARED_INTERMEDIATE_DIR because that directory isn't known to runhooks. BUG=111731 Review URL: https://chromiumcodereview.appspot.com/9169105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119950 0039d316-1c4b-4281-b951-d872f2087c98
* lastchange: don't check git state for whether the tree is dirtyevan@chromium.org2012-01-121-27/+1
| | | | | | | | | | | | | | | | | We don't show whether the tree was dirty for SVN. Because lastchange runs on every build, these commands impact every build. The call to "git checkout" makes git stat every file in the repository (including ones unrelated to the build). This change makes a Ninja build of Chrome 20% faster. I've seen the command take tens of seconds on a cold disk, and it likely has a larger impact on Windows where the disk is slower. Review URL: http://codereview.chromium.org/9148030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117352 0039d316-1c4b-4281-b951-d872f2087c98
* Fix duplicate rule for LASTCHANGEpiman@chromium.org2011-09-191-2/+1
| | | | | | | | | | BUG=None TEST=build it on linux (make/ninja), check no warning of duplicate rule Review URL: http://codereview.chromium.org/7920025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101793 0039d316-1c4b-4281-b951-d872f2087c98
* Fourth attempt at the following. Unreviewed, this was originally reviewed ↵pkasting@chromium.org2011-09-151-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | in http://codereview.chromium.org/7550002 . Clean up SSL false start blacklist code. Numerous changes, including: * Handle trailing dots in LastTwoLabels() as in http://codereview.chromium.org/7518035/ . Rename this function to LastTwoComponents() to match the terminology used in the RegistryControlledDomainService and elsewhere in Chrome. * Since callers are using std::string anyway, make the functions in the header take const std::string& instead of char*. This also allows doing string operations on them. * Use string operations (like find_last_of()) in place of hand-written algorithms, for brevity, clarity, and safety. * Avoid "unsigned", which the style guide forbids, and use allowed types like size_t, uint32, or int (depending on the situation). * Avoid #define and "using". * Use standard algorithms for similar reasons as using string ops. * Use file_util functions to significantly abbreviate file reading/writing code. * Use wmain() (on Windows) in combination with FilePath to avoid issues if the provided pathname has extended characters that don't flatten losslessly to the default codepage (thanks Darin for pointing out this issue). * Avoid casting where possible. Avoid some casts for printf()-style calls by using a string stream, which also allows for slightly less boilerplate. * Convert non-error uses of stderr to the chrome-standard VLOG(1). * Correctly handle hostnames with trailing dots in the input file. * In general, shorten code where possible. Because this adds a dependency on base, and ssl_false_start_blacklist_process has the "#host" specifier in net.gyp, bradnelson tells me that base and its dependencies need an explicit "host, target" toolchain list for the Linux builds to work correctly. It would be nice if we could avoid this but I guess gyp would have to be smarter or something. BUG=none TEST=none Review URL: http://codereview.chromium.org/7903016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101378 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 98885 - Third attempt at the following. Unreviewed, this was ↵rsleevi@chromium.org2011-08-311-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | originally reviewed in http://codereview.chromium.org/7550002 . Clean up SSL false start blacklist code. Numerous changes, including: * Handle trailing dots in LastTwoLabels() as in http://codereview.chromium.org/7518035/ . Rename this function to LastTwoComponents() to match the terminology used in the RegistryControlledDomainService and elsewhere in Chrome. * Since callers are using std::string anyway, make the functions in the header take const std::string& instead of char*. This also allows doing string operations on them. * Use string operations (like find_last_of()) in place of hand-written algorithms, for brevity, clarity, and safety. * Avoid "unsigned", which the style guide forbids, and use allowed types like size_t, uint32, or int (depending on the situation). * Avoid #define and "using". * Use standard algorithms for similar reasons as using string ops. * Use file_util functions to significantly abbreviate file reading/writing code. * Use wmain() (on Windows) in combination with FilePath to avoid issues if the provided pathname has extended characters that don't flatten losslessly to the default codepage (thanks Darin for pointing out this issue). * Avoid casting where possible. Avoid some casts for printf()-style calls by using a string stream, which also allows for slightly less boilerplate. * Convert non-error uses of stderr to the chrome-standard VLOG(1). * Correctly handle hostnames with trailing dots in the input file. * In general, shorten code where possible. Because this adds a dependency on base, and ssl_false_start_blacklist_process has the "#host" specifier in net.gyp, bradnelson tells me that base and its dependencies need an explicit "host, target" toolchain list for the Linux builds to work correctly. It would be nice if we could avoid this but I guess gyp would have to be smarter or something. BUG=none TEST=none Review URL: http://codereview.chromium.org/7804001 TBR=pkasting@chromium.org Review URL: http://codereview.chromium.org/7778035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98917 0039d316-1c4b-4281-b951-d872f2087c98
* Third attempt at the following. Unreviewed, this was originally reviewed in ↵pkasting@chromium.org2011-08-301-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | http://codereview.chromium.org/7550002 . Clean up SSL false start blacklist code. Numerous changes, including: * Handle trailing dots in LastTwoLabels() as in http://codereview.chromium.org/7518035/ . Rename this function to LastTwoComponents() to match the terminology used in the RegistryControlledDomainService and elsewhere in Chrome. * Since callers are using std::string anyway, make the functions in the header take const std::string& instead of char*. This also allows doing string operations on them. * Use string operations (like find_last_of()) in place of hand-written algorithms, for brevity, clarity, and safety. * Avoid "unsigned", which the style guide forbids, and use allowed types like size_t, uint32, or int (depending on the situation). * Avoid #define and "using". * Use standard algorithms for similar reasons as using string ops. * Use file_util functions to significantly abbreviate file reading/writing code. * Use wmain() (on Windows) in combination with FilePath to avoid issues if the provided pathname has extended characters that don't flatten losslessly to the default codepage (thanks Darin for pointing out this issue). * Avoid casting where possible. Avoid some casts for printf()-style calls by using a string stream, which also allows for slightly less boilerplate. * Convert non-error uses of stderr to the chrome-standard VLOG(1). * Correctly handle hostnames with trailing dots in the input file. * In general, shorten code where possible. Because this adds a dependency on base, and ssl_false_start_blacklist_process has the "#host" specifier in net.gyp, bradnelson tells me that base and its dependencies need an explicit "host, target" toolchain list for the Linux builds to work correctly. It would be nice if we could avoid this but I guess gyp would have to be smarter or something. BUG=none TEST=none Review URL: http://codereview.chromium.org/7804001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98885 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 95907 - Clean up SSL false start blacklist code. Numerous changes, ↵mnissler@chromium.org2011-08-111-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | including: * Handle trailing dots in LastTwoLabels() as in http://codereview.chromium.org/7518035/ . Rename this function to LastTwoComponents() to match the terminology used in the RegistryControlledDomainService and elsewhere in Chrome. * Since callers are using std::string anyway, make the functions in the header take const std::string& instead of char*. This also allows doing string operations on them. * Use string operations (like find_last_of()) in place of hand-written algorithms, for brevity, clarity, and safety. * Avoid "unsigned", which the style guide forbids, and use allowed types like size_t, uint32, or int (depending on the situation). * Avoid #define and "using". * Use standard algorithms for similar reasons as using string ops. * Use file_util functions to significantly abbreviate file reading/writing code. * Use wmain() (on Windows) in combination with FilePath to avoid issues if the provided pathname has extended characters that don't flatten losslessly to the default codepage (thanks Darin for pointing out this issue). * Avoid casting where possible. Avoid some casts for printf()-style calls by using a string stream, which also allows for slightly less boilerplate. * Convert non-error uses of stderr to the chrome-standard VLOG(1). * Correctly handle hostnames with trailing dots in the input file. * In general, shorten code where possible. Because this adds a dependency on base, and ssl_false_start_blacklist_process has the "#host" specifier in net.gyp, bradnelson tells me that base and its dependencies need an explicit "host, target" toolchain list for the Linux builds to work correctly. It would be nice if we could avoid this but I guess gyp would have to be smarter or something. BUG=none TEST=none Review URL: http://codereview.chromium.org/7550002 TBR=pkasting@chromium.org Review URL: http://codereview.chromium.org/7623015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96391 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 95910 - Revert 95907 - Clean up SSL false start blacklist code.pkasting@chromium.org2011-08-101-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now that r96121 has landed, this should not cause compile failures when compiling base/ on the host. Original comments follow. Numerous changes, including: * Handle trailing dots in LastTwoLabels() as in http://codereview.chromium.org/7518035/ . Rename this function to LastTwoComponents() to match the terminology used in the RegistryControlledDomainService and elsewhere in Chrome. * Since callers are using std::string anyway, make the functions in the header take const std::string& instead of char*. This also allows doing string operations on them. * Use string operations (like find_last_of()) in place of hand-written algorithms, for brevity, clarity, and safety. * Avoid "unsigned", which the style guide forbids, and use allowed types like size_t, uint32, or int (depending on the situation). * Avoid #define and "using". * Use standard algorithms for similar reasons as using string ops. * Use file_util functions to significantly abbreviate file reading/writing code. * Use wmain() (on Windows) in combination with FilePath to avoid issues if the provided pathname has extended characters that don't flatten losslessly to the default codepage (thanks Darin for pointing out this issue). * Avoid casting where possible. Avoid some casts for printf()-style calls by using a string stream, which also allows for slightly less boilerplate. * Convert non-error uses of stderr to the chrome-standard VLOG(1). * Correctly handle hostnames with trailing dots in the input file. * In general, shorten code where possible. Because this adds a dependency on base, and ssl_false_start_blacklist_process has the "#host" specifier in net.gyp, bradnelson tells me that base and its dependencies need an explicit "host, target" toolchain list for the Linux builds to work correctly. It would be nice if we could avoid this but I guess gyp would have to be smarter or something. BUG=none TEST=none Review URL: http://codereview.chromium.org/7550002 TBR=pkasting@chromium.org Review URL: http://codereview.chromium.org/7529035 TBR=fischman@chromium.org Review URL: http://codereview.chromium.org/7587003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96211 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 95907 - Clean up SSL false start blacklist code. Numerous changes, ↵fischman@chromium.org2011-08-081-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | including: * Handle trailing dots in LastTwoLabels() as in http://codereview.chromium.org/7518035/ . Rename this function to LastTwoComponents() to match the terminology used in the RegistryControlledDomainService and elsewhere in Chrome. * Since callers are using std::string anyway, make the functions in the header take const std::string& instead of char*. This also allows doing string operations on them. * Use string operations (like find_last_of()) in place of hand-written algorithms, for brevity, clarity, and safety. * Avoid "unsigned", which the style guide forbids, and use allowed types like size_t, uint32, or int (depending on the situation). * Avoid #define and "using". * Use standard algorithms for similar reasons as using string ops. * Use file_util functions to significantly abbreviate file reading/writing code. * Use wmain() (on Windows) in combination with FilePath to avoid issues if the provided pathname has extended characters that don't flatten losslessly to the default codepage (thanks Darin for pointing out this issue). * Avoid casting where possible. Avoid some casts for printf()-style calls by using a string stream, which also allows for slightly less boilerplate. * Convert non-error uses of stderr to the chrome-standard VLOG(1). * Correctly handle hostnames with trailing dots in the input file. * In general, shorten code where possible. Because this adds a dependency on base, and ssl_false_start_blacklist_process has the "#host" specifier in net.gyp, bradnelson tells me that base and its dependencies need an explicit "host, target" toolchain list for the Linux builds to work correctly. It would be nice if we could avoid this but I guess gyp would have to be smarter or something. BUG=none TEST=none Review URL: http://codereview.chromium.org/7550002 TBR=pkasting@chromium.org Review URL: http://codereview.chromium.org/7529035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95910 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up SSL false start blacklist code. Numerous changes, including:pkasting@chromium.org2011-08-081-0/+1
| | | | | | | | | | | | | | | | | | | | | | | * Handle trailing dots in LastTwoLabels() as in http://codereview.chromium.org/7518035/ . Rename this function to LastTwoComponents() to match the terminology used in the RegistryControlledDomainService and elsewhere in Chrome. * Since callers are using std::string anyway, make the functions in the header take const std::string& instead of char*. This also allows doing string operations on them. * Use string operations (like find_last_of()) in place of hand-written algorithms, for brevity, clarity, and safety. * Avoid "unsigned", which the style guide forbids, and use allowed types like size_t, uint32, or int (depending on the situation). * Avoid #define and "using". * Use standard algorithms for similar reasons as using string ops. * Use file_util functions to significantly abbreviate file reading/writing code. * Use wmain() (on Windows) in combination with FilePath to avoid issues if the provided pathname has extended characters that don't flatten losslessly to the default codepage (thanks Darin for pointing out this issue). * Avoid casting where possible. Avoid some casts for printf()-style calls by using a string stream, which also allows for slightly less boilerplate. * Convert non-error uses of stderr to the chrome-standard VLOG(1). * Correctly handle hostnames with trailing dots in the input file. * In general, shorten code where possible. Because this adds a dependency on base, and ssl_false_start_blacklist_process has the "#host" specifier in net.gyp, bradnelson tells me that base and its dependencies need an explicit "host, target" toolchain list for the Linux builds to work correctly. It would be nice if we could avoid this but I guess gyp would have to be smarter or something. BUG=none TEST=none Review URL: http://codereview.chromium.org/7550002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95907 0039d316-1c4b-4281-b951-d872f2087c98
* Unify the version string to be displayed on "About Chromium" dialog. (5/6)haraken@google.com2011-07-301-102/+70
| | | | | | | | | | | | | | | | | | | | | | | - Fetch Subversion URL and the revision from 'git log' even if git-svn is not available. - Remove VersionInfo.root, since nobody is using it. - Allow a user to specify the directory name just prior to the svn src URL. FYI: We decided to split the changes of issue 7104106 (http://codereview.chromium.org/7104106/) into the following steps. This is the fifth step of them: (1) Add CreateVersionString() to chrome_version_info.*, update the GTK+ code to use it. (reviewer: erg, tony) (2) Update the mac code to use CreateVersionString(). Update About.xib. (reviewer: mark) (3) Update the views code to use CreateVersionString(). This can happen at the same time as (2). (reviewer: davemoore, tony) (4) Update version.bat to use lastchange.py. (reviewer: evan) (5) Make changes to lastchange.py and webkit_version.py. (reviewer: evan, mark) (6) Update tweak_info_plist to use lastchange.py. (reviewer: mark) BUG=37186 TEST=Observe that "About Chromium" dialog shows the version string like "14.0.787.0 (Developer Build 88242 Windows" on Windows and Linux. Review URL: http://codereview.chromium.org/7493073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94828 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the comments setting emands and vim tab width and expansion variables.tony@chromium.org2011-07-111-6/+0
| | | | | | | | | | | | | | | | | These were added in r28089 (http://codereview.chromium.org/256059) but are unnecessary bloat for everyone to carry around, even those that don't use emacs or vim. In an earlier change, I added editor config files in src/tools/emacs/ and src/tools/vim/ so users of the appropriate editor can source those instead. BUG=none TEST=none Review URL: http://codereview.chromium.org/7310019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92046 0039d316-1c4b-4281-b951-d872f2087c98
* Fetch repository root for git-svn checkouts.dilmah@chromium.org2011-03-041-3/+28
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/6609039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76890 0039d316-1c4b-4281-b951-d872f2087c98
* Fix webkit build failure reported by evan@dilmah@chromium.org2011-03-031-8/+9
| | | | | | | | | | | | | When fetching svn URL via 'git svn info --url' command git-svn.perl script may print its progress log to stdout instead of stderr: as a result we end up using all this junk as svn repository URL. Fix it by filtering output. BUG=None TEST=None Review URL: http://codereview.chromium.org/6603022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76803 0039d316-1c4b-4281-b951-d872f2087c98
* Fix spelling in recent commitdilmah@chromium.org2011-03-031-1/+1
| | | | | | | | | | BUG=None TEST=None TBR=evan@chromium.org Review URL: http://codereview.chromium.org/6618001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76737 0039d316-1c4b-4281-b951-d872f2087c98
* Added check for None missed in recent commit.dilmah@chromium.org2011-03-031-1/+3
| | | | | | | | | | | | Reported by fta At sofaraway.org BUG=None TEST=None TBR=evan@chromium.org Review URL: http://codereview.chromium.org/6610013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76733 0039d316-1c4b-4281-b951-d872f2087c98
* Try harder to dig git-svn revision.dilmah@chromium.org2011-03-021-31/+131
| | | | | | | | | | | | | | | | Previous behaviour for git-svn repositories is to return git hash (this hash then appears on about:version page and can be copy-pasted into bugreport). However for developer branches with local modifications this hash bears no information to the outside world. Now we return svn revision for trunk git-svn checkouts and svn-revision plus "-dirty" suffix for git branches. The magic required to run git on cygwin is factored out into separate function. BUG=chromium:70909 TEST=Manual Review URL: http://codereview.chromium.org/6474044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76530 0039d316-1c4b-4281-b951-d872f2087c98
* lastchange: use shell=True on Windowsevan@chromium.org2011-01-271-1/+2
| | | | | | | | | | | I regressed this by refactoring some code together then splitting it again. Originally it was fixed in r18533. BUG=71016 Review URL: http://codereview.chromium.org/6265031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72897 0039d316-1c4b-4281-b951-d872f2087c98
* lastchange: don't use git rev-parse output when it failsevan@chromium.org2011-01-261-1/+4
| | | | | | | | | | If you weren't using SVN or Git, but you had Git installed, we still thought you were using Git and had empty info for the version number. Review URL: http://codereview.chromium.org/6308016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72706 0039d316-1c4b-4281-b951-d872f2087c98
* lastchange: give up on git-svnevan@chromium.org2011-01-261-29/+24
| | | | | | | | | | | Just put the git hash in the revision fields. Developers who are using git aren't making releases. BUG=70909 Review URL: http://codereview.chromium.org/6348023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72661 0039d316-1c4b-4281-b951-d872f2087c98
* lastchange: wrap another subprocess call in a try blockevan@chromium.org2011-01-241-5/+8
| | | | | | Avoids throwing an exception when git isn't installed. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72418 0039d316-1c4b-4281-b951-d872f2087c98
* lastchange: skip over git-svn "rebuilding..." linesevan@chromium.org2011-01-241-1/+3
| | | | | | | | | | Sometimes git-svn prints extra status info. From a glance at the source, there's no flag to skip it. So just skip it when parsing. Review URL: http://codereview.chromium.org/6349010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72360 0039d316-1c4b-4281-b951-d872f2087c98
* lastchange: handle the git-but-not-git-svn caseevan@chromium.org2011-01-241-3/+18
| | | | | | | | | | | | When we're using a git checkout of WebKit that hasn't had git-svn set up, ignore the missing versioning information rather than failing. BUG=70606,private mails Review URL: http://codereview.chromium.org/6267010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72351 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed invocation of "git svn info" under win32.caseq@google.com2011-01-241-3/+9
| | | | | | | | | TBR=evan BUG=70606 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72335 0039d316-1c4b-4281-b951-d872f2087c98
* webkit: expose webkit branch and revision number in about pagesevan@chromium.org2011-01-221-21/+46
| | | | | | | | | | | | | | | - Change lastchange.py to work in other directories and to provide SVN URL. - Use lastchange.py in place where we generate WebKit versioning info. - Include branch@revision string in glue API. BUG=41264 TEST=compiles Review URL: http://codereview.chromium.org/6354014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72245 0039d316-1c4b-4281-b951-d872f2087c98
* lastchange: add a flag to only print the svn revision numberevan@chromium.org2011-01-211-6/+10
| | | | | | | | | | | | This allows me to change one of the callers to not parse the "REVISION=1234" output, which will allow me to change that output in a future change. BUG=41264 Review URL: http://codereview.chromium.org/6265021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72170 0039d316-1c4b-4281-b951-d872f2087c98
* lastchange.py: fix style, unify git codepathevan@chromium.org2011-01-211-41/+15
| | | | | | | | | | | | 1) Change style to match style guide. 2) Use "git svn info" so we can use the same parsing code for both git and svn. TEST=ran manually Review URL: http://codereview.chromium.org/6263009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72074 0039d316-1c4b-4281-b951-d872f2087c98
* Try harder to determine lastchange in case of git-svn repository with some ↵dilmah@chromium.org2010-10-051-13/+15
| | | | | | | | | | | local changes. BUG=http://crosbug.com/7254 TEST=Manual Review URL: http://codereview.chromium.org/3570006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61526 0039d316-1c4b-4281-b951-d872f2087c98
* Roll gyp DEPS, and mostly revert r38366 which was fixed better in gyp.mmoss@google.com2010-02-171-0/+1
| | | | | | | | | | This properly triggers build targets that depend on "always run" actions. BUG=22044 Review URL: http://codereview.chromium.org/604061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39223 0039d316-1c4b-4281-b951-d872f2087c98
* Make LASTCHANGE work properly for make build.mmoss@google.com2010-02-081-1/+0
| | | | | | | | BUG=22044 Review URL: http://codereview.chromium.org/579014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38366 0039d316-1c4b-4281-b951-d872f2087c98
* Add comments setting emacs and vim tab width and expansion variables.sgk@google.com2009-10-061-0/+6
| | | | | | | | BUG=none TEST=successful builds Review URL: http://codereview.chromium.org/256059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28089 0039d316-1c4b-4281-b951-d872f2087c98
* Force inclusion of build/common.gypi for all chromium gyp files.yaar@chromium.org2009-09-151-3/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | Why: Simpler build code. If everybody includes it, it should be included automatically. Why now: The webkit chromium builds need it be specified, since can't default to build/common.gypi. What was done: 1. build/common.gypi's contents were moved to a new file build/gyp_chromium.gypi 2. tools/gyp/gyp_chromium was moved to build/gyp_chromium and made to automatically include build/gyp_chromium.gypi. 3. lots of gyp files were fixed to not refer to build/common.gypi any more. 4. o3d which also builds independently of chrome, was fixed to have a gyp_o3d that includes gyp_chromium.gypi too. 5. build/common.gypi was left empty, because there are some external projects that still refer to it. Things that are left to do after this patch is in: 1. The following external files (in other repositories) need to stop include common.gypi ./third_party/hunspell/hunspell.gyp ./third_party/icu/icu.gyp ./v8/tools/gyp/v8.gyp 2. Once nobody refers to common.gypi anymore, delete common.gypi -or- Delete gyp_chromium.gypi and move its content back to common.gypi Tested on mac, win and linux. On win, got a few unit tests errors on chrome bookmarks, which should not be related. I'm running again with clobber to verify. Review URL: http://codereview.chromium.org/206006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26302 0039d316-1c4b-4281-b951-d872f2087c98
* Allow the lastchange target to get a hard-coded default last changesgk@google.com2009-08-052-5/+16
| | | | | | | | | from build/LASTCHANGE.in if there's no actual svn or git change found. BUG=none TEST=none Review URL: http://codereview.chromium.org/159876 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22489 0039d316-1c4b-4281-b951-d872f2087c98
* Fetch the SVN revision number correctly regardless of line endingssgk@google.com2009-06-161-4/+6
| | | | | | | | | returned by any version of Python on any platform. BUG=14187 TEST=none Review URL: http://codereview.chromium.org/126227 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18533 0039d316-1c4b-4281-b951-d872f2087c98
* Grab the correct element from the match group of the git regex.mmoss@chromium.org2009-06-051-1/+1
| | | | | | | Review URL: http://codereview.chromium.org/119211 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17769 0039d316-1c4b-4281-b951-d872f2087c98
* Fix make build by providing a hint as to when to expand the filename.tc@google.com2009-06-041-1/+1
| | | | | | | Review URL: http://codereview.chromium.org/119182 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17639 0039d316-1c4b-4281-b951-d872f2087c98
* Fetch last change (revision) info in a separate action that can runsgk@google.com2009-06-042-0/+155
every build, instead of having it occur as a side effect of updating some other target for which we want to use normal up-to-date checks. BUG=none TEST=none Review URL: http://codereview.chromium.org/118192 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17634 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-15 03:42:34 +0000