| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL introduces an automated and centralized way to embed
compatibility manifest into all *.exe files. With this CL,
a potential risk of behavioural inconsistency between
production binaries and unit test binaries is resolved by
enforcing the same compatibility context.
This CL uses 'target_conditions' feature of gyp to inject
manifest settings into each executable target. One tricky
part is that some executables such as setup.exe and
mini_installer.exe require external manifest file instead of
embedded one when component build is enabled.
See http://crbug.com/127233 for this.
You can override the gyp variable
'win_exe_compatibility_manifest' locally for a given
executable target to embed a custom compatibility manifest.
BUG=260692
Review URL: https://chromiumcodereview.appspot.com/19275010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=scottmg@chromium.org
BUG=225195
Review URL: https://chromiumcodereview.appspot.com/13472015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SP2/SP3, which is used by chrome.dll in preference to the Platform SDK's user32.lib import library.
Custom build an import library for Chrome's post-WinXP imports, that binds to a fictional "user32-delay.dll".
Implement and test a delay load hook that diverts dynamic loading of any dll "foo-delay.dll" to "foo.dll".
R=cpu@chromium.org
BUG=176040
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191173
Review URL: https://chromiumcodereview.appspot.com/12295040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Check in a custom-built import library for user32 exports up to Windows XP SP2/SP3, which is used by chrome.dll in preference to the Platform SDK's user32.lib import library.
> Custom build an import library for Chrome's post-WinXP imports, that binds to a fictional "user32-delay.dll".
> Implement and test a delay load hook that diverts dynamic loading of any dll "foo-delay.dll" to "foo.dll".
>
> R=cpu@chromium.org
> BUG=176040
>
>
> Review URL: https://chromiumcodereview.appspot.com/12295040
TBR=siggi@chromium.org
Review URL: https://codereview.chromium.org/13208002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SP2/SP3, which is used by chrome.dll in preference to the Platform SDK's user32.lib import library.
Custom build an import library for Chrome's post-WinXP imports, that binds to a fictional "user32-delay.dll".
Implement and test a delay load hook that diverts dynamic loading of any dll "foo-delay.dll" to "foo.dll".
R=cpu@chromium.org
BUG=176040
Review URL: https://chromiumcodereview.appspot.com/12295040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/12295040/ as it has to be manually committed.
BUG=176040
Review URL: https://codereview.chromium.org/12939020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=mark@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/10165021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
All references have now been removed.
BUG=111731
Review URL: http://codereview.chromium.org/9317020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
"dar'win'" too.
BUG=111731
Review URL: https://chromiumcodereview.appspot.com/9159050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=111731
Review URL: https://chromiumcodereview.appspot.com/9223028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(patch discussed in bug and on connect page)
BUG=97534
Review URL: https://chromiumcodereview.appspot.com/9265019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These were added in r28089 (http://codereview.chromium.org/256059) but
are unnecessary bloat for everyone to carry around, even those that don't
use emacs or vim.
In an earlier change, I added editor config files in src/tools/emacs/
and src/tools/vim/ so users of the appropriate editor can source those
instead.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7310019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Extension of this change, applied more liberally:
http://src.chromium.org/viewvc/chrome/trunk/src/build/linux/chrome_linux.croc?r1=44710&r2=46647
Review URL: http://codereview.chromium.org/3540002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
common.croc.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2022007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1618027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that we have more and more proper grd dependencies in place,
this script may just do more harm than good by causing spurious rebuilds.
Additionally, it horked the build today.
TEST=none
BUG=17706
Review URL: http://codereview.chromium.org/1019007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add platform-specific coverage capability.
Add courgette to windows coverage.
BUG=none
TEST=make sure coverage bots work (continue to have ~36% coverage).
Review URL: http://codereview.chromium.org/545107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36502 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/460033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=successful builds
Review URL: http://codereview.chromium.org/256059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
assumes that the build output is in src/chrome/{Debug,Release}. Update
the clobber script to look in both places.
Review URL: http://codereview.chromium.org/255015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Why: Simpler build code. If everybody includes it, it should be included automatically.
Why now: The webkit chromium builds need it be specified, since can't default to build/common.gypi.
What was done:
1. build/common.gypi's contents were moved to a new file build/gyp_chromium.gypi
2. tools/gyp/gyp_chromium was moved to build/gyp_chromium and made to automatically include build/gyp_chromium.gypi.
3. lots of gyp files were fixed to not refer to build/common.gypi any more.
4. o3d which also builds independently of chrome, was fixed to have a gyp_o3d that includes gyp_chromium.gypi too.
5. build/common.gypi was left empty, because there are some external projects that still refer to it.
Things that are left to do after this patch is in:
1. The following external files (in other repositories) need to stop include common.gypi
./third_party/hunspell/hunspell.gyp
./third_party/icu/icu.gyp
./v8/tools/gyp/v8.gyp
2. Once nobody refers to common.gypi anymore, delete common.gypi
-or-
Delete gyp_chromium.gypi and move its content back to common.gypi
Tested on mac, win and linux. On win, got a few unit tests errors on chrome bookmarks, which should not be related. I'm running again with clobber to verify.
Review URL: http://codereview.chromium.org/206006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26302 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Only try to remove a generated header file if it exists.
Only report "Clobbered" if we actually removed something.
Print the actual system error if the removal fails.
Print the error message on stderr, not stdout.
Normalize the header file path name.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/164173
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=If it doesn't break the tree, it's perfect.
http://crbug.com/17706
Review URL: http://codereview.chromium.org/164096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I was unable to reproduce the failures from the bots on my machine.
If they appear again, the build will not break, ane we will get full info.
TEST=none
http://crbug.com/17706
Review URL: http://codereview.chromium.org/159866
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It turns out that on Windows the path-splitting function will always preserve the drive part (c:\).
TEST=none
http://crbug.com/17706
Review URL: http://codereview.chromium.org/159827
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This workarounds build problem with IncrediBuild.
TEST=none
http://crbug.com/17706
Review URL: http://codereview.chromium.org/159803
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Working around change in msvs_cygwin_shell added for nacl.
BUG=None
TEST=None
TBR=sgk
Review URL: http://codereview.chromium.org/155393
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Otherwise you're assuming you have cygwin in order to set it up.
Review URL: http://codereview.chromium.org/113505
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
dependency of targets that need it (that is, any target with
'rules' or 'actions').
Review URL: http://codereview.chromium.org/115154
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15774 0039d316-1c4b-4281-b951-d872f2087c98
|