| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Only try to remove a generated header file if it exists.
Only report "Clobbered" if we actually removed something.
Print the actual system error if the removal fails.
Print the error message on stderr, not stdout.
Normalize the header file path name.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/164173
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
so that all .gyp files use the same output locations regardless
of whether they're still using the old checked-in release.vsprops file.
BUG=none
TEST=successful build of the Purify configuration
Review URL: http://codereview.chromium.org/172077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Sync gyp stuff moved from common.gypi to chrome.gyp.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/169018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
consumers use executeCommand.
Patch by Marshall Greenblatt
R=darin
BUG=19270
TEST=covered by unit tests
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We're still figuring out what to do about strict aliasing and V8. In
the mean time, V8 (and other parts of the code) are unbuildable with
GCC 4.4 and strict aliasing. Adding this flag at the request of fta.
http://codereview.chromium.org/164538
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/164525
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
common.gypi
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/164445
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will eliminate the cxa_guard_acquire/release locks around static guard
accesses. The Windows compiler doesn't support thread-safe statics at all,
so none of our cross-platform code relies on thread safety. We are using
-fno-threadsafe-statics on Linux as well, since r20616. It's likely that
threading is not a concern in most to all Mac-specific code using statics.
BUG=16713
TEST=none
Review URL: http://codereview.chromium.org/165461
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
build, where C++ exceptions are already disabled.
BUG=19094 12248
TEST=Mac release-mode Google Chrome.app should shrink by about 6MB.
Mac disk image should shrink by about 1.5MB.
Linux binary and package should shrink too.
Review URL: http://codereview.chromium.org/165330
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23304 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/165379
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=mmoss
Review URL: http://codereview.chromium.org/164389
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23177 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Sesek <rsesek@gmail.com>.
Review URL: http://codereview.chromium.org/165314
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=18997
TEST=Release build produces plugin_carbon_interpose.dylib-*-i386.breakpad, and
Google Chrome.dsym.tar.bz2 contains plugin_carbon_interpose.dylib.dSYM
Review URL: http://codereview.chromium.org/164325
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/164265
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ugly, if they aren't built at build start, IB sometimes throws warnings about unknown things, so...
- Use one class for the localizer and generate the table that drives it.
- Update the generator script to process a list of xib files and generate one header.
- Update the data within the GYP file to do this.
- This might actually help overall size since it helps force one set of strings for each different window.
- Switch to bsearch for table lookup since we have one, larger table now.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/164260
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
plugin_carbon_interpose.dylib from the outer browser app bundle to the inner
helper app bundle.
Provide a separate app bundle for subprocesses like the renderer on the Mac.
Remove LSUIElement and related hacks from the browser's app bundle.
BUG=8044
TEST=Observe one Chromium and one or more Chromium Helper processes in
Activity Monitor
Review URL: http://codereview.chromium.org/164177
Review URL: http://codereview.chromium.org/164303
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
implementation. The stub will be replaced once the rest of
sync/engine lands as we open source the sync engine code.
Review URL: http://codereview.chromium.org/165257
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/164298
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22992 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Remove LSUIElement and related hacks from the browser's app bundle.
BUG=8044
TEST=Observe one Chromium and one or more Chromium Helper processes in
Activity Monitor
Review URL: http://codereview.chromium.org/164177
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=If it doesn't break the tree, it's perfect.
http://crbug.com/17706
Review URL: http://codereview.chromium.org/164096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/164208
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/164176
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
necessary 'chromium_builders' module when GYP gets updated to
use a more generic default.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/164216
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=18646
TEST=None
Review URL: http://codereview.chromium.org/165140
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
listed twice (a sub menu ends up with the same title as the menu item it hangs off, so it's easy to get dups within a xib file).
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/165133
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/165103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
_FILE_OFFSET_BITS=64 is incompatible with fts (issue 17492), so
file_util::Delete, file_util::CopyDirectory file_util::FileEnumerator are
reimplemented without fts. Delete and CopyDirectory are now implemented using
FileEnumerator.
Patch from vandebo@google.com, original review:
http://codereview.chromium.org/160479
BUG=13718,17492
TEST=none
Review URL: http://codereview.chromium.org/165085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22670 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/160622
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Patch from gmatht, originally reviewed at
http://codereview.chromium.org/160630
Review URL: http://codereview.chromium.org/164091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/160538
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22506 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
from build/LASTCHANGE.in if there's no actual svn or git change found.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159876
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
When there are no strings to localize, but a stub value into the table to avoid a compile error from array_size.
Review URL: http://codereview.chromium.org/160645
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I was unable to reproduce the failures from the bots on my machine.
If they appear again, the build will not break, ane we will get full info.
TEST=none
http://crbug.com/17706
Review URL: http://codereview.chromium.org/159866
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Purify
Release - no tcmalloc
This is done more pedantically than I'd like,
so I've left in some TODOs. Eventually either gyp needs to support some
notion of inheritance in configurations, or maybe we can make clever use
of includes.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/159362
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It turns out that on Windows the path-splitting function will always preserve the drive part (c:\).
TEST=none
http://crbug.com/17706
Review URL: http://codereview.chromium.org/159827
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This workarounds build problem with IncrediBuild.
TEST=none
http://crbug.com/17706
Review URL: http://codereview.chromium.org/159803
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159771
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/159732
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/160408
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
without tcmalloc for testing purpose. The linker complains about
_set_new_mode so I remove the call from the code for now.
Note this change is different from the change Bradley is working
on which provides an option for building chrome without tcmalloc.
This change simply removes tcmalloc from the build. The plan is
checking it in, keeping it in trunk for 24 hours, and then
reverting it. The benefits are
- Having another round of performance comparison between build
with and w/o tcmalloc.
- Having a full run of UI test under purify with tcmalloc disabled.
- Getting a verified CL in case we'd like to build an alternative
dev build w/o tcmalloc for A/B test.
Review URL: http://codereview.chromium.org/159599
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22080 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(I intend to use this as a quickie way to add
-g to Release builds so I can see symbols.
Is there a better way?)
Review URL: http://codereview.chromium.org/159621
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Also rearrange installer targets with better grouping for easier reading.
Review URL: http://codereview.chromium.org/159641
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=tony@chromium.org
Review URL: http://codereview.chromium.org/160398
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CrxInstaller is a new stateful object that encapsulates a
single installation from unpack through notification.
It currently contains the UI bits, but I suspect in the next
CL (where I will finally implement the install UI) these
will come out and CrxInstaller will become
SilentCrxInstaller, and only used for updates and external
installs.
Also in this change, I removed the concept of install callbacks that ExtensionUpdater was using. This was only used to delete the temp crx file as far as I can tell, and we can easily keep state about that in CrxInstaller.
With this CL, ExtensionsServiceBackend is almost completely
dead, with only a few zombie methods left like
LoadAllExtensions(). These should all become little objects
like CrxInstaller that hold a reference to ExtensionsService
over their lifetime and then kill themselves.
I'll get to that eventually.
Review URL: http://codereview.chromium.org/160311
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/160329
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We should test if it's ia32, not if it's not arm.
Patch by Joel Stanley.
Review URL: http://codereview.chromium.org/160316
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21954 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
repeat as much.
Merge in the missing app_strings resources.
Include app_strings.h in the generated localizers for the shared button titles in dialogs.
TEST=none
BUG=16764
Review URL: http://codereview.chromium.org/159219
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
No functional change, just reducing some cruft.
Review URL: http://codereview.chromium.org/159566
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21933 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
added for the bots. Once the bots are bounced to the new configs, this target could go away completely.
Review URL: http://codereview.chromium.org/159422
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21687 0039d316-1c4b-4281-b951-d872f2087c98
|