| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These were added in r28089 (http://codereview.chromium.org/256059) but
are unnecessary bloat for everyone to carry around, even those that don't
use emacs or vim.
In an earlier change, I added editor config files in src/tools/emacs/
and src/tools/vim/ so users of the appropriate editor can source those
instead.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7310019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Introduce a gyp variable "safe_browsing" which can be set to 0 to remove
safe browsing code at compile time.
Review URL: http://codereview.chromium.org/7227013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7324036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The only difference is I clear modifiers in Scrollbar test, and leave it enabled.
Unrevert ppapi_tests change:
Porting ppapi_tests framework to postMessage. Some tests still rely on scripting, so we changed to using InstancePrivate (since scripting will disappear from Instance soon). Also use conditional compilation so that if compiled as untrusted with NaCl, the tests use Instance instead of InstancePrivate. This means that tests which rely on scripting aren't runnable in NaCl.
BUG=82606
TEST=these tests.
Review URL: http://codereview.chromium.org/7237056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
There are two WebKit layout tests that try to use the HTTP::Date
perl module. This seems to be part of ubuntu-desktop, but in my chroot,
I needed to manually install this package.
Review URL: http://codereview.chromium.org/7237053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7326019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
target.
BUG=72317
TEST=None
R=tony@chromium.org
Review URL: http://codereview.chromium.org/7329002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some tests still rely on scripting, so we changed to using InstancePrivate (since scripting will disappear from Instance soon). Also use conditional compilation so that if compiled as untrusted with NaCl, the tests use Instance instead of InstancePrivate. This means that tests which rely on scripting aren't runnable in NaCl.
I also added a gyp option: pepper_scripting. The default is that scripting is on in this CL, but it will make it easy to turn it off in local builds. Soon we'll switch the default to no scripting, and soon after we can remove the option entirely.
BUG=82606
TEST=these tests
Review URL: http://codereview.chromium.org/7312008
TBR=dmichael@chromium.org
Review URL: http://codereview.chromium.org/7329024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some tests still rely on scripting, so we changed to using InstancePrivate (since scripting will disappear from Instance soon). Also use conditional compilation so that if compiled as untrusted with NaCl, the tests use Instance instead of InstancePrivate. This means that tests which rely on scripting aren't runnable in NaCl.
I also added a gyp option: pepper_scripting. The default is that scripting is on in this CL, but it will make it easy to turn it off in local builds. Soon we'll switch the default to no scripting, and soon after we can remove the option entirely.
BUG=82606
TEST=these tests
Review URL: http://codereview.chromium.org/7312008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7326008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91795 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=61140
TEST=Default compilation on Linux builds in smooth scrolling behind a flag - check about:flags to verify.
Review URL: http://codereview.chromium.org/7314015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=83557
TEST=QA testing required
Review URL: http://codereview.chromium.org/7282046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
r91301 was not intended to be used in Valgrind configurations, but the GYP
variable controlling Valgrind builds is named release_valgrind_build, which
makes it seem like the Valgrind builders use the Release configuration. r91301
was only effective in Debug mode. Who would have guessed that the Valgrind
builders actually use the Release configuration, and a separate check for
release_valgrind_build is needed to keep them from using
-fstack-protector-all.
BUG=88238
TEST=none
Review URL: http://codereview.chromium.org/7302010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was previously in effect at r29591 and then backed out at r29601 because
it may have caused problems with Valgrind. The Valgrind problems were probably
actually caused by -pie, which was recently reintroduced with protection
against being used in Valgrind configurations. I don't think that we have any
Valgrind builds that use the Debug configuration, so reintroducing this here
shouldn't have any effect on Valgrind.
Ancient history: in the pre-GYP days, we had -fstack-protector and
-fstack-protector-all in the debug.xcconfig that our Xcode-based build used.
See
http://src.chromium.org/viewvc/chrome/trunk/src/build/debug.xcconfig?view=markup&pathrev=21959
More information on this option:
http://developer.apple.com/library/mac/#documentation/DeveloperTools/gcc-4.2.1/gcc/Optimize-Options.html#index-fbtr_002dbb_002dexclusive-615
http://en.wikipedia.org/wiki/Buffer_overflow_protection#GCC_Stack-Smashing_Protector_.28ProPolice.29
BUG=16713 (not really, that's for release builds, but close enough)
TEST=everything
Review URL: http://codereview.chromium.org/7291019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enable position independence by linking executables with the -pie linker flag.
This was previously done in r29592, but had to be backed out in r29604 because
Valgrind didn't understand slide. I don't know if Valgrind understands slide
or not on Mac OS X now, but for the time being, we'll do this in non-Valgrind
build configurations.
Position independence turns on address space layout randomization (ASLR).
No perf impact expected. We don't really have any significant quantity of
exported symbols for the loader to chew on.
BUG=16713
TEST=Everything should still work
Review URL: http://codereview.chromium.org/7291012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The ultimate goal is to eliminate TOOLKIT_USES_GTK. Once that migration is completed, TOOLKIT_VIEWS + OS_LINUX should be enough.
Until this happens, we need a binary that:
1) has both gtk and pure-views
2) can enable pure views components with --use-pure-views when possible (this is default in touchui=1).
If we could switch everything with --use-pure-views, that'd be nice, but the world is not perfect and there are things that cannot co-exist (such as message pump). For such component, we'll use GYP_DEFINES to switch.
1) TOOLKIT_USES_PURE_VIEWS is defined with toolkit_pure_views=1.
2) all (or most of) chrome features must be functional with toolkit_pure_views=1
3) both TOOLKIT_USES_GTK and TOOLKIT_USES_PURE_VIEWS are defined. The latter has higher priority (that is, if implementation can't co-exists, TOOLKIT_USE_PURE_VIEWS will take precedence).
4) As the migration proceeds, there will be less TOOLKIT_USES_GTK and more TOOLKIT_USES_PURE_VIEWS.
5) Once the migration is complete (that is, there is no TOOKIT_USES_GTK), we can remove TOOLKIT_USES_PURE_VIEWS or replace it with OS_LINUX when necessary.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7273079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Nothing uses this yet, but is needed to make the changes to buildbot. It only
hooks into all.gyp so it can be built.
BUG=72317
TEST=sql_unittests
Review URL: http://codereview.chromium.org/7281015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
All of this code hasn't been used in over a year and has been replaced by VideoDecodeAccelerator and it's corresponding OpenMAX implementation OmxVideoDecodeAccelerator.
BUG=none
TEST=the world still compiles
Review URL: http://codereview.chromium.org/7066071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90697 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This includes a new lang: bs (Bosnian).
Patch from Fabien Tassin <fta@sofaraway.org>.
Review URL: http://codereview.chromium.org/7278001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/7238018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90616 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Implement AES-128-CTR.
BUG=87152
TEST=None
Review URL: http://codereview.chromium.org/7056026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=jeffbailey
Review URL: http://codereview.chromium.org/7240019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add runtime flag to control smooth scrolling. Add compile time flag handling for a GYP_DEFINE (enable_smooth_scrolling=1).
BUG=575,61140
TEST=compile still works without the flag. Compiling with the flag works once the WebKit change is landed, and then the flag appears in the about:flags page, and actually turns on that WebKit implementation.
Review URL: http://codereview.chromium.org/7034052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=jeffbailey
Review URL: http://codereview.chromium.org/7206052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In addition to these rules, to build
the USE_SKIA_ON_MAC_CHROME variation,
define: gyp_defines='use_skia=1'
As is, this does not change any existing
platform, and has no new tests.
BUG=79463
TEST=none
Review URL: http://codereview.chromium.org/7219009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Patch from Fabien Tassin <fta@sofaraway.org>.
Review URL: http://codereview.chromium.org/7205044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7187009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89292 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=28727
Review URL: http://codereview.chromium.org/7108053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
NO CODE CHANGE.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
in the upstream features.gypi.
Review URL: http://codereview.chromium.org/7104114
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Compile Chrome and confirm that gomacc command line is elided.
Review URL: http://codereview.chromium.org/7134063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88676 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles, run manually
Review URL: http://codereview.chromium.org/6975051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This change just enables the Spellcheck API implemented in <http://webkit.org/b/59693> on Chromium by default to fix WebKit Bug 62296 <http://webkit.org/b/62296>.
BUG=http://webkit.org/b/62296
TEST=editing/spelling/spellcheck-api.html
Review URL: http://codereview.chromium.org/7071003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=dglazkov
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that http://llvm.org/bugs/show_bug.cgi?id=10031 is fixed, this will hopefully
no longer crash clang.
BUG=84815
TEST=none
Review URL: http://codereview.chromium.org/7104062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
All of the changes in this CL are to shut up the warning, not because of real problems (I fixed these in separate CLs).
See the bug for a disussion of this change.
BUG=84424
TEST=none
Review URL: http://codereview.chromium.org/6995085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
features that need to be compiled out, instead of adding stubs.
Review URL: http://codereview.chromium.org/7046052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88374 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Notable changes in the range:
* r132735 (hopefully) fixes a bug introduced in r131951 that made
gold 1.10 crash with
/usr/bin/ld: internal error in set_offset, at output.cc:4030
* r132535 fixes the crash at -O3 on mac
* r132565 adds a warning for "x + y ? a : b" to -Wparentheses
BUG=85289,84424
TEST=none
TBR=evan
Review URL: http://codereview.chromium.org/7046048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=85289
TEST=none
TBR=evan
Review URL: http://codereview.chromium.org/7108018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
clang recently added a warning that warns when invoking 'delete' on a polymorphic non-final class without a virtual destructor. This finds real bugs – see the bug referenced below for a few examples.
However, one common pattern where it fires is this case:
class SomeInterface {
public:
virtual void interfaceMethod() {} // or = 0;
protected:
~SomeInterface() {}
}
class WorkerClass : public SomeInterface {
public:
// many non-virtual functions, but also:
virtual void interfaceMethod() override { /* do actual work */ }
};
void f() {
scoped_ptr<WorkerClass> c(new WorkerClass); // simplified example
}
(See the 2nd half of http://www.gotw.ca/publications/mill18.htm for an explanation of this pattern.)
It is arguably correct to fire the warning here, since someone might make a subclass of WorkerClass and replace |new WorkerClass| with |new WorkerClassSubclass|. This would be broken since WorkerClass doesn't have a virtual destructor.
The solution that the clang folks recommend is to mark WorkerClass as |final| (a c++0x keyword that clang supports as an extension in normal c++ mode – like override). But chrome's base/OWNERS deemed that as too complicated and we decided to make virtual the destructors of leaf classes that implement these interfaces and that are deleted dynamically. All of the changes in this CL are to shut up the warning, not because of real problems (I fixed these in separate CLs).
(For the gtk files, this is necessary because the CHROMEGTK_CALLBACK_ macros add virtual functions.)
BUG=84424
TEST=none
Review URL: http://codereview.chromium.org/7087028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The OS-level registration isn't implemented on Linux, and so every time the
browser starts it will act as though another program has been registered to
handle the protocols it knows about and deregister them all internally.
Review URL: http://codereview.chromium.org/7024043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
relevant code if set to 0.
In chrome/browser/task_manager I moved notifications related code to their own files and allow exclusion and stubbing via GYP. Similarly I have added stubs for other parts including a chrome/browser/notifications/notification_stubs.cc which takes care of classes within that directory.
I also created some static methods in DesktopNotificationService to wrap commonly used notification related code so that we reduce the amount of stubs required.
BUG=none
TEST=existing notification tests succeed
Review URL: http://codereview.chromium.org/7053041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=nsylvain
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88024 0039d316-1c4b-4281-b951-d872f2087c98
|