| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/28289
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/27277
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/28262
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10613 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This removes JSCRE from V8 and I have made the corresponding changes
to the xcode project.
Review URL: http://codereview.chromium.org/27199
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/28180
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
To fix this issue, this change adds a new function TrimWhitespaceUTF8(), which trims space characters (including non-printable characters and broken UTF-8 characters) from either end of a UTF-8 string.
Please feel free to give me your comments since I'm not sure this implimentation is correct. (Maybe this implementation trims too aggressively.)
BUG=7377
Review URL: http://codereview.chromium.org/20219
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10456 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/28138
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/27158
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(Also, stripping whitespace while I'm at it.)
TBR=agl
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/28078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/28076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
but the resulting 'chrome' binary crashes on start-up (test_shell seems to work better).
Review URL: http://codereview.chromium.org/27054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/27008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
symbol to be generated to make the Windows try slaves faster.
Review URL: http://codereview.chromium.org/27009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- fix scons dependencies by adding a target for grit/theme_resources.h
- fix mac build by adding grit to unittest include path
- fix check deps by adding rules for /grit dir.
Create a chrome_resources.vcproj that holds grd files that hold
non-string resources. Put browser_resources.grd into this vcproj.
Port theme_resources.rc/theme_resources.h to theme_resources.grd
and put it in the vcproj too.
I did a find/replace on the theme_resources include line.
Modify grit so header files go in grit_generated_resources/grit/
so the include path can be cleaner. I'll migrate the others
in follow up patches.
theme_resources.rc had a conditional include of distribution_resources.rc
so I had to add support for preprocessor defines to visual studio.
Review URL: http://codereview.chromium.org/24011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/23024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
It doesn't seem to occur anywhere in the SCons code nor in ours(?).
Review URL: http://codereview.chromium.org/20174
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
check to use _WIN32 since it is defined 100% of the time.
Review URL: http://codereview.chromium.org/20108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
back into the V8 Xcode project to make sure that assertions are enabled
in debug builds.
Review URL: http://codereview.chromium.org/21062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9194 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
breaking the debug builds.
Review URL: http://codereview.chromium.org/20002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9053 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
No code change.
B=4380
Review URL: http://codereview.chromium.org/19501
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
r8805 made it compile.
Review URL: http://codereview.chromium.org/19422
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8842 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Follow up to issue 19041/r8767. Building with SHARED=1 --mode=opt got errors with missing sqlite. Move sqlite append from chrome/SConscript to build/SConscript.main.
Review URL: http://codereview.chromium.org/19615
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This change is just disabling the targets that don't currently work. This is
needed for the debug linux webkit builder that is coming online real soon now.
Review URL: http://codereview.chromium.org/19041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Don't pass -s, this doesn't really help anything. The way we will have
to generate our final executables is with -g, and then strip them, since
we will need to keep the original for its symbols.
- Only gc sections in official build. This might slightly improve release
link time (at the cost of size). This allows release to build with GOLD.
Review URL: http://codereview.chromium.org/18846
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
In the presence of an installed copy of the 6.1 SDK, SCons would pick up on the presence of the VC9 toolchain which tags along with it. It would proceed to populate the environment with a mismatched set of paths referring to VC9 includes and libs,
which in turn would cause the chrome base build to terminate with a LNK1103 error complaining of corrupt symbols.
Patch contributed by Siggi @ Google.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Broke linux build.
Review URL: http://codereview.chromium.org/18820
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
In the presence of an installed copy of the 6.1 SDK, SCons would pick up on the presence of the VC9 toolchain which tags along with it. It would proceed to populate the environment with a mismatched set of paths referring to VC9 includes and libs,
which in turn would cause the chrome base build to terminate with a LNK1103 error complaining of corrupt symbols.
Patch contributed by Siggi @ Google.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Strip all symbols. We previously had many exported symbols.
- GC sections. -fdata/function-sections make sure each piece of code/data has it's own section, since GC works on an entire section. I will follow up on the V8 build with the same.
- Remove the ident pragmas. For example, we previously had a string like:
GCC: (GNU) 4.2.4 (Ubuntu 4.2.4-1ubuntu1)
Repeated in the .comment section (one for each object?). This data is just metadata.
Review URL: http://codereview.chromium.org/18586
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
- resorted files by GUIDs (the file adding script wasn't doing that before).
- update the cached sub targets from referenced projects.
Review URL: http://codereview.chromium.org/18595
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18748
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18521
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18521
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=mark@chromium.org
Review URL: http://codereview.chromium.org/18311
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
expect.
Review URL: http://codereview.chromium.org/18047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/17345
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
not allowed to access nfs).
Clean up carefully afterwards.
Review URL: http://codereview.chromium.org/17415
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Doing a full build seems always fine. The issue is for incremental builds, it corrupts the PDBs. Errors look like:
glue.lib(autofill_form.obj) : fatal error LNK1318: Unexpected PDB error; RPC (23) '(0x000006BA)'
...\xmemory(155) : error C2471: cannot update program database '...\debug\obj\plugin_tests\vc80.pdb'
We'll probably need to upgrade to VS2008 to add it back.
Review URL: http://codereview.chromium.org/17208
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
is the same as using_generated_resources.vsprops.
Replace existing paths with this scons file if the SConscript
file has already been converted to the using_ format.
Review URL: http://codereview.chromium.org/14902
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7583 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
about 30%, and at least doesn't hurt 2-processor systems.
Review URL: http://codereview.chromium.org/16521
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/14175
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/15406
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7561 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
be removed from essential.vsprops.
This should have been a part of r7520 ( http://src.chromium.org/viewvc/chrome?view=rev&revision=7520 )
TBR=nsylvain
Review URL: http://codereview.chromium.org/16501
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7533 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
necessary for
dynamic font support.
This is a re-run of http://codereview.chromium.org/14908/show (except that chrome_dll.deps file which needs to be updated along with the actual code change)
This will be followed by http://codereview.chromium.org/16494 (actual webkit code change) and changes in webkit/build
BUG=1303
Review URL: http://codereview.chromium.org/16496
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7520 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=nsylvain
Review URL: http://codereview.chromium.org/17021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
SDK upgrade is necessary to support dynamic/webfont because SDK 6.0 does not have
t2embapi.h and t2embed.lib. SDK 6.1 is compatible with WIn XP and VS 2005 or later.
FYI:
http://codereview.chromium.org/14084/show is the CL for adding web/dynamic font support.
Review URL: http://codereview.chromium.org/14908
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7500 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
updated ICU dep that uses it as well.
Add a SHARED scons command-line flag to build shared libraries.
Review URL: http://codereview.chromium.org/16477
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
base\build\base.vcproj
base\build\base_gfx.vcproj
base\build\base_unittests.vcproj
base\build\debug_message.vcproj
skia\skia.vcproj
testing\gtest.vcproj
third_party\icu38\icu.vcproj
third_party\icu38\icudt.vcproj
third_party\libpng\libpng.vcproj
third_party\zlib\zlib.vcproj
Supporting work in *.scons files:
* Adds .h files to the input_files lists in the various *.scons files.
* Add arguments to ChromeMSVSProject() to actually generate the
.vcproj files.
* Add MSVS.AddConfig() calls to the *.scons files to preserve the
.vsprops inclusion in the generated .vcproj files.
(These will go away eventually as we migrate away from .vsprops
in favor of using the settings from the SCons configuration.)
* Add MSVS.AddConfig() calls to preserve the .vsprops inclusion.
* Move the special generation of dmg_fp/*.cc files ahead of the
input file list so we can list the generated object files.
* Change the 'solutions' Alias to 'msvs' so we don't mislead about
what will actually be generated.
Updates to the new _Node_MSVS.py module with latest from upstream
prototype development:
* Support configurability of:
* buildtarget (used to generat project name)
* RootNamespace
* relative_path_prefix (to prepend './')
* tools (to avoid repetition in the project configs)
* Track the Visual Studio hierarchy in SCons Nodes, not DOM,
so we can delay evaluation until after the complete
configuration has been specified.
* Add a FileList base class for the things that need, with a
subclass hierarchy for the different concrete things in our tree,
and a FileListWalk() function for traversing hierarchies.
* Centralize turning strings into Nodes in the args2nodes() method
and have AddFiles() just use it.
Updates to chromium_builders.py to support all this
* Add knowledge about stripping out noncompilable files
(.h files) from input_files lists.
* Return a Null() class if we're not generating MSVS files
so we don't have to hide the other calls in if:-blocks.
* Add custom ChromeFileList subclass of MSVS.FileList as a
container for the file list manipulation we need to do.
* Move the Chrome*() function definitions out to global space,
and just use the generate() function for adding them to
the passed-in environment as class methods.
* Make a change to SCons (in Node/FS.py) to handle polymorphism in
the new MSVS Node hierarchy.
Review URL: http://codereview.chromium.org/16447
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(project files still to come). To wit:
* Solution file configuration is in *_sln.scons files (base\base_sln.scons,
chrome\chrome_sln.scons).
* Individual Project file configuration is in the the .scons file for
the relevant target (base\base_unittests.scons,
third_party\libxml\libxml.scons, etc.)--that is, where their file
lists will live.
* MSVSProject() calls are currently placeholders that establish
the existence of Project Nodes (and Project dependencies) but don't yet
have actual Project configuration information (file lists, .vsprops, etc.).
* Configuraiton is very manual. In particular, the entries in the .sln
file will be written out in exactly the order specified in the
configuration(s). The current ordering is taken from our existing
.sln files, so we can generate virtually the same configurations
on output.
* Generated solution files are nearly byte-for-byte identical
with our existing .sln files, modulo:
* net\dump_cache has a WebsiteProperties sections (making that
configurable per project isn't important right now);
* sandbox\sandbox.sln was missing a dependency of base.vcproj on
on debug_message.vcproj (present in other .sln files)
* webkit\webkit.sln was missing dependencies of WebCore.vcproj on
libxml_config.vcproj and libxslt_config.vcproj (present in
chrome.sln);
* add a handful of other miscellaneous missing dependencies on various
.vcproj definitions in chrome.sln (present in other .sln files).
* remove stats_viewer.csproj from chrome.sln (sorry, mbelshe),
which was complicating the solution configuration with unnecessary
(for us) "Mixed Platform" types;
* All MSVSFolder(), MSVSProject() and MSVSSolution() calls have
hard-wired guid= values taken from our existing configuration,
so we can: 1) verify generation of working configs; 2) minimize
diffs when checking in generated .sln files. We can remove
these in the future in favor of extracting them from existing
.sln files if we wish.
* Add ChromeMSVSFolder(), ChromeMSVSProject() and ChromeMSVSSolution()
wrappers to chromium_builders.py, that gate the underlying call to
the env.MSVS*() builders based on whether env.Bit('msvs') is set
(i.e., we're in --mode=msvs).
* Remove platform-specific gating of to-be-ported .scons files that we
now need to load on any platform to generate coheren MSVS files.
Move the env.Bit('windows') tests for actually building their
executables into the individual .scons files.
Review URL: http://codereview.chromium.org/14472
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7297 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and better-thought-out Hammer env.Bits() idioms:
* env['PLATFORM'] == 'win32' => env.Bit('windows')
* env['PLATFORM'] == 'posix' => env.Bit('linux')
* env['PLATFORM'] == 'darwin' => env.Bit('mac')
New idioms:
* env.Bit('posix') => really does mean "any POSIX platform"
* env.AnyBits('mac', 'linux') => specifically mac or linux, excluding
other POSIX platforms
Where we were using compound conditionals (e.g., "env['PLATFORM'] in
('posix', 'darwin')") I tried to take my best shot at translating
the intent (i.e., "env.Bits('posix')" for something POSIX, "not
env.Bits('mac')" for something not yet ported to Mac, etc.)
Review URL: http://codereview.chromium.org/15051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7270 0039d316-1c4b-4281-b951-d872f2087c98
|