summaryrefslogtreecommitdiffstats
path: root/build
Commit message (Collapse)AuthorAgeFilesLines
* Add a 'tools' list to 'scons_settings' so we'll still get thesgk@google.com2009-08-101-0/+1
| | | | | | | | | | necessary 'chromium_builders' module when GYP gets updated to use a more generic default. BUG=none TEST=none Review URL: http://codereview.chromium.org/164216 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22892 0039d316-1c4b-4281-b951-d872f2087c98
* Turning on incremental linking for 64-bit machines.bradnelson@chromium.org2009-08-071-1/+7
| | | | | | | | | BUG=18646 TEST=None Review URL: http://codereview.chromium.org/165140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22790 0039d316-1c4b-4281-b951-d872f2087c98
* Bounce through a set so we uniq the string list to avoid having something ↵thomasvl@chromium.org2009-08-071-3/+3
| | | | | | | | | | listed twice (a sub menu ends up with the same title as the menu item it hangs off, so it's easy to get dups within a xib file). TEST=none BUG=none Review URL: http://codereview.chromium.org/165133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22734 0039d316-1c4b-4281-b951-d872f2087c98
* Add 'rpm' to dev tools for creating RPM packages.mmoss@chromium.org2009-08-061-1/+1
| | | | | | | Review URL: http://codereview.chromium.org/165103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22694 0039d316-1c4b-4281-b951-d872f2087c98
* Define _FILE_OFFSET_BITS=64 in order to support large files (>2GB).thestig@chromium.org2009-08-061-0/+1
| | | | | | | | | | | | | | | | | | _FILE_OFFSET_BITS=64 is incompatible with fts (issue 17492), so file_util::Delete, file_util::CopyDirectory file_util::FileEnumerator are reimplemented without fts. Delete and CopyDirectory are now implemented using FileEnumerator. Patch from vandebo@google.com, original review: http://codereview.chromium.org/160479 BUG=13718,17492 TEST=none Review URL: http://codereview.chromium.org/165085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22670 0039d316-1c4b-4281-b951-d872f2087c98
* Add patch to the Linux build deps script.thestig@chromium.org2009-08-061-1/+1
| | | | | | Review URL: http://codereview.chromium.org/160622 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22669 0039d316-1c4b-4281-b951-d872f2087c98
* Report apt-get failures in install-build-deps.shdkegel@google.com2009-08-061-14/+35
| | | | | | | | | Patch from gmatht, originally reviewed at http://codereview.chromium.org/160630 Review URL: http://codereview.chromium.org/164091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22665 0039d316-1c4b-4281-b951-d872f2087c98
* Move the entire application into a dylib (framework)mark@chromium.org2009-08-053-40/+113
| | | | | | Review URL: http://codereview.chromium.org/160538 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22506 0039d316-1c4b-4281-b951-d872f2087c98
* Allow the lastchange target to get a hard-coded default last changesgk@google.com2009-08-052-5/+16
| | | | | | | | | from build/LASTCHANGE.in if there's no actual svn or git change found. BUG=none TEST=none Review URL: http://codereview.chromium.org/159876 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22489 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing parens for format string to work.thomasvl@chromium.org2009-08-051-1/+5
| | | | | | | When there are no strings to localize, but a stub value into the table to avoid a compile error from array_size. Review URL: http://codereview.chromium.org/160645 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22483 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable the grit hook, and make it more solid in case of failures.phajdan.jr@chromium.org2009-08-051-1/+11
| | | | | | | | | | | | | I was unable to reproduce the failures from the bots on my machine. If they appear again, the build will not break, ane we will get full info. TEST=none http://crbug.com/17706 Review URL: http://codereview.chromium.org/159866 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22480 0039d316-1c4b-4281-b951-d872f2087c98
* Adding two new windows configuration types:bradnelson@chromium.org2009-08-041-0/+46
| | | | | | | | | | | | | | | | | Purify Release - no tcmalloc This is done more pedantically than I'd like, so I've left in some TODOs. Eventually either gyp needs to support some notion of inheritance in configurations, or maybe we can make clever use of includes. BUG=None TEST=None Review URL: http://codereview.chromium.org/159362 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22433 0039d316-1c4b-4281-b951-d872f2087c98
* Fix infinite loop in grit headers clobbering script.phajdan.jr@chromium.org2009-08-031-1/+3
| | | | | | | | | | | It turns out that on Windows the path-splitting function will always preserve the drive part (c:\). TEST=none http://crbug.com/17706 Review URL: http://codereview.chromium.org/159827 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22344 0039d316-1c4b-4281-b951-d872f2087c98
* Add hook to clobber header files generated by grit on Windows.phajdan.jr@chromium.org2009-08-031-0/+49
| | | | | | | | | | | This workarounds build problem with IncrediBuild. TEST=none http://crbug.com/17706 Review URL: http://codereview.chromium.org/159803 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22325 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r22080 and re-enable tcmalloc.huanr@chromium.org2009-08-021-0/+1
| | | | | | Review URL: http://codereview.chromium.org/159771 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22251 0039d316-1c4b-4281-b951-d872f2087c98
* Making /MP on by default for msvs2008.bradnelson@chromium.org2009-07-311-6/+18
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/159732 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22220 0039d316-1c4b-4281-b951-d872f2087c98
* Make the Visual Studio /MP flag configurable.aa@chromium.org2009-07-311-0/+8
| | | | | | Review URL: http://codereview.chromium.org/160408 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22176 0039d316-1c4b-4281-b951-d872f2087c98
* Removing tcmalloc from gyp so we can build a version of chromehuanr@chromium.org2009-07-301-1/+0
| | | | | | | | | | | | | | | | | | | | | | without tcmalloc for testing purpose. The linker complains about _set_new_mode so I remove the call from the code for now. Note this change is different from the change Bradley is working on which provides an option for building chrome without tcmalloc. This change simply removes tcmalloc from the build. The plan is checking it in, keeping it in trunk for 24 hours, and then reverting it. The benefits are - Having another round of performance comparison between build with and w/o tcmalloc. - Having a full run of UI test under purify with tcmalloc disabled. - Getting a verified CL in case we'd like to build an alternative dev build w/o tcmalloc for A/B test. Review URL: http://codereview.chromium.org/159599 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22080 0039d316-1c4b-4281-b951-d872f2087c98
* Add a way to inject extra cflags in release builds.dank@chromium.org2009-07-301-0/+2
| | | | | | | | | | (I intend to use this as a quickie way to add -g to Release builds so I can see symbols. Is there a better way?) Review URL: http://codereview.chromium.org/159621 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22064 0039d316-1c4b-4281-b951-d872f2087c98
* Add Linux package building target.mmoss@chromium.org2009-07-301-0/+7
| | | | | | | | | Also rearrange installer targets with better grouping for easier reading. Review URL: http://codereview.chromium.org/159641 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22063 0039d316-1c4b-4281-b951-d872f2087c98
* Undo accidental change to common.gypi.aa@chromium.org2009-07-301-1/+0
| | | | | | | | TBR=tony@chromium.org Review URL: http://codereview.chromium.org/160398 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22059 0039d316-1c4b-4281-b951-d872f2087c98
* Pull CrxInstaller out of ExtensionsService.aa@chromium.org2009-07-301-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | CrxInstaller is a new stateful object that encapsulates a single installation from unpack through notification. It currently contains the UI bits, but I suspect in the next CL (where I will finally implement the install UI) these will come out and CrxInstaller will become SilentCrxInstaller, and only used for updates and external installs. Also in this change, I removed the concept of install callbacks that ExtensionUpdater was using. This was only used to delete the temp crx file as far as I can tell, and we can easily keep state about that in CrxInstaller. With this CL, ExtensionsServiceBackend is almost completely dead, with only a few zombie methods left like LoadAllExtensions(). These should all become little objects like CrxInstaller that hold a reference to ExtensionsService over their lifetime and then kill themselves. I'll get to that eventually. Review URL: http://codereview.chromium.org/160311 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22043 0039d316-1c4b-4281-b951-d872f2087c98
* Dump all .xcconfigs. They're no longer used, all of these settings are in GYP.mark@chromium.org2009-07-296-90/+0
| | | | | | Review URL: http://codereview.chromium.org/160329 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21960 0039d316-1c4b-4281-b951-d872f2087c98
* Fix gyp condition for ia32 specific flags.deanm@chromium.org2009-07-291-1/+1
| | | | | | | | | | | We should test if it's ia32, not if it's not arm. Patch by Joel Stanley. Review URL: http://codereview.chromium.org/160316 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21954 0039d316-1c4b-4281-b951-d872f2087c98
* Put the common paths for localizers into variables so we don't have to ↵thomasvl@chromium.org2009-07-291-0/+1
| | | | | | | | | | | | | | repeat as much. Merge in the missing app_strings resources. Include app_strings.h in the generated localizers for the shared button titles in dialogs. TEST=none BUG=16764 Review URL: http://codereview.chromium.org/159219 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21951 0039d316-1c4b-4281-b951-d872f2087c98
* linux: refactor some common flags in common.gypievan@chromium.org2009-07-291-14/+6
| | | | | | | | No functional change, just reducing some cruft. Review URL: http://codereview.chromium.org/159566 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21933 0039d316-1c4b-4281-b951-d872f2087c98
* Now that testshell depends on imagediff we can start to cleanup the targets ↵thomasvl@chromium.org2009-07-271-6/+4
| | | | | | | | added for the bots. Once the bots are bounced to the new configs, this target could go away completely. Review URL: http://codereview.chromium.org/159422 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21687 0039d316-1c4b-4281-b951-d872f2087c98
* re-do CL 2136 - move image_diff to tools/imagediff, add deps to test_shelldpranke@google.com2009-07-241-1/+1
| | | | | | | | | | | | | | | | | moving image_diff from chrome/tools/test/image_diff to tools/imagediff (not moving to tools/image_diff to avoid some svn unpleasantness with that directory having been created in CL 21366). Also change test_shell.gyp to depend on everything needed to run the layout tests. R=darin@chromium.org TEST=none BUG=none Review URL: http://codereview.chromium.org/159361 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21584 0039d316-1c4b-4281-b951-d872f2087c98
* back out CLs 21367, 21366 - no idea why these keep breakingdpranke@google.com2009-07-231-1/+1
| | | | | | Review URL: http://codereview.chromium.org/155983 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21371 0039d316-1c4b-4281-b951-d872f2087c98
* re-do CL 21252 - move image_diff to tools, add deps to test_shelldpranke@google.com2009-07-231-1/+1
| | | | | | | | | | | | | | | CL 21252 seems to have had some svn brokenness (not sure why). I've recreated it and resubmitted it. The changes are to move image_diff from chrome/tools/test to tools/, and to make test_shell depend on image_diff and npapi_layout_test_plugin (and test_worker, where applicable) R=nsylvain@chromium.org TEST=none BUG=none Review URL: http://codereview.chromium.org/155959 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21366 0039d316-1c4b-4281-b951-d872f2087c98
* Split the IPC code into ipc/agl@chromium.org2009-07-221-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This splits the ipc code from the common project. The 'common' project pulls in all of webkit, the v8 bindings, skia, googleurl, and a number of other projects which makes it very difficult to deal with especially for external projects wanting just to use some of Chromium's infrastructure. This puts the ipc code into its top-level ipc/ directory with a dependency only on base. The common project depends on the new ipc/ipc.gyp:ipc target so that all projects currently pulling common in to get the IPC code still have it available. This mostly follows agl's pre-gyp attempt to do this which was r13062. Known issues: - Currently a number of projects depend on chrome/chrome.gyp:common in order to use the IPC infrastructure. Rather than fixing all of these dependencies I have made common depend on ipc/ipc.gyp:ipc and added "ipc" to the include_rules section of DEPS so that checkdeps.py doesn't complain. Over time projects that need IPC should depend on the IPC project themselves and dependencies on common removed, although I don't think many projects that need IPC will be able to get away without common currently. - ipc/ipc_message_macros.h still has #include "chrome/common/..." inside of a ipc/ should not refer to files in chrome/... now. I'm not sure how to resolve this since it's really an IDE bug - the named pipe name (windows+linux) and the logging event name (all) + env variable (posix) refer explicitly to 'Chrome' which somewhat hurts the illusion of ipc/ being an independent library. I think this should be examined in a subsequent, much smaller patch. - I've eliminated the IPC.SendMsgCount counter since it was implemented in a way to create a dependency from ipc/ to chrome/common/chrome_counters. This is the same approach that r13062 took. http://codereview.chromium.org/155905 (Patch from James Robinson) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21342 0039d316-1c4b-4281-b951-d872f2087c98
* Add a custom subclass of GTMUILocalizer that skips the bundle work so we can ↵thomasvl@chromium.org2009-07-221-5/+3
| | | | | | | | | | | | directly use these from nib files without some extra overhead. Updated the generator to make things based off this subclass. TEST=none BUG=16764 Review URL: http://codereview.chromium.org/159197 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21280 0039d316-1c4b-4281-b951-d872f2087c98
* Starting mac l10n:thomasvl@chromium.org2009-07-221-0/+175
| | | | | | | | | | | | | | | | | | | Added a script to process a xib file and generate a localizer out of the resource constants it finds in the xib. Update the MainMenu.xib to use a generated localizer. Kill off the menu_localizer in favor of a generated one. ui_localizer is a helper so each "localizer" is as small as possible. Build some menus out of base strings and the product name like windows. Added the dir generated for the localizers so we can load the header to directly create them (menubar one). Enable the other 3 languages we were building to help test. Made the context menu code use the new code for handling window's accelerators and ellipsis. Added unittest for ui_localizer. Opened http://crbug.com/17380 to track the problem with the menu titles so I can move on to other parts of the UI for now. TEST=The main menu will have some items localized now (and more will be localizable in the TC). BUG=16764 Review URL: http://codereview.chromium.org/155774 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21272 0039d316-1c4b-4281-b951-d872f2087c98
* revert change 21252, which broke the mac build for some reasondpranke@google.com2009-07-221-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21262 0039d316-1c4b-4281-b951-d872f2087c98
* make 'test_shell' target depend on everything needed to pass layout_testsdpranke@google.com2009-07-221-1/+1
| | | | | | | | | | | | | | | | | This adds project dependencies to test_shell so that all (and only?) the targets needed for the layout_tests to run cleanly are built. On most platforms this is test_shell, npapi_test_plugin, and test_worker, and on the Mac this adds the layout_test_helper binary as well also, this moves image_diff from chrome/tools/test to tools/ R=mmentovai@google.com, darin@google.com BUG=none TEST=none Review URL: http://codereview.chromium.org/149714 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21252 0039d316-1c4b-4281-b951-d872f2087c98
* Add way to override optimization level for release build. dkegel@google.com2009-07-211-1/+4
| | | | | | | | | | Will be used with valgrind to speed up the bots more. This was suggested during http://codereview.chromium.org/67199, finally need it. Review URL: http://codereview.chromium.org/155817 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21169 0039d316-1c4b-4281-b951-d872f2087c98
* Pulling in new gyp version.bradnelson@chromium.org2009-07-201-1/+1
| | | | | | | | | | | | | | Switching two includes in common.gypi to msvs_system_include_dirs. This will force them to the back of the include order (which matches where the non-hermetic copies of these libraries would be). BUG=None TEST=None Review URL: http://codereview.chromium.org/155812 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21124 0039d316-1c4b-4281-b951-d872f2087c98
* Code changes to get the code to compile under GCC.sra@google.com2009-07-181-0/+1
| | | | | | | | | | | | Courgette still only knows how to compress Windows x86 executables. But now you can compress them on linux. BUG=none TEST=none Review URL: http://codereview.chromium.org/149597 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21042 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: move hardcoded paths to GYP variables.agl@chromium.org2009-07-151-1/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch removes the hardcoded paths for the sandbox binary location and the chrome binary location for the sandbox. Instead, you can now set GYP variables for these things. Indeed, you have to set a GYP variable in order to use the sandbox now. GYP variables can be set on the command line, if you run gyp.py directly, with -D key=value. Or you can export GYP_DEFINES="key=value key2=value2". Now, in order to use the sandbox you should set: linux_sandbox_path=/opt/google/chrome/chrome-sandbox linux_sandbox_chrome_path=/opt/google/chrome/chrome (changing the paths as needed, of course). See the comments in build/common.gypi For development see http://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment Because developers need to setup a special sandbox binary. http://codereview.chromium.org/149689 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20801 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: fix for developing on a machine with google-chrome packages installed.agl@chromium.org2009-07-151-0/+8
| | | | | | | | | | | | | | | | | | | | | | | The latest google-chrome packages contain a sandbox binary, which the development builds of chromium will pick up on automatically. However, for safety reasons, the sandbox binary will only exec a fixed chrome binary location. Since development builds will be somewhere else in the filesystem, this means that they will fail to start their zygote processes and generally be very sad. However, we /do/ want people developing with the sandbox, but we don't want the general sandbox binary to be able to exec anything. We could have chromium try and find its sandbox binary relative to the build directory, but some people build on NFS and, since the sandbox binary needs to be SUID, this won't work for them. Instead, we add a new target: chrome_devel_sandbox which developers can use. This builds a sandbox binary that will exec anything which is owned by the running user. This alternative sandbox binary can be selected by exporting CHROME_DEVEL_SANDBOX. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20709 0039d316-1c4b-4281-b951-d872f2087c98
* Add a variable that lets you override the optimization level for release ↵thomasvl@chromium.org2009-07-141-0/+7
| | | | | | | | builds (for valgrind -- to avoid inlining, etc.) Review URL: http://codereview.chromium.org/155501 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20636 0039d316-1c4b-4281-b951-d872f2087c98
* Add -fno-threadsafe-statics to the Linux build.deanm@chromium.org2009-07-141-0/+6
| | | | | | | | | | | We already depend on our static initializers being thread safe, since MSVC does not implement locking around static initialization. This avoids extra locking (__cxa_guard_acquire / __cxa_guard_release). Review URL: http://codereview.chromium.org/149607 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20616 0039d316-1c4b-4281-b951-d872f2087c98
* Pulling in new gyp version.bradnelson@chromium.org2009-07-111-1/+1
| | | | | | | | | | | | Working around change in msvs_cygwin_shell added for nacl. BUG=None TEST=None TBR=sgk Review URL: http://codereview.chromium.org/155393 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20449 0039d316-1c4b-4281-b951-d872f2087c98
* Replace instances of LINUX2 with OS_CHROMEOS and linux2 with chromeos.brettw@chromium.org2009-07-081-3/+3
| | | | | | Review URL: http://codereview.chromium.org/149367 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20210 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: SUID sandbox supportagl@chromium.org2009-07-081-1/+2
| | | | | | | | | | | | | | | | | | | | | * Make processes dumpable when they crash. * Find crashing processes by searching for a socket inode, rather than relying on SCM_CREDENTIALS. The kernel doesn't translate PIDs between PID namespaces with SCM_CREDENTIALS, so we can't use the PID there. * Use a command line flag to the renderer to enable crash dumping. Previously it tried to access the user's home directory for this information. * Search for a sandbox helper binary and, if found, use it. * Include the source for a sandbox helper binary. It's currently not built by default. http://codereview.chromium.org/149230 R=evan,markus BUG=8081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20110 0039d316-1c4b-4281-b951-d872f2087c98
* Beginning of code coverage on Windows.jrg@chromium.org2009-07-071-4/+16
| | | | | | Review URL: http://codereview.chromium.org/155123 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20045 0039d316-1c4b-4281-b951-d872f2087c98
* Modifying mini_installer to have different additional options.bradnelson@chromium.org2009-07-031-7/+20
| | | | | | | | | | | | This should not affect other targets. BUG=None TEST=None TBR=sgk Review URL: http://codereview.chromium.org/149152 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19916 0039d316-1c4b-4281-b951-d872f2087c98
* Don't screw up /usr/bin/ld if you can't write to current dir as root.dkegel@google.com2009-06-301-11/+23
| | | | | | | | | BUG=http://crbug.com/15700 TEST=make sure ld is not gold, make sure root can't write to your nfs home directory, copy this script there, run it, let it install gold, verify it aborts early without torching /usr/bin/ld Review URL: http://codereview.chromium.org/151113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19683 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the tree. It looks like the previous change (19561)nsylvain@chromium.org2009-06-301-16/+7
| | | | | | | | | | | | | did not work as expected, since most of the windows machines are red trying to load dwmapi.dll, which should be in the delay load list. I'm reverting part of this change. TBR:bradnelson Review URL: http://codereview.chromium.org/150102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19581 0039d316-1c4b-4281-b951-d872f2087c98
* Learned that mini_installer's linker settings cannot actually be sharedbradnelson@chromium.org2009-06-301-8/+17
| | | | | | | | | | | | | by everyone else. Separated mini_installer into its own gyp file and isolated it from several common settings. BUG=None TEST=None Review URL: http://codereview.chromium.org/150045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19561 0039d316-1c4b-4281-b951-d872f2087c98