| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
was accidentally lost in r16719.
BUG=9007
Review URL: http://codereview.chromium.org/115902
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add support for scanning missing source files for executable lines.
Add support for HTML output.
Now reports percent coverage.
BUG=none
TEST=by hand on experimental buildbot
Review URL: http://codereview.chromium.org/113980
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115874
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Initially these will be drop in replacements for the existing projects.
These were generated mechanically in lieu of a looping syntax.
Review URL: http://codereview.chromium.org/115853
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This checkin adds gmock, and a small example of how to write a gmock-based unittest.
Original Review URL: http://codereview.chromium.org/113807
Review URL: http://codereview.chromium.org/115846
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* activex_test_control.dll
* browser_tests.dll
* browser_tests.exe
* memory_watcher.dll
* rlz.dll
* security_tests.dll
* test_chrome_plugin.dll
* themes/default.dll
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113915
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
make chrome app depend on pdfsqueeze
add a rule to run pdfs through pdfsqueeze
BUG=7654
TEST=pdf files in resources should be smaller now.
Review URL: http://codereview.chromium.org/113911
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17022 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115778
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(For reference, it was committed with the wrong message: "Patch to make
password patch build.")
This reverts commit r16708.
Review URL: http://codereview.chromium.org/113871
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115801
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
This reverts commit 071e95bcdcefcd2cb86c9aed5cb073bbcaa7f2a7.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This checkin adds gmock, and a small example of how to write a gmock-based unittest.
Review URL: http://codereview.chromium.org/113807
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This commits a rewrite of the Breakpad Linux client.
The old code:
* Had a number of plain bugs in it, but those could just have been
fixed.
* Allocated memory from the heap, which is a no go.
* Made libc calls which can enter the dynamic linker - another source
of crashes.
* Didn't understand some of the tricks needed, like clone() via libc
will write to random areas of memory because it assumes that it's
only called from libpthread
Additionally, we had one more requirement which meant changing the
interface:
* We need to be able to crash dump the renderers from the browser
process.
And that last one really needed a rewrite.
We intend to try and upstream this new code into Breakpad.
The new Breakpad design works like this:
When a renderer crashes, a signal handler runs on an alternative stack
and collects information about the registers of the thread before the
crash. Then we enter Chromium specific code an send a datagram message
to a magic file descriptor (4) containing:
* the registers and tid of the crashing thread
* the active URL
* a file descriptor to a socket
* a CREDENTIALS structure giving the PID of the renderer.
On the other end of the socket is an object on the IO thread
(render_crash_handler_host_linux.cc) which reads and parses the
datagram. The CREDENTIALS structure is validated by the kernel, so the
renderer can't lie about it's PID and try and get the browser to crash
dump the wrong process.
The browser then ptraces the renderer and extracts all the needed
information to write a minidump to a temp file. Then we write a byte
to the file descriptor which the renderer gave the browser in the
datagram and that's the signal to the renderer to finish dying. It
dies by sending itself the same signal which trigger the crash dump in
the first place, so it will appear to crash as normal as far as kernel
core dumps and waitpid are concerned.
The browser then constucts a MIME message in a temp file for upload to
the crash service. We then fork out to /usr/bin/wget to actually do
the upload (since Debian numbers suggest that 99.8% of users have wget
installed.) A second forked child unlinks the temp files once wget has
completed.
For a browser crash, everything works pretty much the same except that
the datagram step is omitted and we clone() off a process to ptrace
ourselves and write the minidump.
This code is only enabled in Chrome branded builds. Stub source files
are substituted in the case of a Chromium build.
http://codereview.chromium.org/115526
BUG=9646,10772
TEST=Build a Chrome branded binary. Send SEGV to a renderer and verify that wget output appears on stderr. Send a SEGV to the main binary and verify the same.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113710
Patch from John Maguire <johnmaguire@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Explicitly disable it (/INCREMENTAL:NO) for Release, and for the
following targets that require it:
chrome.dll
interactive_ui_tests.exe
perf_tests.exe
unit_tests.exe
Explicitly specificy /SUBSYSTEM:CONSOLE as default for linking,
and match current practice by overriding with /SUBSYSTEM:WINDOWS for:
chrome.exe
chrome.dll
media_player.exe
sandbox_poc.exe
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/115664
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115591
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16542 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16516 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
build.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16515 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Added a default in common.gypi to remove headers from all mac applications that are bundles.
Added a var to control the inclusion of keystone to chrome.gyp defaulted on branding and then honor it for the shipping work.
Review URL: http://codereview.chromium.org/113652
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=9007
Review URL: http://codereview.chromium.org/113487
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16506 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/11387
Review URL: http://codereview.chromium.org/113618
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Update the scripts to fetch values from the BRANDING files instead of hardcoding the values.
Review URL: http://codereview.chromium.org/113555
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
users opt in at that level, we just want to send the crashes.
Review URL: http://codereview.chromium.org/113553
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=11826
Review URL: http://codereview.chromium.org/115474
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16313 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
http://crbug.com/11387
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Otherwise you're assuming you have cygwin in order to set it up.
Review URL: http://codereview.chromium.org/113505
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
gyp change.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113431
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113321
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The alternative is that gyp silently succeeds and your build mysteriously
doesn't link, even after you've installed the dependencies, and you need
to know to rerun "gclient runhooks --force".
BUG=11432
Review URL: http://codereview.chromium.org/114007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(out of build/temp_gyp)
Review URL: http://codereview.chromium.org/113352
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
writable repository)
Review URL: http://codereview.chromium.org/113346
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
- Add script for running dump_syms on release builds if breakpad is enabled.
- Update the info.plist tweaks to add the breakpad keys if needed
- Add a var to check for breakpad support within the chrome.gyp instead of having the knowledge about breakpad being in official builds spread all around.
Review URL: http://codereview.chromium.org/113305
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115275
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
do anything else, but it will eventually.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113304
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Dropping setting that conflicts with this in common.gpyi
Review URL: http://codereview.chromium.org/112019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=maruel
BUG=2528
TEST=Building with VS2008 should succeed.
Review URL: http://codereview.chromium.org/113270
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=11762
Review URL: http://codereview.chromium.org/113268
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
branding).
- Stop using CPP on the info.plist since we have to run a script anyways.
- Set the bundleid into a build setting for simple info.plist processing to pick up.
- Add a script for the chrome/app target to manually tweak the info.plist:
- collect the version number from the build tree
- collect the svn revision from the build tree
- update the info.plist keys that need the version number based on collected data.
- record the svn revision into the info.plist for trouble shooting.
Review URL: http://codereview.chromium.org/115187
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
dependency of targets that need it (that is, any target with
'rules' or 'actions').
Review URL: http://codereview.chromium.org/115154
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115182
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
from src\third_party\courgette
to src\courgette and src\courgette\third_party
Fixed #includes
Added properties to ignore generated files:
C:\c5\src>svn pg svn:ignore courgette
courgette.xcodeproj
courgette.sln
courgette_fuzz.vcproj
courgette_lib.vcproj
courgette_minimal_tool.vcproj
courgette_tool.vcproj
courgette.vcproj
courgette_unittests.vcproj
SConstruct
courgette_fuzz.scons
courgette_lib.scons
courgette_main.scons
courgette_minimal_tool.scons
courgette.scons
courgette_tool.scons
courgette_unittests.scons
Review URL: http://codereview.chromium.org/115062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115142
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Add a target to build a dmg out of the app.
Add a target to all that will build everything and the dmg (since we don't include the dmg in all since developers really don't need to wait for that).
Review URL: http://codereview.chromium.org/113152
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
the {test_shell,webkit}.gyp:* targets from the 'all_gyps' section,
not the specific 'test_shell' and 'test_shell_tests' targets
from the mac condition.
Review URL: http://codereview.chromium.org/113144
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* build\all.gyp now uses webkit\webkit.gyp and
webkit\tools\test_shell\test_shell.gyp.
* 'svn remove' checked-in .sln and .vcproj files that will now
become gyp-generated files. (We'll leave the other old ones
in place, uncalled, and remove them with a later CL.)
* Add generated *.sln and *.vcproj files to svn:ignore on
the relevant directories.
* Update various chrome\**.vcproj files with the new gyp directory
in which various generated webkit files will now appear.
* Update the checked-in chrome\chrome.sln with all (?) the changes
necessary to reflect the new gyp generation.
Review URL: http://codereview.chromium.org/115115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15618 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
rough, but makes things work a bit more.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113123
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Split gtest into two libraries, where the latter provides main().
This is consistent with the way gtest works within Google and with its
automake files.
Fix binaries that require gtest's main() to depend on gtest.gyp:main.
Review URL: http://codereview.chromium.org/99132
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15377 0039d316-1c4b-4281-b951-d872f2087c98
|