| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In order to avoid duplicating most of the run-tests-on-devices logic, make
sure that the Android scripts are able to be usable from a WebKit checkout.
Two flags have been added for this: --webkit, which is necessary as a file's
path on the host and device are not per se equal anymore, and --out-directory,
accepting a path as it's not always in the Chromium source directory.
BUG=
Review URL: https://chromiumcodereview.appspot.com/11312239
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167999 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/11366175
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
provide defines.
This change decouples the logic that associates the app launcher and
settings app with windows-only builds, and consolidates the list of
app_list sources in chrome_browser_ui.gypi.
BUG=160839
TEST=on Windows: compiles with -Denable_app_list=0 (with no app launcher function), and
on Windows: compiles with -Denable_settings_app=0 (with app launcher but no settings app in it)
on ChromeOS: compiles (functional ChromeOS launcher)
Review URL: https://chromiumcodereview.appspot.com/11293267
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=maruel@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/11369238
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=nsylvain@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/11362244
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167818 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This avoids a stack trace for developers who have dos line endings in their
chromium.gyp_env files.
BUG=
Review URL: https://chromiumcodereview.appspot.com/11293286
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This new option will install the arm cross toolchain (which
is only currently available on Ubuntu precise).
BUG=
Review URL: https://chromiumcodereview.appspot.com/11360255
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167803 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL also includes the python script required to convert the JSON file to a .cc/.h pair. The generated .cc/.h are not generated by the build process and must be committed to the repository.
BUG=159990
Review URL: https://chromiumcodereview.appspot.com/11377049
TBR=beaudoin@chromium.org
Compiler errors:
http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20ChromiumOS%20Builder&number=28409
http://build.chromium.org/p/chromium.win/buildstatus?builder=Win%20Builder%20%28dbg%29&number=4778
Review URL: https://codereview.chromium.org/11293291
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This CL also includes the python script required to convert the JSON file to a .cc/.h pair. The generated .cc/.h are not generated by the build process and must be committed to the repository.
BUG=159990
Review URL: https://chromiumcodereview.appspot.com/11377049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=160253
Review URL: https://chromiumcodereview.appspot.com/11293284
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167785 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add the -Wobjc-missing-property-synthesis compiler flag for iOS and Mac builds. Because Clang now automatically
synthesizes properties if it's not done explicitly, forgetting to add a @synthesize
directive may result in difficult-to-uncover bugs, as Clang silently synthesizes instance
variables and binds them to the wrong property (see, for example, https://chromereviews.googleplex.com/5618018/).
Review URL: https://chromiumcodereview.appspot.com/11361240
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167783 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The cacheinvalidation_java target is also added to build/all_android.gyp to
ensure it is always built since nothing currently depends on it upstream.
When all of Android-specific sync code is upstreamed, a target for sync
should be used instead of cacheinvalidation.
BUG=158382
Review URL: https://chromiumcodereview.appspot.com/11146005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Move chrome/browser/component/web_contents_delegate_android to
content/components/web_contents_delegate_android.
2. Rename package org.chromium.chrome.browser.component.
web_contents_delegate_android to org.chromium.content.components.
web_contents_delegate_android.
3. Remove shouldOverrideUrlLoading from WebContentsDelegateAndroid
interface, which is no longer required.
I will follow up with a second change to completely remove
chrome/browser/component/web_contents_delegate_android once
external dependencies on it have been removed.
BUG=157575
Review URL: https://chromiumcodereview.appspot.com/11365199
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167670 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is possible since r167167 landed.
BUG=146979
Review URL: https://chromiumcodereview.appspot.com/11363194
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds the ability for devs/troopers/etc. to set 'landmines' in the tree so that
the build will selectively clobber when a builder moves over a revision with such
a change.
This cl has an basis landmines.py, and hooks the clobber mechanism to the android
build scripts.
The relevant cl which implements this for
compile.py is here: https://chromiumcodereview.appspot.com/11234013/
I'm planning to also implement an informational invocation for gclient to let devs know
about any potential landmines so they can decide if they need to clobber.
This previously attempted to land as: https://chromiumcodereview.appspot.com/11175016
R=ilevy@chromium.org,maruel@chromium.org
BUG=121897
Review URL: https://chromiumcodereview.appspot.com/11377141
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Since we only need the lite version of protobuf, we generate a jar file based
on includes in the maven pom.xml file for the lite profile.
BUG=158382
Review URL: https://chromiumcodereview.appspot.com/11347026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The sync implementation is not yet complete (e.g., there is not yet an
invalidator_factory implementation on iOS), but enough of the structure is in
place to allow for the sync target to build and a reduced set of unittests to
run successfully.
Review URL: https://chromiumcodereview.appspot.com/11360194
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
LIcense check is failing too frequenly, we should put it on the main builder/CQ.
Making the step failure a warning for now (it should not block tests).
BUG=160741
Review URL: https://codereview.chromium.org/11358219
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167469 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is only used for testing on Android.
BUG=
Review URL: https://codereview.chromium.org/11359166
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These units are recorded in the graphs.dat file, and can then be used to determine whether the test has improved or regressed when the graph goes up.
Review URL: https://chromiumcodereview.appspot.com/11234012
TBR=sullivan@chromium.org
Review URL: https://codereview.chromium.org/11365067
TBR=sullivan@chromium.org
Review URL: https://codereview.chromium.org/11361218
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This changes forwarder2 to support both test-server spawner and HTTP server
forwarding.
The main issue was that the device_forwarder was killed when instantiating a
second Forwarder (Python object).
Test server based unit tests require two device-to-host redirections, one for
the test server spawner and one for the HTTP server.
The port used by the HTTP server is allocated dynamically which means that we
can't know the full forwarding configuration before we spawn a HTTP server
(through the test server spawner).
This CL changes the forwarder to let it forward new ports while it is running
by making host_forwarder a daemon. This is similar to how ADB works.
This also means that a single host_forwarder process (daemon) can now handle
multiple devices.
BUG=146979
Review URL: https://chromiumcodereview.appspot.com/11269036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167167 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Compiled the target.
Review URL: https://chromiumcodereview.appspot.com/11236066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Differences:
- Constructor doesn't require View.
- The listener callback is called at most MAX_VSYNC_COUNT times.
- VSYNC_TIMEOUT is not used and Terminator is not created.
- Minimal timer-based ICS support is added, but see http://crbug.com/156397.
BUG=160017
Review URL: https://chromiumcodereview.appspot.com/11362177
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows copying files with spaces in the paths (most notably,
profiles, which have a number of files containing spaces).
There are two fixes:
- Input/output lists \-escape spaces so that gyp will convert the output back into a list correctly.
- The argument list is no longer parsed by spaces, and the gyp call instead passes the input list as a list of separate arguments instead of one giant string.
BUG=None
Review URL: https://chromiumcodereview.appspot.com/11293198
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, switch chromedriver2 to a loadable_module, since we never intend to
link against it, just dlopen it.
NOTRY=true
BUG=none
Review URL: https://chromiumcodereview.appspot.com/11366163
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Remove -w for TSan builds.
BUG=128314
TBR=thakis
Review URL: https://codereview.chromium.org/11363164
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166895 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Move C++ source from chrome/browser/component/navigation_interception
to content/components/navigation_interception.
2. Change the namespace from navigation_interception:: to content::
3. Change Java package from org.chromium.chrome.browser.components.
navigation_interception to org.chromium.content.components.
navigation_interception.
I will follow up with another patch to completely remove
chrome/browser/component/navigation_interception once external
dependencies have been updated to use the component at its new
component
BUG=157575
Review URL: https://chromiumcodereview.appspot.com/11293017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=159752
Review URL: https://codereview.chromium.org/11368155
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The offending code was fixed in WebKit r133796.
BUG=159452
Review URL: https://chromiumcodereview.appspot.com/11368144
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also cleaning up steps a bit.
R=yfriedman@chromium.org
NOTRY=True
Review URL: https://chromiumcodereview.appspot.com/11361179
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166791 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- this will stick these tests on CQ. But I will try to rewrite
them as a presubmit test next week.
NOTRY=True
Review URL: https://chromiumcodereview.appspot.com/11364155
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A superset of this change was needed to fix a bug downstream. Note that the bug
doesn't exist upstream since it was caused by a piece of code not upstreamed.
Therefore the only purpose of this change is to decrease the upstream vs
downstream diff.
Review URL: https://chromiumcodereview.appspot.com/11365147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Findbugs was emitting:
M P SIC: Should org.chromium.content.browser.ContentVideoView$FullScreenMediaController be a _static_ inner class? At ContentVideoView.java
NOTRY=true
TEST=findbugs_diff.py
Review URL: https://chromiumcodereview.appspot.com/11293170
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TestWebServer moved from Android WebView to net.test in
https://chromiumcodereview.appspot.com/11366108 , but the
findbugs file was not correctly updated.
Review URL: https://codereview.chromium.org/11365148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=159935
Review URL: https://chromiumcodereview.appspot.com/11365140
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes the android FYI test runners run android_webview
native unittests.
BUG=None
Review URL: https://chromiumcodereview.appspot.com/11366133
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/11364130
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also remove the tests_to_run output from summay if we do not have the list of tests.
BUG=
Review URL: https://chromiumcodereview.appspot.com/11365134
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to catch memory problems early, easily, and cleanly.
Because of gyp limitations, this can't be now controlled
by a flag.
BUG=30715
TEST=none
Review URL: https://codereview.chromium.org/11266019
TBR=phajdan.jr@chromium.org
Review URL: https://codereview.chromium.org/11366141
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=159240
Review URL: https://codereview.chromium.org/11361075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=118986, 91970
Review URL: https://codereview.chromium.org/11364077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to catch memory problems early, easily, and cleanly.
Because of gyp limitations, this can't be now controlled
by a flag.
BUG=30715
TEST=none
Review URL: https://codereview.chromium.org/11266019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=scroggo@chromium.org
Review URL: https://codereview.chromium.org/11360134
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166537 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The WebKit tester builds in release mode, which we need to tell the run_tests.py
script about. Otherwise it'll assume a debug build, causing it to be unable to
find the webkit_unit_tests and TestWebKitAPI APKs.
BUG=136774
Review URL: https://chromiumcodereview.appspot.com/11368122
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166519 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move Android WebView Test WebServer to net so that other test code can
make use of it.
BUG=159601
Review URL: https://chromiumcodereview.appspot.com/11366108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166493 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/11360130
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
parameters.
Rather than explicitly listing all the parameters
(see crbug.com/158722), infer almost all of them from the import section and inner classes.
Assumes other classes are in the same package as a fallback.
BUG=159397
TEST=base/android/jni_generator/jni_generator_tests.py
Review URL: https://chromiumcodereview.appspot.com/11363079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This brings us up to the same version as the rest of Chromium.
Disable -Wasm-operand-widths until crbug.com/159452 is fixed.
BUG=159712, 156947, 159452
Review URL: https://chromiumcodereview.appspot.com/11371004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/11364128
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The stack annotation tool has been changed to work with Chrome output
directory structure and so we no longer need to create the artificial
structure in out/android.
BUG=
Review URL: https://chromiumcodereview.appspot.com/11368102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166423 0039d316-1c4b-4281-b951-d872f2087c98
|