| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Requires compiling with linux_use_tcmalloc=1.
When enabled by --heap-profiler flag in test_shell exposes
chromium.HeapProfiler object to JavaScript. The object has three
methods:
o start() -- starts profiling
o dump() -- dumps data accumulated since start() to file
named like chromium-YYYY-MM-DD-TS.heap
o stop() -- stops profiling.
Output can be analyzed by third_party/tcmalloc/tcmalloc/src/pprof.
For example:
$ third_party/tcmalloc/tcmalloc/src/pprof \
sconsbuild/Release/test_shell \
chromium-2009-11-06-1234567890.heap
See http://code.google.com/p/google-perftools/ for details on how to
use pprof.
Patch contributed by vitalyr@chromium.org. Original review at
http://codereview.chromium.org/377010/show.
TBR=vitalyr
Review URL: http://codereview.chromium.org/390015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31688 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
target_defaults. This is equivalent to how Xcode sets SDKROOT from the
Project Info window's General tab. Making this setting project-wide means
that the selected SDK will show up properly in that UI.
BUG=26976
TEST=Build still works.
SDK (typically "Mac OS X 10.5") shows up in Project Info:General.
Review URL: http://codereview.chromium.org/371035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31307 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The motivation is that this removes the sync IPC on every call to the spellchecker. Also, currently we spellcheck in the IO thread, which frequently needs to go to disk (in particular, the entire spellcheck dictionary starts paged out), so this will block just the single renderer when that happens, rather than the whole IO thread.
This breaks the SpellChecker class into two new classes.
1) On the browser side, we have SpellCheckHost. This class handles browser-wide tasks, such as keeping the custom words list in sync with the on-disk custom words dictionary, downloading missing dictionaries, etc. On Posix, it also opens the bdic file since the renderer isn't allowed to open files. SpellCheckHost is created and destroyed on the UI thread. It is initialized on the file thread.
2) On the renderer side, SpellChecker2. This class will one day be renamed SpellChecker. It handles actual checking of the words, memory maps the dictionary file, loads hunspell, etc. There is one SpellChecker2 per RenderThread (hence one per render process).
My intention is for this patch to move Linux to this new approach, and follow up with ports for Windows (which will involve passing a dictionary file name rather than a file descriptor through to the renderer) and Mac (which will involve adding sync ViewHost IPC callsfor when the platform spellchecker is enabled). Note that anyone using the platform spellchecker rather than Hunspell will get no benefit out of this refactor.
There should be no loss of functionality for Linux (or any other platform) in this patch. The following should all still work:
- dictionary is loaded lazily
- hunspell is initialized lazily, per renderer
- language changes work.
- Dynamic downloading of new dictionaries
- auto spell correct works (as well as toggling it).
- disabling spellcheck works.
- custom words work (including adding in one renderer and immediately having it take effect in other renderers, for certain values of "immediate")
TODO:
- move spellchecker unit tests to test SpellCheck2
- add sync IPC for platform spellchecker; port to Mac
- add dictionary location fallback; port to Windows
- remove SpellChecker classes from browser/
BUG=25677
Review URL: http://codereview.chromium.org/357003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=26509
TEST=none
Review URL: http://codereview.chromium.org/340072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Skia correctly depends on Harfbuzz so we don't need to depend on it
from the top-level gyp file.
TEST=compiles
Review URL: http://codereview.chromium.org/355031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/346027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
The regex didn't work for GCC = 4.4.
Review URL: http://codereview.chromium.org/341085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30847 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This runs g++ -dumpversion (or $CXX) to establish the compiler version
and set the gyp gcc_version variable automatically.
BUG=25209
Review URL: http://codereview.chromium.org/339046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=22307,26548
TEST=start with clean machine that has no bzip2 and build chrome without it.
Review URL: http://codereview.chromium.org/348052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
whether enable_pepper variable is set to 1. Defaults to 0.
Added run_as block to automatically launch chrome and load the plugin when the pepper_test_plugin project is run or debugged.
See new instructions in updated README.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/343070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/339079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
These do not build, but are for experimentation.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/344041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=sgk
Review URL: http://codereview.chromium.org/351003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=22307
TEST=none
Review URL: http://codereview.chromium.org/340051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=22307
TEST=builds correctly, and an html5 video runs.
Review URL: http://codereview.chromium.org/300013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/342041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30515 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
between the specified good and bad builds.
Also, add usage string for specifying chromium options
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/343029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
- only include cflags/linkflags and other compiler settings that are target-specific when building for 'target'
- make build tools (protoc) compile for 'host', and change the dependencies on them to reflect that.
Review URL: http://codereview.chromium.org/265031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/342021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We use this on OS X, so it shouldn't be harmful and it will fix a visibility
issue that came up in
http://groups.google.com/group/chromium-dev/browse_thread/thread/800bda968bdc8f29
BUG=17943
Review URL: http://codereview.chromium.org/332035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
chrome/tools/build/mac.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/334049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
release_optimize vars.
This will allow lower-level targets to change their desired optimization level. In particular, the ffmpeg build requires this because it has problems compiling with -O0.
BUG=22307
TEST=none
Review URL: http://codereview.chromium.org/334018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Add extra unit test bundles (all platforms).
Review URL: http://codereview.chromium.org/307032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(alongside the existing cases for Windows with 16-bit wchars and Linux with
32-bit wchars) so that it becomes possible to compile and link the Chromium
base together with third-party libraries that require short wchars.
BUG=none
TEST=none
Original review http://codereview.chromium.org/315004
Patch by mdsteele@google.com
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29786 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/306049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29771 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/307031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
unnecessary UTF-8 conversion when converting C strings to WebKit
Strings. Re-enabled WebGL in Dev Channel builds.
BUG=http://crbug.com/21852
TEST=none (runs existing WebGL tests; more coming)
Review URL: http://codereview.chromium.org/308006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=12497
TEST=none
Review URL: http://codereview.chromium.org/251087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29610 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
executable slide.
BUG=25372
TEST=green tree
Review URL: http://codereview.chromium.org/311001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
failures and bug 25372.
BUG=25372
TEST=green tree
Review URL: http://codereview.chromium.org/306021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29601 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=16713
TEST=none
Review URL: http://codereview.chromium.org/308010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We used to have this in debug.xcconfig, but it seems to have gotten lost when
we migrated to GYP.
BUG=16713 (not really, that's for release builds, but close enough)
TEST=none
Review URL: http://codereview.chromium.org/292036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29591 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24766
Review URL: http://codereview.chromium.org/271113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Turn on ENABLE_SHARED_WORKERS by default, but disable the SharedWorker bindings
so they are not available. This allows the SharedWorker code to get compiled in
to fight against bit rot, but prevents applications from using this API yet.
TEST=existing layout tests suffice
Review URL: http://codereview.chromium.org/273019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29185 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
com.google.Chrome.framework
BUG=24836
TEST=After running Google Chrome.app, run
~/Library/Google/GoogleSoftwareUpdate/GoogleSoftwareUpdate.bundle/Contents/MacOS/ksadmin -p.
You should see, at the very least, tickets for com.google.Keystone and
com.google.Chrome, and they should appear to have valid data. You should
not see any tickets for com.google.Chrome.framework. If you run ksadmin
-l, you should not get any error output.
Review URL: http://codereview.chromium.org/273059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
build only the subset of projects required by Chrome Frame.
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/264016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
widget_gtk when building chromeos build. We need a #ifdef for
CHROMEOS but not using TOOLKIT_VIEWs for the browser window. I'm
temporarily adding this one.
This bug is the result of Oshima making TOOLKIT_VIEWS set OS_CHROMEOS.
Review URL: http://codereview.chromium.org/270092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* changed gyp files so that all files compiled for chrome os will be also compiled when toolkit_views==1
* changed to define OS_CHROMEOS when toolkit_views==1
* changed TabOverbiewMessageListener to use BrowserView instead of BrowserWindowGtk when toolkit_views==1
I left one for CHROME_NOTIFY_FLOATING_TAB_OVER_TOPLEVEL b/c i couldn't figure out how to get gdkwindow
from xid. Looks like I need to register it somewhere
Note: Nicolas updated trybot and buildbot to include chromeos dependency, so this all should compile fine.
BUG=none
TEST=run views unit test and browser.
Review URL: http://codereview.chromium.org/262027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/274004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
breaking the interactive ui tests. It just needs a clobber.
It looks like 2 parts of the code don't agree on the number of
buttons on the bookmark bar. Maybe because part of the code is
compiled with CHROME_PERSONALIZATION = 1 while the test is compiled
with CHROME_PERSONALIZATION = 0. Maybe this new gyp change broke the
define propagation. This is really easy to replicate, and should also
be easy to debug.
Original Log:
Relanding the interactive UI tests GYP factor out, as it turns
out it is not responsible for breaking the interactive ui tests.
Review URL: http://codereview.chromium.org/271046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
out it is not responsible for breaking the interactive ui tests.
See http://codereview.chromium.org/259018/show
TBR=brettw
Review URL: http://codereview.chromium.org/270042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=brettw
Review URL: http://codereview.chromium.org/268024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Args to Chromium can be passed like:
python build-bisect.py -- --no-first-dialog
such that everything after '--' will be ignored by this script
Review URL: http://codereview.chromium.org/265026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=The interactive tests should still build and run on Windows and Linux
Review URL: http://codereview.chromium.org/259018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to pick up the flag.
TBR=kbr
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
WebKit.
TBR=kbr
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=rebuild gyp files, open chrome.sln. Observer chrome_frame project.
Review URL: http://codereview.chromium.org/271014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
requires command line option --enable-webgl (and, currently,
--no-sandbox) to enable.
BUG=http://crbug.com/21852
TEST=none (runs existing WebGL tests; more coming)
Review URL: http://codereview.chromium.org/270003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/256074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=successful builds
Review URL: http://codereview.chromium.org/256059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28089 0039d316-1c4b-4281-b951-d872f2087c98
|