summaryrefslogtreecommitdiffstats
path: root/build
Commit message (Collapse)AuthorAgeFilesLines
* src/platform-linux.cc in v8_base now seems to need '-lrt' forsgk@google.com2009-03-251-1/+13
| | | | | | | | | clock_gettime(). Add it to link_settings, and add the right export_dependent_settings to propagate it through the hierarchy appropriately. Review URL: http://codereview.chromium.org/53057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12468 0039d316-1c4b-4281-b951-d872f2087c98
* Add a gtk_clipboard_dump target with a new .gyp file.sgk@google.com2009-03-251-0/+5
| | | | | | Review URL: http://codereview.chromium.org/42593 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12454 0039d316-1c4b-4281-b951-d872f2087c98
* Update gyp files one more time. Formatting changes and added theager@chromium.org2009-03-251-4/+32
| | | | | | | platform-posix file in one more place. Review URL: http://codereview.chromium.org/42595 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12441 0039d316-1c4b-4281-b951-d872f2087c98
* Fix syntax error in v8.gyp.ager@chromium.org2009-03-251-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12440 0039d316-1c4b-4281-b951-d872f2087c98
* Let's try this again. This time actually include the new platformager@chromium.org2009-03-251-2/+4
| | | | | | | | | file and add a couple of new -inl.h files to the project. TBR=sgjesse@chromium.org Review URL: http://codereview.chromium.org/53044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12439 0039d316-1c4b-4281-b951-d872f2087c98
* Add new platform file to V8 gyp file.ager@chromium.org2009-03-251-0/+1
| | | | | | | TBR=sgjesse@chromium.org Review URL: http://codereview.chromium.org/53043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12438 0039d316-1c4b-4281-b951-d872f2087c98
* Propagate CC, CXX variables to Webcore and v8.thestig@chromium.org2009-03-251-0/+1
| | | | | | | I realize this will all go away Any Day Now. Until then, we can speed things up a bit more. Review URL: http://codereview.chromium.org/53029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12425 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Linux: back off build to only require P3"agl@chromium.org2009-03-241-2/+2
| | | | | | | This reverts commit r12389. Maybe a GCC bug in it's SSE implementation. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12402 0039d316-1c4b-4281-b951-d872f2087c98
* loadable_modules are just like shared libs for code generation.thomasvl@chromium.org2009-03-241-1/+1
| | | | | | Review URL: http://codereview.chromium.org/45038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12392 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: back off build to only require P3agl@chromium.org2009-03-241-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | The current linux version of chromium will instantly crash with SIGILL on an Athlon/AthlonXP/AthlonMP class processor. It will presumably do the same thing on the pentium3. This is because it's built to use SSE2 instructions to implement floating point. We cannot build for i686 normally because we can't have the floating point results be different between debug/opt builds. Without forcing it to use SSE that happens (and it has a lot of noticeable effects on our tests). For builds which users actually use, I expect the distros will back off the compiler flags because people won't be using those builds for development. However, I'm landing this patch because there's little point in causing problems for SSE1 only chips because it will only make 3rd party contributions harder. Thanks. The only downside is minutely slower double precision floating point. (Patch from Elladan) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12389 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a typo in the shared library link line arguments.sgk@google.com2009-03-241-1/+1
| | | | | | Review URL: http://codereview.chromium.org/51006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12337 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disable the v8 *_arm targets on Linux so we can rollsgk@google.com2009-03-241-0/+7
| | | | | | | | | this out while working on the right model to handle building both variants. Includes gyp DEPS roll to get fixes for latest Linux backend. Review URL: http://codereview.chromium.org/52022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12336 0039d316-1c4b-4281-b951-d872f2087c98
* Switching sandbox to gyp on windows.bradnelson@google.com2009-03-231-0/+5
| | | | | | | | | Rolling forward deps on gyp to get 'copies' support. This time handled wow_helper. Review URL: http://codereview.chromium.org/42355 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12270 0039d316-1c4b-4281-b951-d872f2087c98
* Fix pkg_config_wrapper.py paths now that the updated gyp executessgk@google.com2009-03-211-6/+6
| | | | | | | the variable expansion from the same directory as the .gyp file Review URL: http://codereview.chromium.org/50085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12245 0039d316-1c4b-4281-b951-d872f2087c98
* Update the gyp Linux build:sgk@google.com2009-03-203-0/+150
| | | | | | | | | | | | | | | | | | | | | | | | * Add Linux settings to target_defaults in common.gypi so gyp-generated SConscript files no longer depend on build/SConscript.main or the Hammer infrastructure. * Copy the FilterOut() function from Hammer to the chromium_builders.py Tool module. * Add a ChromiumLoadableModule() builder to chromium_builders.py. * Add dependencies on the 'views' library to the chrome link (target 'app'). * Add missing views/*/*_unittest.cc modules to the 'unit_tests' target. Exclude all but the one that builds on Linux from the non-Windows builds. * Crib a list of chrome/views files to exclude from the Linux build from the old SCons configuration. * Add a new build/linux/system.gyp file with new 'settings' targets to encapsulate the pkg-config checks for gtk+-2.0, nss and pangoft2. * Add depenedencies in the other targets on the new gtk, nss and pangoft2 'settings' targets from build/linux/system.gyp. * Add a pkg_config_wrapper.py script that keeps gyp happy by simply exiting 0 if the package isn't found. * DEPS roll for latest gyp changes to support the above. Review URL: http://codereview.chromium.org/42340 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12228 0039d316-1c4b-4281-b951-d872f2087c98
* Make the ObjC linker flag more generic so it only cares if we're building athomasvl@chromium.org2009-03-201-1/+1
| | | | | | | bundle (catches frameworks and app and anything else added in the future). Review URL: http://codereview.chromium.org/50053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12196 0039d316-1c4b-4281-b951-d872f2087c98
* Chromium side of http://codereview.chromium.org/42394thomasvl@chromium.org2009-03-191-2/+3
| | | | | | | | | | | | | | | | - Remove the use of the mac specific type 'application' and use 'executable' with 'mac_bundle' set to 1. - update common.gypi to default mac_bundle to zero. - update common.gypi to look at mac_bundle for some of the base behaviors that were on 'application'. - Roll DEPS to get the new version of gyp w/ the matching support. Review URL: http://codereview.chromium.org/50015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12136 0039d316-1c4b-4281-b951-d872f2087c98
* Uses FFmpeg in chrome/rendererhclam@chromium.org2009-03-191-1/+1
| | | | | | | | | | | - Have chrome/renderer to use FFmpeg - Added using_media.vsprops to all affected projects that depends on chrome/renderer. - Added lib path "$(OutDir)\lib" to essential.vsprops Review URL: http://codereview.chromium.org/48118 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12071 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 to version 1.1.1.2.ager@chromium.org2009-03-181-0/+18
| | | | | | | This contains the new compiler infrastructure which gives a nice performance improvement on the V8 benchmark suite. Review URL: http://codereview.chromium.org/48143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11994 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 11946 since it is causing a build breakage on full rebuild. The maruel@chromium.org2009-03-181-5/+0
| | | | | | | | | | sandbox project wasn't copying wow_helper.exe anymore, causing a build breakage on x64 platforms only. TBR=bnelson Review URL: http://codereview.chromium.org/42328 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11955 0039d316-1c4b-4281-b951-d872f2087c98
* Moving sbox to gyp on windows.bradnelson@google.com2009-03-181-0/+5
| | | | | | | | | (Also fixing missing property on sdch.) Review URL: http://codereview.chromium.org/42317 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11946 0039d316-1c4b-4281-b951-d872f2087c98
* Switching net over to use gyp on windows.bradnelson@google.com2009-03-181-1/+1
| | | | | | Review URL: http://codereview.chromium.org/48108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11942 0039d316-1c4b-4281-b951-d872f2087c98
* Pull out V8 update.ager@chromium.org2009-03-161-18/+0
| | | | | | Review URL: http://codereview.chromium.org/44006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11804 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Use -mfpmath=sse to remove differences between opt and debugagl@chromium.org2009-03-161-1/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (note: this change now requires a P4 to build. It's easy to back it out for older processors, but they shouldn't be used to run layout-tests.) We are seeing issues where the opt build ends up with very slightly different colours in layout tests than the debug build. This is probably due to floating point rounding differences. All floating-point computations on x87 happens in 80-bit precision. Because the C and C++ language standards allow the compiler to keep the floating-point values in higher precision than what's specified in the source and doing so is more efficient than constantly rounding up to 64-bit or 32-bit precision as specified in the source, the compiler, especially in the optimized mode, tries very hard to keep values in x87 floating-point stack (in 80-bit precision) as long as possible. This has important side effects, that the real value used in computation may change depending on how the compiler did the optimization - that is, the value kept in 80-bit is different than the value rounded down to 64-bit or 32-bit. There are possible compiler options to make this behavior consistent (e.g. -ffloat-store would keep all floating-values in the memory, thus force them to be rounded to its original precision) but they have significant runtime performance penalty. -mfpmath=sse -msse2 makes the compiler use SSE instructions which keep floating-point values in SSE registers in its native precision (32-bit for single precision, and 64-bit for double precision values). This means the floating-point value used during computation does not change depending on how the compiler optimized the code, since the value is always kept in its specified precision. Internal performace tests of these options shows that it's not a clear performance win or loss across the board. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11751 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 containing the new compiler infrastructure.ager@chromium.org2009-03-161-0/+18
| | | | | | | | | | We will pull this out again once the dev channel release has been cut. We need to get this in the dev channel release to have the new infrastructure tested in the real world. Review URL: http://codereview.chromium.org/42234 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11745 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting change 11688.bradnelson@google.com2009-03-141-1/+1
| | | | | | | | TBR. Review URL: http://codereview.chromium.org/46070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11692 0039d316-1c4b-4281-b951-d872f2087c98
* Switching net to gyp on windows.bradnelson@google.com2009-03-131-1/+1
| | | | | | Review URL: http://codereview.chromium.org/42184 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11688 0039d316-1c4b-4281-b951-d872f2087c98
* Have the gyp build use base SCons, not Hammer components, so it cansgk@google.com2009-03-131-19/+25
| | | | | | | | control the Alias namespace directly and set appropriate default targets. This currently switches within the various Chrome*() calls. Review URL: http://codereview.chromium.org/46037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11657 0039d316-1c4b-4281-b951-d872f2087c98
* Rollback v8 DEPS roll (for real)jar@chromium.org2009-03-131-18/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I snagged the wrong rev last time. Reverting back to 11622, which had the comment: --------------- r11622 | ager@chromium.org | 2009-03-12 23:53:03 -0700 (Thu, 12 Mar 2009) | 6 lines Update V8 to version 1.1.1. Contains a couple of layout tests rebaselines. This time contains an updated gyp file for the mac build. Review URL: http://codereview.chromium.org/43134 --------------- This also includes the other file change in 11624: --------------- r11624 | ager@chromium.org | 2009-03-13 02:17:01 -0700 (Fri, 13 Mar 2009) | 6 li nes Update V8 to fix an assertion that does not hold. Add test that tests arbitrary limits on expressions that can be handled without stack overflows to the test list. I have filed a bug report and Kevin is investigating. Review URL: http://codereview.chromium.org/46029 --------------- trb=darin,ager Review URL: http://codereview.chromium.org/46048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11654 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 to version 1.1.1.ager@chromium.org2009-03-131-0/+18
| | | | | | | | | Contains a couple of layout tests rebaselines. This time contains an updated gyp file for the mac build. Review URL: http://codereview.chromium.org/43134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11622 0039d316-1c4b-4281-b951-d872f2087c98
* Allow Mac precompiled headers to be disabled based on a GYP variable.mark@chromium.org2009-03-121-1/+23
| | | | | | Review URL: http://codereview.chromium.org/42133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11557 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of now unnecessary SCons-isms for gyp on Linuxsgk@google.com2009-03-121-8/+0
| | | | | | | | (in favor of letting the gyp generator pass us $DESTINATION_ROOT, which gives us the right absolute path name to the output directory). Review URL: http://codereview.chromium.org/43108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11549 0039d316-1c4b-4281-b951-d872f2087c98
* Switching to gyp generated vcprojs for some components.bradnelson@google.com2009-03-121-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Includes propset changes: Property changes on: C:\clients\chrome6\src\skia ___________________________________________________________________ Modified: svn:ignore - skia.xcodeproj + skia.xcodeproj skia.sln Property changes on: C:\clients\chrome6\src\third_party\zlib ___________________________________________________________________ Modified: svn:ignore - zlib.xcodeproj + zlib.xcodeproj zlib.sln Property changes on: C:\clients\chrome6\src\third_party\libpng ___________________________________________________________________ Modified: svn:ignore - libpng.xcodeproj + libpng.xcodeproj libpng.sln Property changes on: C:\clients\chrome6\src\third_party\libjpeg ___________________________________________________________________ Modified: svn:ignore - libjpeg.xcodeproj + libjpeg.xcodeproj libjpeg.sln Property changes on: C:\clients\chrome6\src\build ___________________________________________________________________ Modified: svn:ignore - all.xcodeproj + all.xcodeproj all.sln All.vcproj Property changes on: C:\clients\chrome6\src\base ___________________________________________________________________ Modified: svn:ignore - base.xcodeproj + base.xcodeproj base.vcproj base_gfx.vcproj base_unittests.vcproj debug_message.vcproj Property changes on: C:\clients\chrome6\src\testing ___________________________________________________________________ Modified: svn:ignore - gtest gtest.xcodeproj + gtest gtest.xcodeproj gtest.sln Review URL: http://codereview.chromium.org/43101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11512 0039d316-1c4b-4281-b951-d872f2087c98
* NO CODE CHANGEdeanm@chromium.org2009-03-111-1/+0
| | | | | | | | | Normalize end of file newlines in build/ media/ printing/ testing/ and tools/. All files end in a single newline. Review URL: http://codereview.chromium.org/43082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11449 0039d316-1c4b-4281-b951-d872f2087c98
* Reenable incremental linking for most projects except the largest ones. Will ↵maruel@chromium.org2009-03-111-1/+1
| | | | | | | | fix later. Review URL: http://codereview.chromium.org/42016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11440 0039d316-1c4b-4281-b951-d872f2087c98
* Adding fixed guids to some modules to facilitate incremental switch to gyp.bradnelson@google.com2009-03-102-0/+4
| | | | | | Review URL: http://codereview.chromium.org/42044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11388 0039d316-1c4b-4281-b951-d872f2087c98
* Making what gets generated platform conditional to allow gradual phase in on ↵bradnelson@google.com2009-03-101-22/+35
| | | | | | | | windows. Review URL: http://codereview.chromium.org/42003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11387 0039d316-1c4b-4281-b951-d872f2087c98
* Prompt the user before performing particularly expensive operations.markus@chromium.org2009-03-101-1/+62
| | | | | | | This should help users that have slow network connections. Review URL: http://codereview.chromium.org/43043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11378 0039d316-1c4b-4281-b951-d872f2087c98
* Re-implemented the install-build-deps.sh script file, so that on 64 bitmarkus@chromium.org2009-03-101-109/+178
| | | | | | | | | | | | | | | | systems we build and install proper Debian packages instead of directly installing files into the filesystem. This allows the user to cleanly uninstall the packages and it prevents corruption from us accidentally overwriting files that the system tries to manage itself. Also, the script now installs debugging symbols where available. This allows gdb to step into system libraries. The developer still needs to download the actual source code with "apt-get source" and point the debugger to it. Review URL: http://codereview.chromium.org/40288 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11336 0039d316-1c4b-4281-b951-d872f2087c98
* Build test_shell and test_shell_tests on Linux from gyp-generated scons files:sgk@google.com2009-03-061-1/+7
| | | | | | | | | | | | | | | | | | | | | | * Catch up to recent changes: * Rename RenderThemeChromiumGtk.cpp to RenderThemeChromiumLinux.cpp. * Fix spelling of V*NPObject.{cpp,h} * Explicitly include varions WebCore *Gtk.cpp and *Linux.cpp files that are excluded by the general regular expression. * Add webinput_event_util.cc. * Exclude glue/plugins/plugin_stubs.cc. * Add a Linux test_shell_resources target to build test_shell_resources.{h,pak}. * Add an explicit test_shell action to repack resources into test_shell.pak. * Use -Wno-multichar when building libtest_shell_common.a. * Use -DWTF_USE_PTHREADS when building libwtf.a, and when dependent targets compile against it. * Use tools/test_shell/test_shell_main{,_GYP}.scons as the main entry point for GYP-based builds of webkit. * Add base/gfx/gtk_util.cc to the base build. Review URL: http://codereview.chromium.org/39219 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11160 0039d316-1c4b-4281-b951-d872f2087c98
* Branding of Chrome.app.jrg@chromium.org2009-03-041-3/+8
| | | | | | | | | To brand, do a "src/tools/gyp/gyp_dogfood -Dbranding=Chrome src/build/all.gyp" (Then build, of course.) Review URL: http://codereview.chromium.org/40066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10920 0039d316-1c4b-4281-b951-d872f2087c98
* Move the main entry point *.scons files in the key remaining componentssgk@google.com2009-03-041-4/+4
| | | | | | | | | (net, webkit, chrome) to *_main.scons, so we can use GYP=1 on the command line to switch between old and new while tracking down the remaining inconsistencies. Review URL: http://codereview.chromium.org/39080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10882 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes to gyp files to get test_shell building on windows from a gyp project ↵bradnelson@google.com2009-03-031-2/+2
| | | | | | | | | | (doesn't run correctly yet). Switched all uses of windows system libraries that assumed they were in the include path to use -l (which will be supported on windows in a separate change). Review URL: http://codereview.chromium.org/27362 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10781 0039d316-1c4b-4281-b951-d872f2087c98
* Start stitching GYP-generated files into the Linux build:sgk@google.com2009-03-031-11/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add a GYP=1 command-line variable to use the gyp-generated files (which are generated side-by-side until everything's okay enough to cut over for real). * Rearrange existing *.scons files to match the layout of the gyp-generated ones, so the transition will be easier: * base.scons (the wrapping logic that calls the other *.scons files) => base_sln.scons * base_lib.scons (the library itself) => base.scons (matching the gyp target generation) * gfx/base_gfx.scons => base_gfx.scons (with necessary prepending of "gfx/" to path names) build/SConscript.main fixes: * Use an internal ${_GYP} infix variable to select the right flavor of *.scons file (multiple places) * When building with GYP=1, only load the one component *_sln_gyp.scons file, because gyp has already created it with knowledge of all the right dependent *_gyp.scons files to load. Linux gyp build fixes: * Add -32 to $ASFLAGS for generating a 32-bit libicudata.a from the now-checked in .s. * Add -Wno-unused and -Wno-unused-function to skia. Review URL: http://codereview.chromium.org/28207 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10759 0039d316-1c4b-4281-b951-d872f2087c98
* Add googleurl.gyp:googleurl_unittestsmark@chromium.org2009-03-021-6/+22
| | | | | | Review URL: http://codereview.chromium.org/28317 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10705 0039d316-1c4b-4281-b951-d872f2087c98
* GYP it, GYP it good.mark@chromium.org2009-03-026-4121/+1
| | | | | | | | Convert the Mac build to the new GYP-based Xcode build, and remove the old Xcode projects. Review URL: http://codereview.chromium.org/28305 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10693 0039d316-1c4b-4281-b951-d872f2087c98
* Link applications with -Wl,-ObjC to keep Objective-C implementations availablemark@chromium.org2009-02-282-146/+3
| | | | | | Review URL: http://codereview.chromium.org/28289 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10662 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure classes only referenced by .xib files end up in the executablemark@chromium.org2009-02-271-0/+146
| | | | | | Review URL: http://codereview.chromium.org/27277 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10619 0039d316-1c4b-4281-b951-d872f2087c98
* v8.gyp changes for Chromium r10594 v8 r1370 (1.0.2)mark@chromium.org2009-02-271-14/+0
| | | | | | Review URL: http://codereview.chromium.org/28262 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10613 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 to version 1.0.2.ager@chromium.org2009-02-272-138/+0
| | | | | | | | | This removes JSCRE from V8 and I have made the corresponding changes to the xcode project. Review URL: http://codereview.chromium.org/27199 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10594 0039d316-1c4b-4281-b951-d872f2087c98