| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I did some profiling and found that we spend a lot of
time in SCons/Subst.py resolving paths with $ vars in
them. By pre-resolving some common $ vars, we can get
a 16% speed up of an empty build (running hammer Hammer
when everything is already built). On my work desktop,
this is a saving from ~180s to do an empty build to
~150s to do an empty build.
I found which symbols to pre-resolve by gathering stats
on what symbols were resolved during a single run.
Originally, these were the top 10 calls to
StringSubber.substitute:
91466 /src/gclient-git/src/chrome
89457 $MAIN_DIR/Hammer
89457 $DESTINATION_ROOT
89447 $TARGET_ROOT/obj
65514 $OBJ_ROOT/webkit
18169 $OBJ_ROOT/third_party
8991 -I/src/gclient-git/src/webkit/pending
5700 $THIRD_PARTY_DIR/WebKit
4488 -I/src/gclient-git/src/webkit/port/platform/network
4488 -I/src/gclient-git/src/webkit/port/platform
Afterwards, the top 10 calls were:
65514 /src/gclient-git/src/chrome/Hammer/obj/webkit
23933 /src/gclient-git/src/chrome/Hammer/obj
18169 $OBJ_ROOT/third_party
8991 -I/src/gclient-git/src/webkit/pending
5700 $THIRD_PARTY_DIR/WebKit
4488 -I/src/gclient-git/src/webkit/port/platform/network
4488 -I/src/gclient-git/src/webkit/port/platform
3813 $OBJ_ROOT/skia
3498 $THIRD_PARTY_DIR/icu38
3456 $THIRD_PARTY_WEBKIT_DIR/JavaScriptCore
Adding these rules cuts the total number of calls to
StringSubber.substitute from 1001817 to 665933.
Review URL: http://codereview.chromium.org/8608
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
that get passed to the build environment. This allows
us to have our CCACHE_DIR off of NFS.
Review URL: http://codereview.chromium.org/8610
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
targets into the new *.scons file naming scheme.
Review URL: http://codereview.chromium.org/8616
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add 'midl' Tool module.
* Filter out the default OS_WINDOWS= definition from the Hammer
modules, which messes up our build.
* Fix the $PLATFORMSDK_VISTA definition.
* Remove the current directory from the 'base' Alias (avoid cycles).
* Remove by-hand addition of .lib, .pdb and .ilk files to the target
list when build shared libraries (multiple places).
* Comment out a post-action Touch() of the themes/default resource.
(Thanks to bradnelson for many of the above individual fixes.)
Review URL: http://codereview.chromium.org/8207
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
environment.
Things have been rigged temporarily so they emit to the same directories.
Review URL: http://codereview.chromium.org/8139
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7966
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
depend on the "all" target in webkit. (Re-sniff port?)
Review URL: http://codereview.chromium.org/7959
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7860
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3843 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
in all.xcodeproj.
Review URL: http://codereview.chromium.org/7901
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
PLATFORM(MAC).
Review URL: http://codereview.chromium.org/7893
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3786 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
webkit.xcodeproj:port out of the "all" Mac build temporarily to accommodate
PLATFORM(MAC) killing in progress.
Review URL: http://codereview.chromium.org/7870
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This will facilitate changing where the main sconstruct lives.
Review URL: http://codereview.chromium.org/7847
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Rename SConscript files to {module}.scons or {moduel}_lib.scons,
depending on the primary target involved.
* Separate targets into individual *.scons files, with one
construction environment (named "env") per *.scons file.
* Add using_{module}.scons files (like .vsprops) that will be used
by other modules to add CPPDEFINES, CPPPATH, LIBS and LIBPATH values.
* Update other modules' *.scons files to use the new using_{module}.scons
files (using a temporary one-liner idiom until we have the
ApplySConscript() method from the Hammer modules).
* Use the idiom of removing to-be-ported files from the master list,
so they can be simply deleted from the to-be-ported list as they
get ported in the future, instead of having to shuffle entries
between lists.
* Use $OBJ_ROOT instead of hard-coded '#/$BUILD_TYPE/' for the $*_DIR
variables.
* Add a addRepository() call mapping build/ to $TARGET_ROOT/googleurl,
so its $OBJ_ROOT value can look like the others'.
* Formatting changes, primarily modifying indentation to conform to
style guidelines.
* Fix copyright headers in some third_party/* modules
previously overlooked.
* Add rudimentary __doc__ strings, setting up for a future
ability to generate meaningful documentation.
Review URL: http://codereview.chromium.org/7807
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
HASH/$BUILD_TYPE -> $OBJ_ROOT
Review URL: http://codereview.chromium.org/7801
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7530
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3637 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Construct the $THIRD_PARTY_DIR and $WEBKIT_DIR variables consistently
with other $*_DIR variables.
Don't execute test scripts from the VariantDir by default; everything
isn't installed in the proper place yet.
Use the 'build_component' variable from the submodule SConstruct
files to restrict how much we build by default (e.g. don't try to
build all of webkit if you're only working in base or net).
Review URL: http://codereview.chromium.org/7524
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(V8Bindings, libport and WebCore being the most significant example.) Since the
GNU linker does only a single pass over the archives we need some extra
trickery to deal with these unavoidable cycles. That trickey is --start-group
and --end-group (aka -( and -) ). That causes ld to loop over the group until
no more undefined symbols are found. In an ideal world we would only make
groups from those libraries which we knew to be in cycles. However, that's
tough with SCons, so we bodge it by making all the archives a group by
redefining the linking command here.
Review URL: http://codereview.chromium.org/7523
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7656
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3597 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7507
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3582 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6569
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
diagnostic output to stderr)
Review URL: http://codereview.chromium.org/7149
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
nonfunctioning UI.
Review URL: http://codereview.chromium.org/2983
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3299 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
generated. They're currently ending up in src/build/googleurl
but they should be in $TARGET_ROOT/googleurl.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
adding that too.
Review URL: http://codereview.chromium.org/6361
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
asserts in the plugin stub code that throw off the layout tests.
Review URL: http://codereview.chromium.org/6588
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
base_unittest.
BUG=1319
Review URL: http://codereview.chromium.org/4261
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
* Have v8 build v8.lib with snapshot=off.
* Call the v8 build again to build copies of libraries-empty.obj
and snapshot.obj with which we build v8_snapshot.lib.
Review URL: http://codereview.chromium.org/6403
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2810 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
causing some startup performance regressions, and we don't really need it now anyway. We should have a different design when we implement this in the future.
BUG=3076
Review URL: http://codereview.chromium.org/6404
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
leftover file from previous incremental builds.
Review URL: http://codereview.chromium.org/6084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
up to webkit@36102.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
environment to generate bindings on all platforms.
Review URL: http://codereview.chromium.org/5619
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Use the configuration options of the webkit SCons build itself
to build a v8.lib with snapshot=off.
* Move the build of v8_snapshot.lib (renamed from snapshotv8.lib)
from chrome\SConscript to build\SConscript.v8.
* Use the libraries{,-empty}.obj and snapshot{,-empty}.obj
files from the v8 build itself instead of rolling our own.
* Re-order thing in build/SConscript.v8 for readability (I hope).
Review URL: http://codereview.chromium.org/5615
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
captured values for generating a config.h file.
Builds base/sdch_{filter,manager}.cc on all platforms and links
the 'sdch' library.
Add sdch to the SCons configuration loaded on Mac and Linux.
Removes platform #ifs in net/base/filter.cc initialization code
(reverting r2740).
B=2662
Review URL: http://codereview.chromium.org/5204
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add an ICU_UTIL_DATA_IMPL #defines to control whether we're expecting
the ICU data as ICU_UTIL_DATA_{SHARED,STATIC,FILE}.
* Set defaults on the platforms to match our current practice:
Windows => shared, Linux => file, Mac => static.
* On Mac, link the separate icui18n, icuuc and icudata libs (matching
how we're building there), instead of the common icu lib.
* Roll the icu38 revision in DEPS to get the updated SCons build.
Review URL: http://codereview.chromium.org/5022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
not libicuuc. Add a new $ICU_LIBS construction variable to allow
different platforms to link with different sets of ICU libraries.
Use it in the LIBS lists of the various construction environments
used to build the things that link with it.
Review URL: http://codereview.chromium.org/4312
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Otherwise it deletes the build directory and db file which are needed by the rest of the build, causing the build to fail.
Fixes error:
scons: *** [Errno 2] No such file or directory: 'src/chrome/src/chrome/Hammer/.sconsign.dblite'
Review URL: http://codereview.chromium.org/5010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/4096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
from the latest SCons version about the lack of pywin32
extensions making parallel support shaky in some corner cases.
Review URL: http://codereview.chromium.org/4280
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Call the $LIBEVENT_DIR/SConscript file on both Linux and Mac.
* Add generation of the config.h file.
* Modify the libevent_prebuild.sh script so SCons can pass in the input
file name (because SCons executes things from top of tree) but the
script still defaults to what XCode wants.
* Only build epoll.c and epoll_sub.c on Linux.
* Only build kqueue.c on Mac.
* Add -framework AppKit to the link lines.
* Add -fobjc-gc to Objective C compilation.
* Add message_pump_mac.mm to the base input file list on Mac.
* Build message_pump_libevent.cc on for base on both Linux and Mac.
* Link against -levent on both Linux and Mac.
Review URL: http://codereview.chromium.org/4254
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
files with the same "Compiling ..." messages we get when compiling static object files.
Review URL: http://codereview.chromium.org/3802
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2550 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/4060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2535 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/4052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
supported, and required.
Review URL: http://codereview.chromium.org/4047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2508 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
googleurl target files by hand on the command line.
Review URL: http://codereview.chromium.org/4226
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2506 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/4046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3157
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
to our copy (includes changes from r300 too).
Review URL: http://codereview.chromium.org/2971
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2375 0039d316-1c4b-4281-b951-d872f2087c98
|