| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Get GN in sync with gyp by adding missing dependencies, removing
the obsoletes dependencies and adding missing files and targets.
Change the toolchain when targetting iOS devices to not build fat
binaries as this break the "gn gen"-time selection of the level of
optimisation to use from skia and libwebp. Instead, building for
devices on iOS is now similar to other platforms (i.e. the arch is
selected via "target_cpu" with "arm" an alias for "armv7").
Fixes the following errors:
Undefined symbols for architecture arm64:
"_VP8DspInitNEON", referenced from:
_VP8DspInit in dec.o
...
BUG=459705,596237
Review URL: https://codereview.chromium.org/1810423002
Cr-Commit-Position: refs/heads/master@{#383416}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Integration test suite for the web shell, based on EarlGrey. This
includes the suite and gyp configurations to build and run two
sample tests.
build/common.gypi change is a revert of
https://codereview.chromium.org/1538973002, TBRed
BUG=583736
TBR=dpranke@chromium.org
Review URL: https://codereview.chromium.org/1828143007
Cr-Commit-Position: refs/heads/master@{#383414}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
/fastfail and /maxilksize:0x7ff00000 were added to the wrong place in
crrev.com/1816333002 and need to be moved/merged. Also, the
mini_installer link command removes executable_config (which suppresses
LNK4199 warnings) and then triggers those warnings so that suppression
needs to be added back in.
The /maxilksize argument is also changed to be consistent and to avoid
duplication.
This doesn't change build behavior at all, it just suppresses some
warnings and tidies up the configuration.
Review URL: https://codereview.chromium.org/1835603002
Cr-Commit-Position: refs/heads/master@{#383399}
|
|
|
|
|
|
|
|
| |
BUG=597066
Review URL: https://codereview.chromium.org/1818273002
Cr-Commit-Position: refs/heads/master@{#383389}
|
|
|
|
|
|
|
|
|
| |
BUG=596650
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/1832213002
Cr-Commit-Position: refs/heads/master@{#383382}
|
|
|
|
|
|
|
|
|
|
| |
reduces the number of instrumented blocks by ~50%.
BUG=
Review URL: https://codereview.chromium.org/1829283002
Cr-Commit-Position: refs/heads/master@{#383350}
|
|
|
|
|
|
|
|
|
|
| |
Also add a statement about where to find the actual logcat.
BUG=597771,448050
Review URL: https://codereview.chromium.org/1838483002
Cr-Commit-Position: refs/heads/master@{#383330}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This cl adds a new configuration flag to gold linker: "gdb_index"
The flag is on by default if is_desktop_linux && is_debug && is_component_build
The previous attempt to add this flag to all the builds was reverted
because of disk-space requirements. This checkin makes it a default
only for linux debug builds.
Why do this?
gold linker has a flag to automatically generate gdb-index section
inside shared libraries when linking.
Webkit single-file compile/linking time:
16.31s without gdb-index
16.11s with gdb-index
gdb startup time
~51s without gdb-index
~19s with gdb-index
BUG=
Committed: https://crrev.com/f68b7c07a30baac088b8eda055ba52835c04692c
Cr-Commit-Position: refs/heads/master@{#378600}
Review URL: https://codereview.chromium.org/1680943002
Cr-Commit-Position: refs/heads/master@{#383324}
|
|
|
|
|
|
|
|
|
|
|
| |
This isn't used anymore.
R=piman@chromium.org
BUG=597021
Review URL: https://codereview.chromium.org/1827603002
Cr-Commit-Position: refs/heads/master@{#383302}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a new template bundle_data_xib that compile a xib or storyboard
file and declare a bundle_data target with the compilation output.
Add bundle_data targets required to get ios_web_shell to build and
run in the simulator.
BUG=297668,546283
Review URL: https://codereview.chromium.org/1808733003
Cr-Commit-Position: refs/heads/master@{#383295}
|
|
|
|
|
|
|
|
|
|
|
|
| |
We have these targets in gn now.
BUG=None
R=dpranke@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_dbg
Review URL: https://codereview.chromium.org/1827163002
Cr-Commit-Position: refs/heads/master@{#383262}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The /RTC1 switch adds references to _RTC_CheckStackVars and
_RTC_InitBase which causes msvcrtd.lib to be pulled in which causes
gn debug builds of mini_installer to fail. /RTC1 is not used in gyp
builds and therefore it should be removed from gn builds unless we
decide that it offers enough value to justify the effort required to put
it back in.
BUG=596885
Review URL: https://codereview.chromium.org/1831213002
Cr-Commit-Position: refs/heads/master@{#383261}
|
|
|
|
|
|
|
|
|
|
|
|
| |
These files are used by QuicTestServer & PkpTest. They're currently handled
as a special case in //build/android/pylib/instrumentation/setup.py that I'd
like to get rid of.
BUG=
Review URL: https://codereview.chromium.org/1826313003
Cr-Commit-Position: refs/heads/master@{#383232}
|
|
|
|
|
|
|
|
|
|
|
| |
This is required for any test that uses an .isolate to push files to the
device (e.g. base_unittests).
BUG=589318
Review URL: https://codereview.chromium.org/1784373002
Cr-Commit-Position: refs/heads/master@{#383127}
|
|
|
|
|
|
|
|
| |
BUG=484854
Review URL: https://codereview.chromium.org/1827913002
Cr-Commit-Position: refs/heads/master@{#383002}
|
|
|
|
|
|
|
|
|
|
|
| |
This will mean even fewer UnusedResource checks, but that is covered by:
https://bugs.chromium.org/p/chromium/issues/detail?id=595810
BUG=597007
Review URL: https://codereview.chromium.org/1826563002
Cr-Commit-Position: refs/heads/master@{#382986}
|
|
|
|
|
|
|
|
|
|
|
|
| |
gyp always specified a value for --no-locals when compiling targets but
GN doesn't.
This resulted in GN erroneously stripping them.
BUG=596134
Review URL: https://codereview.chromium.org/1830693003
Cr-Commit-Position: refs/heads/master@{#382985}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds the MB config for the 'Chromium Windows Analyze' bot
on the chromium.fyi waterfall, and adds the needed flag maps
to disable precompiled headers (incl. adding a disable_precompiled_headers
flag to GN) and adding 'win_analyze' mixin (we need to actually
implement the win_analyze GN flag still, though).
R=brettw@chromium.org, brucedawson@chromium.org
BUG=597112
Review URL: https://codereview.chromium.org/1827683002
Cr-Commit-Position: refs/heads/master@{#382931}
|
|
|
|
|
|
|
|
| |
BUG=594807
Review URL: https://codereview.chromium.org/1828523002
Cr-Commit-Position: refs/heads/master@{#382917}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
VC++ 2015 defaults to *not* installing the C++ toolchain. Several
developers have failed to notice this and then hit cryptic errors when
building Chrome. This detects the problem and gives a more informative
error message for gn builds.
crrev.com/1832593002 does this for gyp builds.
BUG=440500
Review URL: https://codereview.chromium.org/1822383002
Cr-Commit-Position: refs/heads/master@{#382915}
|
|
|
|
|
|
|
|
| |
BUG=484854
Review URL: https://codereview.chromium.org/1829823002
Cr-Commit-Position: refs/heads/master@{#382905}
|
|
|
|
|
|
|
|
|
|
|
|
| |
No longer trying to guess name of cached .bin file.
Previous commit forgot to set --cache-dir for GN.
BUG=583661,597251
Review URL: https://codereview.chromium.org/1828693002
Cr-Commit-Position: refs/heads/master@{#382871}
|
|
|
|
|
|
|
|
| |
BUG=583661
Review URL: https://codereview.chromium.org/1823173002
Cr-Commit-Position: refs/heads/master@{#382848}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(fix-up) (patchset #2 id:20001 of https://codereview.chromium.org/1824093002/ )
Reason for revert:
Breaks on Android 64bit unpublished builders
BUG=597251
Original issue's description:
> Android: Run lint using a cache in the output directory (fix-up)
>
> Previous commit forgot to set --cache-dir for GN.
>
> BUG=583661
>
> Committed: https://crrev.com/99748af41ad073389f3f38274a024a830585609c
> Cr-Commit-Position: refs/heads/master@{#382699}
TBR=jbudorick@chromium.org,agrieve@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=583661
Review URL: https://codereview.chromium.org/1829683002
Cr-Commit-Position: refs/heads/master@{#382838}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When building with DEPOT_TOOLS_WIN_TOOLCHAIN=0 the vs_toolchain.py
script uses environment variables set up by vcvarsall.bat, such as
WINDOWSSDKDIR. The default value of this with VS 2015 is
WindowsSdkDir=C:\Program Files (x86)\Windows Kits\10\ - note the
trailing slash.
When ninja runs "build\vs_toolchain.py get_toolchain_dir" it translates
this to:
sdk_path = "C:\Program Files (x86)\Windows Kits\10\"
The trailing slash in front of the quote confuses the gn parser. This
change strips those trailing slashes. For more details see the gn
docs:
https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/language.md#Strings
BUG=593154
Review URL: https://codereview.chromium.org/1827663002
Cr-Commit-Position: refs/heads/master@{#382752}
|
|
|
|
|
|
|
|
|
|
| |
Previous commit forgot to set --cache-dir for GN.
BUG=583661
Review URL: https://codereview.chromium.org/1824093002
Cr-Commit-Position: refs/heads/master@{#382699}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
/fastfail should get us crash dumps when the linker crashes, which it
has been doing. /maxilksize is being added for consistency with gyp
builds, and because the linker crashes are incremental linking related.
This is being added in order to investigate a particular problem but
it is a good long-term change also - crashing without a crash dump is
not helpful.
BUG=482671
Review URL: https://codereview.chromium.org/1816333002
Cr-Commit-Position: refs/heads/master@{#382682}
|
|
|
|
|
|
|
|
|
|
| |
Removes the ability to override the definition of configuration_policy from outside the build, since this no longer works. It is now hardcoded to be on everywhere except iOS.
Renames the define used by syncable_prefs to make more clear this is a local flag only. This is the only code that still needs to use preprocessor based on the presence of policy. I removed the ifdef from the header and always declared the functions to prevent define skew, and just assert if the functions are called inappropriately.
Review URL: https://codereview.chromium.org/1805213002
Cr-Commit-Position: refs/heads/master@{#382595}
|
|
|
|
|
|
|
|
| |
BUG=583661
Review URL: https://codereview.chromium.org/1817943005
Cr-Commit-Position: refs/heads/master@{#382582}
|
|
|
|
|
|
|
|
| |
BUG=415300
Review URL: https://codereview.chromium.org/1809893002
Cr-Commit-Position: refs/heads/master@{#382468}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Thought I could clean up the android_webview/tools dir a little bit.
It basically has some random tools as well as the WebViewShell apks
so I moved all the apks into a shared folder.
- Moved all WebViewShell Apks into tools/system_webview_shell
- Moved WebViewShell/test/ to system_webview_shell/test/data/ to better
match the naming of test data elsewhere
- Removed DEPRECATED_java_in_dir from tools/BUILD.gn.
- Updated gn_migration.gypi since GN targets exist for the WebView
Shell apks.
BUG=
Review URL: https://codereview.chromium.org/1785283005
Cr-Commit-Position: refs/heads/master@{#382390}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit ed07b3773e3aad4a44a79a48c17162ef57ca82ee.
Reason for revert: crbug.com/596373.
BUG=596373
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/1821763002
Cr-Commit-Position: refs/heads/master@{#382356}
|
|
|
|
|
|
|
|
|
|
| |
Also delete an unused, commented-out block of code.
BUG=495204
Review URL: https://codereview.chromium.org/1822633002
Cr-Commit-Position: refs/heads/master@{#382330}
|
|
|
|
|
|
|
|
| |
BUG=565452
Review URL: https://codereview.chromium.org/1811933007
Cr-Commit-Position: refs/heads/master@{#382321}
|
|
|
|
|
|
|
|
|
|
| |
This fixes arch detection when 32-bit Chrome is run on a 64-bit device
BUG=596088
Review URL: https://codereview.chromium.org/1811363002
Cr-Commit-Position: refs/heads/master@{#382319}
|
|
|
|
|
|
|
|
| |
BUG=583661
Review URL: https://codereview.chromium.org/1815563005
Cr-Commit-Position: refs/heads/master@{#382306}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Define a global assert_no_deps on iOS (in ios/build/config.gni) and
use it in targets that have been fixed to work on iOS to prevent
further regression.
BUG=297668
Review URL: https://codereview.chromium.org/1812823002
Cr-Commit-Position: refs/heads/master@{#382286}
|
|
|
|
|
|
|
|
|
| |
Removed all files used to build app_remoting webapp and cleaned up
build files.
Review URL: https://codereview.chromium.org/1816653002
Cr-Commit-Position: refs/heads/master@{#382147}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For unknown reasons (Windows!) shutil.rmtree has been failing frequently
when the landmines change due to a toolchain change. This avoids the
the problem. This is necessary because manually deleting the 'out'
directory causes args.gn to get lost, which is a hassle.
This was noticed because the VS 2015 toolchain upgrades kept failing
to clobber the out directory on multiple machines.
Review URL: https://codereview.chromium.org/1812673003
Cr-Commit-Position: refs/heads/master@{#382140}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Linking currently takes forever when building with clang/win
without fastbuild=1 (see bug for details). Turn this on by
default until things are usable without it again.
BUG=589977
TBR=rnk
Review URL: https://codereview.chromium.org/1816683002
Cr-Commit-Position: refs/heads/master@{#382095}
|
|
|
|
|
|
|
|
|
|
|
| |
This changes the macro used to be USE_NSS_VERIFIER and modifies build
files to no longer assume iOS is using NSS.
BUG=591545
Review URL: https://codereview.chromium.org/1808963004
Cr-Commit-Position: refs/heads/master@{#382077}
|
|
|
|
|
|
|
|
|
|
| |
and fix it not erroring out when multiple devices are attached
BUG=none
Review URL: https://codereview.chromium.org/1818433002
Cr-Commit-Position: refs/heads/master@{#382036}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The WiFi Display elementary stream packetizer packetizes unit buffers to
Packetized Elementary Stream (PES) packets. It will be used internally by
a WiFi Display transport stream packetizer.
This is part of a WiFi Display packetizer patch series:
* https://codereview.chromium.org/1796123002/ <-- this CL
WiFi Display elementary stream packetizer
* https://codereview.chromium.org/1800493003/
WiFi Display elementary stream descriptors
* https://codereview.chromium.org/1797953002/
WiFi Display transport stream packetizer
* https://codereview.chromium.org/1796073003/
WiFi Display media packetizer
BUG=242107
Review URL: https://codereview.chromium.org/1796123002
Cr-Commit-Position: refs/heads/master@{#381945}
|
|
|
|
|
|
|
|
| |
BUG=297668
Review URL: https://codereview.chromium.org/1797323002
Cr-Commit-Position: refs/heads/master@{#381934}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I don't know why http://crrev.com/293913 has moved these flags outside
if(is_android),
but the corresponding GYP code (build/config.gypi) is still applying
these flags only to Android.
BUG=433082
Review URL: https://codereview.chromium.org/1807163002
Cr-Commit-Position: refs/heads/master@{#381890}
|
|
|
|
|
|
|
|
|
|
|
| |
But not on Chrome OS.
This reverts commit 7812fb8ba8271fbc542fd5716498517b82ba821a.
BUG=62400
Review URL: https://codereview.chromium.org/1811613005
Cr-Commit-Position: refs/heads/master@{#381811}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of https://codereview.chromium.org/1811743002/ )
Reason for revert:
Causing "Target image has run out of space" errors on Chrome OS builders:
http://crbug.com/595763
Original issue's description:
> Re-land: Enable XFA-Forms for the PDFium plugin.
>
> This reverts commit 13fe4645b7199ed2da4f1810d4c96262eaecea5f.
> See https://codereview.chromium.org/1761673002/
>
> TBR=thakis@chromium.org
>
> Committed: https://crrev.com/ed07b3773e3aad4a44a79a48c17162ef57ca82ee
> Cr-Commit-Position: refs/heads/master@{#381573}
TBR=thakis@chromium.org,ochang@chromium.org,jschuh@chromium.org,rpop@chromium.org,dsinclair@chromium.org,tsepez@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1814843003
Cr-Commit-Position: refs/heads/master@{#381764}
|
|
|
|
|
|
|
|
|
|
|
|
| |
When targetting simulator, builds iossim as a data_deps for all iOS
application bundle as it is required to run the bundle on simulator
from the command-line.
BUG=594519
Review URL: https://codereview.chromium.org/1800083003
Cr-Commit-Position: refs/heads/master@{#381696}
|
|
|
|
|
|
|
|
|
|
|
| |
Add a new config //build/config/compiler:enable_arc that adds the
required flag to enable ARC (automatic reference counting).
BUG=594519
Review URL: https://codereview.chromium.org/1806513002
Cr-Commit-Position: refs/heads/master@{#381686}
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 13fe4645b7199ed2da4f1810d4c96262eaecea5f.
See https://codereview.chromium.org/1761673002/
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/1811743002
Cr-Commit-Position: refs/heads/master@{#381573}
|