| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/8536052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/8536051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
currying, and use less types.
The main API change IgnoreResult() and fully currying. See unittest for what the new API looks like. The rest of the changes are done to support that.
Previously, IgnoreReturn could not be used with WeakPtr<> Bind()s as it was applied after the fact to the Callback object. Now, IgnoreResult() wraps the function like Unretained().
As an incidental benefit, the new implementation gave us fully currying for free.
Also, the new implementation scales better when supporting higher arities of functions. The new type growth is:
(n^2 + 20n) / 2
as opposed to
(3n^2 + 17n) / 2
where n == arity.
For n = 6 and n=10, the new implementation has 81 and 155 templates respectively.
The old implementation had 105 and 235 templates respectively.
BUG=35233,98919,98542
TEST=existing unittests
Review URL: http://codereview.chromium.org/8483003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The chromeos-chrome ebuild strips Chrome tests after the build, but it
can run significantly faster if we strip them during the build. This
changelist reduces the time it takes to build Chrome by allowing
developers to remove unnecessary debug symbols.
Performance comparison on z600 LOCAL_SOURCE build:
Before: 24m31s (257m04s user, 23m19s sys)
After: 20m55s (236m12s user, 22m10s sys)
Companion CL for updating Chrome OS to use strip_tests by default is here:
https://gerrit.chromium.org/gerrit/11517
BUG=chromium-os:22844
TEST=Build with and without debug symbols. Confirm speed difference.
Review URL: http://codereview.chromium.org/8526022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
-- set -DADDRESS_SANITIZER when compiling, because ASan will no more define it;
-- use -faddress-sanitizer instead of -fasan (these will coexist until we update all the binaries)
TBR=thakis
Review URL: http://codereview.chromium.org/8461008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
based classes that are obsoleted by Aura. Also remove a bunch of Wayland stuff, since any future Wayland integration is likely done as an implementation detail of Aura, not Views.
Specifically:
- views-desktop (classes and NativeWidgetView[s])
- NativeWidgetViews subclasses in Chrome (Constrained Windows, NTCVV, NTCCV, BrowserFrameViews et al).
- RWHVV, NWKEV
- NativeViewHostViews
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8598024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110832 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Right now Android's envsetup.sh requires the chdir to be in Chromium's
src directory, whereas this will be different for WebKit. Furthermore,
disabling build_ffmpegsumo will resolve a gyp error in ffmpeg.gyp.
BUG=
TEST=
Review URL: http://codereview.chromium.org/8523029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110697 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8589011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This version fixes a problem with the windows incremental linking build. We can't incrementally link chrome when content is being built as a DLL because chrome links in webkit_glue and webkit_glue depends on symbols defined in content. We can remove this when we fix glue.
R=jam@chromium.org
BUG=90442, 98755.
Review URL: http://codereview.chromium.org/8570024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=mal@chromium.org
Review URL: http://codereview.chromium.org/8576012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=thestig
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8513024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=kcc
Review URL: http://codereview.chromium.org/8488004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/8568012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8555029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=compile
Review URL: http://codereview.chromium.org/8564020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The os_bsd variable is only available on FreeBSD and OpenBSD.
Later on others like NetBSD and DragonflyBSD can be added.
This variable was introduced in order to have shorter
conditions in the gyp files.
BUG=
TEST=compile
Patch by Robert Nagy <robert.nagy@gmail.com>
Review URL: http://codereview.chromium.org/8567001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/8558002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
before).
For other configurations it can also be set by a command line option at run-time (also as before).
What changes is that we are removing use_only_pure_views as a separate GYP flag which we no longer really need.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8528014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=102738
TEST=none
Review URL: http://codereview.chromium.org/8496034
Review URL: http://codereview.chromium.org/8515025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109552 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use XFixes to update the clipboard sequence number.
BUG=73478
TEST=manual testing
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109528
Review URL: http://codereview.chromium.org/8501002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109537 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=73478
TEST=manual testing
Review URL: http://codereview.chromium.org/8501002
TBR=dcheng@chromium.org
Review URL: http://codereview.chromium.org/8524014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=73478
TEST=manual testing
Review URL: http://codereview.chromium.org/8501002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109528 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change makes it use webkit_glue::ImageDecoder instead
of gdk-pixbuf and hides various GTK+ theme-related code
behind TOOLKIT_USES_GTK ifdefs. Chrome OS is currently
loading its own icons from resources (see r86936 and
http://crosbug.com/129) instead of using IconLoader and
IconManager, so this only removes NOTIMPLEMENTED()s on
non-Chrome-OS Linux Aura builds (along with simplifying the
GTK+ version of the code).
BUG=99494
TEST=manual: download icons are still visible on a gtk+ build
Review URL: http://codereview.chromium.org/8501030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109527 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=No visible changes. Virtual printer binaries should now appear on the official builder.
Review URL: http://codereview.chromium.org/8509022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8462017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=101731
Review URL: http://codereview.chromium.org/8520005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
unit_tests.
Print Preview unit_tests were good to tackle because it brought in a dependency on the need
to include another js file.
This also hilighted another need - that of being able to include non-generative js files in gyp
and have them copied to the test_data dir, while doing both generation and copy for gtest files.
I changed the "extension" of files which generate C++ with gtest-like syntax to .gtestjs and
added a copyjs rule to the chrome_tests.gypi.
FWIW, I believe this is mostly needed for unit_tests and only applied it there, although I would
be amenable to also making this change for the webui tests to make it clear that they are not
plain js files.
R=dpapad@chromium.org
BUG=101443,102222
TEST=unit_tests --gtest_filter=PrintPreviewUtilsUnitTest.*
Review URL: http://codereview.chromium.org/8438063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I had hoped to just turn this on globally after fixing all instances, but people
add these fairly often. So enable the warning for clean targets incrementally.
BUG=10600
TEST=none
TBR=ben
Review URL: http://codereview.chromium.org/8495043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
components build.
BUG=102738
TEST=none
Review URL: http://codereview.chromium.org/8496034
TBR=rvargas@chromium.org
Review URL: http://codereview.chromium.org/8495036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=102738
TEST=none
Review URL: http://codereview.chromium.org/8496034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Depends on http://codereview.chromium.org/8395046
BUG=None
TEST=Visiting about:rotate?right, about:rotate?left, etc. should cause the appropriate screen rotations.
Review URL: http://codereview.chromium.org/8402002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/8437033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108589 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://build.chromium.org/p/chromium/builders/Win%20Builder%202010%20%28dbg%29/builds/12897
This CL is based on the patch:
http://codereview.chromium.org/8416025
Use GYP to build nacl_irt
Converts Chrome from using scons to using GYP when building nacl_irt.
This change causes chrome to use GYP based components for untrusted
code. As a benifit, GYP will no longer need to run and scrape scons
output to determine irt dependencies. This also allows us to avoid
invoking scons during the build process.
We roll NaCl deps to get a fix for a simultaneous 32/64 bit build
issue on Windows.
This broke the mac build due to a missing dependency where pthread.h was
unavailable. This header gets copied to the correct location during the
prep_toolchain action. I've added the appropriate dependency shown bellow
to the original patch.
This add the addition dependency to ppruntime
'dependencies': [
'<(DEPTH)/native_client/src/tools.gyp:prep_toolchain'
],
TEST= try
BUG= http://code.google.com/p/chromium/issues/detail?id=96782
Review URL: http://codereview.chromium.org/8440004
TBR=noelallen@google.com
Review URL: http://codereview.chromium.org/8423080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Build
Review URL: http://codereview.chromium.org/8386039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/8351064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/8416025
Use GYP to build nacl_irt
Converts Chrome from using scons to using GYP when building nacl_irt.
This change causes chrome to use GYP based components for untrusted
code. As a benifit, GYP will no longer need to run and scrape scons
output to determine irt dependencies. This also allows us to avoid
invoking scons during the build process.
We roll NaCl deps to get a fix for a simultaneous 32/64 bit build
issue on Windows.
This broke the mac build due to a missing dependency where pthread.h was
unavailable. This header gets copied to the correct location during the
prep_toolchain action. I've added the appropriate dependency shown bellow
to the original patch.
This add the addition dependency to ppruntime
'dependencies': [
'<(DEPTH)/native_client/src/tools.gyp:prep_toolchain'
],
TEST= try
BUG= http://code.google.com/p/chromium/issues/detail?id=96782
Review URL: http://codereview.chromium.org/8440004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/8438010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108194 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reverted because it was killing pagecycler performance
More background info at http://code.google.com/p/chromium/issues/detail?id=101731 ('re-enable use_skia by default')
BUG=101731
Review URL: http://codereview.chromium.org/8384004
TBR=kerz@chromium.org
Review URL: http://codereview.chromium.org/8386008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Converts Chrome from using scons to using GYP when building nacl_irt.
This change causes chrome to use GYP based components for untrusted
code. As a benifit, GYP will no longer need to run and scrape scons
output to determine irt dependencies. This also allows us to avoid
invoking scons during the build process.
We roll NaCl deps to get a fix for a simultaneous 32/64 bit build
issue on Windows.
TEST= try
BUG= http://code.google.com/p/chromium/issues/detail?id=96782
Review URL: http://codereview.chromium.org/8416025
TBR=noelallen@google.com
Review URL: http://codereview.chromium.org/8440003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Converts Chrome from using scons to using GYP when building nacl_irt.
This change causes chrome to use GYP based components for untrusted
code. As a benifit, GYP will no longer need to run and scrape scons
output to determine irt dependencies. This also allows us to avoid
invoking scons during the build process.
We roll NaCl deps to get a fix for a simultaneous 32/64 bit build
issue on Windows.
TEST= try
BUG= http://code.google.com/p/chromium/issues/detail?id=96782
Review URL: http://codereview.chromium.org/8416025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
More background info at http://code.google.com/p/chromium/issues/detail?id=101731 ('re-enable use_skia by default')
BUG=101731
Review URL: http://codereview.chromium.org/8384004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8430008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8418046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8341137
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Existing
Review URL: http://codereview.chromium.org/8396043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
wonky, and this is a convenient fix.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8400023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107608 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The flager has been used by the other subclass. The previous change
was a mistake.
BUG=
TEST=
Review URL: http://codereview.chromium.org/8394024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107450 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
a previous CL I added the crx file and the corresponding change to the json
file, but forgot to add the crx file to the gyp files.
BUG=101500
TEST=Make sure the search app appears in new profiles
Review URL: http://codereview.chromium.org/8391011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=99517
TEST=http://www.webkit.org/blog/386/3d-transforms/
Review URL: http://codereview.chromium.org/8307001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107262 0039d316-1c4b-4281-b951-d872f2087c98
|