| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=500882
Review URL: https://codereview.chromium.org/1231723002
Cr-Commit-Position: refs/heads/master@{#338512}
|
|
|
|
|
|
|
|
|
|
|
| |
Supports just --quick-check for now.
BUG=508895
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/1232073003 .
Cr-Commit-Position: refs/heads/master@{#338488}
|
|
|
|
|
|
|
|
| |
BUG=505303
Review URL: https://codereview.chromium.org/1223363004
Cr-Commit-Position: refs/heads/master@{#338464}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
0 configs already ran on Swarming
7 used to run locally and were converted:
- chromium.fyi.json: CrWinAsan tester
- chromium.fyi.json: CrWinAsan(dll) tester
- chromium.win.json: Vista Tests (1)
- chromium.win.json: Win 7 Tests x64 (1)
- chromium.win.json: Win7 Tests (1)
- chromium.win.json: Win7 Tests (dbg)(1)
- chromium.win.json: XP Tests (1)
Ran:
./manage.py --convert installer_util_unittests
R=thakis@chromium.org
BUG=98637
Review URL: https://codereview.chromium.org/1220833004
Cr-Commit-Position: refs/heads/master@{#338449}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This warns on code of the form:
#endif RANDOM_TEXT
MIDL generated code tends to emit code in this pattern, so suppress
this warning when compiling MIDL generated files.
BUG=504663
R=thakis@chromium.org
TBR=dtseng, robertshield, weitaosu
Review URL: https://codereview.chromium.org/1233453008
Cr-Commit-Position: refs/heads/master@{#338435}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
0 configs already ran on Swarming
7 used to run locally and were converted:
- chromium.fyi.json: CrWinAsan tester
- chromium.fyi.json: CrWinAsan(dll) tester
- chromium.win.json: Vista Tests (1)
- chromium.win.json: Win 7 Tests x64 (1)
- chromium.win.json: Win7 Tests (1)
- chromium.win.json: Win7 Tests (dbg)(1)
- chromium.win.json: XP Tests (1)
Ran:
./manage.py --convert sbox_validation_tests
R=cpu@chromium.org,thakis@chromium.org
BUG=98637
Review URL: https://codereview.chromium.org/1212003003
Cr-Commit-Position: refs/heads/master@{#338434}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/1236643002
Cr-Commit-Position: refs/heads/master@{#338428}
|
|
|
|
|
|
|
|
|
|
| |
Ninja takes care of creating output directories already
BUG=
Review URL: https://codereview.chromium.org/1223273005
Cr-Commit-Position: refs/heads/master@{#338421}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
0 configs already ran on Swarming
7 used to run locally and were converted:
- chromium.fyi.json: CrWinAsan tester
- chromium.fyi.json: CrWinAsan(dll) tester
- chromium.win.json: Vista Tests (1)
- chromium.win.json: Win 7 Tests x64 (1)
- chromium.win.json: Win7 Tests (1)
- chromium.win.json: Win7 Tests (dbg)(1)
- chromium.win.json: XP Tests (1)
Ran:
./manage.py --convert sbox_unittests
R=cpu@chromium.org,thakis@chromium.org
BUG=98637
Review URL: https://codereview.chromium.org/1219403002
Cr-Commit-Position: refs/heads/master@{#338418}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is gives Chromium developers visibility into what features are active, but hidden behind field trial testing while developing Chromium.
There is already a JSON file in Chromium with which field trials should be active. The goal is make a code generator to output a struct based off the contents of this JSON file. The next step after this is to create a mechanism to activate the trials defined by this generated struct.
BUG=504075
Review URL: https://codereview.chromium.org/1209743002
Cr-Commit-Position: refs/heads/master@{#338416}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously GN would put object files in a similar place to GYP. They would go in a corresponding directory as the source file and would be prefixed with the target name for uniqueness.
Since GN target names are not unique, this doesn't work as well. Instead use a simpler scheme and put all the object files in a directory for each target.
This causes a few object file name collisions which this patch fixes in various ways:
- Renamed chrome/browser/ui/views/find_bar_host_interactive_uitest.cc to have "views" in the name (collided with chrome/browser/ui/find_bar/find_bar_host_interactive_uitest.cc)
- Renamed chrome/browser/apps/speech_recognition_browsertest.cc to have "app" in the name (collided with chrome/browser/speech/speech_recognition_browsertest.cc).
- Renamed chrome/common/extensions/api/extension_api_unittest.cc to have "common" in the name (collided with chrome/browser/extensions/extension_api_unittest.cc which is actually a test harness with that name).
- Moved the extensions files that were in the chrome interactive UI tests and browser tests to source sets in the extensions directory. These are things that should be cleaned up and moved there anyway.
- Net has some messy duplication in quic files. I made a dummy target for them. Apparently each copy of this file (same code, different namespace) is supposed to match something different upstream and this should be fixed.
- Moved chrome/browser/chromeos unit tests to its own target.
- Renamed chrome/browser/favicon/favicon_helper to favicon_utils. It conflicted with chrome/browser/android/favicon_helper which has an actual class named "FaviconHelper.
- Renamed service.* and service_factory.* in chrome/browser/chromeos/launcher_search_provider to have a launcher_search_provider prefix to avoid collisions with the file_system_provider one.
- Added a "chromeos" prefix to chrome/browser/chromeos/first_run/first_run_browsertest.cc to avoid collisions with the one in browser/first_run.
- Added "chromeos" to chrome/browser/chromeos/preferences_browsertest.cc to avoid collision with browser/ui/webui/options.
- Rename "chrome/browser/chromeos/drive/test_util.*" to "drive_test_util.*". Update includes. Rename chrome/browser/chromeos/file_manager/drive_test_util* to mount_test_util to avoid colliding with above new file.
The deps->public_deps changes in components/policy and content/test is because those targets were used externally in a way that this patch uncovered.
Review URL: https://codereview.chromium.org/1208963003
Cr-Commit-Position: refs/heads/master@{#338408}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A custom tab client project has been mirrored in third_party. We
should add a gyp target to compile it in upstream, and delete the
downstream one.
This CL also updated java.gypi to let it take customizable
src suffix, just like java_apk.gypi.
BUG=NONE
Review URL: https://codereview.chromium.org/1222403005
Cr-Commit-Position: refs/heads/master@{#338399}
|
|
|
|
|
|
|
|
|
|
|
| |
Using --gtest_filter=-AudioInputTest.* currently results in no tests being
run, instead of "all tests except for AudioInputTest".
R=skyostil@chromium.org,cjhopman@chromium.org
Review URL: https://codereview.chromium.org/1235713003
Cr-Commit-Position: refs/heads/master@{#338396}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
#1 id:1 of https://codereview.chromium.org/1228093005/)
Reason for revert:
might be better now?
Original issue's description:
> Revert of Clang on Windows: Remove -Wno-unused-variable. (patchset #3 id:40001 of https://codereview.chromium.org/1226573002/)
>
> Reason for revert:
> Broke Clang build on Windows according to http://crbug.com/505319#c30.
>
> Those warnings should be fixed before relanding.
>
> Original issue's description:
> > Clang on Windows: Remove -Wno-unused-variable.
> >
> > Unused variables are now errors. However, since lots of third-party code
> > has unused variables, added a blanket suppression to all third-party
> > code.
> >
> > BUG=505319
> >
> > Committed: https://crrev.com/3371ccbd9d83e1031c5891520e88acbc9c1859a0
> > Cr-Commit-Position: refs/heads/master@{#338242}
>
> TBR=garykac@chromium.org,thakis@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=505319
>
> Committed: https://crrev.com/ff68a3ba6f2dc9b226047b3355c135f73352570e
> Cr-Commit-Position: refs/heads/master@{#338253}
TBR=garykac@chromium.org,mgiuca@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=505319
Review URL: https://codereview.chromium.org/1232543005
Cr-Commit-Position: refs/heads/master@{#338395}
|
|
|
|
|
|
|
|
|
|
|
| |
The usage of these strings was removed in
https://codereview.chromium.org/1226933004/.
BUG=484806
Review URL: https://codereview.chromium.org/1228343003
Cr-Commit-Position: refs/heads/master@{#338382}
|
|
|
|
|
|
|
|
|
| |
BUG=505317
TBR=benwells@chromium.org
Review URL: https://codereview.chromium.org/1226373006 .
Cr-Commit-Position: refs/heads/master@{#338375}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
0 configs already ran on Swarming
15 used to run locally and were converted:
- chromium.chromiumos.json: Linux ChromiumOS Ozone Tests (1)
- chromium.chromiumos.json: Linux ChromiumOS Tests (1)
- chromium.chromiumos.json: Linux ChromiumOS Tests (dbg)(1)
- chromium.fyi.json: Linux Trusty
- chromium.fyi.json: Linux Trusty (dbg)
- chromium.linux.json: Linux Tests
- chromium.linux.json: Linux Tests (dbg)(1)
- chromium.linux.json: Linux Tests (dbg)(1)(32)
- chromium.memory.fyi.json: Linux ChromeOS MSan Tests
- chromium.memory.fyi.json: Linux MSan Tests
- chromium.memory.fyi.json: Linux TSan Tests
- chromium.memory.json: Linux ASan LSan Tests (1)
- chromium.memory.json: Linux Chromium OS ASan LSan Tests (1)
- chromium.webkit.json: Linux ChromiumOS Tests (1)
- chromium.webkit.json: Linux ChromiumOS Tests (dbg)(1)
Ran:
./manage.py --convert display_unittests
R=oshima@chromium.org,thakis@chromium.org
BUG=98637
Review URL: https://codereview.chromium.org/1207383007
Cr-Commit-Position: refs/heads/master@{#338370}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
0 configs already ran on Swarming
7 used to run locally and were converted:
- chromium.fyi.json: CrWinAsan tester
- chromium.fyi.json: CrWinAsan(dll) tester
- chromium.win.json: Vista Tests (1)
- chromium.win.json: Win 7 Tests x64 (1)
- chromium.win.json: Win7 Tests (1)
- chromium.win.json: Win7 Tests (dbg)(1)
- chromium.win.json: XP Tests (1)
Ran:
./manage.py --convert sbox_integration_tests
R=cpu@chromium.org,thakis@chromium.org
BUG=98637
Review URL: https://codereview.chromium.org/1214053003
Cr-Commit-Position: refs/heads/master@{#338358}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/1229073003
Cr-Commit-Position: refs/heads/master@{#338292}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bots have the sdk library delivered in a different way than
the devs. The version they get is explicitely set in the build
files while devs have to download the extras themselves.
Running this check would not allow for example to download an
already processed version of split client libraries
BUG=490091
Review URL: https://codereview.chromium.org/1229883002
Cr-Commit-Position: refs/heads/master@{#338262}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
id:40001 of https://codereview.chromium.org/1226573002/)
Reason for revert:
Broke Clang build on Windows according to http://crbug.com/505319#c30.
Those warnings should be fixed before relanding.
Original issue's description:
> Clang on Windows: Remove -Wno-unused-variable.
>
> Unused variables are now errors. However, since lots of third-party code
> has unused variables, added a blanket suppression to all third-party
> code.
>
> BUG=505319
>
> Committed: https://crrev.com/3371ccbd9d83e1031c5891520e88acbc9c1859a0
> Cr-Commit-Position: refs/heads/master@{#338242}
TBR=garykac@chromium.org,thakis@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=505319
Review URL: https://codereview.chromium.org/1228093005
Cr-Commit-Position: refs/heads/master@{#338253}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Unused variables are now errors. However, since lots of third-party code
has unused variables, added a blanket suppression to all third-party
code.
BUG=505319
Review URL: https://codereview.chromium.org/1226573002
Cr-Commit-Position: refs/heads/master@{#338242}
|
|
|
|
|
|
|
|
|
|
| |
(OS=="linux" or chromeos==1) can be folded into just a
simple *OS=="linux") test because chromeos builds assume
that OS is always set to linux.
Review URL: https://codereview.chromium.org/1012483004
Cr-Commit-Position: refs/heads/master@{#338239}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1222203012/)
Reason for revert:
ANGLE has rolled in https://crrev.com/01b5c82d06fcbddd7556ea848ba803b72c61811c
Original issue's description:
> Re-add -Wno-missing-braces on win clang.
>
> ANGLE needs a roll to fix one last instance of this warning, but the
> roll is currently blocked. Disable this warning again until ANGLE can be
> successfully rolled to fda3ec747c3dca037b961c7f8c04a81766f37007.
>
> BUG=505297
> R=thakis@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/c38a1f71038e5f0a5565b42e30b8985870b49286
TBR=thakis@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=505297
Review URL: https://codereview.chromium.org/1226143007
Cr-Commit-Position: refs/heads/master@{#338234}
|
|
|
|
|
|
|
|
|
|
|
|
| |
The world isn't ready for this yet, see bug. This reverts parts of
https://codereview.chromium.org/1215643003/
BUG=505317
TBR=benwells@chromium.org
Review URL: https://codereview.chromium.org/1232033002.
Cr-Commit-Position: refs/heads/master@{#338228}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It defines YY_USE_CONST when building mesa to fix this warning, disables
-Wincompatible-pointer-types for the other third-party libraries that
trigger it and fixes some underspecified dependencies in
third_party/libwebp.
BUG=504696
Review URL: https://codereview.chromium.org/1226583002
Cr-Commit-Position: refs/heads/master@{#338227}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will hopefully fix symbolization on the asan/android bots.
This also brings in somewhat major changes in how the asan runtime is
built on OS X; hopefully it won't break the mac asan bots.
libcxx(abi) grew CMake files, which is great – except it adds the libcxx(abi)
tests to `check-all`, and they don't pass in bootstrap mode on OS X.
So delete libcxx(abi) before starting the main build. (It's only needed on OS X
for bundling libcxx with the compiler so it can run on 10.6, and that's all done
after the first build.)
This also adds support for __nullable and Objective-C generics.
BUG=502974,499448
TBR=hans
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1229653005
Cr-Commit-Position: refs/heads/master@{#338220}
|
|
|
|
|
|
|
|
| |
BUG=505304
Review URL: https://codereview.chromium.org/1234483002
Cr-Commit-Position: refs/heads/master@{#338218}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that cacheinvalidation lives in the Chromium repo (after [1]), we can have
these BUILD.gn files directly in third_party/cacheinvalidation.
[1] -
https://chromium.googlesource.com/chromium/src.git/+/4a996cdc7a36a71ac511c153375fc6170fea80e6
BUG=None
TEST=gn gen out-gn/Debug still works
R=zea@chromium.org,dpranke@chromium.org
TBR=dpranke@chromium.org
Review URL: https://codereview.chromium.org/1231503002
Cr-Commit-Position: refs/heads/master@{#338156}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 311a46585ee5b77486ef42d947bc7cc7566558b1 / #338040,
https://codereview.chromium.org/1212163011/. The change broke tests in official
builds (http://crbug.com/508659).
BUG=504841, 508148, 508659
TBR=sdefresne@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1229933005 .
Cr-Commit-Position: refs/heads/master@{#338150}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/1211013009
Cr-Commit-Position: refs/heads/master@{#338128}
|
|
|
|
|
|
|
|
| |
BUG=505317
Review URL: https://codereview.chromium.org/1215643003
Cr-Commit-Position: refs/heads/master@{#338115}
|
|
|
|
|
|
|
|
|
|
|
| |
If a test needs to disable mock location, pass --disable-mock-location
to provision_devices.py.
BUG=493980
Review URL: https://codereview.chromium.org/1228003004
Cr-Commit-Position: refs/heads/master@{#338097}
|
|
|
|
|
|
|
|
| |
BUG=500920
Review URL: https://codereview.chromium.org/1225123004
Cr-Commit-Position: refs/heads/master@{#338087}
|
|
|
|
|
|
|
|
| |
BUG=505299
Review URL: https://codereview.chromium.org/1227173004
Cr-Commit-Position: refs/heads/master@{#338041}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add new class RLZTrackerDelegate that abstract access to embedder
specific singletons and informations and provide an implementation for
Chrome based on the previous implementation.
Split rlz_unittest.cc in tests of the RLZTracker and Chrome
implementation of the RLZTrackerDelegate interface and move the
RLZTracker tests into the component.
Add a new gyp/gn variable "enable_rlz_support". This variable is true on
the platforms that support RLZ (currently Windows, Mac, iOS and
ChromeOS). Use it to build library and unit tests even when the RLZ
support is not enabled in the Chrome binary (this is still controlled by
"enable_rlz" and depends on the branding).
Enable the tests on iOS and convert rlz_tracker_ios.mm to a C++ file.
TEST=Run unit_tests and components_unittests on a platform that supports
RLZ (Windows, Mac, iOS or ChromeOS) and check that they pass. Then build
Chrome with "enable_rlz" and manually checks that RLZ are sent with
searches as expected.
BUG=504841,508148
Review URL: https://codereview.chromium.org/1212163011
Cr-Commit-Position: refs/heads/master@{#338040}
|
|
|
|
|
|
|
|
|
|
|
|
| |
As part of this, allow asynchronous token return. This should be
allowed anyway, but is particularly important on Android, where getting
a token may cause user interaction.
BUG=474943
Review URL: https://codereview.chromium.org/1128043007
Cr-Commit-Position: refs/heads/master@{#338039}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This ports the chromevox build: chromevox and chromevox_tests targets to
gn. Liblouis is still missing since it requires native client which is
not enabled for Chrome OS.
BUG=None
Review URL: https://codereview.chromium.org/1145243006
Cr-Commit-Position: refs/heads/master@{#338002}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Newer version of GLib define *get_instance_private symbols in
the G_DEFINE_TYPE macros. These symbols might be unused in cases
where a GObject class doesn't access its instances private data,
triggering -Wunused-function warnings.
BUG=504375
TEST=compile with gn on linux with GLib >= 2.37
Review URL: https://codereview.chromium.org/1216153005
Cr-Commit-Position: refs/heads/master@{#338001}
|
|
|
|
|
|
|
|
|
|
| |
Also replaced some Mac-specific #ifdef's with this flag.
BUG=415302
Review URL: https://codereview.chromium.org/1210943008
Cr-Commit-Position: refs/heads/master@{#337969}
|
|
|
|
|
|
|
|
|
|
| |
This setting has to be enabled for running Android CTS GeolocationTest
BUG=493980
Review URL: https://codereview.chromium.org/1214753005
Cr-Commit-Position: refs/heads/master@{#337915}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ANGLE needs a roll to fix one last instance of this warning, but the
roll is currently blocked. Disable this warning again until ANGLE can be
successfully rolled to fda3ec747c3dca037b961c7f8c04a81766f37007.
BUG=505297
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/1222203012 .
Cr-Commit-Position: refs/heads/master@{#337843}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This silences the warning "bootstrap class path not set in conjunction
with -source 1.7" when building with OpenJDK 1.8.
The multiple_proguards test was removed as javac will now catch the use
of host packages that do not exist on Android.
BUG=
Review URL: https://codereview.chromium.org/1213433007
Cr-Commit-Position: refs/heads/master@{#337805}
|
|
|
|
|
|
|
|
|
| |
Useful for specifying specific or modified libc++ library files instead of
always using the one in android_ndk_root.
Review URL: https://codereview.chromium.org/1215713006
Cr-Commit-Position: refs/heads/master@{#337797}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Missing braces have been located and restored to their rightful
positions.
BUG=505297
TBR=aboxhall,ananta,atwilson,hajimehoshi,jamiewalch,vitalybuka
Review URL: https://codereview.chromium.org/1216413002
Cr-Commit-Position: refs/heads/master@{#337781}
|
|
|
|
|
|
|
|
| |
BUG=504661
Review URL: https://codereview.chromium.org/1214723011
Cr-Commit-Position: refs/heads/master@{#337768}
|
|
|
|
|
|
|
|
|
|
|
| |
The suppression is still active for third_party code because quite a lot
of third_party breaks this rule.
BUG=505301
Review URL: https://codereview.chromium.org/1221333010
Cr-Commit-Position: refs/heads/master@{#337765}
|
|
|
|
|
|
|
|
| |
BUG=504699
Review URL: https://codereview.chromium.org/1214303004
Cr-Commit-Position: refs/heads/master@{#337709}
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1210253002/
BUG=500920
Review URL: https://codereview.chromium.org/1219293005
Cr-Commit-Position: refs/heads/master@{#337695}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
20 Files with Fixes
2 Files with Suppressions
Some errors were suppressed as they appear to be deliberate
Includes fixes for:
[Finally]
[PrimitiveArrayPassedToVarargsMethod]
[DepAnn]
[StaticAccessedFromInstance]
[StringEquality]
[CollectionIncompatibleType]
[WaitNotInLoop]
See http://errorprone.info/bugpatterns
for information about these bug patterns
BUG=485599
Review URL: https://codereview.chromium.org/1209413009
Cr-Commit-Position: refs/heads/master@{#337683}
|