| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
| |
The overenthusiastic presubmit tries to prevent ASSERT but also prevents
COMPILE_ASSERT, which is valid.
BUG=none
Review URL: https://codereview.chromium.org/11227036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163396 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We can't compile-guard code and use DCHECK since it can be enabled at runtime. So we guard the DCHECKs that we want to rely on conditionally-compiled code in !NDEBUG compile guards.
This also replaces use of LOG_ERROR("Foo") with LOG(ERROR)<<"Foo";
This was previously discussed and committed as https://codereview.chromium.org/11048044/
using a guard based on LOGGING_IS_OFFICIAL_BUILD, however this was not sufficient since there are build configurations that are official builds but have dchecks compiled.
R=enne
Review URL: https://codereview.chromium.org/11192030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
The default bots build and run on linux debug in order to
verify assertions are working as intended.
We just run the unittests that test the cc/ code
specifically. And we also run linux_layout_rel in order to
get equal coverage of LayoutTests as we had from the WebKit
EWS bots (though with more noise).
Review URL: https://chromiumcodereview.appspot.com/11091047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161871 0039d316-1c4b-4281-b951-d872f2087c98
|
