summaryrefslogtreecommitdiffstats
path: root/cc/animation
Commit message (Collapse)AuthorAgeFilesLines
* Revert "Fix for bug where composited rotate3d should SLERP instead of ↵soonm2015-08-073-41/+6
| | | | | | | | | | | | | | | | | | | | | | interpolating the axes and angles numerically." This reverts commit 76ccfb05fe20d7c5007ceba84a011fc1453d621c. https://codereview.chromium.org/1194073007/ Although the behavior is slightly different from the intended one as in CSS Transform Module Level 1, the original behavior before this patch is one that is more consistent when animation cancel happens. However, the tests are relevant to checking when rotation starts or stops with a 0deg angle. It will be re-added as a separate patch to check for the correct behavior after the fix for blink rotate lands. https://codereview.chromium.org/1279833006/ BUG=516577 R=ajuma@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1276813002 Cr-Commit-Position: refs/heads/master@{#342247}
* cc: Keep the transform tree's to_screen_is_animated updatedajuma2015-08-046-10/+259
| | | | | | | | | | | | | | | The transform tree's to_screen_is_animated is currently set during tree building but is never updated. This CL updates this value as transform animations change, and makes VerifyPropertyTreeValuesForLayer verify that this matches CDP's screen_space_transform_is_animating. BUG=509673 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1227863009 Cr-Commit-Position: refs/heads/master@{#341728}
* CC Animation: Fix pauseAnimation so it doesn't reset blink negative delays.loyso2015-07-312-9/+39
| | | | | | | | | | | This function is used only for testing. BUG=509482 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1255883006 Cr-Commit-Position: refs/heads/master@{#341253}
* cc: Clean up <Property>IsAnimating and related logicajuma2015-07-245-44/+218
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Layers currently have two notions of having an animated property, such as an animated transform. HasPotentiallyRunningTransformAnimation means there's a transform animation that hasn't finished. TransformIsAnimating is a stronger condition: it means there's a transform animation that hasn't finished, and is currently "in effect". For animations without start delays, these notions are equivalent, since unfinished animations without a start delay are always "in effect". However, an animation with a start delay can be unfinished without yet being "in effect"; this is the case during the start delay, for animations that don't have a "backwards" fill-mode. Animations that aren't yet in effect don't get ticked. CDP and property trees use <Property>IsAnimating when deciding whether a property's value might change on the compositor thread. For example, when a layer has opacity 0, its subtree is skipped unless OpacityIsAnimating, and similar logic exists for uninvertible transforms and TransformIsAnimating. However, this doesn't correctly account for animations with start delays -- once the delay has finished, such animations will cause changes on the compositor thread. This CL replaces usage of <Property>IsAnimating with HasPotentiallyRunning<Property>Animation wherever we're really trying to check "will this value change on the compositor thread". In particular, this includes the computation of screen_space_transform_is_animating. A second problem with <Property>IsAnimating and HasPotentiallyRunning<Property>Animation is that on the compositor thread, they don't distinguish between animations that affect the pending tree and those that affect the active tree. This means, for example, that right after a commit that adds a transform animation to a layer, the corresponding active layer's screen_space_transform_is_animating value is true, even before activation, and even though there isn't yet any animation that affects it. This is unintuitive, and also awkward behavior to match when using property trees, since property trees propagate through commit and activation. This CL makes <Property>IsAnimating and HasPotentiallyRunning<Property>Animation take into account whether particular animations affect the active tree, the pending tree, or both. BUG=509673 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1239983006 Cr-Commit-Position: refs/heads/master@{#340338}
* cc: Fix post-commit property tree update for animationsajuma2015-07-132-0/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | After a commit, property tree nodes corresponding to animated layers have their values updated during a layer tree walk, to handle the case where the most recent compositor thread animation tick happened at a different time than the most recent main thread tick. This CL fixes two problems with this update: 1) An animation that's running at the start of a BeginMainFrame may finish on the compositor thread before the commit. In this situation, the property tree still needs to updated after commit. The current logic used by LayerImpl to decide whether an update is needed involves calling TransformIsAnimating or OpacityIsAnimating, but these will be false since the animation has finished. As a result, the update doesn't happen and the property tree is out-of-sync. 2) If an in-progress animation is removed on the main thread, the previously-animated layer may no longer own a property tree node. However, right after commit, the animation is still in a "Running" state on the compositor thread (so that the active tree continues to be affected until tree activation). As a result, LayerImpl will update a tree node that it doesn't actually own, so this node will end up with the wrong value. To fix these problems, LayerImpl now checks for any animation rather than only those that aren't finished (to handle the possibility that the animation might have finished during the commit), and also now checks that it owns a property tree node before updating this node (to handle the possibility that it no longer owns a node). All layout tests now pass with property tree verification enabled. BUG=509679 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1231903005 Cr-Commit-Position: refs/heads/master@{#338537}
* CC Animations: Port Impl-only-scrolling to use compositor animation timelines.loyso2015-07-086-16/+181
| | | | | | | | | | | | | | | | | | | Use AnimationPlayer to add Scrolloffset animations if new system enabled. Previous episode: https://codereview.chromium.org/1010663002/ Next episode: https://codereview.chromium.org/1012583002/ A step towards AnimationPlayer/AnimationTimeline decoupling. BUG=394777 R=ajuma@chromium.org R=vollick@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1009233002 Cr-Commit-Position: refs/heads/master@{#337751}
* cc: Make ScrollOffsetAnimationCurve::UpdateTarget better handle large velocityajuma2015-07-072-5/+35
| | | | | | | | | | | | | | | | | | | When ScrollOffsetAnimationCurve::UpdateTarget computes a new initial velocity, it doesn't address the possibility that this velocity will be large enough to trigger Inf or NaN when used elsewhere. However, given infinite precision math, increasing the velocity above 1000 has little effect on the cubic bezier curve used for the animation. This CL makes ScrollOffsetAnimationCurve no longer perform computations using large velocities; instead, we set the parameters of the cubic bezier curver directly to the values they approach as velocity approaches infinity. BUG=507252 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1215713017 Cr-Commit-Position: refs/heads/master@{#337668}
* Fix unused variables errors in cc/.mlamouri2015-07-064-22/+14
| | | | | | | | | | | This needed in order to use "= delete" for DISALLOW_COPY_AND_ASSIGN. BUG=447445 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1222243005 Cr-Commit-Position: refs/heads/master@{#337484}
* CC Animations: Redirect all compositor animation requests to AnimationHost.loyso2015-07-032-0/+223
| | | | | | | | | | | | | | | | | | | | | 1) Use AnimationHost's AnimationRegistrar instance if new system enabled. 2) Use AnimationPlayer's LayerAnimationController instance if new system enabled. Previous episode: https://codereview.chromium.org/947033002/ Next episode: https://codereview.chromium.org/1009233002/ In general: The compositor should not need to worry about servicing animations. A step towards AnimationHost/AnimationPlayer/AnimationTimeline decoupling. BUG=394777 R=ajuma@chromium.org R=vollick@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1010663002 Cr-Commit-Position: refs/heads/master@{#337309}
* CC Animations: Establish AnimationHost, AnimationTimeline and AnimationPlayer.loyso2015-07-0314-0/+1907
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The compositor should not need to worry about servicing animations. Instead, it should be able to request property updates as needed from external mutators. - We setup CC representations for blink::AnimationPlayer and blink::AnimationTimeline. - We want to move all the animation-related code from LayerTreeHost to AnimationHost. - We move LayerAnimatedController ownership to cc::AnimationPlayer. - We move AnimationRegistrar ownership to cc::AnimationHost. - We add/remove animations to cc::AnimationPlayer from now. - LayerAnimatedController to be merged into cc::AnimaitonPlayer. - AnimationRegistrar to be merged into cc::AnimationHost/cc::AnimationTimeline. A chromium part. Blink part: https://codereview.chromium.org/946323002 Next episode: https://codereview.chromium.org/1010663002/ BUG=394777 R=dstockwell@chromium.org R=shane@chromium.org R=ajuma@chromium.org R=vollick@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/947033002 Cr-Commit-Position: refs/heads/master@{#337266}
* Fix for bug where composited rotate3d should SLERP instead of interpolating ↵soonm2015-06-293-6/+41
| | | | | | | | | | | | | the axes and angles numerically. This aligns with the behavior specified in the specs : http://dev.w3.org/csswg/css-transforms/#interpolation-of-transform-functions BUG=500797 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1194073007 Cr-Commit-Position: refs/heads/master@{#336520}
* Fix assumptions made in LAC::MarkAnimationsForDeletionvollick2015-06-193-8/+29
| | | | | | | | | | | | | | | | | | lof84 correctly noticed that this function was using broken logic to determine if we were on the impl thread (i.e., a non-null events vector). This got broken in my cl https://codereview.chromium.org/1088773003, which collects events on the main thread as well. The test in this CL was taken directly from lof84's original patch: http://crrev.com/1154323011 BUG=None CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1151763011 Cr-Commit-Position: refs/heads/master@{#335262}
* Matrix decomposition for mismatched functions in keyframesbehara.ms2015-06-192-53/+65
| | | | | | | | | | | | | | | | | | | | According to css specifications If the ‘from’ and ‘to’ transforms don't have same corresponding functions in each transform list. The transform function lists are each converted into the equivalent matrix value and animation proceeds using matrix decomposition. http://www.w3.org/TR/2011/WD-css3-2d-transforms-20111215/#animation This makes chrome behave same as Firefox and Safari. BUG=412229 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1170953002 Cr-Commit-Position: refs/heads/master@{#335221}
* Fix animation start event to have specified start time if settserng2015-06-182-3/+102
| | | | | | | | | | | | | | | | | | | When starting animations, use the specified start time of the animation as the start time if it is set. Otherwise, continue to use the current time. LayerAnimationController would originally set the time of the start event to the current time even if the animation had a specified start time. This would result in the AnimationDelegate and any LayerAnimationEventObserver from getting an incorrect start time. BUG=498404 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1169243002 Cr-Commit-Position: refs/heads/master@{#335128}
* Replace more ObserverList with base::ObserverList.brettw2015-06-031-2/+2
| | | | | | | | | | | | This is everything but the chrome directory CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=zelidrag@chromium.org (chromeos) TBR=keybuk@chromium.org (device/bluetooth) Review URL: https://codereview.chromium.org/1162943002 Cr-Commit-Position: refs/heads/master@{#332626}
* Move ObserverList to base namespace.brettw2015-06-021-6/+6
| | | | | | | | | | | | | Moves ObserverList and related classes to the base namespace. ObserverList[ThreadSafe] maintains a using statement to avoid having to update all users atomically. Users of ObserverListBase are updated in this patch. BUG= CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1152983004 Cr-Commit-Position: refs/heads/master@{#332347}
* cc: Fix size_t to int truncations in animation/ and debug/.vmpstr2015-06-021-12/+11
| | | | | | | | | | | | | This patch fixes size_t to int truncations in animation/ and debug/ directories in cc. R=danakj BUG=167187 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1156483007 Cr-Commit-Position: refs/heads/master@{#332278}
* cc: Make re-added animations get pushed to the compositor threadajuma2015-05-212-19/+20
| | | | | | | | | | | | | | | | | | | | When a layer with an animation is removed from the tree but later re-added (this can happen, for example, when an iframe containing an animation is set to display:none and later set back to display:block), the animation should continue. Currently, the animation is prevented from getting re-pushed to the compositor thread since it already has a start time. This logic used to be needed to prevent incorrectly re-pushing an animation that had already been deleted on the compositor thread, but is no longer needed for that purpose since we now always delete animations on the main thread before deleting them on the compositor thread. This CL removes this logic. BUG=409649 Review URL: https://codereview.chromium.org/1148333002 Cr-Commit-Position: refs/heads/master@{#330938}
* Animation start scale should be considered for the raster scalebehara.ms2015-05-057-0/+172
| | | | | | | | | | | | | | In zoom-in scenarios the start animation should be taken in to account to calculate raster scale else the first animation frame is rastered at a low raster scale which leads to blurred content. Added starting_animation_contents_scale to cc::DrawProperties BUG=422341 Review URL: https://codereview.chromium.org/1076313006 Cr-Commit-Position: refs/heads/master@{#328258}
* Pass gfx structs by const ref(gfx::Vector2D/F)a.berwal2015-04-301-2/+2
| | | | | | | | | | | | | | | | Pass gfx structs by const ref (gfx::Vector2d/F) Avoid unneccessary copy of structures gfx::Vector2d/F by passing them by const ref rather than value. Any struct of size > 4 bytes should be passed by const ref. Passing by ref for these structs is faster than passing by value, especially when invoking function has multiple parameters. Pass gfx structs by const ref (gfx::Vector2d/F) BUG=159273 Review URL: https://codereview.chromium.org/1115653002 Cr-Commit-Position: refs/heads/master@{#327659}
* cc: Move worker threads to RenderThreadImpl.reveman2015-03-232-2/+6
| | | | | | | | | | | | This allows us to Join the threads when RenderThreadImpl is shutdown. BUG=468785 TEST=cc_unittests Review URL: https://codereview.chromium.org/999173004 Cr-Commit-Position: refs/heads/master@{#321836}
* base: Stop passing a non-const ref to ObserverListBase::Iterator.danakj2015-03-091-6/+6
| | | | | | | | | | | | Pass a pointer instead, as per the style guide. Also makes the constructor explicit (all callsites already are explicit). BUG=464816 TBR=blundell@chromium.org,agl,dmichael,garykac Review URL: https://codereview.chromium.org/982413002 Cr-Commit-Position: refs/heads/master@{#319674}
* CC Animations: Move all the passes over controllers to AnimationRegistrarloyso2015-03-063-17/+111
| | | | | | | | | | | | | | | | | | | | | | | | | | Move as much functionality as possible from cc::LayerTreeHost and cc::LayerTreeHostImpl to cc::AnimationRegistrar. This includes all the passes over the list of all/active LayerAnimationControllers: LayerTreeHost::AnimateLayers LayerTreeHostImpl::UpdateAnimationState LayerTreeHostImpl::ActivateAnimations In general: The compositor should not need to worry about servicing animations. Instead, it should be able to request property updates as needed from external mutators. BUG=394777 R=dstockwell@chromium.org R=shane@chromium.org R=ajuma@chromium.org R=vollick@chromium.org Review URL: https://codereview.chromium.org/968423002 Cr-Commit-Position: refs/heads/master@{#319404}
* cc: Make scrollbar animations not require traversing the layer tree.sunnyps2015-02-258-86/+128
| | | | | | Review URL: https://codereview.chromium.org/956453002 Cr-Commit-Position: refs/heads/master@{#317933}
* Fix Enum Style Throughout CC.ericrk2015-02-2014-577/+527
| | | | | | | | | | | | | | | | | | | | | | | | | | | Currently CC does not always follow the chromium C++ style guidelines, sometimes using: enum EnumName { EnumNameValue1, EnumNameValue2, ... etc ... }; This change converts these enums to use: enum EnumName { ENUM_NAME_VALUE_1, ENUM_NAME_VALUE_2, ... etc ... }; This change also converts a few enums from using a NUM_ELEMENTS value to using a LAST_ELEMENT value, which works better with switch statements. R=danakj@chromium.org Review URL: https://codereview.chromium.org/935213002 Cr-Commit-Position: refs/heads/master@{#317211}
* Mechanical rename of tracing includes for /ccprimiano2015-01-281-1/+1
| | | | | | | | | | | | This is just a mechanical rename of tracing includes. See crrev.com/837303004 and the related bug for motivations. BUG=451032 TBR=nduca@chromium.org Review URL: https://codereview.chromium.org/885543002 Cr-Commit-Position: refs/heads/master@{#313442}
* cc: Make LayerAnimationController keep state for clearing scroll deltaajuma2015-01-224-26/+90
| | | | | | | | | | | | | | | When a scroll offset animation is removed, the corresponding LayerImpl's scroll delta needs to be cleared at activation. This CL moves the state tracking whether such clearing is needed from LayerImpl to LayerAnimationController, since this behavior is intended to be specific to this use case rather than providing a general way to clear scroll deltas. BUG=243871 Review URL: https://codereview.chromium.org/864003002 Cr-Commit-Position: refs/heads/master@{#312609}
* CC Animation: Use unique animation IDs to sync main and impl threads.loyso2015-01-215-246/+187
| | | | | | | | | | | | | | | | | | | We previously used the combination of group id and target property to uniquely identify animations. Now we are treating animation id as a unique identifier for real. This is a first step towards multiple compositor animations per property. In fact, we already use Animation IDs in all the higher-level-systems as if they were unique. BUG=358832 R=ajuma@chromium.org R=dstockwell@chromium.org R=vollick@chromium.org Review URL: https://codereview.chromium.org/853423002 Cr-Commit-Position: refs/heads/master@{#312382}
* cc: Fix scroll offset after scroll animation is canceledajuma2015-01-164-11/+69
| | | | | | | | | | | | | | | | | | | When a scroll offset animation is removed by the main thread and a new scroll position is set, this new position should propagate to the pending tree on commit, and then to the active tree on activation. However, the removed animation continues running on the compositor thread until activation, producing a scroll delta. Currently, this scroll delta gets added to the new scroll position (on both threads). This CL prevents the scroll delta produced by a removed animation from being added to the new post-animation scroll position. BUG=243871 Review URL: https://codereview.chromium.org/845543007 Cr-Commit-Position: refs/heads/master@{#311895}
* CC: Allow cubic-bezier timing inputs outside the range [0, 1]loyso2015-01-091-0/+62
| | | | | | | | | | | | | | | | | A chromium part. Blink part: https://codereview.chromium.org/787353003 Support this blink change https://codereview.chromium.org/238573002 but on the compositor side. BUG=445507 R=dstockwell@chromium.org R=ajuma@chromium.org TEST=ManualTests/animation/compositor-animation-steps.html Review URL: https://codereview.chromium.org/833093002 Cr-Commit-Position: refs/heads/master@{#310671}
* Fix forward declarationslof842014-12-233-3/+12
| | | | | | | | | | Fix forward declarations in cc/animation/ R=vollick@chromium.org Review URL: https://codereview.chromium.org/826453002 Cr-Commit-Position: refs/heads/master@{#309570}
* Standardize usage of virtual/override/final specifiers in cc/.dcheng2014-12-232-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. Several formatting edits by clang-format were manually reverted, due to mangling of some of the more complicate IPC macros. BUG=417463 Review URL: https://codereview.chromium.org/818033004 Cr-Commit-Position: refs/heads/master@{#309520}
* Move RenderSurface creation outside of CalcDrawPropsawoloszyn2014-12-227-0/+53
| | | | | | | | BUG=386788 Review URL: https://codereview.chromium.org/465853004 Cr-Commit-Position: refs/heads/master@{#309428}
* Define step timing function for the cc animation framework.loyso2014-12-223-0/+155
| | | | | | | | | | | | | This is a chromium-side part. BUG=441006 R=dstockwell@chromium.org R=ajuma@chromium.org TEST=ManualTests/animation/compositor-animation-steps.html Review URL: https://codereview.chromium.org/809523004 Cr-Commit-Position: refs/heads/master@{#309399}
* replace COMPILE_ASSERT with static_assert in cc/mostynb2014-12-201-6/+8
| | | | | | | | BUG=442514 Review URL: https://codereview.chromium.org/804373004 Cr-Commit-Position: refs/heads/master@{#309309}
* Use EXPECT_EQ when possible.hush2014-12-042-9/+9
| | | | | | | | | | | EXPECT_RECT_EQ, EXPECT_SIZE_EQ, EXPECT_POINT_EQ, EXPECT_POINT3F_EQ could be replaced by EXPECT_EQ. Follow up of https://codereview.chromium.org/751453005/ Review URL: https://codereview.chromium.org/774763004 Cr-Commit-Position: refs/heads/master@{#306913}
* Make Keyframe use TimeTicks/TimeDelta to represent time instead of double.behara.ms2014-11-189-367/+503
| | | | | | | | BUG=178171 Review URL: https://codereview.chromium.org/719453007 Cr-Commit-Position: refs/heads/master@{#304612}
* Make cc::Animation::TrimTimeToCurrentIteration andbehara.ms2014-11-1211-378/+676
| | | | | | | | | | | | | cc::AnimationCurve::Duration use TimeTicks/TimeDelta to represent time. This patch adds a new file time_util.h which adds new class TimeUtil. This TimeUtil class holds helper functions to operate on TimeDelta in double because base::TimeDelta class doesnot allow multiply/divide operations in double. Review URL: https://codereview.chromium.org/693883004 Cr-Commit-Position: refs/heads/master@{#303790}
* Moving background animation ticking from LayerTreeHostImpl into the Scheduler.mithro2014-11-101-1/+5
| | | | | | | | | | | | | | | | Background ticking currently happens in the LayerTreeHostImpl, this makes it very hard to preserve the monotonicity guarantee needed by frame times. http://crrev.com/267783004 set up the scheduler to become the source of background ticks and this CL makes use of that functionality. BUG=345459 Committed: https://crrev.com/4df3c4366015739a7c6b6c1539a8d7c9198e38ef Cr-Commit-Position: refs/heads/master@{#302757} Committed: https://crrev.com/185438b3e5e3f43ce2996da0022f510fbe193a6e Cr-Commit-Position: refs/heads/master@{#303423} Review URL: https://codereview.chromium.org/595973002 Cr-Commit-Position: refs/heads/master@{#303467}
* cc cleanup: Update paths to geometry headersheejin.r.chung2014-10-238-9/+9
| | | | | | | | | | | Geometry headers were moved from /ui/gfx/ to ui/gfx/geometry. Updating includes accordingly. BUG=395370 Review URL: https://codereview.chromium.org/660333004 Cr-Commit-Position: refs/heads/master@{#300902}
* Cleanup: Update paths to vector3d_f.h includes.tfarina2014-10-233-3/+3
| | | | | | | | | | BUG=395370 TEST=None TBR=ben@chromium.org,danakj@chromium.org Review URL: https://codereview.chromium.org/674733002 Cr-Commit-Position: refs/heads/master@{#300832}
* Standardize usage of virtual/override/final in cc/dcheng2014-10-219-68/+65
| | | | | | | | | BUG=417463 TBR=enne@chromium.org Review URL: https://codereview.chromium.org/645853008 Cr-Commit-Position: refs/heads/master@{#300439}
* cc: Remove main-thread tracing of animationsdstockwell2014-10-161-5/+4
| | | | | | | | | | As of http://crrev.com/638313002 this is now handled in Blink. BUG=351446 Review URL: https://codereview.chromium.org/641903003 Cr-Commit-Position: refs/heads/master@{#300004}
* Make a bunch of structs anonymous ...viettrungluu2014-10-161-103/+81
| | | | | | | | | | | | | | | | | ... instead of naming them just so that arraysize can be used (instead of ARRAYSIZE_UNSAFE), since C++11 removes this restriction. Also remove some comments about this. (Note that the change was automatically formatted, as required by the presubmit check. Arguably, the entire file should be reformatted for consistency, but that should be done separately.) R=ajuma@chromium.org BUG=423134 Review URL: https://codereview.chromium.org/660103002 Cr-Commit-Position: refs/heads/master@{#299989}
* cc: Plumb group id through animation creation and start/finish notificationsdstockwell2014-10-163-14/+16
| | | | | | | | | | | | | | This is required for Blink to track the synchronized starting of groups of animations. Blink side plumbing: https://codereview.chromium.org/652593003 Blink usage: https://codereview.chromium.org/651103002 BUG=423265 Review URL: https://codereview.chromium.org/653563003 Cr-Commit-Position: refs/heads/master@{#299979}
* Fix CanScrollOrientation method name.timav2014-10-162-2/+2
| | | | | | | | | | | | | Change the method name from can_scroll_orientation() to CanScrollOrienattion() to comply with the style guide. This is a follow up to https://codereview.chromium.org/655783004 BUG=370892 Review URL: https://codereview.chromium.org/637283004 Cr-Commit-Position: refs/heads/master@{#299803}
* cc: Change scoped_ptr<T>() to nullptr.danakj2014-10-152-192/+96
| | | | | | | | R=enne Review URL: https://codereview.chromium.org/657103003 Cr-Commit-Position: refs/heads/master@{#299782}
* Hide scrollbars when their dimensions are not scrollable.timav2014-10-154-6/+180
| | | | | | | | | | | | | | Make scrollbars disappear by setting their opacity to 0 (i.e. making them completely transparent) when they cannot be scrolled. This CL has been reviewed on https://codereview.chromium.org/640063002/ BUG=370892 Review URL: https://codereview.chromium.org/655783004 Cr-Commit-Position: refs/heads/master@{#299628}
* CC: Fix issue for animations with fill and iteration start specifiedsamli2014-10-152-3/+6
| | | | | | | | | | | | | | | Animations with both or backwards fill mode specified along with a fractional iteration start would result in the compositor placing the element in an incorrect position before the animation has started. When computing the trimmed time/iteration time of an animation that has not yet started, the fractional iteration start is taken into account. BUG=423202 Review URL: https://codereview.chromium.org/652813003 Cr-Commit-Position: refs/heads/master@{#299626}
* CC: Fix issue where the compositor applies unnecessary updatessamli2014-10-142-0/+47
| | | | | | | | | | | | A composited animation with a start delay (time offset) and no backwards fill mode specified should have no visible style changes until the animation reaches the active phase. BUG=422300 Review URL: https://codereview.chromium.org/638953003 Cr-Commit-Position: refs/heads/master@{#299568}
generated by cgit v1.1 at 2024-09-15 00:50:59 +0000