| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Any struct of size > 4 bytes should be passed by const ref.
Passing by ref for these structs is faster than passing by value,
especially when invoking function has multiple parameters and some
other scenarios mentioned in the bug.
BUG=159273
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247426
Review URL: https://codereview.chromium.org/145313006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/145313006/)
Reason for revert:
Suspected of breaking the Linux ASAN tests ( http://build.chromium.org/p/chromium.memory/builders/Linux%20ASAN%20Tests%20%283%29/builds/22104 )
Original issue's description:
> [#7] Pass gfx::Size by const ref.
>
> Any struct of size > 4 bytes should be passed by const ref.
> Passing by ref for these structs is faster than passing by value,
> especially when invoking function has multiple parameters and some
> other scenarios mentioned in the bug.
>
> BUG=159273
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247426
TBR=danakj@chromium.org,enne@chromium.org,bulach@chromium.org,piman@chromium.org,prashant.n@samsung.com
NOTREECHECKS=true
NOTRY=true
BUG=159273
Review URL: https://codereview.chromium.org/142863008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Any struct of size > 4 bytes should be passed by const ref.
Passing by ref for these structs is faster than passing by value,
especially when invoking function has multiple parameters and some
other scenarios mentioned in the bug.
BUG=159273
Review URL: https://codereview.chromium.org/145313006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247426 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There used to be a separate channel for plumbing back a layer's debug name. The
debug info object is more general, and we can just send the debug name through
it. This patch depends on https://codereview.chromium.org/135473002/
R=jamesr@chromium.org
BUG=None
Review URL: https://codereview.chromium.org/135493002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Layer name is useful for web developer to identify different layers. Layer name is pulled from blink. There is a blink side patch provides debugName() API in GraphicsLayer.
BUG=269258
Review URL: https://chromiumcodereview.appspot.com/16903005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We were computing the huds bounds in Update() and then expecting
to push a correct content_bounds based on those bounds. However
content_bounds are computed in CalcDrawProps which happens before
Update, so we are actually pushing the content_bounds based on
the previous frame's bounds.
This means that if we don't push properties again for the hud
layer due to early outs, we have the wrong bounds on the impl
side forever.
Compute the bounds in CalculateContentsScale instead of Update,
which is during CalcDrawProps, and will have the right
content_bounds for the frame as a result.
R=enne
BUG=261506
Review URL: https://chromiumcodereview.appspot.com/19471010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As part of an optimization to prevent needless commits, add a return
value from Update to say whether or not any resources were updated as a
part of the call. Other layer property updates (bounds changes, etc)
that happen during Update are covered through the normal SetNeedsCommit
mechanism.
This will allow a future patch to make
SetNeedsDisplay/SetScrollOffsetFromImplThread only cause an update but
not necessarily cause a commit.
R=danakj@chromium.org
BUG=256381
Review URL: https://chromiumcodereview.appspot.com/18454003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change fixes the Hudlayer's resolution on high-DPI screens and
refactors scaling of debug rects and widgets.
BUG=256286
Review URL: https://chromiumcodereview.appspot.com/18348006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210185 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
depends on: https://codereview.chromium.org/13245007/
and: https://codereview.chromium.org/13132005/
BUG=181319
Review URL: https://chromiumcodereview.appspot.com/13258003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Looks like its DCHECKing on Win Aura interactive_ui_tests again. Same
error as before.
http://build.chromium.org/p/chromium.win/buildstatus?builder=Win%20Aura%20Tests%20%283%29&number=2148
> cc: Switch RenderingStats collection in Layer::Update() to RenderingStatsInstrumentation
>
> This change switches all of the remaining RenderingStats collection in
> composited mode to use RenderinStatsInstrumentation.
>
> BUG=181319
>
>
> Review URL: https://chromiumcodereview.appspot.com/12426024
TBR=egraether@chromium.org
Review URL: https://codereview.chromium.org/13145002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
RenderingStatsInstrumentation
This change switches all of the remaining RenderingStats collection in
composited mode to use RenderinStatsInstrumentation.
BUG=181319
Review URL: https://chromiumcodereview.appspot.com/12426024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also DISALLOW_IMPLICIT_CONSTRUCTORS in a few places instead.
NOTRY=true
R=jamesr
Review URL: https://chromiumcodereview.appspot.com/13065006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> cc: Switch RenderingStats collection in Layer::Update() to RenderingStatsInstrumentation
>
> This change switches all of the remaining RenderingStats collection in
> composited mode to use RenderinStatsInstrumentation.
>
> BUG=181319
>
>
> Review URL: https://chromiumcodereview.appspot.com/12426024
TBR=egraether@chromium.org
Review URL: https://codereview.chromium.org/13117002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190826 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
RenderingStatsInstrumentation
This change switches all of the remaining RenderingStats collection in
composited mode to use RenderinStatsInstrumentation.
BUG=181319
Review URL: https://chromiumcodereview.appspot.com/12426024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
Continuation of https://src.chromium.org/viewvc/chrome?view=rev&revision=188681
BUG=190824
TBR=enne@chromium.org, piman@chromium.org, jschuh@chromium.org, joth@chromium.org
Review URL: https://codereview.chromium.org/12916002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188703 0039d316-1c4b-4281-b951-d872f2087c98
|