| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=523040
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1296673004
Cr-Commit-Position: refs/heads/master@{#348763}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #1 id:1 of https://codereview.chromium.org/1047013002/)
Reason for revert:
Not a culprit. Bring it back.
Original issue's description:
> Revert of Fix text clipping in CompositorFrameTime Display (patchset #2 id:20001 of https://codereview.chromium.org/1027393004/)
>
> Reason for revert:
> Speculative revert for Blink layout test failures in WebKit Mac10.8 (retina):
> https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.8%20%28retina%29/builds/27696
>
> Original issue's description:
> > Fix text clipping in CompositorFrameTime Display
> >
> > Because different OS have different fonts for HUD.
> > Set the width of CompositorFrameTime Display to be maximum
> > of graph width and text width to prevent text clipping.
> >
> > BUG=445877
> >
> > Committed: https://crrev.com/88b4cf8d33b499f972e1c447e741230170beeb8d
> > Cr-Commit-Position: refs/heads/master@{#322807}
>
> TBR=danakj@chromium.org,behara.ms@samsung.com
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=445877
>
> Committed: https://crrev.com/933b39f06e409d623eb4dbc4da692ae41460372e
> Cr-Commit-Position: refs/heads/master@{#322858}
TBR=danakj@chromium.org,behara.ms@samsung.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=445877
Review URL: https://codereview.chromium.org/1043023002
Cr-Commit-Position: refs/heads/master@{#322908}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
id:20001 of https://codereview.chromium.org/1027393004/)
Reason for revert:
Speculative revert for Blink layout test failures in WebKit Mac10.8 (retina):
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.8%20%28retina%29/builds/27696
Original issue's description:
> Fix text clipping in CompositorFrameTime Display
>
> Because different OS have different fonts for HUD.
> Set the width of CompositorFrameTime Display to be maximum
> of graph width and text width to prevent text clipping.
>
> BUG=445877
>
> Committed: https://crrev.com/88b4cf8d33b499f972e1c447e741230170beeb8d
> Cr-Commit-Position: refs/heads/master@{#322807}
TBR=danakj@chromium.org,behara.ms@samsung.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=445877
Review URL: https://codereview.chromium.org/1047013002
Cr-Commit-Position: refs/heads/master@{#322858}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Because different OS have different fonts for HUD.
Set the width of CompositorFrameTime Display to be maximum
of graph width and text width to prevent text clipping.
BUG=445877
Review URL: https://codereview.chromium.org/1027393004
Cr-Commit-Position: refs/heads/master@{#322807}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch changes the way we get damage for a layer to instead use
the layer itself to compute content bounds in target space.
BUG=463424
R=danakj, enne
Review URL: https://codereview.chromium.org/1015433002
Cr-Commit-Position: refs/heads/master@{#321041}
|
|
|
|
|
|
|
|
|
|
|
| |
Part 1 of reland of https://codereview.chromium.org/900063002.
R=danakj@chromium.org
BUG=453731,455104,457248
Review URL: https://codereview.chromium.org/950923002
Cr-Commit-Position: refs/heads/master@{#317675}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #9 id:350001 of https://codereview.chromium.org/900063002/)
Reason for revert:
Causes regression in cold start on Android and maybe Mac.
Details in http://crbug.com/457248.
Original issue's description:
> Fixes for two different HUD issues related to win32k lockdown
>
> 1. Using a GDI bitmap -- switch to SkSurface instead
>
> 2. Lazily loading a font. This breaks for two different reasons.
> The first is a DCHECK for doing IO on the Compositor thread. This
> could have been just ignored in general since it's only for debug
> usage, the drawbacks of minor jank are limited.
>
> However, once lockdown is on, the font load hard fails from the
> renderer. So, load the typeface before lockdown and pass it into
> CC and the hud via LayerTreeSettings.
>
> R=danakj@chromium.org
> BUG=453731,455104
> TEST=run chrome with --enable-win32k-renderer-lockdown --show-fps-counter --ui-show-fps-counter on Win8
>
> Committed: https://crrev.com/616a8e656b2d923ed393bde86adc150e555ba799
> Cr-Commit-Position: refs/heads/master@{#314929}
TBR=enne@chromium.org,danakj@chromium.org,piman@chromium.org
BUG=453731,455104,457248
Review URL: https://codereview.chromium.org/922293006
Cr-Commit-Position: refs/heads/master@{#317648}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The occlusion is a draw property, the layer can access it from there
like other draw properties.
Cleanup CL since moving occlusion to draw properties. Too many
AppendQuads overrides... :(
R=enne
BUG=446751
NOTRY=true
Review URL: https://codereview.chromium.org/927783002
Cr-Commit-Position: refs/heads/master@{#316358}
|
|
|
|
|
|
|
|
|
|
| |
The HUD layer can just get its scale from the compositor thread rather
than the main thread. This change makes it possible to remove content
scale calculations off of the main thread once TiledLayer is removed.
Review URL: https://codereview.chromium.org/913243003
Cr-Commit-Position: refs/heads/master@{#316248}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the last stage of the trace_event directory restructuring.
This is part of a set of 3 CLs which is moving tracing clients to use
the new base::trace_debug namespace.
See crrev.com/837303004 and the related bug for motivations.
BUG=451032
TBR=nduca@chromium.org
Review URL: https://codereview.chromium.org/879913002
Cr-Commit-Position: refs/heads/master@{#315335}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Using a GDI bitmap -- switch to SkSurface instead
2. Lazily loading a font. This breaks for two different reasons.
The first is a DCHECK for doing IO on the Compositor thread. This
could have been just ignored in general since it's only for debug
usage, the drawbacks of minor jank are limited.
However, once lockdown is on, the font load hard fails from the
renderer. So, load the typeface before lockdown and pass it into
CC and the hud via LayerTreeSettings.
R=danakj@chromium.org
BUG=453731,455104
TEST=run chrome with --enable-win32k-renderer-lockdown --show-fps-counter --ui-show-fps-counter on Win8
Review URL: https://codereview.chromium.org/900063002
Cr-Commit-Position: refs/heads/master@{#314929}
|
|
|
|
|
|
|
|
|
|
|
|
| |
LayerTreeHost determines the status, passes it to LayerTreeHostImpl.
HUD adds the new line of text before the memory usage.
BUG=434613
Review URL: https://codereview.chromium.org/774943005
Cr-Commit-Position: refs/heads/master@{#306713}
|
|
|
|
|
|
|
|
|
| |
BUG=417463
TBR=enne@chromium.org
Review URL: https://codereview.chromium.org/645853008
Cr-Commit-Position: refs/heads/master@{#300439}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch updates LayerImpls to accept Occlusion into AppendQuads
instead of OcclusionTracker. This makes it possible for the layer
to retain a local copy for whatever reason, and restricts the code
from modifying occlusion information in unexpected ways.
R=danakj
Review URL: https://codereview.chromium.org/633773004
Cr-Commit-Position: refs/heads/master@{#298556}
|
|
|
|
|
|
|
|
| |
BUG=417463
Review URL: https://codereview.chromium.org/628443002
Cr-Commit-Position: refs/heads/master@{#298271}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Current HeadUpDisplayLayerImpl allocates one resource
and reuse it continuously. This patch is trying to
allocate two resources and swap one of them
which is available.
so HeadUpDisplayLayerImpl does not need free the resource
while the layer is alive.
Bug=None
Review URL: https://codereview.chromium.org/491783003
Cr-Commit-Position: refs/heads/master@{#292690}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new classes allow building JSON-like structural arguments. Current implementation uses base::Value as backing store but that can be replaced in the future with something more efficient without changing client code.
All clients of cc/debug/traced_value.h should eventually switch to use the new builders.
BUG=361045
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286849
R=alph@chromium.org, dsinclair@chromium.org, nduca@chromium.org, willchan@chromium.org
Review URL: https://codereview.chromium.org/380763002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/380763002/)
Reason for revert:
linux ASAN errors.
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/4493/steps/base_unittests/logs/stdio
Original issue's description:
> Add builders for tracing event's structural arguments
>
> The new classes allow building JSON-like structural arguments. Current implementation uses base::Value as backing store but that can be replaced in the future with something more efficient without changing client code.
>
> All clients of cc/debug/traced_value.h should eventually switch to use the new builders.
>
> BUG=361045
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286849
TBR=alph, caseq, dsinclair, nduca, willchan, yurys
NOTREECHECKS=true
NOTRY=true
BUG=361045
Review URL: https://codereview.chromium.org/421183003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new classes allow building JSON-like structural arguments. Current implementation uses base::Value as backing store but that can be replaced in the future with something more efficient without changing client code.
All clients of cc/debug/traced_value.h should eventually switch to use the new builders.
BUG=361045
Review URL: https://codereview.chromium.org/380763002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since QuadSink does not provide more functionatility than passing
through to RenderPass and OcclusionTracker, it can be torn down and
removed. Same is for MockQuadCuller.
This CL follows 302603006, 306683002, 309493002.
BUG=344962
TEST=cc_unittests
Review URL: https://codereview.chromium.org/308193003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/187343007
Review URL: https://codereview.chromium.org/187343007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the HUD is on, and partial swaps are enabled, the damage rects
emitted by the renderer do not include the HUD, so the HUD is not
updated correctly on screen.
Previously we disabled partial swap in the renderer compositor to
force the hud to display, but in ubercomp, partial swap is never
used in the renderer, and the damage rect is given to the browser
instead. So we need to update the renderer's damage rect in this
case.
R=enne@chromium.org, piman@chromium.org, caseq, enne
BUG=350495
Review URL: https://codereview.chromium.org/191433002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make them all use one shade of green to avoid excessive flickery.
This effectivale reverts r251953 ( https://codereview.chromium.org/121223002), though the single paint color is still green.
We plan to eventually change to green that fades with time after last paint.
BUG=324535
Review URL: https://codereview.chromium.org/172123002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/121223002
BUG=324535
Review URL: https://codereview.chromium.org/121223002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251053 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There used to be a separate channel for plumbing back a layer's debug name. The
debug info object is more general, and we can just send the debug name through
it. This patch depends on https://codereview.chromium.org/135473002/
R=jamesr@chromium.org
BUG=None
Review URL: https://codereview.chromium.org/135493002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For Android Webview using deferred gl initialization, calling this
method does not indicate an error and does not necessarily mean the
OutputSurface is lost.
Purely mechanical change.
BUG=
Review URL: https://codereview.chromium.org/132683003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently will NPE in HeadsUpDisplayLayerImpl::UpdateHudTexture
immediately after a DidLoseOutputSurface call that throws away the
resource. Resource loss can happen quite frequently under normal usage
in Android WebView.
Also fixed a condition WillDraw as writing the test for issue above.
Fix for internal bug b/11164012.
TEST=HeadsUpDisplayLayerImplTest.UpdateAfterResourceLoss
BUG=
Review URL: https://codereview.chromium.org/26277008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=254986
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/18120002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CC currently has three (3) ways to dump layers: LayerTreeAsText,
LayerTreeAsJSON, and AsValue.
LayerTreeAsText is the least useful due to the fact that if you have
more than a few layers it falls off the bottom of the screen. Its layer
printing abilities have been entirely replaced (in my opinion) with
TraceViewer's ability to capture frames.
R=nduca@chromium.org
BUG=none
Review URL: https://chromiumcodereview.appspot.com/17351009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207596 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Only draw PictureLayer, SolidColorLayer, and ScrollbarLayer
if using solid color scrollbars.
Changes contract of LayerImpl WillDraw/AppendQuads/DidDraw.
Now WillDraw returns a bool, and AppendQuads/DidDraw will be
skipped if it returns false.
BUG=245047
Review URL: https://chromiumcodereview.appspot.com/16211002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203637 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Unless they choose to opt out.
The VideoResourceUpdater was deleting resources when the ResourceProvider
shut down, which was not ideal. Instead, it deletes them when
it shuts down itself (before the ResourceProvider). This works
out fine, since anyone else using it will be using it through a
mailbox.
DelegatingRenderer needs to use and export the resources in the
quads it is given inside of DrawFrame() as they may be deleted
afterward, instead of waiting until SwapBuffers().
Depends on: https://codereview.chromium.org/14960006/
TEST=cc_unittests
R=jamesr, piman
BUG=123444
Review URL: https://chromiumcodereview.appspot.com/14925009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199496 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This has resolved itself and doesn't need to be done anymore to
avoid DCHECKs. Now we call SetPixels() every frame before we draw
the layer, so it is always initialized.
TBR=epenner
BUG=166784
Review URL: https://chromiumcodereview.appspot.com/13281002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes lint errors in everything except for the few stragglers (occlusion unit test, etc) that haven't been chromified.
BUG=144577
Review URL: https://chromiumcodereview.appspot.com/12965007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
Continuation of https://src.chromium.org/viewvc/chrome?view=rev&revision=188681
BUG=190824
TBR=enne@chromium.org, piman@chromium.org, jschuh@chromium.org, joth@chromium.org
Review URL: https://codereview.chromium.org/12916002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188703 0039d316-1c4b-4281-b951-d872f2087c98
|