summaryrefslogtreecommitdiffstats
path: root/cc/resources/prioritized_resource.cc
Commit message (Collapse)AuthorAgeFilesLines
* cc: Change #if !defined(NDEBUG) to #if DCHECK_IS_ON.danakj@chromium.org2014-03-181-4/+5
| | | | | | | | | | | | | | | | | | Some places in cc enabled DCHECK code only when in a debug build since they added member variables to classes in order to perform their checks, and we could not check for DCHECK at compile time. Since we can now, we can guard these DCHECKS with DCHECK_IS_ON. Yay! DCHECK_IS_ON is always defined by base/logging.h. It is set to 1 when DCHECKS are enabled, and 0 otherwise. R=enne BUG=350462 Review URL: https://codereview.chromium.org/201843005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257761 0039d316-1c4b-4281-b951-d872f2087c98
* Pass gfx structs by const ref (gfx::Vector2d)ajay.berwal@samsung.com2014-02-051-1/+1
| | | | | | | | | | | | | | | | | | Avoid unneccessary copy of structures gfx::Vector2d by passing them by const ref rather than value. Any struct of size > 4 bytes should be passed by const ref. Passing by ref for these structs is faster than passing by value, especially when invoking function has multiple parameters. Pass gfx structs by const ref (gfx::Vector2d) BUG=159273 Review URL: https://codereview.chromium.org/132163009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248941 0039d316-1c4b-4281-b951-d872f2087c98
* [#7] Pass gfx::Size by const ref.prashant.n@samsung.com2014-01-291-3/+4
| | | | | | | | | | | | | | | Any struct of size > 4 bytes should be passed by const ref. Passing by ref for these structs is faster than passing by value, especially when invoking function has multiple parameters and some other scenarios mentioned in the bug. BUG=159273 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247426 Review URL: https://codereview.chromium.org/145313006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247769 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of [#7] Pass gfx structs by const ref (gfx::Size) ↵mnissler@chromium.org2014-01-281-4/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/145313006/) Reason for revert: Suspected of breaking the Linux ASAN tests ( http://build.chromium.org/p/chromium.memory/builders/Linux%20ASAN%20Tests%20%283%29/builds/22104 ) Original issue's description: > [#7] Pass gfx::Size by const ref. > > Any struct of size > 4 bytes should be passed by const ref. > Passing by ref for these structs is faster than passing by value, > especially when invoking function has multiple parameters and some > other scenarios mentioned in the bug. > > BUG=159273 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247426 TBR=danakj@chromium.org,enne@chromium.org,bulach@chromium.org,piman@chromium.org,prashant.n@samsung.com NOTREECHECKS=true NOTRY=true BUG=159273 Review URL: https://codereview.chromium.org/142863008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247437 0039d316-1c4b-4281-b951-d872f2087c98
* [#7] Pass gfx::Size by const ref.prashant.n@samsung.com2014-01-281-3/+4
| | | | | | | | | | | | | Any struct of size > 4 bytes should be passed by const ref. Passing by ref for these structs is faster than passing by value, especially when invoking function has multiple parameters and some other scenarios mentioned in the bug. BUG=159273 Review URL: https://codereview.chromium.org/145313006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247426 0039d316-1c4b-4281-b951-d872f2087c98
* Pass gfx::Rect and gfx::RectF by const ref.prashant.n@samsung.com2014-01-101-2/+2
| | | | | | | | | | | | | | | | | Avoid unneccessary copy of structures gfx::Rect & gfx::RectF by passing them by const ref rather than value. Any struct of size > 4 bytes should be passed by const ref. Passing by ref for these structs is faster than passing by value, especially when invoking function has multiple parameters. Pass by value creates unneccessary overhead which should be avoided. BUG=159273 Review URL: https://codereview.chromium.org/93663004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244224 0039d316-1c4b-4281-b951-d872f2087c98
* More aggressively evict textures used by the parent compositor.ccameron@chromium.org2013-11-281-2/+2
| | | | | | | | | | | | | | | | | | | | | | Do not put textures that are in use by the parent compositor at the back of the eviction queue. Rather, put them in according to their priority, and use being in the parent compositor to break ties (preferring to evict resources in the parent compositor, because only once they are evicted is there a chance that they may be deleted). Rename CanBeRecycled to CanBeRecycledIfNotInExternalUse. This function was used in the sorting function, and CanBeRecycled is false for textures that are in the parent compositor. Can CanBeRecycled to not take into account the parent compositor, and rename the function accordingly. BUG=322299 Review URL: https://codereview.chromium.org/88913007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237748 0039d316-1c4b-4281-b951-d872f2087c98
* cc: Don't check IsLost for PrioritizedResources.danakj@chromium.org2013-10-271-2/+1
| | | | | | | | | | | | | | If a resource is lost, it's in the parent compositor forever, so deleting the resource will not free the data neccessarily, and we can never reuse the texture. Simplify things by just checking IsUseByConsumer() and not checking for !IsLost(). R=ccameron, piman BUG=292971 Review URL: https://codereview.chromium.org/44813005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231224 0039d316-1c4b-4281-b951-d872f2087c98
* cc: Sort backings in the parent compositor to the back of the list.danakj@chromium.org2013-10-261-2/+6
| | | | | | | | | | | | | | | | | | | Backings in the parent should not be preferred for eviction since deleting them in the renderer won't actually free any memory. So sort them to the back of the backings list, so they are evicted last. Also mark them as not CanBeRecycled() so that they will not be evicted at all if we are only evicting recyclable stuff. Tests: PrioritizedResourceTest.NotEvictingTexturesInParent R=ccameron@chromium.org, jbauman@chromium.org BUG=292971 Review URL: https://codereview.chromium.org/42483002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231202 0039d316-1c4b-4281-b951-d872f2087c98
* cc: Reland r233830. "Adding support for RGBA_4444 tile textures". r223830 ↵kaanb@chromium.org2013-09-191-8/+5
| | | | | | | | | | had a bug in async_pixel_transfer_manager_egl.cc that wasn't directly related to the 4444 support. This patch includes the rest of the files in r223830. Changes to async_pixel_transfer_manager_egl.cc have been moved to the separate patch after fixing the bug: https://codereview.chromium.org/23533067/ BUG=272539 Review URL: https://chromiumcodereview.appspot.com/23447048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224040 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Adding support for RGBA_4444 tile textures"tomhudson@google.com2013-09-181-5/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 8e6d15826280b9f11a28060b5b2d2bbef17d15bc (r223830; http://crrev.com/21159007). Although the 4444 textures work on S4, they break on N7v2 and N10. (We've got inconsistent reports about N4.) Passing --disable-4444-textures isn't sufficient to fix the problems. ilevy@ points out that the commit bot is using GN, so could easily have missed this breakage. We're hoping to switch to N4, but in this case there's no guarantee that that would have caught it either. Perhaps the main patch can be landed in pieces next time? From N7: E/chromium(32513): [ERROR:gles2_cmd_decoder.cc(5770)] [.RenderCompositor-0x783c9880]RENDER WARNING: texture bound to texture unit 0 is not renderable. It maybe non-power-of-2 and have incompatible texture filtering or is not 'texture complete' From N10: I/chromium( 2104): [INFO:CONSOLE(0)] "[.WebGLRenderingContext]RENDER WARNING: texture bound to texture unit 0 is not renderable. It maybe non-power-of-2 and have incompatible texture filtering or is not 'texture complete'", source: file:///sdcard/clanktemp/index.html (0) R=skyostil@chromium.org TBR=kaanb@chromium.org BUG=245774,272539 Review URL: https://codereview.chromium.org/24219002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223871 0039d316-1c4b-4281-b951-d872f2087c98
* Adding support for RGBA_4444 tile textureskaanb@chromium.org2013-09-181-8/+5
| | | | | | | | BUG=245774,272539 Review URL: https://chromiumcodereview.appspot.com/21159007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223830 0039d316-1c4b-4281-b951-d872f2087c98
* cc: Fix most cpplint errors in cc/enne@chromium.org2013-05-011-6/+5
| | | | | | | | | | | | There's still 5 more after this that need a closer eye, so will submit separately. R=danakj@chromium.org BUG=none Review URL: https://chromiumcodereview.appspot.com/14694005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197719 0039d316-1c4b-4281-b951-d872f2087c98
* cc: Fix build issues for adding ‘chromium_code’: 1 to cc.gyp and ↵danakj@chromium.org2013-03-291-2/+4
| | | | | | | | | | cc_tests.gyp The flag flip will be a follow up once ChromeOS build is sorted out. Review URL: https://codereview.chromium.org/13206004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191417 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 191400 "cc: Add ‘chromium_code’: 1 to cc.gyp and cc_t..."rsleevi@chromium.org2013-03-291-4/+2
| | | | | | | | | | | | | | | | | CrOS bots are unhappy > cc: Add ‘chromium_code’: 1 to cc.gyp and cc_tests.gyp > > And fix compile errors that it causes. > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191364 > > Review URL: https://codereview.chromium.org/13206004 TBR=danakj@chromium.org Review URL: https://codereview.chromium.org/13334005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191414 0039d316-1c4b-4281-b951-d872f2087c98
* cc: Add ‘chromium_code’: 1 to cc.gyp and cc_tests.gypdanakj@chromium.org2013-03-291-2/+4
| | | | | | | | | | And fix compile errors that it causes. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191364 Review URL: https://codereview.chromium.org/13206004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191400 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 191364 "cc: Add ‘chromium_code’: 1 to cc.gyp and cc_t..."danakj@chromium.org2013-03-291-4/+2
| | | | | | | | | | | | | > cc: Add ‘chromium_code’: 1 to cc.gyp and cc_tests.gyp > > And fix compile errors that it causes. > > Review URL: https://codereview.chromium.org/13206004 TBR=danakj@chromium.org Review URL: https://codereview.chromium.org/13316003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191371 0039d316-1c4b-4281-b951-d872f2087c98
* cc: Add ‘chromium_code’: 1 to cc.gyp and cc_tests.gypdanakj@chromium.org2013-03-291-2/+4
| | | | | | | | And fix compile errors that it causes. Review URL: https://codereview.chromium.org/13206004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191364 0039d316-1c4b-4281-b951-d872f2087c98
* cc: Inline simple PrioritizedResource::ResourceId() method.danakj@chromium.org2013-03-231-7/+1
| | | | | | | | | | | | Move this to the header and name it resource_id(). R=jamesr BUG= Review URL: https://chromiumcodereview.appspot.com/12594016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190083 0039d316-1c4b-4281-b951-d872f2087c98
* Chromify prioritized_resource_manager.* and prioritized_resource_unittest.cc.hartmanng@chromium.org2013-03-201-9/+9
| | | | | | | | | BUG=none Review URL: https://chromiumcodereview.appspot.com/12731010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189404 0039d316-1c4b-4281-b951-d872f2087c98
* cc: Chromify PrioritizedResourceenne@chromium.org2013-03-201-170/+166
| | | | | | | | | | R=danakj@chromium.org BUG=none Review URL: https://chromiumcodereview.appspot.com/12906008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189241 0039d316-1c4b-4281-b951-d872f2087c98
* Part 8 of cc/ directory shuffles: resourcesjamesr@chromium.org2013-03-181-0/+210
Continuation of https://src.chromium.org/viewvc/chrome?view=rev&revision=188681 BUG=190824 TBR=enne@chromium.org, piman@chromium.org, jschuh@chromium.org Review URL: https://codereview.chromium.org/12471007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188696 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-23 13:35:28 +0000