summaryrefslogtreecommitdiffstats
path: root/ceee/ie
Commit message (Collapse)AuthorAgeFilesLines
* Yet another attempt at landing ↵mad@google.com2010-12-054-3/+64
| | | | | | | | | | | | http://src.chromium.org/viewvc/chrome?view=rev&revision=68298 : "Make sure we don't keep tab id - handles mapping when a dread^Wthread dies." And hopefully won't hit http://code.google.com/p/chromium/issues/detail?id=63479 this time... TBR=joi TEST=None BUG=65153 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68319 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting rev 68315... mad@google.com2010-12-054-64/+3
| | | | | | | | | TBR=Joi BUG=None TEST=We need to fix http://crbug.com/63479 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68318 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding of http://src.chromium.org/viewvc/chrome?view=rev&revision=68298...mad@google.com2010-12-054-3/+64
| | | | | | | | | | | Make sure we don't keep tab id - handles mapping when a dread^Wthread dies. TBR=joi BUG=65153 TEST=Just make sure it builds... git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68315 0039d316-1c4b-4281-b951-d872f2087c98
* Use the RPC channel to set the ID <-> handle mapping.mad@google.com2010-12-056-29/+108
| | | | | | | | | | As described in more details in the bug description, if we use COM for these and RPC for the other events, then they could arrive out of order. BUG=65316 TEST=Create as many tabs as quickly as possible and watch the logs (sawbuck) for errors. Review URL: http://codereview.chromium.org/5647001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68311 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 68298 - Make sure we don't keep tab id - handles mapping when a dread ↵joi@chromium.org2010-12-044-64/+3
| | | | | | | | | | | | | | dies. BUG= 65153 TEST=See hard to repro scenario in bug... Review URL: http://codereview.chromium.org/5622001 TBR=mad@google.com Review URL: http://codereview.chromium.org/5595005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68299 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure we don't keep tab id - handles mapping when a dread dies.mad@google.com2010-12-044-3/+64
| | | | | | | | | BUG= 65153 TEST=See hard to repro scenario in bug... Review URL: http://codereview.chromium.org/5622001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68298 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 68292 - Revert 68291 - DCHECK to detect invalid BrokerRpcClient usage.joi@chromium.org2010-12-041-1/+3
| | | | | | | | | | | | | | | | | (relanding for vitalybuka@chromium.org) BUG=none TEST=none Review URL: http://codereview.chromium.org/5606005 TBR=vitalybuka@chromium.org Review URL: http://codereview.chromium.org/5609005 TBR=joi@chromium.org Review URL: http://codereview.chromium.org/5649001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68297 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 68293 - Revert 68290 - Restored missing BrokerRpcClient::Connect.joi@chromium.org2010-12-045-5/+28
| | | | | | | | | | | | | | | | | | | Fixed leaking of BrokerRpcClient. (relanding for vitalybuka@chromium.org) BUG=65392 TEST=none Review URL: http://codereview.chromium.org/5610004 TBR=vitalybuka@chromium.org Review URL: http://codereview.chromium.org/5533007 TBR=joi@chromium.org Review URL: http://codereview.chromium.org/5544010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68296 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 68290 - Restored missing BrokerRpcClient::Connect.joi@chromium.org2010-12-045-28/+5
| | | | | | | | | | | | | | Fixed leaking of BrokerRpcClient. BUG=65392 TEST=none Review URL: http://codereview.chromium.org/5610004 TBR=vitalybuka@chromium.org Review URL: http://codereview.chromium.org/5533007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68293 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 68291 - DCHECK to detect invalid BrokerRpcClient usage.joi@chromium.org2010-12-041-3/+1
| | | | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5606005 TBR=vitalybuka@chromium.org Review URL: http://codereview.chromium.org/5609005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68292 0039d316-1c4b-4281-b951-d872f2087c98
* DCHECK to detect invalid BrokerRpcClient usage.vitalybuka@chromium.org2010-12-041-1/+3
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5606005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68291 0039d316-1c4b-4281-b951-d872f2087c98
* Restored missing BrokerRpcClient::Connect.vitalybuka@chromium.org2010-12-045-5/+28
| | | | | | | | | | | Fixed leaking of BrokerRpcClient. BUG=65392 TEST=none Review URL: http://codereview.chromium.org/5610004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68290 0039d316-1c4b-4281-b951-d872f2087c98
* Adde histograms for addon NavTime.vitalybuka@chromium.org2010-12-035-20/+42
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5545002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68207 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid unwind in function using __tryjoi@chromium.org2010-12-031-1/+9
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5512008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68177 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed histogram name.vitalybuka@chromium.org2010-12-021-1/+1
| | | | | | | | | BUG=65171 TEST=none Review URL: http://codereview.chromium.org/5627001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68095 0039d316-1c4b-4281-b951-d872f2087c98
* Don't even try to create a window executor if we are given not given an ↵mad@google.com2010-12-022-10/+28
| | | | | | | | | | IEFrame handle. BUG=65120 TEST=See Bug description. Review URL: http://codereview.chromium.org/5578002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68085 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting histogram name change.vitalybuka@chromium.org2010-12-021-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5589002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68084 0039d316-1c4b-4281-b951-d872f2087c98
* Silence superfluous DCHECK in BrowserHelperObject::HandleNavigateCompletealekseys@chromium.org2010-12-021-2/+2
| | | | | | | | | | | for the pages containing non-HTML frames. BUG=64986 TEST=DCHECK should not fire on pages containing non-HTML frames. Review URL: http://codereview.chromium.org/5515001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68063 0039d316-1c4b-4281-b951-d872f2087c98
* Add dummy user-level registration entry points to the CEEE dlls. This allows ↵robertshield@chromium.org2010-12-022-4/+20
| | | | | | | | | | | | | | | user-level installation to complete without error. Also fix the presubmit script to allow checkins to toolband_module.cc again (it was picking up DllRegisterServer members in a class declaration). Also add line number printing to the presubmit error message. BUG=62403 TEST=User-level installs of CF work again. Review URL: http://codereview.chromium.org/5539002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68058 0039d316-1c4b-4281-b951-d872f2087c98
* We need to pin Chrome Frame so that it doesn't get stuck on releasing Breakpad.mad@google.com2010-12-021-0/+13
| | | | | | | | | | | The Broker interacts with Chrome Frame from a Worker Thread, and if this thread is the last one to release the Chrome Frame COM object, then the Chrome Frame DLL will be relased during CoUninitialize and will try to release Breakpad while the breakpad thread is stuck on the loader lock. BUG=65116 TEST=Make sure the Broker exists cleanly and in a reasonable amount of time. Review URL: http://codereview.chromium.org/5522002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68042 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid double-setting of the tool band ID in the CEEE executors manager.cindylau@google.com2010-12-023-5/+27
| | | | | | | | | BUG=64854 TEST=ie_unittests.exe Review URL: http://codereview.chromium.org/5271011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67960 0039d316-1c4b-4281-b951-d872f2087c98
* Restart of ceee_broker on crash.vitalybuka@chromium.org2010-12-0215-146/+290
| | | | | | | | | | | Code re-factoring and cleanup. BUG=none TEST=none Review URL: http://codereview.chromium.org/5258006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67928 0039d316-1c4b-4281-b951-d872f2087c98
* Add a lock to the cookie accountant to prevent race conditions in patchingcindylau@google.com2010-12-022-1/+25
| | | | | | | | | | | functions from different threads. BUG=64844 TEST=Run integration tests. Review URL: http://codereview.chromium.org/5290011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67926 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that just started broker doesn't get events addressed to dead instance.vitalybuka@chromium.org2010-12-014-4/+8
| | | | | | | | | BUG=64967 TEST=none Review URL: http://codereview.chromium.org/5481002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67905 0039d316-1c4b-4281-b951-d872f2087c98
* Always use persistent profile for CF+CEEE installs.joi@chromium.org2010-12-015-7/+111
| | | | | | | | | BUG=64840 TEST=With --enable-ceee, CF profiles on IE7 should not be under Temporary Internet Files. Review URL: http://codereview.chromium.org/5254012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67890 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a couple of spurious test dependencies in production code.joi@chromium.org2010-12-011-3/+0
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5359009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67867 0039d316-1c4b-4281-b951-d872f2087c98
* Build break fix, missing a file from previous commit...mad@google.com2010-11-301-1/+10
| | | | | | | | | TBR=hansl@chromium.org BUG=None TEST=None git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67770 0039d316-1c4b-4281-b951-d872f2087c98
* We must return an error if we fail to validate a tab while trying to ↵mad@google.com2010-11-302-55/+80
| | | | | | | | | | | validate it's parent frame. BUG=None TEST=None Review URL: http://codereview.chromium.org/5260005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67767 0039d316-1c4b-4281-b951-d872f2087c98
* Give CEEE's Chrome Frame more screen real estate in browser tool bands to ↵cindylau@google.com2010-11-301-2/+15
| | | | | | | | | | | render extension UI. BUG=none TEST=none Review URL: http://codereview.chromium.org/5254010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67647 0039d316-1c4b-4281-b951-d872f2087c98
* Small fix to make sure we always start connection ID sequences to the same ↵mad@google.com2010-11-291-3/+6
| | | | | | | | | | value. BUG=None TEST=None Review URL: http://codereview.chromium.org/5372005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67595 0039d316-1c4b-4281-b951-d872f2087c98
* Remove an unnecessary DCHECK. IEIsProtectedModeProcess can fail if the call ↵hansl@google.com2010-11-291-3/+5
| | | | | | | | | | | is invalid, in which case we don't want to assert. BUG=64645 TEST=None Review URL: http://codereview.chromium.org/5342007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67580 0039d316-1c4b-4281-b951-d872f2087c98
* Switch from having decoupled funnels and notifiers to a single RpcClient ↵hansl@google.com2010-11-2930-268/+306
| | | | | | | | | | | | | | which is held by the BHO. This ensures that the order of events is serialized through a single queue (when related to a tab). With that change, we can effectively remove the deferral of events from IE, and only defer the queue itself until the tab_id is available. This means the events will keep their orders and that we can attach everything we need (ie FrameEventsHandler) and send events in the order we want them to be, while the actual Broker will receive them only when we have a tab_id. Sending events out of order is practically impossible now (at least in tab-related events through the BHO). From this point on we should see less out-of-order attachments and be as stable as before the TabID first change. Also, don't log metrics if the Rpc Client isn't connected correctly. BUG=None TEST=smoke_tested. Review URL: http://codereview.chromium.org/5376003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67537 0039d316-1c4b-4281-b951-d872f2087c98
* Require a flag --enable-ff-ceee to register for Firefox.joi@chromium.org2010-11-291-17/+18
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5256007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67534 0039d316-1c4b-4281-b951-d872f2087c98
* Commit for siggi, original http://codereview.chromium.org/5385004/joi@chromium.org2010-11-271-1/+1
| | | | | | Review URL: http://codereview.chromium.org/5385004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67496 0039d316-1c4b-4281-b951-d872f2087c98
* Modify the cookies API implementation in IE CEEE to account for the fact ↵cindylau@google.com2010-11-2712-277/+696
| | | | | | | | | | | | | | | | | | | that tabs within protected mode processes have separate cookie stores from those within processes without protected mode, even when protected/unprotected mode tabs are sharing the same frame window. With this change, chrome.cookies.getAllCookieStores will assign protected mode tabs a different cookie store ID from their unprotected counterparts. Finally, added /bigobj flag to ie_unittests/mediumtest_ie Release config to get them to compile again. BUG=none TEST=ie_unittests.exe Review URL: http://codereview.chromium.org/5262006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67492 0039d316-1c4b-4281-b951-d872f2087c98
* Submitting this for motek@google.com. Original code review: ↵hansl@google.com2010-11-271-28/+49
| | | | | | | | | | | http://codereview.chromium.org/5265005/ BUG=3205224 TEST=None Review URL: http://codereview.chromium.org/5374004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67486 0039d316-1c4b-4281-b951-d872f2087c98
* Added histograms with addons load time.vitalybuka@chromium.org2010-11-277-3/+231
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5348004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67485 0039d316-1c4b-4281-b951-d872f2087c98
* Exctracted helper to override registry.vitalybuka@chromium.org2010-11-271-34/+5
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5354004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67484 0039d316-1c4b-4281-b951-d872f2087c98
* No need to wait for a window to completely die anymore.mad@google.com2010-11-271-26/+17
| | | | | | | | BUG=0 TEST=Make sure that windows.onRemoved notifications are sent at the appropriate time. Review URL: http://codereview.chromium.org/5298007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67480 0039d316-1c4b-4281-b951-d872f2087c98
* Remove another redunant DCHECK that's taken to tripping.siggi@chromium.org2010-11-261-1/+0
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/5274005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67476 0039d316-1c4b-4281-b951-d872f2087c98
* IE CEEE: Validate tab IDs passed into all chrome.tabs.* APIs that take a tab ↵ericdingle@chromium.org2010-11-268-0/+159
| | | | | | | | | | | | ID as input before trying to convert them to tab handles. BUG=none TEST=none Review URL: http://codereview.chromium.org/5309004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67475 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a unittest in content script manager I broke in an earlier change.siggi@chromium.org2010-11-262-0/+3
| | | | | | | | | | | Also quench an uninteresting call notification from GMock. BUG=none TEST=none Review URL: http://codereview.chromium.org/5280007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67473 0039d316-1c4b-4281-b951-d872f2087c98
* Fail BHO construction if Toolband is disabled. siggi@chromium.org2010-11-264-21/+62
| | | | | | | | | | | | | Construction of BHO will fail if the toolband is marked as 'invisible' in the registry. Unit tests were updated as required. Submitting for motek@google.com, original review at http://codereview.chromium.org/5322010/. BUG=2840408 TEST=ie_unittest.exe Review URL: http://codereview.chromium.org/5321010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67468 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure we don't crash on NULL pointer reference on late port open ↵siggi@chromium.org2010-11-263-3/+21
| | | | | | | | | | | | | | | notification. Also improve teardown, which should make sure this doesn't happen in the first place, may will close extension ports on frame teardown. BUG=3171179 BUG=3222287 TEST=unittests in change. Review URL: http://codereview.chromium.org/5339008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67463 0039d316-1c4b-4281-b951-d872f2087c98
* Use BRANDING settings for IE CEEE. Simplify chrome_dll_version handling.joi@chromium.org2010-11-269-22/+34
| | | | | | | | | | | | | | | | | | | Adding new CEEE_PRODUCT_FULLNAME key to the BRANDING file. Adapting version.h.in to define a preprocessor constant for it. Using this and the other version/product name constants in IE CEEE's .rc files. Piggybacking on MAD's recent changes to make %NAME% a variable in the .rgs files to fairly easily get the product name from branding in there. Naming the toolband with the product name directly (as it is what shows up in IE's View/Toolbars menu), the BHO with an added "Helper" and the broker with an added "Broker". Removing the 'chrome_dll_version' target from chrome.gyp, and skipping code generation of chrome_dll_version.rc. Instead we have a source file with that name, that includes the verson.h generated by the 'chrome_version_header' target. This is cleaner and less code generation. Fixing 'chrome_dll_nacl64' target, it seemed like it wanted to have version information, but it didn't. Cleaning up the way sources are specified in several of the chrome_tests.gypi targets, to use fewer source! statements just to remove source files that are Windows-only (put them in the Windows-only section instead). BUG=none TEST=Visible change should be that user-visible names in Chromium builds are like "Chromium Extensions Execution Environment" (with "Broker" or "Helper" appended when appropriate), i.e. they lose the "Google" part. Review URL: http://codereview.chromium.org/5360002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67457 0039d316-1c4b-4281-b951-d872f2087c98
* Indent fix.vitalybuka@chromium.org2010-11-262-4/+10
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5373005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67455 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed rpc broker interface.vitalybuka@chromium.org2010-11-267-39/+51
| | | | | | | | | | | Fixed style issues of http://codereview.chromium.org/5349004/ BUG=none TEST=none Review URL: http://codereview.chromium.org/5305008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67453 0039d316-1c4b-4281-b951-d872f2087c98
* Removed cached reference to BrokerRegistrar.vitalybuka@chromium.org2010-11-267-62/+91
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5349004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67432 0039d316-1c4b-4281-b951-d872f2087c98
* A few fixes for IE CEEE BHO stability:cindylau@google.com2010-11-253-86/+185
| | | | | | | | | | | | | | | 1. Ensure that the BHO has registered its tab ID before it ever sends any tab-related events to the broker. 2. Ensure that the tabs.onUpdated and tabs.onRemoved events are only fired if the tabs.onCreated event was fired first. 3. Ensure that the ceee.onTabUnmapped event is only fired if the tab ID was registered. BUG=none TEST=ie_unittests.exe Review URL: http://codereview.chromium.org/5378002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67426 0039d316-1c4b-4281-b951-d872f2087c98
* We used to got through some hoops to validate that tab and frame windows ↵mad@google.com2010-11-2516-133/+414
| | | | | | | | | | | were ready and were the ones we were interested when we now have most of this information in the executors manager. BUG=0 TEST=Make sure we still get notifications of created and removed windows as well as all of them when enumerating windows or when interacting with tabs. Review URL: http://codereview.chromium.org/5315005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67424 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-06 03:54:27 +0000