summaryrefslogtreecommitdiffstats
path: root/ceee/ie
Commit message (Collapse)AuthorAgeFilesLines
* Rename all methods accessing Singleton<T> as GetInstance().satish@chromium.org2010-12-131-4/+2
| | | | | | | | | | | | | This is in preparation to a subsequent CL where Singleton<T> will restrict access to only the type being made singleton. I also moved pepper::ResourceTracker to a lazy instance since there were too many places in code where this class was being accessed from and this was a smaller change than renaming methods in that case. BUG=65298 TEST=all existing tests should pass. Review URL: http://codereview.chromium.org/5685007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68982 0039d316-1c4b-4281-b951-d872f2087c98
* Added refreshing of elevation policy on first run of new version for all users.vitalybuka@chromium.org2010-12-127-29/+72
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5720004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68951 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed unittests broken by misplaced BrokerRpcClient::Connect call.vitalybuka@chromium.org2010-12-098-15/+56
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5691001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68773 0039d316-1c4b-4281-b951-d872f2087c98
* Call IERefreshElevationPolicy after changing the policy.joi@chromium.org2010-12-091-1/+6
| | | | | | | | | BUG=65973 TEST=This is hard to test; when CEEE auto-updates while your browser is running, you should see no prompt for elevation like the one in the section "Starting Processes from Protected Mode" in this article: http://msdn.microsoft.com/en-us/library/bb250462(VS.85).aspx Review URL: http://codereview.chromium.org/5663004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68695 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent the IE CEEE from creating a new renderer process for each new tabrogerta@chromium.org2010-12-092-4/+16
| | | | | | | | | | | | | | | | created in IE. This happens when the Chrome Frame instances used by the BHO navigates to "about:blank". By navigating the Chrome Frame to a web page inside the loaded extension, whether the page exists or not, causes the existing extension process to be reused for these Chrome Frame instances instead of a new process being created. BUG=65966 TEST=create new tabs in IE and make sure that new chrome renderer processes are not created Review URL: http://codereview.chromium.org/5526012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68694 0039d316-1c4b-4281-b951-d872f2087c98
* Add a registry flag, so that we can enable/disable webRequest and ↵joi@chromium.org2010-12-096-8/+37
| | | | | | | | | | | | | webNavigation APIs on IE CEEE. (landing for yzshen@chromium.org) BUG=65952 TEST=none Review URL: http://codereview.chromium.org/5635010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68677 0039d316-1c4b-4281-b951-d872f2087c98
* Add one more error posting...mad@google.com2010-12-081-0/+1
| | | | | | | | | | | This was missed in rev http://src.chromium.org/viewvc/chrome?view=rev&revision=68481 :-( BUG=65440 TEST=None Review URL: http://codereview.chromium.org/5640005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68611 0039d316-1c4b-4281-b951-d872f2087c98
* Don't get tab id until tab window handle is ready.mad@google.com2010-12-081-0/+5
| | | | | | | | | | | There are rare cases where the executor manager will DCHECK that the window handle that we ask it to associate to our tab id doesn't have a valid IEFrame parent. This is because we send the request for id <-> handle association before the handle is completely ready... So wait until the tab window handle is valid before sending a mapping event. BUG=None yet... crbug down for maintenance :-( TEST=None Review URL: http://codereview.chromium.org/5632004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68607 0039d316-1c4b-4281-b951-d872f2087c98
* Small fix to properly return the appropriate type.mad@google.com2010-12-081-1/+6
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/5588008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68595 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash where the chrome_frame_ gets used after it was released.mad@google.com2010-12-081-0/+6
| | | | | | | | | | See bug description for more details, all we need to do is check the pointer before using it. BUG=65826 TEST=This is most likely happening when the use closes a tab very quickly after creating it. Review URL: http://codereview.chromium.org/5611007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68584 0039d316-1c4b-4281-b951-d872f2087c98
* Add a new GetInstance() method for singleton classes, take 2.satish@chromium.org2010-12-0813-51/+70
| | | | | | | | | | | | | | | | | | This is a small step towards making all singleton classes use the Singleton<T> pattern within their code and not expect the callers to know about it. This CL includes all files except those under chrome/browser, chrome/net, chrome/service and third_party/WebKit (these will be done in future CLs). Suggested files to focus for reviewers: - joi@ for files under src/ceee - tommi@ for files under src/chrome_frame - maruel@ for the rest of the files. BUG=65298 TEST=all existing tests should continue to pass. Review URL: http://codereview.chromium.org/5581008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68577 0039d316-1c4b-4281-b951-d872f2087c98
* Provide a safety net for Windows hooks.mad@google.com2010-12-085-8/+58
| | | | | | | | | | | | | As mentioned in http://crbug.com/65655, we have seen cases where the IE process would crash in a Windows Hook called after static uninitialization. We are guessing that this occurs when the thread running the CEEE BHO got terminated without tearing down the BHO and thus we never unhooked. This CL adds a module level set of hooks to be unhooked when the module gets terminated (before the static uninitialization). BUG=65655 TEST=None Review URL: http://codereview.chromium.org/5544014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68552 0039d316-1c4b-4281-b951-d872f2087c98
* Decrease warning severity in ApiDispatcher::InvocationResult::PostError.motek@chromium.org2010-12-071-1/+1
| | | | | | | | | | | This is an API call error which may be justifed on the API level. We don't need to log it as such. BUG=3257972 Review URL: http://codereview.chromium.org/5563008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68535 0039d316-1c4b-4281-b951-d872f2087c98
* Quick fix to properly report error to Chrome Extensions...mad@google.com2010-12-071-1/+2
| | | | | | | | | | I fear this might cause trouble in the Chrome Extensions code if some requests never get their answer and it caused a DCHECK in debug that is annoying when investigating other things... BUG=65440 TEST=None Review URL: http://codereview.chromium.org/5576007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68481 0039d316-1c4b-4281-b951-d872f2087c98
* Yet another attempt at landing ↵mad@google.com2010-12-054-3/+64
| | | | | | | | | | | | http://src.chromium.org/viewvc/chrome?view=rev&revision=68298 : "Make sure we don't keep tab id - handles mapping when a dread^Wthread dies." And hopefully won't hit http://code.google.com/p/chromium/issues/detail?id=63479 this time... TBR=joi TEST=None BUG=65153 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68319 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting rev 68315... mad@google.com2010-12-054-64/+3
| | | | | | | | | TBR=Joi BUG=None TEST=We need to fix http://crbug.com/63479 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68318 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding of http://src.chromium.org/viewvc/chrome?view=rev&revision=68298...mad@google.com2010-12-054-3/+64
| | | | | | | | | | | Make sure we don't keep tab id - handles mapping when a dread^Wthread dies. TBR=joi BUG=65153 TEST=Just make sure it builds... git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68315 0039d316-1c4b-4281-b951-d872f2087c98
* Use the RPC channel to set the ID <-> handle mapping.mad@google.com2010-12-056-29/+108
| | | | | | | | | | As described in more details in the bug description, if we use COM for these and RPC for the other events, then they could arrive out of order. BUG=65316 TEST=Create as many tabs as quickly as possible and watch the logs (sawbuck) for errors. Review URL: http://codereview.chromium.org/5647001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68311 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 68298 - Make sure we don't keep tab id - handles mapping when a dread ↵joi@chromium.org2010-12-044-64/+3
| | | | | | | | | | | | | | dies. BUG= 65153 TEST=See hard to repro scenario in bug... Review URL: http://codereview.chromium.org/5622001 TBR=mad@google.com Review URL: http://codereview.chromium.org/5595005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68299 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure we don't keep tab id - handles mapping when a dread dies.mad@google.com2010-12-044-3/+64
| | | | | | | | | BUG= 65153 TEST=See hard to repro scenario in bug... Review URL: http://codereview.chromium.org/5622001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68298 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 68292 - Revert 68291 - DCHECK to detect invalid BrokerRpcClient usage.joi@chromium.org2010-12-041-1/+3
| | | | | | | | | | | | | | | | | (relanding for vitalybuka@chromium.org) BUG=none TEST=none Review URL: http://codereview.chromium.org/5606005 TBR=vitalybuka@chromium.org Review URL: http://codereview.chromium.org/5609005 TBR=joi@chromium.org Review URL: http://codereview.chromium.org/5649001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68297 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 68293 - Revert 68290 - Restored missing BrokerRpcClient::Connect.joi@chromium.org2010-12-045-5/+28
| | | | | | | | | | | | | | | | | | | Fixed leaking of BrokerRpcClient. (relanding for vitalybuka@chromium.org) BUG=65392 TEST=none Review URL: http://codereview.chromium.org/5610004 TBR=vitalybuka@chromium.org Review URL: http://codereview.chromium.org/5533007 TBR=joi@chromium.org Review URL: http://codereview.chromium.org/5544010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68296 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 68290 - Restored missing BrokerRpcClient::Connect.joi@chromium.org2010-12-045-28/+5
| | | | | | | | | | | | | | Fixed leaking of BrokerRpcClient. BUG=65392 TEST=none Review URL: http://codereview.chromium.org/5610004 TBR=vitalybuka@chromium.org Review URL: http://codereview.chromium.org/5533007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68293 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 68291 - DCHECK to detect invalid BrokerRpcClient usage.joi@chromium.org2010-12-041-3/+1
| | | | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5606005 TBR=vitalybuka@chromium.org Review URL: http://codereview.chromium.org/5609005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68292 0039d316-1c4b-4281-b951-d872f2087c98
* DCHECK to detect invalid BrokerRpcClient usage.vitalybuka@chromium.org2010-12-041-1/+3
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5606005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68291 0039d316-1c4b-4281-b951-d872f2087c98
* Restored missing BrokerRpcClient::Connect.vitalybuka@chromium.org2010-12-045-5/+28
| | | | | | | | | | | Fixed leaking of BrokerRpcClient. BUG=65392 TEST=none Review URL: http://codereview.chromium.org/5610004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68290 0039d316-1c4b-4281-b951-d872f2087c98
* Adde histograms for addon NavTime.vitalybuka@chromium.org2010-12-035-20/+42
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5545002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68207 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid unwind in function using __tryjoi@chromium.org2010-12-031-1/+9
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5512008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68177 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed histogram name.vitalybuka@chromium.org2010-12-021-1/+1
| | | | | | | | | BUG=65171 TEST=none Review URL: http://codereview.chromium.org/5627001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68095 0039d316-1c4b-4281-b951-d872f2087c98
* Don't even try to create a window executor if we are given not given an ↵mad@google.com2010-12-022-10/+28
| | | | | | | | | | IEFrame handle. BUG=65120 TEST=See Bug description. Review URL: http://codereview.chromium.org/5578002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68085 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting histogram name change.vitalybuka@chromium.org2010-12-021-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5589002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68084 0039d316-1c4b-4281-b951-d872f2087c98
* Silence superfluous DCHECK in BrowserHelperObject::HandleNavigateCompletealekseys@chromium.org2010-12-021-2/+2
| | | | | | | | | | | for the pages containing non-HTML frames. BUG=64986 TEST=DCHECK should not fire on pages containing non-HTML frames. Review URL: http://codereview.chromium.org/5515001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68063 0039d316-1c4b-4281-b951-d872f2087c98
* Add dummy user-level registration entry points to the CEEE dlls. This allows ↵robertshield@chromium.org2010-12-022-4/+20
| | | | | | | | | | | | | | | user-level installation to complete without error. Also fix the presubmit script to allow checkins to toolband_module.cc again (it was picking up DllRegisterServer members in a class declaration). Also add line number printing to the presubmit error message. BUG=62403 TEST=User-level installs of CF work again. Review URL: http://codereview.chromium.org/5539002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68058 0039d316-1c4b-4281-b951-d872f2087c98
* We need to pin Chrome Frame so that it doesn't get stuck on releasing Breakpad.mad@google.com2010-12-021-0/+13
| | | | | | | | | | | The Broker interacts with Chrome Frame from a Worker Thread, and if this thread is the last one to release the Chrome Frame COM object, then the Chrome Frame DLL will be relased during CoUninitialize and will try to release Breakpad while the breakpad thread is stuck on the loader lock. BUG=65116 TEST=Make sure the Broker exists cleanly and in a reasonable amount of time. Review URL: http://codereview.chromium.org/5522002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68042 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid double-setting of the tool band ID in the CEEE executors manager.cindylau@google.com2010-12-023-5/+27
| | | | | | | | | BUG=64854 TEST=ie_unittests.exe Review URL: http://codereview.chromium.org/5271011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67960 0039d316-1c4b-4281-b951-d872f2087c98
* Restart of ceee_broker on crash.vitalybuka@chromium.org2010-12-0215-146/+290
| | | | | | | | | | | Code re-factoring and cleanup. BUG=none TEST=none Review URL: http://codereview.chromium.org/5258006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67928 0039d316-1c4b-4281-b951-d872f2087c98
* Add a lock to the cookie accountant to prevent race conditions in patchingcindylau@google.com2010-12-022-1/+25
| | | | | | | | | | | functions from different threads. BUG=64844 TEST=Run integration tests. Review URL: http://codereview.chromium.org/5290011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67926 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that just started broker doesn't get events addressed to dead instance.vitalybuka@chromium.org2010-12-014-4/+8
| | | | | | | | | BUG=64967 TEST=none Review URL: http://codereview.chromium.org/5481002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67905 0039d316-1c4b-4281-b951-d872f2087c98
* Always use persistent profile for CF+CEEE installs.joi@chromium.org2010-12-015-7/+111
| | | | | | | | | BUG=64840 TEST=With --enable-ceee, CF profiles on IE7 should not be under Temporary Internet Files. Review URL: http://codereview.chromium.org/5254012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67890 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a couple of spurious test dependencies in production code.joi@chromium.org2010-12-011-3/+0
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5359009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67867 0039d316-1c4b-4281-b951-d872f2087c98
* Build break fix, missing a file from previous commit...mad@google.com2010-11-301-1/+10
| | | | | | | | | TBR=hansl@chromium.org BUG=None TEST=None git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67770 0039d316-1c4b-4281-b951-d872f2087c98
* We must return an error if we fail to validate a tab while trying to ↵mad@google.com2010-11-302-55/+80
| | | | | | | | | | | validate it's parent frame. BUG=None TEST=None Review URL: http://codereview.chromium.org/5260005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67767 0039d316-1c4b-4281-b951-d872f2087c98
* Give CEEE's Chrome Frame more screen real estate in browser tool bands to ↵cindylau@google.com2010-11-301-2/+15
| | | | | | | | | | | render extension UI. BUG=none TEST=none Review URL: http://codereview.chromium.org/5254010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67647 0039d316-1c4b-4281-b951-d872f2087c98
* Small fix to make sure we always start connection ID sequences to the same ↵mad@google.com2010-11-291-3/+6
| | | | | | | | | | value. BUG=None TEST=None Review URL: http://codereview.chromium.org/5372005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67595 0039d316-1c4b-4281-b951-d872f2087c98
* Remove an unnecessary DCHECK. IEIsProtectedModeProcess can fail if the call ↵hansl@google.com2010-11-291-3/+5
| | | | | | | | | | | is invalid, in which case we don't want to assert. BUG=64645 TEST=None Review URL: http://codereview.chromium.org/5342007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67580 0039d316-1c4b-4281-b951-d872f2087c98
* Switch from having decoupled funnels and notifiers to a single RpcClient ↵hansl@google.com2010-11-2930-268/+306
| | | | | | | | | | | | | | which is held by the BHO. This ensures that the order of events is serialized through a single queue (when related to a tab). With that change, we can effectively remove the deferral of events from IE, and only defer the queue itself until the tab_id is available. This means the events will keep their orders and that we can attach everything we need (ie FrameEventsHandler) and send events in the order we want them to be, while the actual Broker will receive them only when we have a tab_id. Sending events out of order is practically impossible now (at least in tab-related events through the BHO). From this point on we should see less out-of-order attachments and be as stable as before the TabID first change. Also, don't log metrics if the Rpc Client isn't connected correctly. BUG=None TEST=smoke_tested. Review URL: http://codereview.chromium.org/5376003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67537 0039d316-1c4b-4281-b951-d872f2087c98
* Require a flag --enable-ff-ceee to register for Firefox.joi@chromium.org2010-11-291-17/+18
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5256007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67534 0039d316-1c4b-4281-b951-d872f2087c98
* Commit for siggi, original http://codereview.chromium.org/5385004/joi@chromium.org2010-11-271-1/+1
| | | | | | Review URL: http://codereview.chromium.org/5385004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67496 0039d316-1c4b-4281-b951-d872f2087c98
* Modify the cookies API implementation in IE CEEE to account for the fact ↵cindylau@google.com2010-11-2712-277/+696
| | | | | | | | | | | | | | | | | | | that tabs within protected mode processes have separate cookie stores from those within processes without protected mode, even when protected/unprotected mode tabs are sharing the same frame window. With this change, chrome.cookies.getAllCookieStores will assign protected mode tabs a different cookie store ID from their unprotected counterparts. Finally, added /bigobj flag to ie_unittests/mediumtest_ie Release config to get them to compile again. BUG=none TEST=ie_unittests.exe Review URL: http://codereview.chromium.org/5262006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67492 0039d316-1c4b-4281-b951-d872f2087c98
* Submitting this for motek@google.com. Original code review: ↵hansl@google.com2010-11-271-28/+49
| | | | | | | | | | | http://codereview.chromium.org/5265005/ BUG=3205224 TEST=None Review URL: http://codereview.chromium.org/5374004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67486 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 07:43:08 +0000