summaryrefslogtreecommitdiffstats
path: root/ceee
Commit message (Collapse)AuthorAgeFilesLines
* Removed error log message on empty string.vitalybuka@chromium.org2011-01-251-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6268013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72465 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed GetCollectStatsConsent broken by RegKey API change.vitalybuka@chromium.org2011-01-251-1/+1
| | | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6321019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72464 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 71415 - Revert 71377 - Added loading of nested BHO.vitalybuka@chromium.org2011-01-225-1/+65
| | | | | | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6106004 TBR=vitalybuka@chromium.org Review URL: http://codereview.chromium.org/6313002 TBR=vitalybuka@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72281 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing base::lock usage.brettw@chromium.org2011-01-213-3/+3
| | | | | | | TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6336010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72108 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obsolete base/lock.h and fix up callers to use the new header file andbrettw@chromium.org2011-01-2112-50/+50
| | | | | | | | | | | the base namespace. Fix several files including lock.h unnecessarily. BUG=none TEST=none Original review=http://codereview.chromium.org/6142009/ Patch by leviw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72106 0039d316-1c4b-4281-b951-d872f2087c98
* Syntax checker for policy_templates.jsonjkummerow@chromium.org2011-01-191-7/+9
| | | | | | | | | | | To make sure that all policy definitions match the expected format. The checker is called as a presubmit hook, and can also be invoked manually. Run it without any parameters (or with --help) to get usage information. BUG=69527 TEST=manual: checker reports no errors for correct policy definitions, checker complains for malformed policy definitions, checker is invoked as presubmit hook when policy_templates.json has been changed Review URL: http://codereview.chromium.org/6299001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71778 0039d316-1c4b-4281-b951-d872f2087c98
* Regkey functions return error code instead of boolamit@chromium.org2011-01-198-68/+91
| | | | | | | | | | | | | | | | | | | | | | Change the Regkey helper to consistently use and return LONG instead of bool. Fix RegKey usage all over the code base and get rid of workarounds due to lack of return value. Reviewers: brettw: everything (skip parts for other reviewers if you wish) robertshield,grt: chrome_frame, installer siggi: ceee BUG=none TEST=covered by existing tests Review URL: http://codereview.chromium.org/6090006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71768 0039d316-1c4b-4281-b951-d872f2087c98
* Fix LOG_IF check.tommi@chromium.org2011-01-181-1/+1
| | | | | | | | | TEST=Silences expected log entries. BUG=none Review URL: http://codereview.chromium.org/6352007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71695 0039d316-1c4b-4281-b951-d872f2087c98
* Made return types of various Value::DeepCopy() implementations more specificakalin@chromium.org2011-01-181-1/+1
| | | | | | | | | | | | | | | | | | Since C++ supports covariant return types, a subclass of Value can return its own pointer type for Value::DeepCopy(). Also made signatures of Value::Create*Value() more specific. Removed now-unnecessary casts. Added test for covariant return types. BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6324004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71617 0039d316-1c4b-4281-b951-d872f2087c98
* Typedef for readability.vitalybuka@chromium.org2011-01-141-9/+11
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6281003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71493 0039d316-1c4b-4281-b951-d872f2087c98
* Clang: enable -Wbool-conversions and -Wunused-variables on Linux.hans@chromium.org2011-01-141-16/+8
| | | | | | | | | | | | | | | -Wbool-conversion warns about EXPECT_EQ(false, blah), so replace that with EXPECT_FALSE(blah). Do the same with EXPECT_EQ(true, blah) for good measure (even though that doesn't generate warnings). Also remove the one instance of an unused variable. BUG=69421 TEST=buildbots all compile and all tests pass Review URL: http://codereview.chromium.org/6300001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71431 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 71377 - Added loading of nested BHO.vitalybuka@chromium.org2011-01-145-65/+1
| | | | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6106004 TBR=vitalybuka@chromium.org Review URL: http://codereview.chromium.org/6313002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71415 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed initial rendering of toolbar.vitalybuka@chromium.org2011-01-142-34/+31
| | | | | | | | | | | IE will create empty properly rendered toolbar instead of white box. Then chrome frame will be placed above. BUG=none TEST=none Review URL: http://codereview.chromium.org/6245001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71404 0039d316-1c4b-4281-b951-d872f2087c98
* Added loading of nested BHO.vitalybuka@chromium.org2011-01-135-1/+65
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6106004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71377 0039d316-1c4b-4281-b951-d872f2087c98
* Made logging not look up --enable-dcheck from command lineakalin@chromium.org2011-01-113-3/+6
| | | | | | | | | | | | | | | | Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70782 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70920 Review URL: http://codereview.chromium.org/6070006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70977 0039d316-1c4b-4281-b951-d872f2087c98
* Change #ifdef _DEBUG test to #ifndef NDEBUG test.tfarina@chromium.org2011-01-101-2/+2
| | | | | | | | | BUG=None TEST=trybots Review URL: http://codereview.chromium.org/5991010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70956 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 70920 - Made logging not look up --enable-dcheck from command lineakalin@chromium.org2011-01-103-6/+3
| | | | | | | | | | | | | | | | | Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70782 Review URL: http://codereview.chromium.org/6070006 TBR=akalin@chromium.org Review URL: http://codereview.chromium.org/6099012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70923 0039d316-1c4b-4281-b951-d872f2087c98
* Made logging not look up --enable-dcheck from command lineakalin@chromium.org2011-01-103-3/+6
| | | | | | | | | | | | | | Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70782 Review URL: http://codereview.chromium.org/6070006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70920 0039d316-1c4b-4281-b951-d872f2087c98
* Reland "Remove base/scoped_handle_win.h."tfarina@chromium.org2011-01-093-12/+13
| | | | | | | | | | | | | | | Fixed the problem with rlz library. Now should be fine to land this again. This reverts commit 3620d9501af7bff688862c54fdd60f7eb41797f3. Original Review URL: http://codereview.chromium.org/6126002/ BUG=None TEST=trybots Review URL: http://codereview.chromium.org/6110005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70861 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Remove base/scoped_handle_win.h stub and fix up all callers to use ↵thakis@chromium.org2011-01-073-13/+12
| | | | | | | | | | the new location and namespace." This reverts r 70795, it broke the build. TBR=vandebo git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70802 0039d316-1c4b-4281-b951-d872f2087c98
* Remove base/scoped_handle_win.h stub and fix up all callers to use the new ↵tfarina@chromium.org2011-01-073-12/+13
| | | | | | | | | | | location and namespace. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/6126002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70795 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 70782 - Made logging not look up --enable-dcheck from command lineakalin@chromium.org2011-01-073-6/+3
| | | | | | | | | | | | | | | Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Review URL: http://codereview.chromium.org/6070006 TBR=akalin@chromium.org Review URL: http://codereview.chromium.org/6100007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70783 0039d316-1c4b-4281-b951-d872f2087c98
* Made logging not look up --enable-dcheck from command lineakalin@chromium.org2011-01-073-3/+6
| | | | | | | | | | | | Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Review URL: http://codereview.chromium.org/6070006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70782 0039d316-1c4b-4281-b951-d872f2087c98
* Move base/thread.h to base/threading, fix up callers to use the new location.brettw@chromium.org2011-01-012-2/+2
| | | | | | | | TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6028009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70345 0039d316-1c4b-4281-b951-d872f2087c98
* Move base/win_util to the base/win directory and use the base::win namespace.brettw@google.com2010-12-313-4/+2
| | | | | | | | | Fix up includes, many files including base/win_util don't actually need it. TEST=it compiles BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70341 0039d316-1c4b-4281-b951-d872f2087c98
* Change "enable-ceee" to "ceee" to match the installer.tommi@chromium.org2010-12-315-16/+17
| | | | | | | | | TEST=CEEE gets registered when running the installer with --ceee. BUG=61609 Review URL: http://codereview.chromium.org/5965012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70327 0039d316-1c4b-4281-b951-d872f2087c98
* Move rgs_helper out of base to ceee since it's not used anywhere else.brettw@chromium.org2010-12-296-4/+94
| | | | | | | | TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6041007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70280 0039d316-1c4b-4281-b951-d872f2087c98
* ceee: Include base/win/scope_comptr.h instead of base/scoped_comptr_win.htfarina@chromium.org2010-12-217-35/+34
| | | | | | | | | | | Also add base::win:: to ScopedComPtr where necessary. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/6063001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69775 0039d316-1c4b-4281-b951-d872f2087c98
* Updated comments around create tab API.motek@chromium.org2010-12-162-7/+13
| | | | | | | | | | | | | I have investigated the bug in great detail. My previous fix is entirely correct and complete. Removed the TODO, updated the comment to give a better explanation, will close issue upon review. BUG=66864 TEST=none Review URL: http://codereview.chromium.org/5926001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69471 0039d316-1c4b-4281-b951-d872f2087c98
* Added string to VERSIONINFO.vitalybuka@chromium.org2010-12-163-0/+6
| | | | | | | | | | | | "Official Build" to fix UMA issue. "LastChange" for convinience. BUG=none TEST=none Review URL: http://codereview.chromium.org/5860001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69457 0039d316-1c4b-4281-b951-d872f2087c98
* Fix to FF CEEE windows.getCurrent implementation.ericdingle@chromium.org2010-12-162-1/+3
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5910003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69449 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 69167, itself a revert of 69165 - Merge the installer, installer_util ↵robertshield@chromium.org2010-12-152-5/+5
| | | | | | | | | | | | and setup_util namespaces into a single installer namespace. BUG=61609 TEST=NONE Review URL: http://codereview.chromium.org/5738009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69256 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed unittests.vitalybuka@chromium.org2010-12-142-2/+2
| | | | | | | | | | BUG=65973 TEST=none Review URL: http://codereview.chromium.org/5824002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69179 0039d316-1c4b-4281-b951-d872f2087c98
* These DCHECKs are sort-of expected in a fast startup sequence.motek@chromium.org2010-12-143-5/+10
| | | | | | | | | | | | | | They are still errors, but DCHECKs make use of automated testing tools against the debug build virtually impossible. This will be followed-up. BUG=66863 BUG=66864 TEST=none Review URL: http://codereview.chromium.org/5751001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69170 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 69165 - Merge the installer, installer_util and setup_util namespaces ↵robertshield@chromium.org2010-12-142-5/+5
| | | | | | | | | | | | | | into a single installer namespace. BUG=61609 TEST=NONE Review URL: http://codereview.chromium.org/5729004 TBR=robertshield@chromium.org Review URL: http://codereview.chromium.org/5756007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69167 0039d316-1c4b-4281-b951-d872f2087c98
* Merge the installer, installer_util and setup_util namespaces into a single ↵robertshield@chromium.org2010-12-142-5/+5
| | | | | | | | | | | installer namespace. BUG=61609 TEST=NONE Review URL: http://codereview.chromium.org/5729004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69165 0039d316-1c4b-4281-b951-d872f2087c98
* Pin the Module after we register a hook.mad@google.com2010-12-131-0/+6
| | | | | | | | | | This shouldn't be needed since the hook machinery is responsible to load our DLL when it's needed, and we only need to register hooks for threads running in the IE process, but we received a dump for a user where the Broker crashed because of a call from the hook machinery to an unmapped address, and this address is within a range where we have seen the ceee_ie dll sit in other debugging session, and in the crash dump, the ceee_ie dll isn't part of the module list. BUG=66434 TEST=None Review URL: http://codereview.chromium.org/5778002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69044 0039d316-1c4b-4281-b951-d872f2087c98
* Rename all methods accessing Singleton<T> as GetInstance().satish@chromium.org2010-12-133-8/+12
| | | | | | | | | | | | | This is in preparation to a subsequent CL where Singleton<T> will restrict access to only the type being made singleton. I also moved pepper::ResourceTracker to a lazy instance since there were too many places in code where this class was being accessed from and this was a smaller change than renaming methods in that case. BUG=65298 TEST=all existing tests should pass. Review URL: http://codereview.chromium.org/5685007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68982 0039d316-1c4b-4281-b951-d872f2087c98
* Added refreshing of elevation policy on first run of new version for all users.vitalybuka@chromium.org2010-12-128-29/+75
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5720004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68951 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed unittests broken by misplaced BrokerRpcClient::Connect call.vitalybuka@chromium.org2010-12-098-15/+56
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5691001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68773 0039d316-1c4b-4281-b951-d872f2087c98
* Call IERefreshElevationPolicy after changing the policy.joi@chromium.org2010-12-091-1/+6
| | | | | | | | | BUG=65973 TEST=This is hard to test; when CEEE auto-updates while your browser is running, you should see no prompt for elevation like the one in the section "Starting Processes from Protected Mode" in this article: http://msdn.microsoft.com/en-us/library/bb250462(VS.85).aspx Review URL: http://codereview.chromium.org/5663004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68695 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent the IE CEEE from creating a new renderer process for each new tabrogerta@chromium.org2010-12-092-4/+16
| | | | | | | | | | | | | | | | created in IE. This happens when the Chrome Frame instances used by the BHO navigates to "about:blank". By navigating the Chrome Frame to a web page inside the loaded extension, whether the page exists or not, causes the existing extension process to be reused for these Chrome Frame instances instead of a new process being created. BUG=65966 TEST=create new tabs in IE and make sure that new chrome renderer processes are not created Review URL: http://codereview.chromium.org/5526012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68694 0039d316-1c4b-4281-b951-d872f2087c98
* Add a registry flag, so that we can enable/disable webRequest and ↵joi@chromium.org2010-12-096-8/+37
| | | | | | | | | | | | | webNavigation APIs on IE CEEE. (landing for yzshen@chromium.org) BUG=65952 TEST=none Review URL: http://codereview.chromium.org/5635010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68677 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of std::wstring version of HasSwitch.tfarina@chromium.org2010-12-081-2/+2
| | | | | | | | | BUG=24672 TEST=trybots Review URL: http://codereview.chromium.org/5649003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68650 0039d316-1c4b-4281-b951-d872f2087c98
* Add one more error posting...mad@google.com2010-12-081-0/+1
| | | | | | | | | | | This was missed in rev http://src.chromium.org/viewvc/chrome?view=rev&revision=68481 :-( BUG=65440 TEST=None Review URL: http://codereview.chromium.org/5640005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68611 0039d316-1c4b-4281-b951-d872f2087c98
* Don't get tab id until tab window handle is ready.mad@google.com2010-12-081-0/+5
| | | | | | | | | | | There are rare cases where the executor manager will DCHECK that the window handle that we ask it to associate to our tab id doesn't have a valid IEFrame parent. This is because we send the request for id <-> handle association before the handle is completely ready... So wait until the tab window handle is valid before sending a mapping event. BUG=None yet... crbug down for maintenance :-( TEST=None Review URL: http://codereview.chromium.org/5632004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68607 0039d316-1c4b-4281-b951-d872f2087c98
* Some installer cleanup: introduced ChannelInfo class for fiddling with "ap" ↵grt@chromium.org2010-12-081-54/+12
| | | | | | | | | | | ClientState value. BUG=61609 TEST=added to and modified chrome/installer_util_unittests.exe appropriately Review URL: http://codereview.chromium.org/5656002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68603 0039d316-1c4b-4281-b951-d872f2087c98
* Small fix to properly return the appropriate type.mad@google.com2010-12-081-1/+6
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/5588008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68595 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash where the chrome_frame_ gets used after it was released.mad@google.com2010-12-081-0/+6
| | | | | | | | | | See bug description for more details, all we need to do is check the pointer before using it. BUG=65826 TEST=This is most likely happening when the use closes a tab very quickly after creating it. Review URL: http://codereview.chromium.org/5611007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68584 0039d316-1c4b-4281-b951-d872f2087c98
* Add a new GetInstance() method for singleton classes, take 2.satish@chromium.org2010-12-0813-51/+70
| | | | | | | | | | | | | | | | | | This is a small step towards making all singleton classes use the Singleton<T> pattern within their code and not expect the callers to know about it. This CL includes all files except those under chrome/browser, chrome/net, chrome/service and third_party/WebKit (these will be done in future CLs). Suggested files to focus for reviewers: - joi@ for files under src/ceee - tommi@ for files under src/chrome_frame - maruel@ for the rest of the files. BUG=65298 TEST=all existing tests should continue to pass. Review URL: http://codereview.chromium.org/5581008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68577 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-06 13:01:08 +0000