| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
and setup_util namespaces into a single installer namespace.
BUG=61609
TEST=NONE
Review URL: http://codereview.chromium.org/5738009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=65973
TEST=none
Review URL: http://codereview.chromium.org/5824002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
They are still errors, but DCHECKs make use of automated testing tools against the debug build virtually impossible.
This will be followed-up.
BUG=66863
BUG=66864
TEST=none
Review URL: http://codereview.chromium.org/5751001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
into a single installer namespace.
BUG=61609
TEST=NONE
Review URL: http://codereview.chromium.org/5729004
TBR=robertshield@chromium.org
Review URL: http://codereview.chromium.org/5756007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69167 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
installer namespace.
BUG=61609
TEST=NONE
Review URL: http://codereview.chromium.org/5729004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69165 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This shouldn't be needed since the hook machinery is responsible to load our DLL when it's needed, and we only need to register hooks for threads running in the IE process, but we received a dump for a user where the Broker crashed because of a call from the hook machinery to an unmapped address, and this address is within a range where we have seen the ceee_ie dll sit in other debugging session, and in the crash dump, the ceee_ie dll isn't part of the module list.
BUG=66434
TEST=None
Review URL: http://codereview.chromium.org/5778002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is in preparation to a subsequent CL where Singleton<T> will restrict access to only the type being made singleton.
I also moved pepper::ResourceTracker to a lazy instance since there were too many places in code where this class was being accessed from and this was a smaller change than renaming methods in that case.
BUG=65298
TEST=all existing tests should pass.
Review URL: http://codereview.chromium.org/5685007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5720004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5691001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=65973
TEST=This is hard to test; when CEEE auto-updates while your browser is running, you should see no prompt for elevation like the one in the section "Starting Processes from Protected Mode" in this article: http://msdn.microsoft.com/en-us/library/bb250462(VS.85).aspx
Review URL: http://codereview.chromium.org/5663004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
created in IE. This happens when the Chrome Frame instances used by the
BHO navigates to "about:blank". By navigating the Chrome Frame to a web page
inside the loaded extension, whether the page exists or not, causes the
existing extension process to be reused for these Chrome Frame instances
instead of a new process being created.
BUG=65966
TEST=create new tabs in IE and make sure that new chrome renderer processes
are not created
Review URL: http://codereview.chromium.org/5526012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
webNavigation APIs on IE CEEE.
(landing for yzshen@chromium.org)
BUG=65952
TEST=none
Review URL: http://codereview.chromium.org/5635010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24672
TEST=trybots
Review URL: http://codereview.chromium.org/5649003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This was missed in rev http://src.chromium.org/viewvc/chrome?view=rev&revision=68481 :-(
BUG=65440
TEST=None
Review URL: http://codereview.chromium.org/5640005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
There are rare cases where the executor manager will DCHECK that the window handle that we ask it to associate to our tab id doesn't have a valid IEFrame parent. This is because we send the request for id <-> handle association before the handle is completely ready... So wait until the tab window handle is valid before sending a mapping event.
BUG=None yet... crbug down for maintenance :-(
TEST=None
Review URL: http://codereview.chromium.org/5632004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68607 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ClientState value.
BUG=61609
TEST=added to and modified chrome/installer_util_unittests.exe appropriately
Review URL: http://codereview.chromium.org/5656002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/5588008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
See bug description for more details, all we need to do is check the pointer before using it.
BUG=65826
TEST=This is most likely happening when the use closes a tab very quickly after creating it.
Review URL: http://codereview.chromium.org/5611007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68584 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a small step towards making all singleton classes use the Singleton<T> pattern within their code and not expect the callers to know about it.
This CL includes all files except those under chrome/browser, chrome/net, chrome/service and third_party/WebKit (these will be done in future CLs).
Suggested files to focus for reviewers:
- joi@ for files under src/ceee
- tommi@ for files under src/chrome_frame
- maruel@ for the rest of the files.
BUG=65298
TEST=all existing tests should continue to pass.
Review URL: http://codereview.chromium.org/5581008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68577 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As mentioned in http://crbug.com/65655, we have seen cases where the IE process would crash in a Windows Hook called after static uninitialization. We are guessing that this occurs when the thread running the CEEE BHO got terminated without tearing down the BHO and thus we never unhooked.
This CL adds a module level set of hooks to be unhooked when the module gets terminated (before the static uninitialization).
BUG=65655
TEST=None
Review URL: http://codereview.chromium.org/5544014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68552 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is an API call error which may be justifed on the API level. We don't
need to log it as such.
BUG=3257972
Review URL: http://codereview.chromium.org/5563008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68535 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I fear this might cause trouble in the Chrome Extensions code if some requests never get their answer and it caused a DCHECK in debug that is annoying when investigating other things...
BUG=65440
TEST=None
Review URL: http://codereview.chromium.org/5576007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://src.chromium.org/viewvc/chrome?view=rev&revision=68298 : "Make sure we don't keep tab id - handles mapping when a dread^Wthread dies."
And hopefully won't hit http://code.google.com/p/chromium/issues/detail?id=63479 this time...
TBR=joi
TEST=None
BUG=65153
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68319 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=Joi
BUG=None
TEST=We need to fix http://crbug.com/63479
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68318 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Make sure we don't keep tab id - handles mapping when a dread^Wthread dies.
TBR=joi
BUG=65153
TEST=Just make sure it builds...
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68315 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
As described in more details in the bug description, if we use COM for these and RPC for the other events, then they could arrive out of order.
BUG=65316
TEST=Create as many tabs as quickly as possible and watch the logs (sawbuck) for errors.
Review URL: http://codereview.chromium.org/5647001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
dies.
BUG= 65153
TEST=See hard to repro scenario in bug...
Review URL: http://codereview.chromium.org/5622001
TBR=mad@google.com
Review URL: http://codereview.chromium.org/5595005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68299 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= 65153
TEST=See hard to repro scenario in bug...
Review URL: http://codereview.chromium.org/5622001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68298 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(relanding for vitalybuka@chromium.org)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5606005
TBR=vitalybuka@chromium.org
Review URL: http://codereview.chromium.org/5609005
TBR=joi@chromium.org
Review URL: http://codereview.chromium.org/5649001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68297 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixed leaking of BrokerRpcClient.
(relanding for vitalybuka@chromium.org)
BUG=65392
TEST=none
Review URL: http://codereview.chromium.org/5610004
TBR=vitalybuka@chromium.org
Review URL: http://codereview.chromium.org/5533007
TBR=joi@chromium.org
Review URL: http://codereview.chromium.org/5544010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68296 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixed leaking of BrokerRpcClient.
BUG=65392
TEST=none
Review URL: http://codereview.chromium.org/5610004
TBR=vitalybuka@chromium.org
Review URL: http://codereview.chromium.org/5533007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68293 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5606005
TBR=vitalybuka@chromium.org
Review URL: http://codereview.chromium.org/5609005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68292 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5606005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68291 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fixed leaking of BrokerRpcClient.
BUG=65392
TEST=none
Review URL: http://codereview.chromium.org/5610004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68290 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5545002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5512008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68177 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=65191
TEST=it builds, expanding ceee_ff.xpi you find no strings like @CEEE_PRODUCT_FULLNAME@
Review URL: http://codereview.chromium.org/5604003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=65171
TEST=none
Review URL: http://codereview.chromium.org/5627001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
IEFrame handle.
BUG=65120
TEST=See Bug description.
Review URL: http://codereview.chromium.org/5578002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5589002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
for the pages containing non-HTML frames.
BUG=64986
TEST=DCHECK should not fire on pages containing non-HTML frames.
Review URL: http://codereview.chromium.org/5515001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
user-level installation to complete without error.
Also fix the presubmit script to allow checkins to toolband_module.cc again (it was picking up DllRegisterServer members in a class declaration).
Also add line number printing to the presubmit error message.
BUG=62403
TEST=User-level installs of CF work again.
Review URL: http://codereview.chromium.org/5539002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The Broker interacts with Chrome Frame from a Worker Thread, and if this thread is the last one to release the Chrome Frame COM object, then the Chrome Frame DLL will be relased during CoUninitialize and will try to release Breakpad while the breakpad thread is stuck on the loader lock.
BUG=65116
TEST=Make sure the Broker exists cleanly and in a reasonable amount of time.
Review URL: http://codereview.chromium.org/5522002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
windows.getCurrent(), to Firefox's CEEE.
Cloned from issue http://codereview.chromium.org/5277004/ by rogerta@chromium.org.
BUG=64979
TEST=see integration tests
Review URL: http://codereview.chromium.org/5512001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=64854
TEST=ie_unittests.exe
Review URL: http://codereview.chromium.org/5271011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Code re-factoring and cleanup.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5258006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
functions from different threads.
BUG=64844
TEST=Run integration tests.
Review URL: http://codereview.chromium.org/5290011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=64967
TEST=none
Review URL: http://codereview.chromium.org/5481002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=64840
TEST=With --enable-ceee, CF profiles on IE7 should not be under Temporary Internet Files.
Review URL: http://codereview.chromium.org/5254012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5359009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67867 0039d316-1c4b-4281-b951-d872f2087c98
|