| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
we should attempt re-install. This helps robustness e.g. in the
case where we change profile directories (as we recently did).
Mark a test that I noticed was flaky (and open a bug for it).
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5027001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
global namespace instead of automatically.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4997002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=everything compiles
Review URL: http://codereview.chromium.org/5015001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Sumbmitting for Vitaly Buka, see original change at http://codereview.chromium.org/4508002/.
BUG=none
TEST=Unittests in this change.
Review URL: http://codereview.chromium.org/5010001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
adding explicit include_directories where they were previously implied
by direct dependency on a target with a direct_dependent_settings. This is
a candidate fix for today's build breaks.
BUG=none
TEST=it builds
Review URL: http://codereview.chromium.org/4994001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
non-joinable threads.
Fix all known instances or explicitly allow them. Usually the fix involves switching from Default traits to Lazy traits.
BUG=61753
TEST=none
Review URL: http://codereview.chromium.org/4635012
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/4980001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
resubmit
Revert 66002 - Change the FF CEEE to create its chrome frame instance initially hidden, and
make it visible only once the content is done loading. This avoids any flicker
at startup, and fixes a bug where the chrome frame instance is removed after
a print preview.
Also added support to chrome frame to send an uninitialized ready state
when its being torn down.
BUG=62979
TEST=Make sure that there is no UI flicker on chrome frame startup, and make
sure that the extenions works correct after showing print preview and closing
it.
Review URL: http://codereview.chromium.org/4882004
TBR=rogerta@chromium.org
Review URL: http://codereview.chromium.org/4855005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
make it visible only once the content is done loading. This avoids any flicker
at startup, and fixes a bug where the chrome frame instance is removed after
a print preview.
Also added support to chrome frame to send an uninitialized ready state
when its being torn down.
BUG=62979
TEST=Make sure that there is no UI flicker on chrome frame startup, and make
sure that the extenions works correct after showing print preview and closing
it.
Review URL: http://codereview.chromium.org/4882004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fix all known instances or explicitly allow them. Usually the fix involves switching from Default traits to Lazy traits.
BUG=61753
TEST=none
Review URL: http://codereview.chromium.org/4635012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/4903001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move the automation message files from chrome/test/automation to
chrome/common/. This requires a temporary override to chrome/common/DEPS until
Part 3 lands.
BUG=51409
TEST=compiles
Review URL: http://codereview.chromium.org/4758001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
GetAllCookieStores API call.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4747004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the version mismatch warning dialog. Used this in ceee/ to only show
it once per tab.
Changed the logic in Firefox to show the warning dialog even when
in privileged mode. This will mean it gets shown once per Firefox
window.
Wrote a unit test for the additional logic in ChromeFrameActivex.
To write the unit test, used com_mock.py to generate a mock of
the IChromeFramePrivileged interface. This can be extended to
generate mocks of the other CF interfaces.
Discovered duplication of np_browser_functions.h and .cc, resolved
this to a single copy (the one under chrome_frame).
Changed things around so chrome_tab.idl is built only once; this
also lets me more easily depend on it in the com_mock rule.
BUG=none
TEST=chrome_frame_unittests.exe
Review URL: http://codereview.chromium.org/4563001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65613 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixed comment.
Patch submitted by vitalybuka@google.com
Original review at http://codereview.chromium.org/4757001/
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Taken from:
http://codereview.chromium.org/4648004/show
Improved the way InfobarBrowserWindow is instantiated.
2. Fixed AddRef/Release correspondence.
3. Fixed an assertion if infobar is closed before it was opened.
4. Renamed InfobarBrowserWindow::Delegate::OnWindowClose to OnBrowserWindowClose to reduce confusion with InfobarWindow::Delegate::OnWindowClose.
5. Created unit tests for infobar_api_module.
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=0
TEST=None.
Review URL: http://codereview.chromium.org/4641002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4736002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65532 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Some tests were explicitly setting the last error that an expected mock method would have set in the real world, but some code in the mean time can reset it to zero, so we now set the error code as part of the mocked expectation using testing::Invoke.
BUG=None
Test=Make sure the unit tests always succeed.
Review URL: http://codereview.chromium.org/4646002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
ConnectExternalTab.
The ChromeFrame objects now provides an unfrozen interface called IChromeFramePrivate. This interface provides a GetSessionId() which returns the ID used by Chrome in its Tab javascript object. This ID is necessary in CEEE for its tabs management.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/4467002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65257 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=0
TEST=None
Review URL: http://codereview.chromium.org/4482002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I don't have a good enough understanding of the way the reference
counting works in this code to fix it right away; will ask Siggi to
take a look tomorrow. I believe the test failure may be IE9-specific
as I am running IE, and these tests have been required to run for any
CEEE changes prior to commit for a long time.
BUG=61969
TEST=The only failing test from running mediumtest_ie.exe should be the one I have marked FAILS_
Review URL: http://codereview.chromium.org/4540001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4496001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BrowserHelperObject::BrowserContainsChromeFrame.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4490002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change extends the log severities into the negative for VLOG verbosities.
It also keeps track of file/line information and passes it to any registered log handler.
The log level is naturally controlled by translating ETW log levels to the severities.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4164011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
There seems to be cases where there is an event with no type and get_type return a success code (probably S_FALSE, but I couldn't confirm it) and doesn't set the type string pointer return argument.
BUG= 61900
TEST= Make sure we still get proper web progress notifications...
Review URL: http://codereview.chromium.org/4444002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65053 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/4262001/show
The r64883 broke most unit tests in CEEE that relied on disabling logs while testing error paths.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/4390001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
will be removed as soon as getSessionId is implemented in ChromeFrame. Also, it is not needed for the other code path as ChromeFrame does make the check in it.
BUG=3161153
TEST=None
Review URL: http://codereview.chromium.org/4321007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4262005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64819 0039d316-1c4b-4281-b951-d872f2087c98
|
|
Environment), an optional feature of Chrome Frame that acts as an
adapter layer for a subset of the Chrome Extension APIs. This enables
extensions that stick to the supported subset of APIs to work in the
context of Chrome Frame with minimal or sometimes no changes.
See http://www.chromium.org/developers/design-documents/ceee for an
overview of the design of CEEE.
TEST=unit tests (run ceee/smoke_tests.bat as an administrator on Windows)
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64712 0039d316-1c4b-4281-b951-d872f2087c98
|