summaryrefslogtreecommitdiffstats
path: root/ceee
Commit message (Collapse)AuthorAgeFilesLines
* Fix a stupid thing I did this morning...mad@google.com2010-11-242-16/+5
| | | | | | | | BUG=0 TEST=Alweays test more than just a few simple things... Review URL: http://codereview.chromium.org/5277003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67294 0039d316-1c4b-4281-b951-d872f2087c98
* Implements tabs.getCurrent, and fixes windows.getCurrent, in IE CEEE.cindylau@google.com2010-11-2424-138/+732
| | | | | | | | | | | | | | | | This is achieved by creating a map between tool band Chrome Frame instances and tab windows, and using the associated tab sent by the automation message, which is the tool band CF instance when the call originates from a tool band. Also added some unit tests and slightly changed logic for the ExecutorsManager tab ID management code, which was missing tests before. BUG=none TEST=ie_unittests.exe Review URL: http://codereview.chromium.org/5102009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67273 0039d316-1c4b-4281-b951-d872f2087c98
* Don't try to use the RPC on teh Broker BEFORE the Broker gets CoCreated.mad@google.com2010-11-241-40/+49
| | | | | | | | BUG=0 TEST=Make sure we can start IE with a CRX in it. Review URL: http://codereview.chromium.org/5330006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67262 0039d316-1c4b-4281-b951-d872f2087c98
* Stop using Hard Coded copies of GUID strings in RGS files.mad@google.com2010-11-2312-28/+51
| | | | | | | | | BUG=0 TEST=Make sure everything works after unregistration and re-registration. Review URL: http://codereview.chromium.org/5113005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67180 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to recommit r67153 with successful tries.hansl@google.com2010-11-238-43/+87
| | | | | | | | | | Review here: http://codereview.chromium.org/5257003 BUG=None TEST=None Review URL: http://codereview.chromium.org/5356002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67167 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 67153 - Ajusted the BrokerRpcClient, BHO and mediumtests to correctly ↵rsimha@chromium.org2010-11-238-87/+43
| | | | | | | | | | | | | | | EXPECT on Rpc calls. Also ajusted some invalid comments in the RpcServer and fixed a typo in the BHO mediumtest name. Reason for revert: broke the windows build. BUG=None TEST=mediumtest_ie.exe Review URL: http://codereview.chromium.org/5257003 TBR=hansl@google.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67156 0039d316-1c4b-4281-b951-d872f2087c98
* Ajusted the BrokerRpcClient, BHO and mediumtests to correctly EXPECT on Rpc ↵hansl@google.com2010-11-238-43/+87
| | | | | | | | | | | calls. Also ajusted some invalid comments in the RpcServer and fixed a typo in the BHO mediumtest name. BUG=None TEST=mediumtest_ie.exe Review URL: http://codereview.chromium.org/5257003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67153 0039d316-1c4b-4281-b951-d872f2087c98
* Fix presubmit script so smoke_test check works after move. Also let itjoi@chromium.org2010-11-231-1/+3
| | | | | | | | | | | work with cygwin clients. BUG=64202 TEST=none Review URL: http://codereview.chromium.org/5278005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67147 0039d316-1c4b-4281-b951-d872f2087c98
* Unset accidental +x flag on file.evan@chromium.org2010-11-231-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67127 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 67103 - Revert 67102 - Use async COM to service tab executor requests.siggi@chromium.org2010-11-2319-26/+1529
| | | | | | | | | | | | | | | | | | | | | | | | | Change to proxy/stub marshaling from typelib marshaling, with manual registration of proxy/stubs. Moving away from registered proxy/stubs is desireable in the context of upcoming GCF autoupdate changes, and this is an opportune moment. Implement an async ICeeeTabExecutor that defers execution until a posted message is processed. This avoids (I hope) processing reentrantly on out-of-apartment invocations in IE, which has a tendency to lead to deadlocks and general nastyness. BUG=none TEST=unittests in change Review URL: http://codereview.chromium.org/4845001 TBR=siggi@chromium.org Review URL: http://codereview.chromium.org/5343001 TBR=siggi@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67122 0039d316-1c4b-4281-b951-d872f2087c98
* Fix include problem in .rc file.joi@chromium.org2010-11-231-4/+4
| | | | | | | | | | TBR=siggi@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/5262003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67112 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 67102 - Use async COM to service tab executor requests.siggi@chromium.org2010-11-2319-1529/+26
| | | | | | | | | | | | | | | | | | | | | | | Change to proxy/stub marshaling from typelib marshaling, with manual registration of proxy/stubs. Moving away from registered proxy/stubs is desireable in the context of upcoming GCF autoupdate changes, and this is an opportune moment. Implement an async ICeeeTabExecutor that defers execution until a posted message is processed. This avoids (I hope) processing reentrantly on out-of-apartment invocations in IE, which has a tendency to lead to deadlocks and general nastyness. BUG=none TEST=unittests in change Review URL: http://codereview.chromium.org/4845001 TBR=siggi@chromium.org Review URL: http://codereview.chromium.org/5343001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67103 0039d316-1c4b-4281-b951-d872f2087c98
* Use async COM to service tab executor requests.siggi@chromium.org2010-11-2319-26/+1529
| | | | | | | | | | | | | | | | | | | | Change to proxy/stub marshaling from typelib marshaling, with manual registration of proxy/stubs. Moving away from registered proxy/stubs is desireable in the context of upcoming GCF autoupdate changes, and this is an opportune moment. Implement an async ICeeeTabExecutor that defers execution until a posted message is processed. This avoids (I hope) processing reentrantly on out-of-apartment invocations in IE, which has a tendency to lead to deadlocks and general nastyness. BUG=none TEST=unittests in change Review URL: http://codereview.chromium.org/4845001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67102 0039d316-1c4b-4281-b951-d872f2087c98
* Working around library->library dependency issues by adding explicitjoi@chromium.org2010-11-236-5/+14
| | | | | | | | | | | | | | | dependency on any static library's transitive dependency on a code-generating target. Some belt-and-suspenders stuff as well; shouldn't hurt. BUG=63479 TEST=it builds Review URL: http://codereview.chromium.org/5136004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67062 0039d316-1c4b-4281-b951-d872f2087c98
* Committing patch http://codereview.chromium.org/5288001/ from ↵joi@chromium.org2010-11-231-5/+18
| | | | | | | | | | | vitalybuka@google.com. BUG=none TEST=none Review URL: http://codereview.chromium.org/5284002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67059 0039d316-1c4b-4281-b951-d872f2087c98
* Reconstructing 67000.bradnelson@google.com2010-11-231-1/+1
| | | | | | | | | | | | | | (python24 -> python26). Regression in nacl fixed, new DEPS change. BUG=None TEST=NOne Review URL: http://codereview.chromium.org/5310001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67057 0039d316-1c4b-4281-b951-d872f2087c98
* Committing patch http://codereview.chromium.org/5153004/ from ↵joi@chromium.org2010-11-233-1/+38
| | | | | | | | | | | vitalybuka@google.com BUG=none TEST=none Review URL: http://codereview.chromium.org/5268002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67056 0039d316-1c4b-4281-b951-d872f2087c98
* Add UMA histograms services to CEEE. The histograms are aggregated in the ↵hansl@google.com2010-11-2313-1/+261
| | | | | | | | | | | | | | | broker, using RPC to send them, and then sent once every 15 minutes to the server. Uses metrics_service.cc from chrome_frame. Adds dependency to RPC runtime for the BHO and to glue_renderer for linking. This depends on http://codereview.chromium.org/5247001 for uploading data. BUG=none TEST=none Review URL: http://codereview.chromium.org/5116008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67035 0039d316-1c4b-4281-b951-d872f2087c98
* IE CEEE: Revert content script injection back to no isolation mode.ericdingle@chromium.org2010-11-223-80/+3
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5267001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67006 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 67000.bradnelson@google.com2010-11-221-1/+1
| | | | | | | | | | BUG=None TEST=None TBR=nsylvain Review URL: http://codereview.chromium.org/5272001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67004 0039d316-1c4b-4281-b951-d872f2087c98
* Switching chrome to use python26 in place of python24.bradnelson@google.com2010-11-221-1/+1
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/5121009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67000 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure tasks retain ownership of arguments for deferred execution, take two.siggi@chromium.org2010-11-221-2/+2
| | | | | | | | | BUG=63748 TEST=none Review URL: http://codereview.chromium.org/5092010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66984 0039d316-1c4b-4281-b951-d872f2087c98
* Firing event to broker without worker thread.siggi@chromium.org2010-11-2232-323/+211
| | | | | | | | | | | | Landing for vitalybuka@google.com. Original review at http://codereview.chromium.org/4989002/. BUG=3093218 TEST=Unittests pass Review URL: http://codereview.chromium.org/5241002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66946 0039d316-1c4b-4281-b951-d872f2087c98
* Always use flag needed by CEEE. Now that we use the same profile forjoi@chromium.org2010-11-216-38/+0
| | | | | | | | | | | | | | | | CF and CEEE, we need to ensure they both start Chrome with the same flags. Since IChromeFramePrivileged is a private/unfrozen interface, I simply removed the GetChromeExtraArguments method as we are no longer using it. BUG=63427 TEST=none Review URL: http://codereview.chromium.org/5109006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66916 0039d316-1c4b-4281-b951-d872f2087c98
* Add a PRESUBMIT.py for Chrome Frame. As many of the checks will be commonjoi@chromium.org2010-11-191-6/+7
| | | | | | | | | | | | | across CF and CEEE, this just reuses the ceee_presubmit.py file with some special-casing to avoid checks written for CEEE that do not apply to CF. BUG=none TEST=none Review URL: http://codereview.chromium.org/5162007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66815 0039d316-1c4b-4281-b951-d872f2087c98
* Reland 66791 (change was innocent)willchan@chromium.org2010-11-191-5/+1
| | | | | | | | | | | | | | | | | | | Revert 66719 - Reland r65996. Disallows Singletons on non-joinable thread. Test breakages caused by this change have been fixed here or in other changelists. BUG=61753 TEST=none Review URL: http://codereview.chromium.org/5024003 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/5206005 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/5242002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66808 0039d316-1c4b-4281-b951-d872f2087c98
* The FF CEEE does not inject content scripts into the content windowrogerta@chromium.org2010-11-192-27/+24
| | | | | | | | | | | | | | | | | | | | at initial start up if the page loaded contains iframes. The problem is that a hash map was being used to track the scripts to run, and the window object was used as a key. The window of iframes was mapping to the same entry in the map as the top level window, causing some scripts to be lost and not run. The code now puts all scripts to run in an array. As it runs each one, it sees if the scripts have already been run in the given window. If so, they are not run again. BUG=0 TEST=make sure that content scripts are run for the first page loaded into chrome frame. Review URL: http://codereview.chromium.org/5188007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66797 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 66719 - Reland r65996. Disallows Singletons on non-joinable thread.willchan@chromium.org2010-11-191-1/+5
| | | | | | | | | | | | | | Test breakages caused by this change have been fixed here or in other changelists. BUG=61753 TEST=none Review URL: http://codereview.chromium.org/5024003 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/5206005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66791 0039d316-1c4b-4281-b951-d872f2087c98
* Check for CCom(Ptr|BSTR|Variant) in files being touched injoi@chromium.org2010-11-191-0/+18
| | | | | | | | | | | | a change and warn if they are present. BUG=none TEST=none Review URL: http://codereview.chromium.org/5198004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66787 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure tasks retain ownership of arguments for deferred execution.siggi@chromium.org2010-11-193-74/+149
| | | | | | | | | BUG=63748 TEST=Unit and intergation tests. Review URL: http://codereview.chromium.org/5191003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66767 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r65996. Disallows Singletons on non-joinable thread.willchan@chromium.org2010-11-191-5/+1
| | | | | | | | | | | Test breakages caused by this change have been fixed here or in other changelists. BUG=61753 TEST=none Review URL: http://codereview.chromium.org/5024003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66719 0039d316-1c4b-4281-b951-d872f2087c98
* Make ceee_ie_lib explicitly depend on initializing_coclass.siggi@chromium.org2010-11-181-0/+1
| | | | | | | | | | | Seems to be a GYP bug that incorrectly propagates dependencies of libraries. BUG=none TEST=chrome frame builder builds. Review URL: http://codereview.chromium.org/5232001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66681 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a logic mistake in ExecutorsManager::DeleteTabHandle that causes the ↵cindylau@google.com2010-11-181-2/+2
| | | | | | | | | | | broker to DCHECK fail every time a tab is closed. BUG=0 TEST=None Review URL: http://codereview.chromium.org/5174007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66678 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a problem that would only show up in non-admin mode.mad@chromium.org2010-11-181-0/+9
| | | | | | | | | | | | We were letting the result of IEIsProtectedModeURL decide the code flow of our tests, and for some reason, when run in non-admin mode, it causes a CoCreateInstance to be called and we mock it. So we decided to mock IEIsProtectedModeURL too, so that we can have a more deterministic code flow, and now we have the opportunity (behind a TODO for now) to valid all code flows based on diferent return values. TEST=Make sure the unit tests succeed in both and non-admin mode, which ever version of IE instance on whatever version of the OS. BUG= 62387 Review URL: http://codereview.chromium.org/5116004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66655 0039d316-1c4b-4281-b951-d872f2087c98
* Set version string for Breakpad reporting by ceee_ie.dlljoi@chromium.org2010-11-184-7/+17
| | | | | | | | | | | | and ceee_broker.exe. BUG=none TEST=none Review URL: http://codereview.chromium.org/5113001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66648 0039d316-1c4b-4281-b951-d872f2087c98
* Manually instantiate the BHO at need from the Toolband.siggi@chromium.org2010-11-186-5/+225
| | | | | | | | | | | | | | | | | | Enabling (either through IE's plugin manager or via its context menu) a visual gadget depending on ceee would create and display that gadget, but the BHO would not be instantiated (the latter part is consistent with documented IE BHO behaviur). The new mechanism will allow a dependant CF gadget to make sure the BHO it requries already exists and take action (for instance- create the BHO) when required. The pattern for this behaviour is taken (partly) from chrome_frame_activex.cpp. Submitting for motek@google.com. Original review at http://codereview.chromium.org/4918001/. BUG=3019459 TEST=none Review URL: http://codereview.chromium.org/5227001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66640 0039d316-1c4b-4281-b951-d872f2087c98
* Add shared macros for stringizing and converting ANSI string constantsjoi@chromium.org2010-11-181-7/+3
| | | | | | | | | | | | | | | | | | | | | (in particular defined by macros) to wide string constants. Convert existing locally-defined stringizing to use the shared macros. Unit tests for the shared macros. This also fixes a minor bug in ceee_module_util.cc where I accidentally quoted a string constant I only meant to convert to wide (this caused no bug, but was unintended, so the change in semantics in that file in the current change is intentional). BUG=none TEST=automated tests Review URL: http://codereview.chromium.org/5103001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66579 0039d316-1c4b-4281-b951-d872f2087c98
* Change the FF CEEE to create its chrome frame instance initially hidden, androgerta@chromium.org2010-11-184-37/+30
| | | | | | | | | | | | | | | | | | | make it visible only once the content is done loading. This avoids any flicker at startup, and fixes a bug where the chrome frame instance is removed after a print preview. Also added support to chrome frame to send an uninitialized ready state when its being torn down. Did some cleanup in the chrome frame tests which were broke the first time this change was committed. BUG=62979 TEST=Make sure that there is no UI flicker on chrome frame startup, and make sure that the extenions works correct after showing print preview and closing it. Review URL: http://codereview.chromium.org/5022003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66552 0039d316-1c4b-4281-b951-d872f2087c98
* Remove now-redundant precompile headers and builders, take two.siggi@chromium.org2010-11-1713-88/+6
| | | | | | | | | | | Remove all mention of precompile files from GYP files. BUG=none TEST=it compiles Review URL: http://codereview.chromium.org/5190002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66547 0039d316-1c4b-4281-b951-d872f2087c98
* Add a dummy library statement to the RPC idl file.siggi@chromium.org2010-11-171-2/+13
| | | | | | | | | | | This prevents it from being forever out of date. BUG=none TEST=the broker_rpc_lib target is not always out of date. Review URL: http://codereview.chromium.org/5109005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66546 0039d316-1c4b-4281-b951-d872f2087c98
* Submitting changes by Vitaly Buka, reviewed here: ↵twiz@google.com2010-11-171-0/+4
| | | | | | | | | | | http://codereview.chromium.org/5168002 BUG=3205655 TEST=none Review URL: http://codereview.chromium.org/5182003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66543 0039d316-1c4b-4281-b951-d872f2087c98
* IE CEEE: Wrap frameElement access in ceee_bootstrap.js to prevent access ↵ericdingle@chromium.org2010-11-171-1/+8
| | | | | | | | | | | denied error. BUG=none TEST=none Review URL: http://codereview.chromium.org/5122004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66530 0039d316-1c4b-4281-b951-d872f2087c98
* IE CEEE: Release native_api_ in ContentScriptManager when script host ↵ericdingle@chromium.org2010-11-171-0/+1
| | | | | | | | | | | initialization fails. BUG=none TEST=none Review URL: http://codereview.chromium.org/5186002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66514 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 66501 - Removing now-redundant precompile files.siggi@chromium.org2010-11-176-0/+64
| | | | | | | | | | | | | This broke the windows compile as I forgot to remove gyp file references to them. BUG=none TEST=it compiles Review URL: http://codereview.chromium.org/5171002 TBR=siggi@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66509 0039d316-1c4b-4281-b951-d872f2087c98
* Removing now-redundant precompile files.siggi@chromium.org2010-11-176-64/+0
| | | | | | | | | BUG=none TEST=it compiles Review URL: http://codereview.chromium.org/5171002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66501 0039d316-1c4b-4281-b951-d872f2087c98
* Move log statements out of functions that contain __try/__except clauses, ↵siggi@chromium.org2010-11-171-3/+7
| | | | | | | | | | | because logging instantiates objects, and under some compiler settings the two cannot coexist in the same function. BUG=none TEST=it compiles Review URL: http://codereview.chromium.org/5104003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66480 0039d316-1c4b-4281-b951-d872f2087c98
* Committing for Vadim:mad@google.com2010-11-179-36/+541
| | | | | | | | | | | http://codereview.chromium.org/4991002/ New unittests for infobar. BUG=None TEST=None git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66459 0039d316-1c4b-4281-b951-d872f2087c98
* IE CEEE: Add another layer of isolation to content scripts execution through ↵ericdingle@chromium.org2010-11-173-40/+51
| | | | | | | | | | | use of window vs unsafeWindow. BUG=none TEST=none Review URL: http://codereview.chromium.org/5133002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66450 0039d316-1c4b-4281-b951-d872f2087c98
* Add the Chrome version as one of the things we check to see ifjoi@chromium.org2010-11-153-8/+36
| | | | | | | | | | | | | | | we should attempt re-install. This helps robustness e.g. in the case where we change profile directories (as we recently did). Mark a test that I noticed was flaky (and open a bug for it). BUG=none TEST=none Review URL: http://codereview.chromium.org/5027001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66180 0039d316-1c4b-4281-b951-d872f2087c98
* IE CEEE: Explicitly assign window properties/methods into the script host ↵ericdingle@chromium.org2010-11-153-23/+83
| | | | | | | | | | | global namespace instead of automatically. BUG=none TEST=none Review URL: http://codereview.chromium.org/4997002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66144 0039d316-1c4b-4281-b951-d872f2087c98