| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- The glue passes the notification checkbox state;
- The glue updates the "Save locally" checkbox state;
- The dialog reacts to the notification checkbox state change;
- Notifications area is moved to the top;
- No overlapping of the checkbox label and the check box.
BUG=230549, 222751
NOTRY=True
Review URL: https://chromiumcodereview.appspot.com/14579003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197570 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=234124
R=cjhopman@chromium.org, nileshagrawal@chromium.org
Review URL: https://codereview.chromium.org/14417019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Removes hardcoded "Add..." and "Edit..." menu items.
- Adds an "Edit" button to editable items in a drop-down.
- Removes our own strings and uses those provided by the controller.
(We could change the controller strings through .grd per platform.)
- Handles "Edit" button clicks.
- Pulls back the edited data into the presentable menu item.
UI mocks (option B):
https://docs.google.com/a/google.com/document/d/15USYTwRRhbDQRdbA1JpmWs53opL8864cwt9ETCLCFKM/edit#heading=h.n459ql1no01k
Follow-up bugs: 224162 (IsMenuItemEditable), 230685 (collapse user input).
BUG=224162, 225551, 225554, 236437
Review URL: https://chromiumcodereview.appspot.com/14061013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Controller doesn't survive it.
BUG=235493
NOTRY=True
Review URL: https://chromiumcodereview.appspot.com/14307018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The call to read the preference used to happen on every application startup
even if the provider is not going to be used. Since we only kick off the
shared preferences load on the line before, the read causes the UI thread to
pause until the preferences are done loading on a separate thread.
Moving access to this variable into a getter function to have it lazily
initialize.
BUG=234927
Review URL: https://chromiumcodereview.appspot.com/14450005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We were disconnecting the Java side from the C/C++ too early.
BUG=235493
NOTRY=True
Review URL: https://chromiumcodereview.appspot.com/14021006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196821 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes the Java side of the constants and relevant layouts after
https://chromiumcodereview.appspot.com/14366018/
TBR=yusufo@chromium.org,dbeam@chromium.org
TEST=manual
BUG=235458
NOTRY=True
Review URL: https://chromiumcodereview.appspot.com/14284016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Adding errors to spinners in the AutofillDialog on validation.
BUG=230958
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/13979008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fot the steady state: on Submit/Cancel we receive a Hide() call from the controller anyway, so there is no need to rely on any "automatic" behavior.
For the editing state: we should never dismiss the dialog.
Note that the Back button is ignored with this CL (it has quite surprising behavior in the editing mode anyway), see http://crbug.com/234477.
BUG=233809
NOTRY=True
Review URL: https://chromiumcodereview.appspot.com/14159021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use controller-provided strings and enables for
- Dialog "confirm" button;
- Dialog "cancel" button;
- "Save locally" checkbox;
- Progress bar.
Refresh the state on Show().
Avoid crashing if the state is not yet set.
BUG=226853, 223134
Review URL: https://chromiumcodereview.appspot.com/14018031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196060 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Create a new class WindowAndroid that serves the purpose of representing a native (platform specific) view where Chromium code expects to have a cross platform handle to the system view type. As Views are Java objects on Android, ViewAndroid.java and view_android.* will provide the expected abstractions on the C++ side and allow it to be flexibly glued to an actual Android Java View at runtime. It should only be used where access to Android Views is needed from the C++ code as there are easier/better ways to access Views from Java.
This new abstraction will allow to reuse AutofillPopup for regular use in a webpage (using ContentView) as well as for AutofillDialog.
BUG=229199
Review URL: https://chromiumcodereview.appspot.com/14018004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
last commit was reverted due to a conflict between r195565 and r195569
BUG=225093
TBR=sky@chromium.org,isherman@chromium.org,aruslan@chromium.org,sail@chromium.org
Review URL: https://codereview.chromium.org/14414002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195616 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=226509
Review URL: https://chromiumcodereview.appspot.com/13977004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Breaks compile on Linux and Linux ChromiumOS.
> retry 195316 "Remove "Use billing for shipping" checkbox in fav..."
>
> this time, don't break Mac.
>
> BUG=225093
> TBR=sky@chromium.org,isherman@chromium.org,aruslan@chromium.org,sail@chromium.org
>
> Review URL: https://codereview.chromium.org/13879013
TBR=estade@chromium.org
Review URL: https://codereview.chromium.org/14146008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
this time, don't break Mac.
BUG=225093
TBR=sky@chromium.org,isherman@chromium.org,aruslan@chromium.org,sail@chromium.org
Review URL: https://codereview.chromium.org/13879013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Breaks Mac ASAN compile:
http://build.chromium.org/p/chromium.memory/buildstatus?builder=Mac%20ASAN%20Builder&number=19054
> Remove "Use billing for shipping" checkbox in favor of item in suggestions menu.
>
> BUG=225093
>
> Review URL: https://codereview.chromium.org/14129005
TBR=estade@chromium.org
Review URL: https://codereview.chromium.org/13877016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195320 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=225093
Review URL: https://codereview.chromium.org/14129005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Renaming NativeWindow to WindowAndroid for consistency with C++ name of window_android.
Also removing AwNativeWindow as according to joth@ it is no longer isued in WebView.
BUG=233064
Review URL: https://chromiumcodereview.appspot.com/14169011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=226873
Review URL: https://codereview.chromium.org/14122018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Cleaning up the content/public/android/java/src/.. ../content/browser/
directory by moving input related classes to a separate directory.
BUG=230059
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/14100003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes the initialization so that updating menu items dont trigger
layout changes. It makes the dialog resize on keyboard coming up and down.
It also adds an email layout so that we have a valid(although non-ideal)
transition for all sections. The transition will be fixed properly on
crbug.com/180980
BUG=226500,226496,226497
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/14165005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
On Android, ProfileSyncService will use methods of AccountManagerHelper that
retry in case of network errors.
BUG=165687
Review URL: https://chromiumcodereview.appspot.com/12545023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This checkbox will be visible in the pay locally layout and will give the
option to save the edited details locally in Chrome.
BUG=222751
Review URL: https://chromiumcodereview.appspot.com/14099002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193546 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
namespace autofill
BUG=140037,165534
Review URL: https://chromiumcodereview.appspot.com/13247002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Wrapped the onMeasure call with a version check and added xml attributes to
make the ICS version look nicer.
BUG=222051
Review URL: https://chromiumcodereview.appspot.com/14095004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193509 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=149661
Review URL: https://codereview.chromium.org/13862016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[X] Save details in Google Wallet
checkbox notification and the account chooser (and rest of the dialog). Previous problems were:
- the notification disappeared when the account chooser wasn't on Wallet
- the account chooser didn't change to "Pay without Wallet" when unchecked
- no way to tell if user is signed in when "Pay without Wallet" showing
- closing a dialog changed the state of an existing dialog (no longer first run)
BUG=224787
R=estade@chromium.org,aruslan@chromium.org,sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/13625002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adding the checkbox and the wiring necessary to properly change it when
the user adds or edits a shipping address manually.
BUG=222747
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/13851002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is purely a crash and texts fix; the proper solution is to have an Android-specific model wrapper on the native side (http://crbug.com/224162).
BUG=226172,224162
NOTRY=True
Review URL: https://chromiumcodereview.appspot.com/13441005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adding field validation in editing mode of AutofillDialog for following cases:
- Swiching from one editing field to another.
- Pressing 'Done' button.
BUG=188844
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/13467007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Permission name for Bookmark folders should not be a fixed string but
instead should depend on the package name of the application.
BUG=226056
Review URL: https://chromiumcodereview.appspot.com/13605002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adding the dropdown for country, month and year with the glue that
gives the related string array for a given field. Made changes so
the dialog calls are aware that some views in the edit layout are
spinners and not edittexts. This gives a non-null UI element for each field
now.
BUG=181538
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/13446004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192268 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add api to let clients call the newly added Bookmark.removeAll using
the Private Bookmark api.
BUG=114408
Review URL: https://chromiumcodereview.appspot.com/13410002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This should also help with payment dialogs and content/test shells.
NOTRY=True
Review URL: https://chromiumcodereview.appspot.com/13558003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192098 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Android was enabling Sessions, not Proxy Tabs, via configuration.
BUG=224144, 225428
Review URL: https://chromiumcodereview.appspot.com/13461009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously the code did not clear the old notifications so on the second
update duplicate notifications would appear.
BUG=178536
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/13467008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds the edit box for entering the CVC value and includes
the wiring from the native view class for getting the icon for any
field.
BUG=222755
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/13261003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
New API that could also be used by the Android Webview was introduced in https://codereview.chromium.org/12374099/
BUG=
Review URL: https://chromiumcodereview.appspot.com/12848006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Depends on https://chromiumcodereview.appspot.com/12920006/ and
https://chromiumcodereview.appspot.com/12810009/
Without https://chromiumcodereview.appspot.com/13331007/ the
account chooser will return empty strings and "Google Walet",
but it should be functional otherwise.
BUG=225039
NOTRY=True
Review URL: https://chromiumcodereview.appspot.com/13341002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
At build time, we know what native libraries an apk needs to load.
Instead of requiring those .apks to specify this again in code, instead
generate a .java file containing a list of the libraries to load.
This is done using a pattern similar to resources, content_java is built
with a placeholder NativeLibraries.java (i.e. without an actual value
for its libraries list). The corresponding .class file is not included
in content_java.jar. Then, when building an apk we generate the "real"
NativeLibraries.java (with the real String[]) and include that in the
.apk.
This is designed to also support the component build, where, we will
have to calculate the list of libraries at build time, and sort them in
dependency order (because Android's linker, for some reason, doesn't do
that itself).
BUG=158821
TBR=brettw@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12939021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We were just using three labels before with placeholders. This glues the
native strings to java and starts putting labels for each section.
BUG=225057
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/13254006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This diff is no longer needed since sync code is now upstream. Need this
to refactor the bookmark private api from ChromeBrowserProvider.
BUG=181288
Review URL: https://chromiumcodereview.appspot.com/13228003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, there was only TabAndroid on the native side and no java
counterpart. This makes it impossible to share code between testshell
and Chrome on Android because Java is needed to interact with Android
views and native with the rest of chrome.
Getting the write native pointers assigned is tricky and the flow is as
follow:
Consumers should subclass TabBase in Java and TabAndroid in native.
Construction of the Java subclass initializes the native subclass which
passes the java pointer to TabAndroid so that TabAndroid can associate
the java parent class (TabBase) with it. Destruction follows a similar
flow.
Once this building block is in place, I'll move more of TestShellTab
into TabBase to re-use it. It also opens the door to upstream more of
Tab.
Also moves testshell-specific classes to the testshell libraries and out
of Chrome for android.
BUG=159202
TBR=sky
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/12962006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We will need edit related strings since Android is the only platform that uses them.
Adding "add" related strings as well just in case formatting doesnt match with current
ones
BUG=223134
Review URL: https://chromiumcodereview.appspot.com/12954004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191296 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
controls. Instead we need to manually translate input events and popup windows so they line up appropriately with the web content.
BUG=192727
Review URL: https://chromiumcodereview.appspot.com/12844009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Start showing Autofill Dialog notifications.
BUG=178536
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/13111003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds a JNI method to get the set of enabled types, which is then used
in registering for invalidations.
BUG=224144
Review URL: https://chromiumcodereview.appspot.com/13109002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
dead code.
BUG=222282
Review URL: https://chromiumcodereview.appspot.com/12578027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=196350
Review URL: https://chromiumcodereview.appspot.com/12972006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In order to get OAuth tokens on Android, we have to call out to Java. This CL
makes it possible. It's not the ideal solution but works for now.
BUG= 222271
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190531
Review URL: https://codereview.chromium.org/12880014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190600 0039d316-1c4b-4281-b951-d872f2087c98
|