| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
This should completely get rid of seccomp-legacy (15000+ LOC).
BUG=230142
TBR=ben@chromium.org
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/14271018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Mac and Windows's method.
Review URL: https://chromiumcodereview.appspot.com/12545017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=178750
Review URL: https://chromiumcodereview.appspot.com/12463029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=sky
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Now that our release process in integrated with other platforms we can use the same PRODUCT_VERSION for crash reports.
BUG=174002
Review URL: https://chromiumcodereview.appspot.com/12330020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/12213104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Use a separate product name for Chrome_Linux_ASan to distinguish from Chrome_Linux.
BUG=152150
Review URL: https://codereview.chromium.org/12090090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will allow nacl_helper to link against breakpad_linux.cc (which
calls SetDumpWithoutCrashingFunction()) without pulling in the rest of
logging_chrome.cc, which depends on logging code generated for all IPC
messages which we don't want to pull into nacl_helper.
BUG=https://code.google.com/p/nativeclient/issues/detail?id=2096
TEST=build
Review URL: https://chromiumcodereview.appspot.com/12090096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
After https://chromiumcodereview.appspot.com/10407058 we can compile
breakpad by default and still have it disabled for non-official builds.
Changes the Android build to allow compiling breakpad but not use
it by not creating the crash fd and not passing it to the renderer
process unless breakpad is enabled.
Changes linux and Android to use a switch for enabling breakpad
since that's a lot easier to test with on android then an environment
variable.
BUG=105778,170530
Review URL: https://chromiumcodereview.appspot.com/11969025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178111 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
protocol buffers.
Adding these fields to differentiate between devices with the same 'model' string but different GPUs. Also remove gpu vendor_id and device_id for Android since this concept does not exist for Android.
BUG=165263
Review URL: https://chromiumcodereview.appspot.com/11958047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The build id will be included in about:version page and used for tracking build artifacts
such as static libraries and symbol files with a particular build.
BUG=163224
Review URL: https://chromiumcodereview.appspot.com/11464012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172296 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When there are upwards of 200 threads in a crashing process, each having an
8KB stack, this can result in a huge, 1.8MB minidump file. The Crash Server
throws away any uploaded file larger than 1.2MB. Setting the minidump size
limit (see https://breakpad.appspot.com/487002/) will result in less stack
being dumped when there are so many threads.
BUG=chromium-os:31447, chromium:154546
Contributed by Michael Krebs <mkrebs@chromium.org>
Review URL: https://chromiumcodereview.appspot.com/11142010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Breakpad crash handlers on Android should call
FinalizeCrashDoneAndroid() to dump a chrome fingerprint to the Android
log, and then return false so that breakpad reinstalls the Android
signal handlers which then drop a tombstone.
BUG=160649
Review URL: https://chromiumcodereview.appspot.com/11359214
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/11366229
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This file represents a posix-only concept.
BUG=
Review URL: https://codereview.chromium.org/11293210
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Landing the patch by Denis Glotov (glotov@chromium.org) from http://codereview.chromium.org/11273110/
TBR=thestig
BUG=none
TEST=Build with asan=1, buildtype=Official
Review URL: https://codereview.chromium.org/11367009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165177 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in-process for renderers as well (as the browser cannot access all the
necessary states of the renderer process).
Breakpad has support for generating minidumps to a passed FD (as the renderer
process on Android does not have permission to create file), so the flow on
Android is:
- when a render process is created the browser creates a file and passes its FD
to the process
- the renderer process initializes Breakpad with that FD
- if there is a crash, Breakpad generates the minidump to that FD.
- when the browser process detects a renderer stopped it checks the minidump
file. If it's empty it deletes the file. If it's not empty, it means there
was a crasher in which case it moves it to the crash dump folder for it to be
picked up and uploaded by the Java side.
BUG=None
TEST=Test that minidumps are generated and uploaded when visiting about:crash
and about:crashbrowserforrealz on Android and desktop Chrome.
Review URL: https://chromiumcodereview.appspot.com/11189068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add information about java exceptions to Android breakpad dumps.
BUG=136988
Review URL: https://chromiumcodereview.appspot.com/11096027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=152278
Review URL: https://codereview.chromium.org/10982049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the DoneCallback returns false, breakpad should reinstall the old
signal handlers. Specifically, it will reinstall the Android tombstone
handler. This change ensure that on Android we always return false from
these callbacks. When this happens, the minidump should still be
created/uploaded as normal.
Also, just prior to returning we log a Chrome build fingerprint. This
should appear in the log just above the tombstone.
Requires breakpad DEPS roll to >=1025
(http://breakpad.appspot.com/440002/) to work correctly, but fails
safely without it.
BUG=
Review URL: https://chromiumcodereview.appspot.com/10908115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the Linux side of the following changes:
Windows: http://codereview.chromium.org/9432033
Mac: https://chromiumcodereview.appspot.com/10661057
Also cleans up some surrounding code:
- Change strncpy() calls to safer base::strlcpy().
- No need to NULL terminate after snprintf(), which does that already.
- Use arraysize() throughout.
- No need to call strlen() just to check if a string is empty.
BUG=145323
TEST=Linux crash reports show experiment chunks.
Review URL: https://chromiumcodereview.appspot.com/10890015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154190 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is an updated version of https://chromiumcodereview.appspot.com/10703116/
which got reverted.
When the code is built with ASan, Chrome should register a callback which notifies the browser about a memory error.
The error report message is passed to the crash handler and is then sent to the crash server along with the minidump.
BUG=143657
Review URL: https://chromiumcodereview.appspot.com/10860006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rolling the DEPS of Breakpad in order to get the file descriptor support for
generating minidumps, it is needed on Android.
BUG=None
TEST=Breakpad unit-tests should compile and run.
Review URL: https://chromiumcodereview.appspot.com/10825329
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Causes compile failures on the official builders.
BUG=None
TBR=glider@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10836131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
When the code is built with ASan, Chrome should register a callback which notifies the browser about a memory error.
The error report message is passed to the crash handler and is then sent to the crash server along with the minidump.
Review URL: https://chromiumcodereview.appspot.com/10703116
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10792027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
_linuxish is ambiguous. Use 'target_conditions' to include the required files
that are for linux on Android.
(TBR because the changes in chrome/browser/ui/gtk and content/app/android are all simple changes of #include file names)
BUG=none
TEST=Build successfully
TBR=erg@chromium.org,jrg@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10532178
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Third time is a charm.
Original Reviews:
https://chromiumcodereview.appspot.com/9838033/
http://codereview.chromium.org/9967017
Revert "Revert 131593"
This reverts commit e306ea7f630d4264075913ea3a1a728d98ca9605.
BUG=
TEST=
Review URL: http://codereview.chromium.org/9960072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Speculatively reverting due to gyp update error on official bots:
KeyError: 'src/breakpad/breakpad.gyp:dump_syms#target while trying to load target src/remoting/remoting.gyp:remoting_linux_symbols#target'
This is the only patch in the regression range that touches breakpad.gyp.
---
Upstream Android native crash handling changes.
This is actulaly the second time.
Revert "Revert 131404 - Upstream native crash handling changes for Android."
This reverts commit 421df96aab6267e963ddff16c9f738aa903a2cba.
Conflicts:
chrome/browser/chrome_browser_main.cc
BUG=
TEST=
Review URL: http://codereview.chromium.org/9967017
TBR=carlosvaldivia@google.com
Review URL: https://chromiumcodereview.appspot.com/10037013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is actulaly the second time.
Revert "Revert 131404 - Upstream native crash handling changes for Android."
This reverts commit 421df96aab6267e963ddff16c9f738aa903a2cba.
Conflicts:
chrome/browser/chrome_browser_main.cc
BUG=
TEST=
Review URL: http://codereview.chromium.org/9967017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131593 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Android native crash handling is almost identical to linux handling with
some differences.
Note that even after this change Chrome on Android will not compile with
the USE_LINUX_BREAKPAD flag. Forthcomming changes in breakpad should
remedy this state of affairs.
BUG=
TEST=
Review URL: http://codereview.chromium.org/9838033
TBR=carlosvaldivia@google.com
Review URL: https://chromiumcodereview.appspot.com/9999004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Android native crash handling is almost identical to linux handling with
some differences.
Note that even after this change Chrome on Android will not compile with
the USE_LINUX_BREAKPAD flag. Forthcomming changes in breakpad should
remedy this state of affairs.
BUG=
TEST=
Review URL: http://codereview.chromium.org/9838033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=111733
TEST=none
Review URL: http://codereview.chromium.org/9834001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9835001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
information will be added by Chrome (in different CL) just before performing error-prone printer related operations.
BUG=108194
TEST=none
Review URL: http://codereview.chromium.org/9600060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127105 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
driver. This information will be added by Chrome (in different CL) just before performing error-prone printer related operations.
BUG=108194
TEST=none
Review URL: http://codereview.chromium.org/9600060
TBR=vitalybuka@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
information will be added by Chrome (in different CL) just before performing error-prone printer related operations.
BUG=108194
TEST=none
Review URL: http://codereview.chromium.org/9600060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:26357
TEST=see bug
Review URL: https://chromiumcodereview.appspot.com/9460053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
checking; remove shadow variables.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9460032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9432015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:20487
TEST=manual
Review URL: http://codereview.chromium.org/8618015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121285 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=96179
TEST=none
Review URL: http://codereview.chromium.org/9288055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=46368,chromium-os:25195
TEST=none
Review URL: http://codereview.chromium.org/9212033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
sizeof(int) != sizeof(void*) so use another ugly cast to make it so
BUG=chromium:108725
TEST=build chrome 64bit ChromeOS with internal use flag enabled
Change-Id: Ie60b136ef7ccd8e9f6a41cd53bffaa679cf8eb0f
Review URL: http://codereview.chromium.org/9006049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also move the --process=extension command line flag to --extension-process
BUG=89642
TEST=everything still works
Review URL: http://codereview.chromium.org/8113035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- number of extensions
- up to 10 extension IDs
- number of views
- number of switches
- up to 15 switches
BUG=60993, 82977
TEST=none
TBR=agl
Review URL: http://codereview.chromium.org/7926002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reason for revert: Broke clang compile.
- number of extensions
- up to 10 extension IDs
- number of views
- number of switches
- up to 15 switches
BUG=60993,82977
TEST=none
Review URL: http://codereview.chromium.org/7886057
TBR=thestig@chromium.org
Review URL: http://codereview.chromium.org/7915004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- number of extensions
- up to 10 extension IDs
- number of views
- number of switches
- up to 15 switches
BUG=60993,82977
TEST=none
Review URL: http://codereview.chromium.org/7886057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=92949
TEST=none
Review URL: http://codereview.chromium.org/7715006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
headers. No code change.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7198033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91379 0039d316-1c4b-4281-b951-d872f2087c98
|