summaryrefslogtreecommitdiffstats
path: root/chrome/app/breakpad_mac.mm
Commit message (Collapse)AuthorAgeFilesLines
* Fix Breakpad-enabled builds on the Mac.mark@chromium.org2009-09-011-1/+1
| | | | | | | | | | | | | | | | | | | .../src/chrome/app/breakpad_mac.mm: In function ‘void InitCrashReporter()’: .../src/chrome/app/breakpad_mac.mm:56: error: ‘parsed_command_line’ was not declared in this scope IMPORTANT NOTE: When you're making changes to files that aren't part of the normal build, you MUST test them. The next time I see an obvious case of "oops, I never actually built that file," I'm just going to back it out. As for this instance, I'm fixing it now, but you MUST build and test your change locally. We can't afford accidentally losing Breakpad coverage. I've already seen an embarrassing number of instances of "oops, Breakpad's broken" but we've fortunately caught them all before integrating them into a release. BUG=It doesn't build TEST=Does it build now? Review URL: http://codereview.chromium.org/178056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25041 0039d316-1c4b-4281-b951-d872f2087c98
* Change when we enable Apple's Crash reporter.jeremy@chromium.org2009-08-311-4/+7
| | | | | | | | | | | | | | | | | | | | Enable Apple Crash Reporter for Browser process in Non-Debug builds. * Introduce mac_util::IsBackgroundProcess(). * Invert logic around Breakpad Enabling/Disabling to make it clearer. * Honor the kDisableBreakpad switch. Our new policy: * Breakpad is enabled/disabled based on the user stats reporting opt-in flag - this hasn't changed. * Always disable Apple Crash in background processes (plug-in, renderer, etc). * If Breakpad is enabled browser crashes will be passed to Crash Reporter. * If Breakpad is NOT enabled browser [or any other foreground app] crashes will be passed to Crash Reporter in Release builds. Effectively this means that we now enable Crash Reporter for the browser process in Chromium release builds so these will no longer crash silently with no trace. Review URL: http://codereview.chromium.org/180048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24959 0039d316-1c4b-4281-b951-d872f2087c98
* Tweak the comment in the lproj fixup script to explain why we need an "en" ↵thomasvl@chromium.org2009-08-241-1/+2
| | | | | | | | | | | | | | | | | | | | | | folder. Added a string for the products short name, this is current mac only, and is used for the application menu title via the infoplist.strings file. Added source for a tool to build InfoPlist.strings files based on the values within the GRD files. Run the InfoPlist.strings generation tool during the build. Added a script to take a string and list of locale and generate all the versions of the string. Wired up the string locale tool so GYP knows about all the inputs/outputs from the InfoPlist.strings generation tool. Stop setting some of the Info.plist keys that are now covered by the InfoPlist.strings files. Update the mac links script to stop creating a resources link. Add a shim to nuke the helper's resource link so it can get a real folder. Helper in in chrome_paths_mac to find the main app's bundle (that the helper lives in). At startup, if not the browser, set the main bundle to be the parent of this bundle. Fix up the breakpad init to use the mac_util helper for main bundle. TEST=when runnining in the supported languages, Finder Get Info should show a localized copyright. The process names in activity monitor should also be correct and show localized names once the TC work is done. BUG=19019 Review URL: http://codereview.chromium.org/171040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24104 0039d316-1c4b-4281-b951-d872f2087c98
* Flip inverted logic that caused Breakpad to never initialize after r23509.mark@chromium.org2009-08-171-1/+1
| | | | | | | | | | | | | BUG=19204 TEST=When reporting is enabled, Breakpad should pick up browser and renderer process crashes; When reporting is enabled, renderer should not log messages like [mmdd/hhmmss:WARNING:/path/to/breakpad_mac.mm(57)] Breakpad disabled; When reporting is disabled, browser and renderer should both log these messages. Review URL: http://codereview.chromium.org/172037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23538 0039d316-1c4b-4281-b951-d872f2087c98
* Change breakpads on the helper processes to keep our rimZ clean.mark@chromium.org2009-08-151-52/+46
| | | | | | | | | | | | | | | | | | | | | Initialize crash reporting in helper processes such as the renderer process. Renderer crash reporting stopped working in r23006 when multiple .app bundles were introduced, because the stats collection and crash reporting preference is presently accessed via NSUserDefaults, keyed on the bundle ID. The main browser process and helper processes have distinct bundle IDs. In the new scheme, only the main browser process consults this preference, and passes it to helper processes in their command lines. BUG=19204 TEST=When reporting is enabled, Breakpad should pick up browser and renderer process crashes; When reporting is enabled, renderer should not log messages like [mmdd/hhmmss:WARNING:/path/to/breakpad_mac.mm(47)] Breakpad disabled; When reporting is disabled, browser and renderer should both log these messages. Review URL: http://codereview.chromium.org/165546 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23509 0039d316-1c4b-4281-b951-d872f2087c98
* Send browser crashes to Apple Crash Reporters.jeremy@chromium.org2009-08-121-1/+11
| | | | | | | | | | | Send crashes to Apple Crash Reporters so we get a nice UI to restart the Browser process if it crashes. BUG=9231 TEST=Induce a browser crash in a Chrome build, Apple Crash reporter UI should appear aftera few seconds. Induce a renderer crash, no UI should be displayed. Review URL: http://codereview.chromium.org/164433 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23237 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify how we stub breakpad. If breakpad is in, use the real file, if ↵thomasvl@chromium.org2009-07-111-25/+0
| | | | | | | | | | | not, use the stubs. We already use the stubs on unittests, so this just makes the same thing apply to the app. This gets breakpad's slow steps out of the google chrome mac rolling build. TEST=breakpad still works in official builds BUG=none TBR=mark@chromium.org Review URL: http://codereview.chromium.org/149499 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20443 0039d316-1c4b-4281-b951-d872f2087c98
* Renable sending page urls in renderer crashes on Mac.jabdelmalek@google.com2009-07-091-0/+5
| | | | | | Review URL: http://codereview.chromium.org/149370 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20226 0039d316-1c4b-4281-b951-d872f2087c98
* Try to fix broken treejrg@chromium.org2009-07-081-4/+5
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20197 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for extra BreakPad param upload on OSXjeremy@chromium.org2009-06-031-4/+5
| | | | | | | | | | | | | A change in Breakpad upstream caused the custom key/value pairs we specified to no longer be sent to crash server (e.g. process type). This change pulls in an upstream fix and causes our code to use new APIs to specify this information. BUG=13131 TEST=Crash breakpad, look at crash dump on crash server, make sure pytpe field is present. Review URL: http://codereview.chromium.org/119121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17563 0039d316-1c4b-4281-b951-d872f2087c98
* 1)When we enabled breakpad on first run we weren't correctly setting the ↵jeremy@chromium.org2009-05-221-2/+2
| | | | | | | | | | | process type. 2)Fixed another logic inversion in SetActiveRendererURL. 3)Change IsCrashReporterEnabled-> IsCrashReporterDisabled to prevent future confusion since that was the question all the callers where askign anyway. Review URL: http://codereview.chromium.org/113737 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16707 0039d316-1c4b-4281-b951-d872f2087c98
* Implement temporary First Run Dialog on OS Xjeremy@chromium.org2009-05-211-0/+5
| | | | | | | | | | | | | | | | | | | | | | We use a modal dialog with a single checkbox on OS X. We use the OSX defaults system since we want something quick and reliable. The dialog is displayed at a very early stage in Chrome startup (Before any subsystems start relying on the stats variable). This means there are a few quirks in displaying the UI. A change was also needed to our event handling code since when the dialog is shown we spin an event loop at a very early stage in the process lifetime. Changed default value for stats to false and updated unit tests to reflect that. Also some misc. minor cleanup. BUG=11971,12046 Review URL: http://codereview.chromium.org/115608 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16669 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for breakpad not generating a minidump in certain cases on OSX.jeremy@chromium.org2009-05-191-1/+1
| | | | | | | | | | | | | | | | | | | | 1)Fix logic inversion in IsCrashReporterEnabled(). 2)Don't intercept SIGPIPE in non-branded builds since it isn't fatal. 3)Roll DEPS to pickup a bunch of Mac Breakpad fixes. When breakpad is disabled, we intercept a bunch of signals so that we can crash fast, without waiting for Apple's crash reporter. The problem was that the function we where using to test whether breakpad was enabled was wrong so we were always installing these signal handlers which where just calling exit(). By fixing the IsCrashReporterEnabled() call, we no longer install these signal handlers if Breakpad is enabled. In any case SIGPIPE is non-fatal so we remove it from the list of signals we intercept. There have been a number of fixes to the OSX version of Breakpad recently, so we pull those in as well. BUG=11929 Review URL: http://codereview.chromium.org/115493 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16346 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up stats reporting via default system on OS X.jeremy@chromium.org2009-05-181-7/+2
| | | | | | | | | | | | | | Allow enabling/disabling stats via user defaults. Fix breakpad to read from global stats setting. To disable stats, type the following in the terminal: defaults write com.google.Chrome usagestats -bool NO BUG=12046 Review URL: http://codereview.chromium.org/113549 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16333 0039d316-1c4b-4281-b951-d872f2087c98
* Last chunk of OS X Breakpad integration:jeremy@chromium.org2009-04-221-69/+70
| | | | | | | | | | * Link agasint Breakpad from public svn repo. * Bump DEPS to new svn rev of Breakpad with fixes for 10.5 compilation. * Fill in code to differentiate between processes types in crash report. Review URL: http://codereview.chromium.org/88043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14245 0039d316-1c4b-4281-b951-d872f2087c98
* * Breakpad on OSX now works with stock Breakpad framwork.jeremy@chromium.org2009-03-301-17/+73
| | | | | | | | | | * We now add all the same Metadata on OS X as we do on Windows. * Made the code for logging URLs in crash dumps a little more x-platform. Remove custom Breakpad hacks so we can use an unmodified version of the Framework. Review URL: http://codereview.chromium.org/55028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12811 0039d316-1c4b-4281-b951-d872f2087c98
* First stab at Mac breakpad support.jeremy@chromium.org2009-03-261-0/+95
breakpad_mac.mm still needs some work, there's a bunch of scaffolding in there referring to a custom version of Breakpad I've got going locally. Review URL: http://codereview.chromium.org/53075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12553 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-23 09:42:31 +0000