summaryrefslogtreecommitdiffstats
path: root/chrome/app/breakpad_win.cc
Commit message (Collapse)AuthorAgeFilesLines
* Fix the compiler error in breakpad_win if exception is enabled.victorw@chromium.org2010-06-221-34/+35
| | | | | | | | | | | | | | | The error (C2712) is caused by using __try in function that requires object unwinding. To fix this, move the code that requires SEH to another function. R=cpu CC=maruel BUG=none TEST=none Review URL: http://codereview.chromium.org/2841022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50530 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a heap leak in GetCustomInfo.mazda@chromium.org2010-06-171-0/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2715003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50077 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure GoogleUpdateSettings::GetChromeChannel does not read siggi@chromium.org2010-04-201-1/+2
| | | | | | | | | | | | | from the wrong section of registry when a per-user install has left some registrations behind. Fix the odd race and other bugs I encountered along the way. BUG=40994 TEST=Unittests in this change. Open about box and look at the channel string. Review URL: http://codereview.chromium.org/1582035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45043 0039d316-1c4b-4281-b951-d872f2087c98
* Convert variables in chrome/common/env_vars.cc from wchar_t to char. Enable ↵thestig@chromium.org2010-04-061-9/+15
| | | | | | | | | | ChromeLoggingTest along the way. BUG=none TEST=none Review URL: http://codereview.chromium.org/1559016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43738 0039d316-1c4b-4281-b951-d872f2087c98
* Use env_vars::kHeadless instead of hard coded strings.thestig@chromium.org2010-03-121-3/+5
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/876002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41451 0039d316-1c4b-4281-b951-d872f2087c98
* Tweak minidump flags to include a little more detail.siggi@chromium.org2010-03-011-3/+32
| | | | | | | | | | | | | | | | | | In release channel this adds PEB/TEB and the unloaded module list to crash dumps. In dev/beta channel builds this additionally adds stack-referenced memory to crash dumps. For full memory dumps, this adds capture of the PEB/TEB, unloaded module list and all handle information. These minidump flags have been verified safe against the DbgHelp.dll version shipping with XP SP2 and later. Move some code from platform_util to install_util to allow reusing it in the chrome exe project. Add a test for the additional install_util code. BUG=32441 TEST=Unittests in this change. Review URL: http://codereview.chromium.org/659001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40300 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash reporting on Windows.aa@chromium.org2009-12-021-1/+3
| | | | | | | | BUG=29217 Review URL: http://codereview.chromium.org/460028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33614 0039d316-1c4b-4281-b951-d872f2087c98
* Ok, here is a different approach at this change.aa@chromium.org2009-12-021-65/+74
| | | | | | | | | | | | Instead of storing pointers into a vector, store offsets. That way, if the vector resizes, we should still be OK. Also, add a DCHECK that we only enter this method once, which is my current assumption. Review URL: http://codereview.chromium.org/457028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33541 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 33255 - Report active extensions in crash reports. This only ↵nsylvain@chromium.org2009-11-301-63/+50
| | | | | | | | | | | | | | | | | | | | | | | | | | | implements Windows right now. Mac and linux will be separate CLs. "Active" is overloaded to mean different things depending on the process type: browser: all enabled extensions renderer: unique set of extensions from all user scripts extension: extensions running in the process BUG=27169 Review URL: http://codereview.chromium.org/437078 -- There are thousands of new crashes with reivison 33256 and 33255, so i'm reverting. the crashes are in chrome_2610000!child_process_logging::SetActiveURL TBR=aa@chromium.org Review URL: http://codereview.chromium.org/448006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33269 0039d316-1c4b-4281-b951-d872f2087c98
* Report active extensions in crash reports. This only implements Windows ↵aa@chromium.org2009-11-301-50/+63
| | | | | | | | | | | | | | | | | right now. Mac and linux will be separate CLs. "Active" is overloaded to mean different things depending on the process type: - browser: all enabled extensions - renderer: unique set of extensions from all user scripts - extension: extensions running in the process BUG=27169 Review URL: http://codereview.chromium.org/437078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33255 0039d316-1c4b-4281-b951-d872f2087c98
* Potential fix for duplicate crash reports on Windows.kuchhal@chromium.org2009-11-121-11/+19
| | | | | | | | | BUG=24638 TEST=Not sure how the duplicate crash reports were getting generated so can not test that but made sure that the crash reporting works fine. Review URL: http://codereview.chromium.org/385030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31847 0039d316-1c4b-4281-b951-d872f2087c98
* Change id that identifies client in crash reports. Whenever metrics service ↵kuchhal@chromium.org2009-11-051-3/+28
| | | | | | | | | | | | | | | recording is enabled, it sets the client id for crash reporting. - On Windows this id gets stored in the registry so that we can read it pretty early regardless of the process type. If the id has not been generated (like in the case of first run) we initialize with empty string but the real id gets inserted once metrics service gets initialized. - On Linux we were creating a hash and storing it in 'Consent to Send Stats'. This change replaces that hash with the metrics id. Unlike before calling SetConsentToSendStats doesn't generate a new id, if an id already exists. - On Mac there was no id set. Now we use metrics id as guid for the browser process. For other process types a change is still required to pass that id as command line param to renderers/plugins (like Linux). BUG=23658 TEST=Cause a deliberate crash in Chrome renderer/browser/plugin and make sure the clientID reported to the crash server is the right GUID. Review URL: http://codereview.chromium.org/346007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31143 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite of chrome.exe startup codecpu@chromium.org2009-11-041-2/+0
| | | | | | | | | | | | | | | | | | | | | | | A lot of cruft and repeated code has deposited over the years on chrome's initialization code. This CL makes it all much more clear and straightforward. There is no fundamental change of behavior except the order of certain things is different but it should not alter the observed operation. - chrome's and chromium load is fundamentally the same but most of the code was repeated - chrome's way to load the dll was incorrect: using a relative path with LOAD_WITH_ALTERED_SEARCH_PATH - Use of SearchPath() was dangerous and not needed - removed google_update_client.cc and .h - removed bunch of #ifdefs TEST=all convered by UI tests already except [1] BUG=none [1] The only thing I don't see convered by test is the restart dialog ('woa! chrome crashed'). Review URL: http://codereview.chromium.org/345036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30934 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent multiple threads from executing the DumpDoneCallback handlercpu@chromium.org2009-10-171-0/+9
| | | | | | | | | | | | - So respawning the browser is more reliable. BUG=25091 TEST=see bug Review URL: http://codereview.chromium.org/283024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29364 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize default crash callback if we fail to get user SID.kuchhal@chromium.org2009-10-131-7/+9
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/261029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28848 0039d316-1c4b-4281-b951-d872f2087c98
* Add the page url to plugin crashes to aid debugging.jam@chromium.org2009-07-081-5/+5
| | | | | | Review URL: http://codereview.chromium.org/155238 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20191 0039d316-1c4b-4281-b951-d872f2087c98
* Revert change 20173 because it breaks the ui_tests, plugin_testsnsylvain@chromium.org2009-07-081-5/+5
| | | | | | | | and most likely some page cyclers. Review URL: http://codereview.chromium.org/155236 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20180 0039d316-1c4b-4281-b951-d872f2087c98
* Add the page url to plugin crashes to aid debugging.jam@chromium.org2009-07-081-5/+5
| | | | | | Review URL: http://codereview.chromium.org/149305 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20173 0039d316-1c4b-4281-b951-d872f2087c98
* Fix potential memleak in InitCrashReporterWithDllPath. It can leak at line ↵finnur@chromium.org2009-06-301-10/+10
| | | | | | | | | | | 294 and 370 (if the if clause is false). BUG=None TEST=None Review URL: http://codereview.chromium.org/151050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19639 0039d316-1c4b-4281-b951-d872f2087c98
* Adding chrome start-up parameters to information passed back in breakpad crashcpu@google.com2009-06-261-20/+42
| | | | | | | | | | | | | - we collect the first two params : switch-1 and switch-2 - up to 64 chars, then it truncates BUG=b/1910452 TEST=starting chrome should work as usual, otherwise see the bug Review URL: http://codereview.chromium.org/149034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19376 0039d316-1c4b-4281-b951-d872f2087c98
* Stop compulsive crasher in respawn dialogcpu@google.com2009-06-031-21/+33
| | | | | | | | | | | | | | | - Users with CursorXP or FontExporer crash in MessageBoxW - leads to many crash reports within seconds solution: eat the fatal exception and exit silently. TEST = see the bug for instructions BUG = 12162 Review URL: http://codereview.chromium.org/118148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17461 0039d316-1c4b-4281-b951-d872f2087c98
* Adds 'hard error' message box support cpu@google.com2009-05-191-0/+6
| | | | | | | | | | | | - Initially just the two failed to delay-load bind exceptions - Shows the same error dialog as the OS shows so no localization required TEST= hard to test, but I'll give some pointers on the bug BUG = 11919 Review URL: http://codereview.chromium.org/113492 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16391 0039d316-1c4b-4281-b951-d872f2087c98
* First stab at Mac breakpad support.jeremy@chromium.org2009-03-261-0/+332
breakpad_mac.mm still needs some work, there's a bunch of scaffolding in there referring to a custom version of Breakpad I've got going locally. Review URL: http://codereview.chromium.org/53075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12553 0039d316-1c4b-4281-b951-d872f2087c98