summaryrefslogtreecommitdiffstats
path: root/chrome/app/chrome_dll_main.cc
Commit message (Collapse)AuthorAgeFilesLines
* First step towards NaCl-Chrome integration:1. NaCl plugin becomes a built-in ↵gregoryd@google.com2009-09-291-0/+3
| | | | | | | | | | | plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "--internal-nacl" is required to enable the built-in NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandboxCommitted: http://src.chromium.org/viewvc/chrome?view=rev&revision=27315 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27324 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27397 Review URL: http://codereview.chromium.org/153002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27445 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 27397 - First step towards NaClChrome integration:1. NaCl plugin ↵gregoryd@google.com2009-09-281-3/+0
| | | | | | | | | | | | | becomes a builtin plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "internalnacl" is required to enable the builtin NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandboxCommitted: http://src.chromium.org/viewvc/chrome?view=rev&revision=27315 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27324 Review URL: http://codereview.chromium.org/153002 TBR=gregoryd@google.com Review URL: http://codereview.chromium.org/235042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27400 0039d316-1c4b-4281-b951-d872f2087c98
* First step towards NaCl-Chrome integration:1. NaCl plugin becomes a built-in ↵gregoryd@google.com2009-09-281-0/+3
| | | | | | | | | plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "--internal-nacl" is required to enable the built-in NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandboxCommitted: http://src.chromium.org/viewvc/chrome?view=rev&revision=27315 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27324 Review URL: http://codereview.chromium.org/153002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27397 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: remove --google-internal-crash-reporting.agl@chromium.org2009-09-281-18/+0
| | | | | | | | | It's time to kill this. It's been marginally useful, but only marginally. http://codereview.chromium.org/222021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27375 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 27324 - First step towards NaClChrome integration:1. NaCl plugin ↵gregoryd@google.com2009-09-261-3/+0
| | | | | | | | | | | | becomes a builtin plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "internalnacl" is required to enable the builtin NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandboxCommitted: http://src.chromium.org/viewvc/chrome?view=rev&revision=27315 Review URL: http://codereview.chromium.org/153002 TBR=bradnelson@google.com Review URL: http://codereview.chromium.org/244017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27326 0039d316-1c4b-4281-b951-d872f2087c98
* First step towards NaCl-Chrome integration:1. NaCl plugin becomes a built-in ↵gregoryd@google.com2009-09-261-0/+3
| | | | | | | | plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "--internal-nacl" is required to enable the built-in NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandboxCommitted: http://src.chromium.org/viewvc/chrome?view=rev&revision=27315 Review URL: http://codereview.chromium.org/153002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27324 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 27315 - First step towards NaClChrome integration:1. NaCl plugin ↵gregoryd@google.com2009-09-261-3/+0
| | | | | | | | | | | | becomes a builtin plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "internalnacl" is required to enable the builtin NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandbox Review URL: http://codereview.chromium.org/153002 TBR=gregoryd@google.com Review URL: http://codereview.chromium.org/244014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27317 0039d316-1c4b-4281-b951-d872f2087c98
* First step towards NaCl-Chrome integration:1. NaCl plugin becomes a built-in ↵gregoryd@google.com2009-09-261-0/+3
| | | | | | | | plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "--internal-nacl" is required to enable the built-in NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandbox Review URL: http://codereview.chromium.org/153002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27315 0039d316-1c4b-4281-b951-d872f2087c98
* Make Linux Breakpad initialization call to lsb_release asynchronous. Also ↵thestig@chromium.org2009-09-231-0/+2
| | | | | | | | | | | | wrap more things in USE_LINUX_BREAKPAD while we're at it. BUG=21782 TEST=Add time.sleep(10) to /usr/bin/lsb_release; starting Chrome should not take 10 seconds more. Review URL: http://codereview.chromium.org/209042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27001 0039d316-1c4b-4281-b951-d872f2087c98
* Preparing rollback in case things don't work out.bradnelson@google.com2009-09-181-3/+0
| | | | | | | | | | | This rolls back 26540, gregoryd's attempt at a nacl landing. BUG=None TEST=None Review URL: http://codereview.chromium.org/213019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26543 0039d316-1c4b-4281-b951-d872f2087c98
* This is a copy of http://codereview.chromium.org/153002/showgregoryd@google.com2009-09-181-0/+3
| | | | | | | | | | First step towards NaCl-Chrome integration:1. NaCl plugin becomes a built-in plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. This CL relies on another CL that contains the changes on the Native Client side: http://codereview.chromium.org/1501904. Command line flag "--internal-nacl" is required to enable the built-in NaCl plugin.5. NaCl still cannot run in Chrome sandbox, so the "--no-sandbox" flag is also required TBR=bradnelson Review URL: http://codereview.chromium.org/207025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26540 0039d316-1c4b-4281-b951-d872f2087c98
* Add Profile Import Process Type.jeremy@chromium.org2009-09-171-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | This is currently only used on OS X. We need a separate process to do profile import for 3 reasons: 1)In Firefox we load external libraries which we have no control over. 2)Conceptually it's safer to run parsing code OOP. 3)quoth chrome/browser/importer/nss_decryptor_mac.mm : """ On OS X the nss3 libraries are compiled with depedencies on one another, referenced using dyld's @executable_path directive. To make a long story short in order to get the libraries to load, dyld's fallback path needs to be set to the directory containing the libraries. To do so, the process this function runs in must have the DYLD_FALLBACK_LIBRARY_PATH set on startup to said directory. """ BUG=14458 TEST=None Possible Review URL: http://codereview.chromium.org/193131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26501 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: set the process title (that shows in "ps" etc.) of renderers ↵mdm@chromium.org2009-09-101-4/+8
| | | | | | | | | | | correctly when using the zygote. BUG=none TEST=none Review URL: http://codereview.chromium.org/196009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25877 0039d316-1c4b-4281-b951-d872f2087c98
* linux: call PR_Init on UI threadevan@chromium.org2009-09-021-1/+5
| | | | | | | | | | It complains about being shutdown on the wrong thread otherwise. BUG=18410 Review URL: http://codereview.chromium.org/178062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25259 0039d316-1c4b-4281-b951-d872f2087c98
* Landing the patch of Thiago Farina.jcampan@chromium.org2009-09-021-2/+2
| | | | | | | | | | | | | See http://codereview.chromium.org/183025 Removes the deprecated version of PathService::Override that uses std::wstring and fix the callers. BUG=None TEST=None Review URL: http://codereview.chromium.org/185007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25185 0039d316-1c4b-4281-b951-d872f2087c98
* Change when we enable Apple's Crash reporter.jeremy@chromium.org2009-08-311-6/+28
| | | | | | | | | | | | | | | | | | | | Enable Apple Crash Reporter for Browser process in Non-Debug builds. * Introduce mac_util::IsBackgroundProcess(). * Invert logic around Breakpad Enabling/Disabling to make it clearer. * Honor the kDisableBreakpad switch. Our new policy: * Breakpad is enabled/disabled based on the user stats reporting opt-in flag - this hasn't changed. * Always disable Apple Crash in background processes (plug-in, renderer, etc). * If Breakpad is enabled browser crashes will be passed to Crash Reporter. * If Breakpad is NOT enabled browser [or any other foreground app] crashes will be passed to Crash Reporter in Release builds. Effectively this means that we now enable Crash Reporter for the browser process in Chromium release builds so these will no longer crash silently with no trace. Review URL: http://codereview.chromium.org/180048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24959 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Issue 19689: Command line URL parameter does not support Chinese.suzhe@chromium.org2009-08-261-0/+7
| | | | | | | | | | | | | | | | This CL fixes issue 19689 by handling command line values with native encoding on non-Windows systems. For Linux, native encoding specified in current locale is used. For Mac, UTF-8 will always be used. This CL only changes command line values and program name to use native encoding, command line switches still use ASCII. BUG=19689: Command line URL parameter does not support Chinese TEST=Execute chrome with "http://www.google.com/search?q=中文" to see if this url can be opened successfully. Review URL: http://codereview.chromium.org/174139 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24423 0039d316-1c4b-4281-b951-d872f2087c98
* linux: call g_thread_init() at relevant startup pointsevan@chromium.org2009-08-251-0/+1
| | | | | | | | | | | | | | | | | | According to glib docs, we need to do this if it's at all possible for us to hit glib on multiple threads. This may be happening when we grab plugin metadata from the file thread. Rather than explicitly depending on gthread all over the place, just put it in with the GTK dep (since anywhere we're using GTK we ought to init gthread). (Note that this is *not* initializing the GDK locking system.) BUG=18957 Review URL: http://codereview.chromium.org/174264 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24207 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "linux: call g_thread_init() at relevant startup points"evan@chromium.org2009-08-251-1/+0
| | | | | | This reverts commit r24203, Mac breakage. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24204 0039d316-1c4b-4281-b951-d872f2087c98
* linux: call g_thread_init() at relevant startup pointsevan@chromium.org2009-08-251-0/+1
| | | | | | | | | | | | | | | | | | According to glib docs, we need to do this if it's at all possible for us to hit glib on multiple threads. This may be happening when we grab plugin metadata from the file thread. Rather than explicitly depending on gthread all over the place, just put it in with the GTK dep (since anywhere we're using GTK we ought to init gthread). (Note that this is *not* initializing the GDK locking system.) BUG=18957 Review URL: http://codereview.chromium.org/174264 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24203 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "linux: call g_thread_init() at relevant startup points"tony@chromium.org2009-08-241-1/+0
| | | | | | | | | | | This reverts commit r24148 because the FDRemapping unittest is failing. TBR=evanm Review URL: http://codereview.chromium.org/173309 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24168 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: exit render processes with the correct code.agl@chromium.org2009-08-241-1/+3
| | | | | | | | | | | | | | | | | When using a zygote, we don't set the |rv| variable in ChromeMain. Thus, renderers exit with a code of 255. There appears to be a harmless race where, when closing a render process, sometimes we'll see the close event from the IPC channel before we believe that the process has exited. In that case, the 255 exit code makes us believe that the renderer crashed. This is probably the cause of the huge renderer crash numbers in UMA. BUG=20149 http://codereview.chromium.org/173302 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24157 0039d316-1c4b-4281-b951-d872f2087c98
* linux: call g_thread_init() at relevant startup pointsevan@chromium.org2009-08-241-0/+1
| | | | | | | | | | | | | | | | | | According to glib docs, we need to do this if it's at all possible for us to hit glib on multiple threads. This may be happening when we grab plugin metadata from the file thread. Rather than explicitly depending on gthread all over the place, just put it in with the GTK dep (since anywhere we're using GTK we ought to init gthread). (Note that this is *not* initializing the GDK locking system.) BUG=18957 Review URL: http://codereview.chromium.org/174264 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24148 0039d316-1c4b-4281-b951-d872f2087c98
* Tweak the comment in the lproj fixup script to explain why we need an "en" ↵thomasvl@chromium.org2009-08-241-2/+13
| | | | | | | | | | | | | | | | | | | | | | folder. Added a string for the products short name, this is current mac only, and is used for the application menu title via the infoplist.strings file. Added source for a tool to build InfoPlist.strings files based on the values within the GRD files. Run the InfoPlist.strings generation tool during the build. Added a script to take a string and list of locale and generate all the versions of the string. Wired up the string locale tool so GYP knows about all the inputs/outputs from the InfoPlist.strings generation tool. Stop setting some of the Info.plist keys that are now covered by the InfoPlist.strings files. Update the mac links script to stop creating a resources link. Add a shim to nuke the helper's resource link so it can get a real folder. Helper in in chrome_paths_mac to find the main app's bundle (that the helper lives in). At startup, if not the browser, set the main bundle to be the parent of this bundle. Fix up the breakpad init to use the mac_util helper for main bundle. TEST=when runnining in the supported languages, Finder Get Info should show a localized copyright. The process names in activity monitor should also be correct and show localized names once the TC work is done. BUG=19019 Review URL: http://codereview.chromium.org/171040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24104 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r24043, "linux: call g_thread_init() at relevant startup points"evan@chromium.org2009-08-211-1/+0
| | | | | | Build failures. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24044 0039d316-1c4b-4281-b951-d872f2087c98
* linux: call g_thread_init() at relevant startup pointsevan@chromium.org2009-08-211-0/+1
| | | | | | | | | | | | | | According to glib docs, we need to do this if it's at all possible for us to hit glib on multiple threads. This may be happening when we grab plugin metadata from the file thread. (Note that this is *not* initializing the GDK locking system.) BUG=18957 Review URL: http://codereview.chromium.org/174264 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24043 0039d316-1c4b-4281-b951-d872f2087c98
* Breakpads missing from browser process.mark@chromium.org2009-08-211-16/+16
| | | | | | | | | | | | | | | | GoogleUpdateSettings::GetCollectStatsConsent uses the Chrome path provider, so if the Breakpad glue is going to decide whether to enable Breakpad based on that function, it can't call it until after the Chrome path provider has been added to the path service. TBR=jeremy BUG=19913 TEST=Does Breakpad work in the browser process? If stats reporting is enabled, in an official release Google Chrome build, you'd better not see this: [mmdd/hhmmss:WARNING:.../chrome/app/breakpad_mac.mm(57)] Breakpad disabled Review URL: http://codereview.chromium.org/173172 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23929 0039d316-1c4b-4281-b951-d872f2087c98
* Change breakpads on the helper processes to keep our rimZ clean.mark@chromium.org2009-08-151-24/+20
| | | | | | | | | | | | | | | | | | | | | Initialize crash reporting in helper processes such as the renderer process. Renderer crash reporting stopped working in r23006 when multiple .app bundles were introduced, because the stats collection and crash reporting preference is presently accessed via NSUserDefaults, keyed on the bundle ID. The main browser process and helper processes have distinct bundle IDs. In the new scheme, only the main browser process consults this preference, and passes it to helper processes in their command lines. BUG=19204 TEST=When reporting is enabled, Breakpad should pick up browser and renderer process crashes; When reporting is enabled, renderer should not log messages like [mmdd/hhmmss:WARNING:/path/to/breakpad_mac.mm(47)] Breakpad disabled; When reporting is disabled, browser and renderer should both log these messages. Review URL: http://codereview.chromium.org/165546 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23509 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Fancy html5 draggy stuff.estade@chromium.org2009-08-051-0/+2
| | | | | | | | | | | | | | | | | | | | | Also, don't crash in release mode when the tab contents is deleted during a drag. 1) Source side: when the tab contents is going down, abort the current drag (if any). Initiate drags on a GtkInvisible (matching firefox, among other programs I assume). This lets us give up ownership of the drag widget and let the drag unwind. 2) Destination side: make a seemingly harmless GTK assert point to a crbug bug. This warrants further investigation. BUG=16249 TEST=drag around ntp thumbnails BUG=18557 In release mode, you should be able to do all the following without crashing or getting any asserts besides the two mentioned in 18557 TEST=drag something from gedit over a tab that closes TEST=drag something from the render view over a tab that closes TEST=drag something from the render view off of the browser from within a tab that closes TEST=repeat all the above with a tab that is being swapped out according to the repro steps in bug 16073 Review URL: http://codereview.chromium.org/159889 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22542 0039d316-1c4b-4281-b951-d872f2087c98
* Move the entire application into a dylib (framework)mark@chromium.org2009-08-051-1/+24
| | | | | | Review URL: http://codereview.chromium.org/160538 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22506 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r22080 and re-enable tcmalloc.huanr@chromium.org2009-08-021-2/+2
| | | | | | Review URL: http://codereview.chromium.org/159771 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22251 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding r22155 (GTK Themes: Use theme colors in the text view in the ↵erg@google.com2009-07-311-1/+2
| | | | | | | | | | | | location bar.) Fixed build issues with Ben's help. Original Review URL: http://codereview.chromium.org/159671 Review URL: http://codereview.chromium.org/160466 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22181 0039d316-1c4b-4281-b951-d872f2087c98
* I give up. Reverting all attempts at fixing the gtk-view bustage.erg@google.com2009-07-311-2/+1
| | | | | | | | Reverts r22161,r22159,r22155 Review URL: http://codereview.chromium.org/159719 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22163 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Use theme colors in the text view in the location bar.erg@google.com2009-07-311-1/+2
| | | | | | | | Tested with a bunch of light and dark themes. Review URL: http://codereview.chromium.org/159671 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22155 0039d316-1c4b-4281-b951-d872f2087c98
* Removing tcmalloc from gyp so we can build a version of chromehuanr@chromium.org2009-07-301-2/+2
| | | | | | | | | | | | | | | | | | | | | | without tcmalloc for testing purpose. The linker complains about _set_new_mode so I remove the call from the code for now. Note this change is different from the change Bradley is working on which provides an option for building chrome without tcmalloc. This change simply removes tcmalloc from the build. The plan is checking it in, keeping it in trunk for 24 hours, and then reverting it. The benefits are - Having another round of performance comparison between build with and w/o tcmalloc. - Having a full run of UI test under purify with tcmalloc disabled. - Getting a verified CL in case we'd like to build an alternative dev build w/o tcmalloc for A/B test. Review URL: http://codereview.chromium.org/159599 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22080 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: add internal core dump reporting.agl@chromium.org2009-07-281-0/+18
| | | | | | | | | | | | | | | In order to get a handle on a number of browser crashes, this patch adds an options for Google internal folks to upload full core files when the browser crashes. The core files are uploaded to an internal IP address and will be available to other developers. This is only enabled for Chrome branded builds and then, only if --google-internal-crash-reporting is given on the command line. http://codereview.chromium.org/160212 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21782 0039d316-1c4b-4281-b951-d872f2087c98
* linux: show the manpage on -h or --helpevan@chromium.org2009-07-231-0/+10
| | | | | | Review URL: http://codereview.chromium.org/160026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21450 0039d316-1c4b-4281-b951-d872f2087c98
* Fix liner errors due to duplicate symbols in the switches. These switchesbrettw@chromium.org2009-07-231-0/+1
| | | | | | | were moved to IPC, but the source ones in chrome/common were kept. Review URL: http://codereview.chromium.org/160014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21389 0039d316-1c4b-4281-b951-d872f2087c98
* Make workers functional on OSX and Linux.levin@chromium.org2009-07-141-4/+0
| | | | | | | | | | BUG=http://crbug.com/16664 TEST=The same tests run for Web Workers on Windows should be run on Linux and OSX. Review URL: http://codereview.chromium.org/155015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20653 0039d316-1c4b-4281-b951-d872f2087c98
* linux: cut down on logging spamevan@chromium.org2009-07-131-2/+8
| | | | | | Review URL: http://codereview.chromium.org/149546 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20503 0039d316-1c4b-4281-b951-d872f2087c98
* posix: ignore SIGPIPE in all processes, not just the browserevan@chromium.org2009-07-111-9/+5
| | | | | | | | | E.g. plugin<->renderer channel can go down, causing SIGPIPE instead of a normal error. Review URL: http://codereview.chromium.org/155390 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20448 0039d316-1c4b-4281-b951-d872f2087c98
* A little bit of bookmark bar cleanup, a little bit of padding improvement.estade@chromium.org2009-07-101-1/+0
| | | | | | | | | | | | | | | | | | The spacing between the toolbar buttons now matches windows pixel for pixel (tested empirically). The bookmark bar item spacing is now a little better, but we need some hackery to improve it to the state of windows (we need to annex about 5 pixels from the toolbar when the bookmark bar is open). The code for packing bookmark bar buttons is now all in one place. Functional change: There will be no other bookmarks button until the model is loaded. If you care I can fix this, it just doesn't seem like a very important matter since it's unusable anyway when the model isn't loaded.o I also removed a log warning from chrome_dll_main because with this change it started spamming a lot. We're already living with this warning, and have a bug filed for it (they fixed the root problem in newer versions of gtk so I think this bug will just never get resolved), so I don't think this is a big deal. BUG=15870 TEST=things look marginally better, theming still works properly Review URL: http://codereview.chromium.org/155342 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20389 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Initial implementation of using GTK themes, partially based on evan's ↵erg@google.com2009-07-031-0/+3
| | | | | | | | | | | | | | | | | | | | | | | CL 118358. A lot of stuff works: - Colors are picked out of the GTK theme. - Buttons use the current GTK button theme. - We use the user's icon theme. A lot of stuff doesn't: - We could do a better job of picking colors for the skylines. - The omnibox hasn't been touched. - UI that's not part of the toolbar hasn't been touched. - We currently fail on themes like HighContrastInverse. TEST=Under Options>Personal Stuff, click GTK Theme. Colors and widgets should be rendered with the current GTK theme stuff. TEST=With chrome open and in GTK Theme mode, change your GTK theme or icon theme. chrome should pick up on the change immediately and reimport the colors and images. http://crbug.com/13967 Review URL: http://codereview.chromium.org/150176 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19868 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: fix crash reporting for zygote modelagl@chromium.org2009-06-231-7/+0
| | | | | | | | | | | | | | | | | | Crash reporting broke on Linux when we enabled the zygote model a couple of weeks ago. We can't just add "zygote" to the check for the process type because the crash signal fd is set at the same time and that will change when a renderer is forked from the zygote. This fixes it for now, but it will need to be redone when we enable sandboxing. http://codereview.chromium.org/147004 BUG=14969 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19035 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a valgrind error related to Zygote's CommandLine usage.craig.schlenter@chromium.org2009-06-191-1/+8
| | | | | | | | Also touch up some include guards and a comment. Review URL: http://codereview.chromium.org/131054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18801 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Add support for chrooted renderers.agl@chromium.org2009-06-151-14/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | http://code.google.com/p/chromium/wiki/LinuxSandboxIPC Without filesystem access from the renderers, we need another way of dealing with fontconfig and font loading. This add support for: * An "SBX_D" environment variable in the renderers which is used to signal the end of dynamic linking so that the chroot can be enforced. * A sandbox_host process, running outside the sandbox, to deal with fontconfig requests from the renderers. See the wiki page for the reasoning behind making it a separate process. * A new, custom SkFontHost for Skia. Because this is Chrome specific, it will live outside the upstream Skia tree. This FontHost can be configured either to drive fontconfig directly (for the browser process and for any unsandboxed renderers) or to use an IPC system. Since the same SkFontHost has to be linked into both the browser and renderer (they are the same binary), this switch has to be made at run time. Sandbox IPC calls are rare (a couple of dozen at page load time) and add about 50us of overhead for each call. (Reland of r17575 which was reverted in r17577) http://codereview.chromium.org/112074 BUG=8081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18405 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: refactor zygote supportagl@chromium.org2009-06-121-15/+26
| | | | | | | | | | | | | | | | | | | http://code.google.com/p/chromium/wiki/LinuxZygote * Move Chrome specific bits out of base * Move away from the idea of reserved file descriptors (which don't really work with zygotes) * Load resources before forking renderers (means that we don't need communication between the zygote process and the renderers) * Make sure that gdb works against the browser again * Make sure that we have different ASLR between the renderers and the browser. http://codereview.chromium.org/119335 (This is a reland. First landed in r18109, reverted in r18112.) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18291 0039d316-1c4b-4281-b951-d872f2087c98
* Enable the _set_new_mode() call so that calls to mallocmbelshe@google.com2009-06-111-0/+6
| | | | | | | | | | | | | | behave like calls to new, and will go through the std_new_handler on crash. For chrome, this means that all out of memory conditions, be they malloc induced or new induced will cause the process to abort. BUG=11475 TEST=none Review URL: http://codereview.chromium.org/122041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18180 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for issue 13724: Don't hard code chrome.exensylvain@chromium.org2009-06-111-1/+2
| | | | | | | | | | | | | | | Use chrome::kBrowserProcessExecutableName instead Original patch by tedoc2000@gmail.com R=nsylvain,cpu BUG=13724 http://codereview.chromium.org/119405 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18127 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 18109, 18111: Windows UI tests failed.agl@chromium.org2009-06-101-24/+15
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18112 0039d316-1c4b-4281-b951-d872f2087c98