summaryrefslogtreecommitdiffstats
path: root/chrome/app/chrome_dll_main.cc
Commit message (Collapse)AuthorAgeFilesLines
* startup: rename chrome_dll_main to chrome_mainevan@chromium.org2010-11-181-862/+0
| | | | | | | | | | | | | | | Startup works like this: 1) platform-specific main, which calls 2) ChromeMain(), which calls 3) subprocess-specific main, like RendererMain() On Windows the middle step is kept in a DLL, but it's a framework on Mac and it's part of the original binary on Linux. This no-op change renames the file to match the function it does. Review URL: http://codereview.chromium.org/5183003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66660 0039d316-1c4b-4281-b951-d872f2087c98
* Make the PPAPI plugin process actually run on Linux by properly hooking up ↵brettw@chromium.org2010-11-121-0/+2
| | | | | | | | the zygote. Review URL: http://codereview.chromium.org/4843001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65913 0039d316-1c4b-4281-b951-d872f2087c98
* startup: move some browser startup code into BrowserMainevan@chromium.org2010-11-121-123/+0
| | | | | | | | | | | | There was a block of code that was #ifdef LINUX right before our call to BrowserMain(). We can instead put that code into BrowserMain(), which knows how to delegate to multiple platforms. TEST=should be just a refactoring change, all tests should still pass Review URL: http://codereview.chromium.org/4579002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65892 0039d316-1c4b-4281-b951-d872f2087c98
* Implement a new process type for running PPAPI plugins. The process itself isbrettw@chromium.org2010-11-101-1/+5
| | | | | | | | | | | | | | | quite simple and just sets up the PPAPI dispatcher and loads the library. There is a new command line switch --ppapi-out-of-process which runs PPAPI plugins out of process using the new code path. There is some logic in RenderView and PepperPluginModule for setting up this connection, but it should be straightforward. TEST=none BUG=none Review URL: http://codereview.chromium.org/3915002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65614 0039d316-1c4b-4281-b951-d872f2087c98
* chrome_exe_main: name os-specific files according to naming patternevan@chromium.org2010-11-041-5/+6
| | | | | | | | | | | | These files probably just predate us having a _win suffix on Windows-specific code. BUG=18504 TEST=compiles Review URL: http://codereview.chromium.org/4451001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65001 0039d316-1c4b-4281-b951-d872f2087c98
* Move debug-related stuff from base to the base/debug directory and use thebrettw@chromium.org2010-10-261-3/+5
| | | | | | | | | | | | | | | | base::debug namespace. This splits apart debug_util into base/debugger and base/stack_trace There are still two functions in debug_util that I'm not sure what to do with. Since this uses the base::debug namespace, I removed the functions in debugger.h from the static class and just made them free functions in the namespace. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3945002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63859 0039d316-1c4b-4281-b951-d872f2087c98
* Make USE_OPENSSL and USE_NSS mutually exclusivejoth@chromium.org2010-10-221-0/+2
| | | | | | | | | | | | | | | | | | - that is, defining use_openssl=1 will now remove all dependency on NSS. This does not impact any of the standard, non-openssl builds. Adds stub implementations of several files that need to be fully implemented in follow up patchs. Firefox import code will need some more substatial refactoring, as it makes little sense to be attempting a firefox import without NSS libraries to hand, however the UI etc has numerous assumption about the presence of this importer. BUG=None TEST=None Review URL: http://codereview.chromium.org/3855004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63506 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Change bwsi to guest in a bunch of places.tfarina@chromium.org2010-10-201-1/+1
| | | | | | | | | BUG=chromium-os:7042 TEST=trybots Review URL: http://codereview.chromium.org/3795008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63156 0039d316-1c4b-4281-b951-d872f2087c98
* Move scoped_nsdisable_screen_update from base to app/macbrettw@chromium.org2010-10-181-2/+2
| | | | | | | | | | | Move scoped_aedesc from base to base/mac Use namespace and proper Google-style class naming. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3828009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62904 0039d316-1c4b-4281-b951-d872f2087c98
* Move Stats, histograms, and field trial into a metrics subdirectory of base andbrettw@chromium.org2010-10-141-5/+5
| | | | | | | | | put them in the base namespace. TEST=it compiles BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62510 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 62205 - Make writing to stdout and stderr work in Chrome processes ↵isherman@chromium.org2010-10-121-22/+0
| | | | | | | | | | | | | | | | | | | | | when inherited handles are available. Don't create a console, just attach to any existing console. R=cpu BUG=none TEST=none Review URL: http://codereview.chromium.org/3574008 Reverting because it breaks browser_tests logging TBR=darin@chromium.org Review URL: http://codereview.chromium.org/3691005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62236 0039d316-1c4b-4281-b951-d872f2087c98
* Make writing to stdout and stderr work in Chrome processes when inheriteddarin@chromium.org2010-10-111-0/+22
| | | | | | | | | | | | | | handles are available. Don't create a console, just attach to any existing console. R=cpu BUG=none TEST=none Review URL: http://codereview.chromium.org/3574008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62205 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: call SetProcTitle() in GpuMain() to make the process name correct.mdm@chromium.org2010-10-111-0/+3
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3645003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62203 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Replace the existing browser-child mach ipc with a long-lived listener ↵rohitrao@chromium.org2010-09-171-1/+27
| | | | | | | | | | | | | | | | | on a well-known port. Before this CL: Before fork()ing a child, the browser process creates a mach receive port with a random name. After the fork() but before exec(), the child uses mach ipc to transmit send rights to its task port. The child has access to the random name because it inherits it from the browser process. Unfortunately, some of the library functions involved in sending a mach message are not safe to call after fork(). After this CL: Before forking the first child, the browser spins off a new thread that listens on a well-known port for mach ipc from any process. This well-known port is "com.google.Chrome.<browserpid>". When a child process starts up, it sends a mach message to its parent browser's well-known port. On the browser side, we listen for said message, extract the pid of the sending process, and ignore any messages from processes we did not personally fork(). This check is necessary because any arbitrary process on the system could send mach ipc to that port. BUG=35374 TEST=Browser should still start up. The task manager should still show correct cpu/memory data. There should be no perf regressions. TEST=Mac ui_tests and browser_tests should be less flaky. Review URL: http://codereview.chromium.org/3443002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59782 0039d316-1c4b-4281-b951-d872f2087c98
* This is a second attempt of http://codereview.chromium.org/3175038davemoore@chromium.org2010-09-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | It failed the Vista Perf UI tests. This is because those tests close the browser upon an error. And they always get an error when the session is closed in the middle of the test. The new changes are in chrome/browser/automation/testing_automation_provider.cc BUG=50006 TEST=Run chrome under nested window manager using Xephyr (see http://code.google.com/p/chromium/wiki/LayoutTestsLinux) use --enable-logging=stderr --log-level=0 kill xephyr examine log. You should see X IO Error detected followed (not necessarily immediately) by successfully saved /tmp/tx/Default/Preferences successfully saved /tmp/tx/Local State successfully saved /tmp/tx/Local State successfully saved /tmp/tx/Default/Preferences along with no crash. BUG= TEST= Review URL: http://codereview.chromium.org/3364019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59269 0039d316-1c4b-4281-b951-d872f2087c98
* Run worker processes via the zygote.agl@chromium.org2010-09-131-2/+4
| | | | | | | | | | | | | | | | | | | | | | The following tests fail when using the SUID sandbox because they try to count processes and the extra sandbox processes throw them off. They pass with this patch so long as the SUID sandbox isn't invoked (which is the case on the builders): WorkerTest.FLAKY_MultipleTabsQueuedSharedWorker WorkerTest.FLAKY_LimitPerPage WorkerTest.WorkerClose WorkerTest.QueuedSharedWorkerShutdown WorkerTest.FLAKY_QueuedSharedWorkerStartedFromOtherTab Note that this patch doesn't trigger the seccomp sandbox for worker processes. That will have to wait for another CL. BUG=54794 TEST=ui_tests http://codereview.chromium.org/3312021/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59242 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 59147 - Allow overriding of X error functionsdavemoore@chromium.org2010-09-101-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | BUG=50006 (and various other reports) TEST=Run chrome under nested window manager using Xephyr (see http://code.google.com/p/chromium/wiki/LayoutTestsLinux) use --enable-logging=stderr --log-level=0 kill xephyr examine log. You should see X IO Error detected followed (not necessarily immediately) by successfully saved /tmp/tx/Default/Preferences successfully saved /tmp/tx/Local State successfully saved /tmp/tx/Local State successfully saved /tmp/tx/Default/Preferences along with no crash. There is a high ranking crash report on both linux and chromeos that happens whenever X sends an error to chrome. This change causes us to log and continue when we get a regular error from X. When we get an IO error, indicating X is gone, we attempt to shut down gracefully. Review URL: http://codereview.chromium.org/3175038 TBR=davemoore@chromium.org Review URL: http://codereview.chromium.org/3332019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59175 0039d316-1c4b-4281-b951-d872f2087c98
* Allow overriding of X error functionsdavemoore@chromium.org2010-09-101-1/+1
| | | | | | | | | | | | | | | | | | | | | | | BUG=50006 (and various other reports) TEST=Run chrome under nested window manager using Xephyr (see http://code.google.com/p/chromium/wiki/LayoutTestsLinux) use --enable-logging=stderr --log-level=0 kill xephyr examine log. You should see X IO Error detected followed (not necessarily immediately) by successfully saved /tmp/tx/Default/Preferences successfully saved /tmp/tx/Local State successfully saved /tmp/tx/Local State successfully saved /tmp/tx/Default/Preferences along with no crash. There is a high ranking crash report on both linux and chromeos that happens whenever X sends an error to chrome. This change causes us to log and continue when we get a regular error from X. When we get an IO error, indicating X is gone, we attempt to shut down gracefully. Review URL: http://codereview.chromium.org/3175038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59147 0039d316-1c4b-4281-b951-d872f2087c98
* Turns on by default accelerated compositing on the mac. Removes ↵vangelis@chromium.org2010-09-091-15/+0
| | | | | | | | | | | | --enable-accelerated-compositing flag altogether as it's no longer useful. BUG=54469 Review URL: http://codereview.chromium.org/3303020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58903 0039d316-1c4b-4281-b951-d872f2087c98
* Build failure fix: Disabling accelerated compositing on the mac as it fails ↵vangelis@chromium.org2010-09-081-0/+15
| | | | | | | | | | media related UI tests on 10.5 . This failure was introduced in r58792. TBR=kbr@google.com Review URL: http://codereview.chromium.org/3336014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58797 0039d316-1c4b-4281-b951-d872f2087c98
* Back out r58711. It appears to have caused video/media-related ui_testsmark@chromium.org2010-09-071-15/+0
| | | | | | | | | | | | | | | | failures on Windows: MediaTest.VideoBearTheora MediaTest.VideoBearSilentTheora MediaTest.VideoBearWebm MediaTest.VideoBearSilentWebm UILayoutTest.MediaUILayoutTest BUG=54469 TEST=tree Review URL: http://codereview.chromium.org/3333019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58730 0039d316-1c4b-4281-b951-d872f2087c98
* Turning WebGL and the accelerated compositor on by default (linux and ↵vangelis@chromium.org2010-09-071-0/+15
| | | | | | | | | | | windows only for the compositor), removing the --enable-webgl flag and adding --disable-webgl and --disable-accelerated-compositing. On the mac --enable-accelerated-compositing still needs to be supplied to enable the compositor. BUG=54469 Review URL: http://codereview.chromium.org/3342016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58711 0039d316-1c4b-4281-b951-d872f2087c98
* Set --user-data-dir override earlier, so breakpad gets the right path.mnissler@chromium.org2010-09-031-6/+6
| | | | | | | | | BUG=38642 TEST=Using an official build, check whether the crash reporter respects the prefs checkbox when using --user-data_dir Review URL: http://codereview.chromium.org/3356004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58479 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor version-getting info into a chrome::VersionInfo object.evan@chromium.org2010-08-271-10/+9
| | | | | | | | | | | | | | | I was trying to replace wstring usage in base::FileVersionInfo, but that class is rather Windows-specific with strange fields like "private_build()" where the value and encoding aren't clear. 95% of the users of FileVersionInfo actually just care about the current Chrome version, so we can provide a much simpler interface for them. We still use FileVersionInfo for retrieving information from e.g. plugin DLLs, but in those cases the usage is clearer. Review URL: http://codereview.chromium.org/3135028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57725 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Enforce proper usage of main app bundle and helper app bundle.thomasvl@chromium.org2010-08-241-0/+20
| | | | | | | | | | | | - Add a check to make sure the helper isn't used without --type - Add a check to make sure the main app isn't used with --type. - Make inproc browser tests invoke the helper that is within the app bundle on disk to recreate the real world environment. BUG=23645,52858 TEST=green tree, invoking the main app with --type fails, and invoking the helper without it fails. Review URL: http://codereview.chromium.org/3171027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57231 0039d316-1c4b-4281-b951-d872f2087c98
* Reland 56669: Initial change that allows to disable bookmarksdpolukhin@chromium.org2010-08-231-0/+2
| | | | | | | | | | | | | | | | Original CL: http://codereview.chromium.org/3191007 Initial change that allows to disable bookmarks in Chrome for Chrome OS (BWSI mode). Added disable-bookmarks flag and disabled some UI elements. BUG=chromium-os:4302 TEST=Run Chrome build for Chrome OS with --disable-bookmarks flag and verify that the corresponding UI is disabled. Verify that BWSI mode runs with this flag. Review URL: http://codereview.chromium.org/3156035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57033 0039d316-1c4b-4281-b951-d872f2087c98
* TBR:skydpolukhin@chromium.org2010-08-191-2/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56676 0039d316-1c4b-4281-b951-d872f2087c98
* Land 3122014 for Anton: Initial change that allows to disable bookmarksdpolukhin@chromium.org2010-08-191-0/+2
| | | | | | | | | | | | | | | | Original CL: http://codereview.chromium.org/3122014 Initial change that allows to disable bookmarks in Chrome for Chrome OS (BWSI mode). Added disable-bookmarks flag and disabled some UI elements. BUG=chromium-os:4302 TEST=Run Chrome build for Chrome OS with --disable-bookmarks flag and verify that the corresponding UI is disabled. Verify that BWSI mode runs with this flag. Review URL: http://codereview.chromium.org/3191007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56669 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Remove unneeded headers from base/ (part 1)thestig@chromium.org2010-08-051-1/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3071012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55034 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstrings from l10n_util/ResourceBundle locale functions.evan@chromium.org2010-08-041-2/+2
| | | | | | Review URL: http://codereview.chromium.org/3069026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54917 0039d316-1c4b-4281-b951-d872f2087c98
* De-wstringify some browser startup code and net utility.evan@chromium.org2010-08-041-10/+8
| | | | | | Review URL: http://codereview.chromium.org/3054042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54860 0039d316-1c4b-4281-b951-d872f2087c98
* Move the number conversions from string_util to a new file.brettw@chromium.org2010-07-301-2/+4
| | | | | | | | | | | | | Use the base namespace in the new file. Update callers. I removed all wstring variants and also the string->number ones that ignore the return value. That encourages people to write code and forget about error handling. TEST=included unit tests BUG=none Review URL: http://codereview.chromium.org/3056029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54355 0039d316-1c4b-4281-b951-d872f2087c98
* Added --bwsi flag and handling of --login-user=incognito to support BWSI ↵avayvod@chromium.org2010-07-261-0/+9
| | | | | | | | | | | | mode with sync and extensions disabled. BUG=http://crosbug.com/4420 TEST=With latest session manager click on BWSI mode or just run Chrome with --login-user=incognito and --bwsi. Sync and extensions should be disabled. Review URL: http://codereview.chromium.org/2873047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53617 0039d316-1c4b-4281-b951-d872f2087c98
* Need to call BootTimesLoader::Get() after AtExitManager is createddavemoore@chromium.org2010-07-211-3/+4
| | | | | | | | | BUG=None TEST=Debug build of chromeos version of chrome doesn't crash w/ DCHECK() at startup. Review URL: http://codereview.chromium.org/3035016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53201 0039d316-1c4b-4281-b951-d872f2087c98
* Added file to track login times, and moved functionality to boot_times_loader.davemoore@chromium.org2010-07-211-1/+1
| | | | | | | | | BUG=chromium-os:4727 TEST=None Review URL: http://codereview.chromium.org/2858061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53192 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Break another common->app dependency.thestig@chromium.org2010-07-201-3/+3
| | | | | | | | BUG=46666 TEST=none Review URL: http://codereview.chromium.org/3007008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53113 0039d316-1c4b-4281-b951-d872f2087c98
* Fix stats table on linux. There were two problems:mbelshe@chromium.org2010-07-191-17/+31
| | | | | | | | | | | | a) We were using the wrong pid for the browser pid b) We weren't initializing the StatsTable after running the zygote. BUG=none TEST=none Review URL: http://codereview.chromium.org/3051003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52962 0039d316-1c4b-4281-b951-d872f2087c98
* Fix svn:executable permissions.thestig@chromium.org2010-07-191-0/+0
| | | | | | | | BUG=none TEST=checkperms.py is happy. Review URL: http://codereview.chromium.org/3042006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52951 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the application locale police that allows to enforce the ↵markusheintz@chromium.org2010-07-191-1/+8
| | | | | | | | | | | kApplicationLocale preference. bug=44504 test=none Review URL: http://codereview.chromium.org/2809058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52936 0039d316-1c4b-4281-b951-d872f2087c98
* Set up tests to exercise the chrome outersandbox from the nacl loader.jvoung@google.com2010-07-151-2/+4
| | | | | | | | | | | | | | | | | | | It is similar to the renderer sandbox tests in that the test code is separated into a DLL and only loaded based on commandline flags. Currently tests file open, process creation, and connect. This is currently not set up for Linux. To set it up for Linux, we need to be more careful about what tests are expected to pass, and will need to look into zygote process for how to get the test shared lib loaded. BUG=39409 TEST=none Review URL: http://codereview.chromium.org/1549046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52567 0039d316-1c4b-4281-b951-d872f2087c98
* Command line flag cleanup.estade@chromium.org2010-06-251-2/+2
| | | | | | | | | | | | | Move some string literals into chrome/common/chrome_switches. There are still many uses in places that cannot depend on chrome/common. BUG=none TEST=trybots Review URL: http://codereview.chromium.org/2824008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50888 0039d316-1c4b-4281-b951-d872f2087c98
* linux: initialize glib-dbus threading during startupevan@chromium.org2010-06-231-0/+5
| | | | | | | | | | | | Rather than scattering init calls through the code, just inititialize it once. (In particular, the gnome-keyring support also needs this function called, and I didn't want to copy it one more time.) TEST=no threading-related crash during gnome-keyring startup Review URL: http://codereview.chromium.org/2873015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50652 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Catch X errors and force a crash.thestig@chromium.org2010-06-111-6/+13
| | | | | | | | BUG=45020 TEST=See http://crosbug.com/3487 Review URL: http://codereview.chromium.org/2716007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49488 0039d316-1c4b-4281-b951-d872f2087c98
* add --version flagestade@chromium.org2010-06-101-0/+13
| | | | | | | | | BUG=none TEST=manual Review URL: http://codereview.chromium.org/2727005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49447 0039d316-1c4b-4281-b951-d872f2087c98
* Linux/GTK: implement update notification.estade@chromium.org2010-06-031-0/+11
| | | | | | | | | BUG=45148 TEST=compile chrome with PRODUCT_VERSION manually set to something higher than the current version (e.g. 7.0.0.0), and manually set the upgrade detector time to something short (like 10 seconds). Launch chrome and wait a short time for the update notification to appear. The update notification should pulse every few seconds, and should stop pulsing when the user opens the wrench menu. The about menu item should launch a dialog that allows the user to restart chrome, restoring the current session. Review URL: http://codereview.chromium.org/2365003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48795 0039d316-1c4b-4281-b951-d872f2087c98
* Enable warning 4389 as an error on windows builds. This will make mbelshe@chromium.org2010-05-271-2/+2
| | | | | | | | | | | | windows builds more similar to linux/mac, which already treat signed/ unsigned equality comparisons as warnings (and hence errors). BUG=44471 TEST=none Review URL: http://codereview.chromium.org/2222002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48395 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Another dependency the bbot missed!!!"rafaelw@chromium.org2010-05-261-2/+2
| | | | | | | | | | | | | | | | | | This reverts commit 161f7fd3bdd425167af9fe26fdc5373a2ff44c98. Revert "Missed a file as part of checkin for r48186" This reverts commit cff86beba5938209393a6c3bccced62a7f3ff36b. Revert "Enable warning 4389 as an error on windows builds. This will make" This reverts commit c78936bcfc65b98edf288191d927a495b0364621. TBR=mbelshe Review URL: http://codereview.chromium.org/2253001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48238 0039d316-1c4b-4281-b951-d872f2087c98
* Enable warning 4389 as an error on windows builds. This will makembelshe@chromium.org2010-05-251-2/+2
| | | | | | | | | | | | windows builds more similar to linux/mac, which already treat signed/ unsigned equality comparisons as warnings (and hence errors). BUG=44471 TEST=none Review URL: http://codereview.chromium.org/2081007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48186 0039d316-1c4b-4281-b951-d872f2087c98
* Call mac_util::SerOverrideAppBundlePath before invoking DiagnosticsMain for ↵csilv@chromium.org2010-05-251-7/+7
| | | | | | | | | | | | | | | Mac builds. This fixes any tests that rely on the bundle paths. (Currently this affects the 'Inspector Directory' test. BUG=none TEST=Launch Mac client from command line with --diagnostics switch. The 'Inspector Directory' test should pass. Review URL: http://codereview.chromium.org/2107017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48165 0039d316-1c4b-4281-b951-d872f2087c98
* - Made the writing of boot times happen on the file thread.davemoore@chromium.org2010-05-191-6/+5
| | | | | | | | | | | | | - Also combined two different ways of writing these times into common code. - Tweaked the color / font of the output BUG=NONE TEST=Ensure that boot times still display on login screen. Review URL: http://codereview.chromium.org/2112006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47682 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-06 14:02:07 +0000