summaryrefslogtreecommitdiffstats
path: root/chrome/app/chrome_dll_resource.h
Commit message (Collapse)AuthorAgeFilesLines
* Make app launcher on Windows pinnable.benwells@chromium.org2012-09-281-0/+1
| | | | | | | | | | | | | This sets the appropriate property store values so that when pinned the created shortcut will have the right icon and launch switches. A .ico has been added to the resources for this. This also removes the need to set the window icon in the previous way, so the previous resource and code has been removed. BUG=151672 Review URL: https://chromiumcodereview.appspot.com/10996042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159225 0039d316-1c4b-4281-b951-d872f2087c98
* Split out command IDs from chrome_dll_resource.h.evan@chromium.org2010-11-081-289/+0
| | | | | | | | | | | | The name of this file is a leftover from Windows. Split the command ids (which are used on all platforms) out, leaving just the Windows-specific resource IDs in the original file. TEST=compiles Review URL: http://codereview.chromium.org/4710001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65453 0039d316-1c4b-4281-b951-d872f2087c98
* First cut of the about:conflicts page, listing all DLLs loaded in the Chrome ↵finnur@chromium.org2010-11-081-0/+1
| | | | | | | | | | | process. BUG=http://crbug.com/51105, http://crbug.com/57239 TEST=Unit tests included. Review URL: http://codereview.chromium.org/4524002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65366 0039d316-1c4b-4281-b951-d872f2087c98
* The "Update Chrome" menu item should appear in addition to the About menu.erg@google.com2010-08-311-0/+1
| | | | | | | | | | | It should not replace it. This patch modifications to the GTK and Cocoa ports to make the update chrome item appear when an update is available. On win/chromeos, the menu item is always there but disabled, since I'm having some problems figuring out the views custom menu implementation. BUG=46221 TEST=The upgrade item should now appear under instead of replacing the about command. Review URL: http://codereview.chromium.org/3143046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58040 0039d316-1c4b-4281-b951-d872f2087c98
* Added "Look Up in Dictionary" item to context menu for Mac. tkent@chromium.org2010-08-231-0/+1
| | | | | | | | | | BUG=46153 TEST=manual Patch by morrita@google Original code review: http://codereview.chromium.org/3139007/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57025 0039d316-1c4b-4281-b951-d872f2087c98
* Changed ChromeOS status bar menu handlers to obey --enable-tabbed-options ↵zelidrag@chromium.org2010-08-201-0/+1
| | | | | | | | | | | switch and display the new DOM UI when it's used. BUG=chromium-os:5522 TEST=make sure the new DOM UI option tab opens from status bar drop down menues (language, internet and system settings) Review URL: http://codereview.chromium.org/3142020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56816 0039d316-1c4b-4281-b951-d872f2087c98
* remove toolstripserikkay@chromium.org2010-08-121-1/+0
| | | | | | | | | | | BUG=51703 BUG=30178 BUG=25106 TEST=none Review URL: http://codereview.chromium.org/3129003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55921 0039d316-1c4b-4281-b951-d872f2087c98
* Adding remoting setup to wrench menuhclam@chromium.org2010-08-121-0/+3
| | | | | | | | | | | | | | pranvak@ is OOO so I'm submitting for him. This patch will add a menu in wrench menu to start the chromoting setup flow. Submit for: pranvak@chromium.org Reviewed: http://codereview.chromium.org/3075024/show Review URL: http://codereview.chromium.org/3134003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55815 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 55311 - Add remoting to wrench menu.erikchen@google.com2010-08-061-3/+0
| | | | | | | | | | | | | | | | | | | This change adds remoting item to wrench menu. The change is under flag enable-remoting, so end users will not see it. The CL is cleaned up. It was compiling and working. I added the check for kEnableRemoting and resynched and it is no longer compiling. Submitted for: pranavk@chromium.org Reviewed: http://codereview.chromium.org/3075024/show BUG=50242 TEST=NONE Review URL: http://codereview.chromium.org/3080038 TBR=hclam@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55316 0039d316-1c4b-4281-b951-d872f2087c98
* Add remoting to wrench menu.hclam@chromium.org2010-08-061-0/+3
| | | | | | | | | | | | | | | | | This change adds remoting item to wrench menu. The change is under flag enable-remoting, so end users will not see it. The CL is cleaned up. It was compiling and working. I added the check for kEnableRemoting and resynched and it is no longer compiling. Submitted for: pranavk@chromium.org Reviewed: http://codereview.chromium.org/3075024/show BUG=50242 TEST=NONE Review URL: http://codereview.chromium.org/3080038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55311 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Add "Show Tab Overview" menu item.thakis@chromium.org2010-07-271-0/+1
| | | | | | | | | | | | xib changes: Add menu item with shortcut cmd-f10 for now, connect it to -commandDispatch:. Connect app controller's new outlet to the new menu item. BUG=50307 TEST=No changes by default. If --enable-expose-for-tabs is passed, a new menu item should be visible below "prev tab" in the window menu. It should be active for normal browser windows and fullscreen windows, but not if there are no browser windows around or if the current window is a popup window or a non-browser window (e.g. prefs). Clicking the menu item doesn't do anything yet. cmd-f10 should trigger the menu item, but it shouldn't if the cmdline flag isn't passed. TEST2=Go to a page that is busy spinning some javascript (e.g. "javascript:while(1);"), give it focus, hit cmd-f10. Menu should blink immediately. Review URL: http://codereview.chromium.org/3020035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53833 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-261-0/+1
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the page and app menus.pkasting@chromium.org2010-07-201-4/+3
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3033007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52985 0039d316-1c4b-4281-b951-d872f2087c98
* Put sidetab menu back to wrench menu (confirmed with sky)oshima@chromium.org2010-07-201-2/+1
| | | | | | | | | | | | Removed OpenTanMode (confirmed with cole) Removed ToolbarView::SetAppMenuModel BUG=49229 TEST=none. Review URL: http://codereview.chromium.org/2832058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52968 0039d316-1c4b-4281-b951-d872f2087c98
* Removing the code that are no longer in use.oshima@chromium.org2010-07-161-4/+3
| | | | | | | | | | | | | | | | | | * CompactNavigationBar this feature has been discontinued * BrowserStatusAreaView status area used to have a menu, but it's gone and this class no longer needed. * BrowserExtender used to implement chromeos specific feature, which has been replaced by chromeos/browser_view BUG=49229 TEST=no functional chagne. all test should pass. Review URL: http://codereview.chromium.org/3035004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52690 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a way for user to report errors in language detectionjcivelli@chromium.org2010-07-161-6/+7
| | | | | | | | | | Adding a menu to the translate infobar that let users report when the language of a page has been incorrectly detected. BUG=48739 TEST=Visit a page in a language that triggers the translate infobar. Select the menu to report an error. A new tab should be opened that references the page and language and let you report the error. Review URL: http://codereview.chromium.org/2911005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52683 0039d316-1c4b-4281-b951-d872f2087c98
* Add "Inspect Element" shortcut to browser tabs.apavlov@chromium.org2010-07-161-0/+1
| | | | | | | | | | | | | | If the DevTools window is closed, it gets opened, and the Inspect Element tool is enabled. If the DevTools window is opened, the inspected tab remains focused with the Inspect Element tool enabled. If the Inspect Element tool is enabled, it gets turned off. The shortcut is Ctrl-Shift-C for Win/Linux, Cmd-Shift-C for Mac BUG=29532 TEST=manual Review URL: http://codereview.chromium.org/3011002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52651 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Put buttons into the new unified Wrench menu.rsesek@chromium.org2010-07-151-0/+1
| | | | | | | | | | | | This also makes changes to MenuController to support NIB-based initialization. Screen shots: http://cl.ly/1cyU (en) and http://cl.ly/1cyE (ru). BUG=47848 TEST=Click on Wrench menu and see buttons. Buttons perform their function. Review URL: http://codereview.chromium.org/2923009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52485 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Cleanups to the new wrench menu.erg@chromium.org2010-06-301-0/+1
| | | | | | | | | | | | | | | - Make the rendering for multiple buttons pretty by unifying sequnces of buttons. - Add the zoom label control and make the wrench menu model listen for notifications about zoom percentage changing. - Fixes crash that would have gone away once this was taken out from behind a flag BUG=45757 TEST=none Review URL: http://codereview.chromium.org/2799043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51266 0039d316-1c4b-4281-b951-d872f2087c98
* Improve toolbar keyboard accessibility.dmazzoni@chromium.org2010-06-181-0/+4
| | | | | | | | | | | | Design doc: https://docs.google.com/a/google.com/Doc?docid=0ATICCjR-gNReY2djdjkyNnNfNzl4ZnpiODQ2Mg&hl=en BUG=40745 BUG=36728 BUG=36222 TEST=New test added to focus_manager_unittest.cc Review URL: http://codereview.chromium.org/2737010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50234 0039d316-1c4b-4281-b951-d872f2087c98
* Detach reload from omnibox, combine with stop, and eliminate go.pkasting@chromium.org2010-06-111-3/+1
| | | | | | | | | | This does the basic surgery on all three OSes without trying to fix up the visual appearance. As a result, things look pretty ugly. My intent is to at least put endcaps on the omnibox in a subsequent patch. BUG=45745,45762,45763 TEST=Reload and stop should be combined; go should be gone. Review URL: http://codereview.chromium.org/2677003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49492 0039d316-1c4b-4281-b951-d872f2087c98
* Rip out the multiprofile implementation.erg@chromium.org2010-06-101-15/+0
| | | | | | | | | | | Requested by Ben. Never worked on linux or OSX and apparently broken on Windows. Removal of the multiprofile code will make switching out the old AppMenuModel with the new WrenchMenuModel trivial. BUG=27177 TEST=none Review URL: http://codereview.chromium.org/2736001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49440 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Make the History menu behave more like the NTP in its display of ↵rsesek@chromium.org2010-06-031-2/+0
| | | | | | | | | | | | | | | | | | | | | recently closed items. Now, the menu will show Window entries that have a submenu of all the tabs. Currently, only the complete window can be restored, not submenu items (representing individual tabs) as this requires changing the TabRestoreService. That will come in a future CL. This CL also significantly refactors the internals of the history menu. XIB changes: Re-assign tag values in the History menu to those used in HistoryMenuBridge::Tags enum. BUG=43787 TEST=Open a window and navigate two tabs. Close window. In the History menu, there should be a "2 Tabs" item in the Recently Closed section. Select that to restore. TEST=Open a window and navigate two tabs. Close one tab. In the History menu, there should be that individual tab entry. Select to restore. Review URL: http://codereview.chromium.org/2481001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48844 0039d316-1c4b-4281-b951-d872f2087c98
* Pressing the search button brings the NTP or close it if it is opened.jcivelli@chromium.org2010-06-011-0/+1
| | | | | | | | | | | | Note: this requires the WebKit https://bugs.webkit.org/show_bug.cgi?id=39752 to work. BUG=3404 TEST=See bug. Review URL: http://codereview.chromium.org/2260004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48658 0039d316-1c4b-4281-b951-d872f2087c98
* Adds side tab layout for chromeos. As part of this I renamed thesky@chromium.org2010-05-281-0/+2
| | | | | | | | | | | | | compact location bar menu to experimental and place both items there. The two are mutually exclusive, so toggling one untoggles the other. Also makes the status bubble not overlap the tabstrip for side tabs. BUG=none TEST=none Review URL: http://codereview.chromium.org/2340001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48531 0039d316-1c4b-4281-b951-d872f2087c98
* Only use IDC_ values for command ids in the render view context menu.estade@chromium.org2010-05-131-0/+47
| | | | | | | | | BUG=43816 TEST=none Review URL: http://codereview.chromium.org/1981014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47187 0039d316-1c4b-4281-b951-d872f2087c98
* Win: Fix wrong default icon being shown on chrome.exe.mattm@chromium.org2010-05-031-1/+1
| | | | | | | | | BUG=42977 TEST=build official exe, look at it in explorer Review URL: http://codereview.chromium.org/1736029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46241 0039d316-1c4b-4281-b951-d872f2087c98
* Win: Use different icon for SxSmattm@chromium.org2010-04-231-1/+1
| | | | | | | | | BUG=37119 TEST=build official exe, run with --chrome-sxs Review URL: http://codereview.chromium.org/1727006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45388 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Fill the default profile when the AutoFill accelerator combo is ↵jhawkins@chromium.org2010-04-091-0/+1
| | | | | | | | | | | pressed (ctrl-shift-a). BUG=39491 TEST=none Review URL: http://codereview.chromium.org/1521020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44149 0039d316-1c4b-4281-b951-d872f2087c98
* Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-311-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility interactive ui test. Review URL: http://codereview.chromium.org/660323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43216 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting this CL to fix the interactive ui test failures.ananta@chromium.org2010-03-261-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Revert 42498 - Keyboard accessibility for the page and app menus. Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility interactive ui test. Review URL: http://codereview.chromium.org/660323 TBR=dmazzoni@chromium.org Review URL: http://codereview.chromium.org/1428001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42779 0039d316-1c4b-4281-b951-d872f2087c98
* Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-241-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility interactive ui test. Review URL: http://codereview.chromium.org/660323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42498 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 42465 - Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-241-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Reverting because newly added Test*MenuKeyboardAccess tests fail on some of the Windows buildbots, and possibly a XP Perf regression. Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility ui test. Review URL: http://codereview.chromium.org/660323 TBR=dmazzoni@chromium.org Review URL: http://codereview.chromium.org/1257003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42468 0039d316-1c4b-4281-b951-d872f2087c98
* Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-241-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility ui test. Review URL: http://codereview.chromium.org/660323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42465 0039d316-1c4b-4281-b951-d872f2087c98
* Initial version of an experimental Extensions Context Menu API.asargent@chromium.org2010-03-231-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The proposal for the API is documented at: http://dev.chromium.org/developers/design-documents/extensions/context-menu-api Notable limitations in this initial implementation: -No reliable way to get at the unique, actual node clicked on in contexts like IMAGE/LINK/etc. We'll need to fix this in the long run - see the API proposal page for some notes on this. -No update or deleteAll methods ; the only way you can change items is to delete by id and re-add. -We aren't yet matching the UI goal of having the extension items at the top level include the extension icon on the left. This will require a refactoring of RenderViewContextMenu to steal some of the code from the bookmarks bar context menus, which can display favicons. -The only kind of parent->child menu that currently works is if you have a single top-level parent, and only one level of children. (This is because of how RenderViewContextMenu currently works) -No browser tests that the menu items actually get drawn (will wait on those until the above mentioned refactor is complete), or API tests (the API may change a bit based on feedback, at which point I'll write more tests). -Unit tests need to cover some more cases. BUG=32363 TEST=Should be able to create context menus with this API. Review URL: http://codereview.chromium.org/1042003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42321 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Keyboard accessibility for the page and app menus.", rev 42234 and ↵maruel@chromium.org2010-03-221-1/+0
| | | | | | | | | | 42236. TBR=dmazzoni Review URL: http://codereview.chromium.org/1158004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42239 0039d316-1c4b-4281-b951-d872f2087c98
* Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-221-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility ui test. Review URL: http://codereview.chromium.org/660323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42234 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Keyboard accessibility for the page and app menus."maruel@chromium.org2010-03-221-1/+0
| | | | | | | | | | This reverts commit 42217. TBR=dmzazzoni Review URL: http://codereview.chromium.org/1154003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42218 0039d316-1c4b-4281-b951-d872f2087c98
* Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-221-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility ui test. Review URL: http://codereview.chromium.org/660323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42217 0039d316-1c4b-4281-b951-d872f2087c98
* linux: plumb shift-reload down into new shift-reload APIevan@chromium.org2010-02-191-0/+3
| | | | | | | | | | | | | | | | | | | | | Currently Linux-only, but the Mac/Win bits should now be trivial. While I was add it, I tweaked a NavigationController function that took a bare boolean into an enum to make the call sites more explicit about what they're doing. (In most places I added new functions that call into a shared backing function; this is so I don't need to change every single caller of e.g. Reload() to pass through an extra flag that will be the same for almost every caller.) BUG=1906 TEST=visit astronomy picture of the day; hit reload, picture pops up quickly; hit shift-reload, picture loads slowly Review URL: http://codereview.chromium.org/594063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39430 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit side is in https://bugs.webkit.org/show_bug.cgi?id=34524jeremy@chromium.org2010-02-051-0/+6
| | | | | | | | | BUG=NONE TEST=Right clicking on a text input field in Web content on OS X should now show a Writing Direction submenu. Clicking on "Left To Right" should align the input to the left, and "Right To Left" should do the opposit. The "Default" menu item should always be disabled. Review URL: http://codereview.chromium.org/566031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38204 0039d316-1c4b-4281-b951-d872f2087c98
* Wire popup blocking UI to the new machinery and port over the user's old ↵pkasting@chromium.org2010-02-021-5/+4
| | | | | | | | | | | | | | | | whitelist. Notably, this removes the UI entirely for Mac and Linux. We need to rebuild it. This also guts the old system's testing, since most of it disappeared or changed radically. We should test the new stuff. I will file a followup bug for that. There are various tiny edge cases, like if you click the address bar icon really quickly, sometimes you'll get popups without any title yet, which makes them leave gaps in the bubble that appears. We can fix that sort of thing. The critical bit I tried to ensure was that we never try to open a dead popup or use a dead TabContents, no matter what. BUG=33314 TEST=Go visit some sites with popups and play with things Review URL: http://codereview.chromium.org/562013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37819 0039d316-1c4b-4281-b951-d872f2087c98
* implement infobars and delegates placeholders for translate feature.kuan@chromium.org2010-01-271-1/+10
| | | | | | Review URL: http://codereview.chromium.org/546132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37281 0039d316-1c4b-4281-b951-d872f2087c98
* Split chromeos options page into system and internet.chocobo@chromium.org2010-01-261-1/+2
| | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/548152 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37155 0039d316-1c4b-4281-b951-d872f2087c98
* [Linux] Implement input methods context menu.suzhe@chromium.org2010-01-241-1/+2
| | | | | | | | | BUG=31008 TEST=Right click in the content area, there will be an "Input Method" submenu. Review URL: http://codereview.chromium.org/549100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36977 0039d316-1c4b-4281-b951-d872f2087c98
* Unhandled keyboard messages coming back from the host browser running ↵ananta@chromium.org2010-01-121-0/+1
| | | | | | | | | | | | | | | | | | | | | ChromeFrame need to process accelerators. Currently accelerators are processed by the focus manager. We already have code in browser_view to process unhandled keyboard messages coming back from the renderer. Moved this code to a new class UnhandledKeyboardEventHandler which maintains state about whether the next character event has to be ignored, etc. This class is now used by BrowserView and the ExternalTabContainer to process unhandled keyboard messages. To support accelerators in ChromeFrame, the ExternalTabContainer needs to implement an Accelerator target. I also added a minimal accelerator table for Chromeframe in the chrome_dll.rc and chrome_dll_resource.h files. This fixes bug http://code.google.com/p/chromium/issues/detail?id=31672 Bug=31672 Review URL: http://codereview.chromium.org/536023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36037 0039d316-1c4b-4281-b951-d872f2087c98
* Add some licensing comments under chrome/.evan@chromium.org2009-12-281-0/+4
| | | | | | | | BUG=28291 Review URL: http://codereview.chromium.org/507067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35301 0039d316-1c4b-4281-b951-d872f2087c98
* Chromium: support custom WebCore context menu items in Chromium port ↵pfeldman@chromium.org2009-12-091-0/+4
| | | | | | | | (downstream). Review URL: http://codereview.chromium.org/465123 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34154 0039d316-1c4b-4281-b951-d872f2087c98
* Implement "Email Link To Page" menu command.snej@chromium.org2009-12-031-0/+1
| | | | | | | | | | | | | | | | | | | This menu item only exists in the Mac build, but the code is cross-platform so it could be hooked up on other platforms as well, if desired. It works by generating a URL of the form mailto:?subject=Fwd:%20PAGETITLE&body=%0A%0APAGEURL and telling platform_utils to open it. This is my first patch involving command handling; I've tried to follow the way similar menu commands like Print are implemented, but feel free to tell me if there are better ways. I didn't find any place for unit tests for TabContents; if this needs tests, let me know where they should go. BUG=29232 TEST=none Review URL: http://codereview.chromium.org/466019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33746 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Wire Ctrl+Shift+C to "Show JavaScript console".pfeldman@chromium.org2009-11-061-1/+2
| | | | | | Review URL: http://codereview.chromium.org/377005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31225 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-10 22:45:06 +0000