summaryrefslogtreecommitdiffstats
path: root/chrome/app/client_util.cc
Commit message (Collapse)AuthorAgeFilesLines
* Add a --chrome-version switch to Chrome that serves a similar purpose to the ↵robertshield@chromium.org2010-11-161-21/+56
| | | | | | | | | | | | | | CHROME_VERSION environment variable since environment variables are unsuitable for Chrome Frame's needs. Also add some validation to the version numbers plucked from both the command line flag and the environment variable to reduce the chances of success of bogus-version number skulduggery. BUG=61609 TEST=Run Chrome with --chrome-version=a.b.c.d, observe that that version of chrome.dll is loaded. Review URL: http://codereview.chromium.org/4664004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66268 0039d316-1c4b-4281-b951-d872f2087c98
* Move debug-related stuff from base to the base/debug directory and use thebrettw@chromium.org2010-10-261-1/+1
| | | | | | | | | | | | | | | | base::debug namespace. This splits apart debug_util into base/debugger and base/stack_trace There are still two functions in debug_util that I'm not sure what to do with. Since this uses the base::debug namespace, I removed the functions in debugger.h from the static class and just made them free functions in the namespace. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3945002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63859 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 56978 - Use Environment::GetVar instead of the obscure EnvQueryStr ↵mal@chromium.org2010-08-221-8/+14
| | | | | | | | | | | | | | | | function. - Remove this obscure function since it was called only once. - Use Environment::GetVar instead. BUG=52951 TEST=trybots Review URL: http://codereview.chromium.org/3135036 TBR=tfarina@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57013 0039d316-1c4b-4281-b951-d872f2087c98
* Use Environment::GetVar instead of the obscure EnvQueryStr function.tfarina@chromium.org2010-08-211-14/+8
| | | | | | | | | | | | - Remove this obscure function since it was called only once. - Use Environment::GetVar instead. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/3135036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56978 0039d316-1c4b-4281-b951-d872f2087c98
* Use Environment::SetVar in more places.tfarina@chromium.org2010-08-131-5/+9
| | | | | | | | | | | | Make use of Environment::SetVar API to replace the calls to the Windows function SetEnvironmentVariable. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/3076042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55993 0039d316-1c4b-4281-b951-d872f2087c98
* Add event traces to measure the performance of the function which pre reads ↵ananta@chromium.org2010-08-121-0/+3
| | | | | | | | | | | chrome.dll to improve startup performance. Bug=51638 TBR=stoyan Review URL: http://codereview.chromium.org/3158008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55828 0039d316-1c4b-4281-b951-d872f2087c98
* base/ header cleanup. Forward declaration instead of including.erg@google.com2010-07-281-0/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3068004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53969 0039d316-1c4b-4281-b951-d872f2087c98
* After verifying the startup win though more testing, removing the guards ↵slightlyoff@chromium.org2010-07-131-6/+1
| | | | | | | | | | | around the pre-reading optimization. BUG=45510 TEST=None Review URL: http://codereview.chromium.org/2891014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52234 0039d316-1c4b-4281-b951-d872f2087c98
* PreRead chrome.dll only for release builds.ananta@chromium.org2010-07-091-0/+2
| | | | | | | | Bug=45510 Review URL: http://codereview.chromium.org/2918003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51988 0039d316-1c4b-4281-b951-d872f2087c98
* Changing the pre-reading of chrome.dll to read it as an image section ↵ananta@chromium.org2010-07-031-40/+22
| | | | | | | | | | | | | | | | | | | instead. XP ignores pages read as data while mapping image sections. This shows a reasonable improvement in cold startup performance on XP. This change only comes into effect for headless mode which enables us to try out the effect on the perf bots and for chrome frame processes. Code mostly written by Amit. Added a chrome frame perf tests which measures LoadLibrary in cold mode with pre-reading. Bug=45510 Review URL: http://codereview.chromium.org/2805064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51594 0039d316-1c4b-4281-b951-d872f2087c98
* Previously we didn't pre-read at all if there was any configuration in the ↵slightlyoff@chromium.org2010-07-021-2/+5
| | | | | | | | | | | ChromeFrame key. This change makes that decision sensitive to the existance of the PreRead value, not just the existance of the ChromeFrame key. TEST=On Vista, create a ChromeFrame pref key, then run: chrome_frame_perftests.exe --gtest_filter=*X.PerfCold BUG=45510 Review URL: http://codereview.chromium.org/2844023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51486 0039d316-1c4b-4281-b951-d872f2087c98
* Fix nacl buildamit@chromium.org2010-06-211-2/+1
| | | | | | Review URL: http://codereview.chromium.org/2833023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50389 0039d316-1c4b-4281-b951-d872f2087c98
* Experimental pre-reading optimization to run on perf botsamit@chromium.org2010-06-211-0/+57
| | | | | | | | | | | | Pre-reading chrome.dll prior to calling loadlibrary has shown significant improvement int he startup performance. Temporarily enabling this for headless mode so that we can try out the effect on the perf bots. Review URL: http://codereview.chromium.org/2814019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50386 0039d316-1c4b-4281-b951-d872f2087c98
* Using different Version environment variable for SxS.huanr@chromium.org2010-05-191-3/+6
| | | | | | | | | | | BUG=44474 TEST=mini_installer.exe --chrome-sxs. The first run should start regardless what is set for CHROME_VERSION. Review URL: http://codereview.chromium.org/2101006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47600 0039d316-1c4b-4281-b951-d872f2087c98
* r46025 reverted r46023 which caused a build break on chromeos.prasadt@chromium.org2010-04-301-0/+15
| | | | | | | | | | | | | | | This change reverts r46025 and fixes the build break which is just a one line change in chrome/browser/first_run_gtk.cc to move the definition of Upgrade::new_command_line_ to be inside a #if. Details on the change and code review feedback for the original CL can be found at http://codereview.chromium.org/1633021. BUG=40975 TEST=none Review URL: http://codereview.chromium.org/1691022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46103 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r46023: "Detect new instance of the browser when running in the ↵willchan@chromium.org2010-04-301-15/+0
| | | | | | | | | | background in persistent" Broke the build. Review URL: http://codereview.chromium.org/1718024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46025 0039d316-1c4b-4281-b951-d872f2087c98
* Detect new instance of the browser when running in the background in persistentprasadt@chromium.org2010-04-301-0/+15
| | | | | | | | | | | | | | | | | | mode, shutdown and restart the new instance. This is already done for Windows, this CL enables the functionality for Linux. We don't yet have a unit test for this. Local testing is done by: 1) Reducing the timer to 30 seconds. 2) Changing BrowserList::IsInPersistentMode to return true. 3) Setting BrowserProcessImpl::autoupdate_timer_ to 30 seconds interval. 4) Running "touch" command on chrome exe to pretend there is an update. BUG=40975 TEST=none Review URL: http://codereview.chromium.org/1633021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46023 0039d316-1c4b-4281-b951-d872f2087c98
* Implement the broker process that launches NaCl loader processes on 64-bit ↵gregoryd@google.com2010-02-011-0/+16
| | | | | | | | | | | | Windows systems. BUG=28176 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=37578 Review URL: http://codereview.chromium.org/542030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37720 0039d316-1c4b-4281-b951-d872f2087c98
* Correct the length of the string saved to the "dr" registry value used for ↵robertshield@chromium.org2010-01-301-1/+4
| | | | | | | | | | | Omaha active user reporting. BUG=33457 TEST=The dr value of "1" is written with length 4 bytes. Review URL: http://codereview.chromium.org/548204 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37638 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 37578 - Implement the broker process that launches NaCl loader ↵gregoryd@google.com2010-01-301-16/+0
| | | | | | | | | | | | processes on 64bit Windows systems. BUG=28176 TEST=none Review URL: http://codereview.chromium.org/542030 TBR=gregoryd@google.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37580 0039d316-1c4b-4281-b951-d872f2087c98
* Implement the broker process that launches NaCl loader processes on 64-bit ↵gregoryd@google.com2010-01-301-0/+16
| | | | | | | | | | Windows systems. BUG=28176 TEST=none Review URL: http://codereview.chromium.org/542030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37578 0039d316-1c4b-4281-b951-d872f2087c98
* Reset the dr key if the toast experiment is cancelled.cpu@chromium.org2009-12-191-6/+24
| | | | | | | | | | | | | | TEST= run the toast experiment and cancel it. Then look at the dr key on HKEY_CURRENT_USER\Software\Google\Update\ClientState\{8A69D345-D564-463C-AFF1-A69D9E530F96} should be "0" BUG=30799 Review URL: http://codereview.chromium.org/502077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35028 0039d316-1c4b-4281-b951-d872f2087c98
* Push the Omaha app guid into the browser distribution classes to remove ↵robertshield@chromium.org2009-11-051-2/+4
| | | | | | | | compile-time differences between Chrome Frame and Chrome. Review URL: http://codereview.chromium.org/361023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31073 0039d316-1c4b-4281-b951-d872f2087c98
* Continue to remove CHROME_FRAME_BUILD define from code that goes into ↵robertshield@chromium.org2009-11-041-1/+3
| | | | | | | | | | | | | | | | | | | | | chrome.dll. This reworks the browser distribution code to use the ChromeFrameBrowserDistribution iff --chrome-frame is present on the command line. Also, * At startup, chrome.exe now uses the BrowserDistribution code to determine where the Chromium version key resides (instead of hard coding it). * The installer now propagates the presence of --verbose-logging to uninstalls. * The chrome_launcher now allows the --chrome-frame switch through to chrome. * The installer now accepts a --chrome-frame switch. * Remove almost all occurences of the CHROME_FRAME_BUILD define from the installer. BUG=26012, 26603 TEST=Chrome Frame still builds and runs correctly. Chrome Frame builds built without 'branding'='Chrome' now install correctly. Review URL: http://codereview.chromium.org/345021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31015 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for broken mini_installer_testcpu@chromium.org2009-11-041-1/+1
| | | | | | | | | | | | | - Definitely broken. Nice to have these tests BUG=none TEST=none TBR=kuchhal Review URL: http://codereview.chromium.org/360002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30944 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite of chrome.exe startup codecpu@chromium.org2009-11-041-63/+168
| | | | | | | | | | | | | | | | | | | | | | | A lot of cruft and repeated code has deposited over the years on chrome's initialization code. This CL makes it all much more clear and straightforward. There is no fundamental change of behavior except the order of certain things is different but it should not alter the observed operation. - chrome's and chromium load is fundamentally the same but most of the code was repeated - chrome's way to load the dll was incorrect: using a relative path with LOAD_WITH_ALTERED_SEARCH_PATH - Use of SearchPath() was dangerous and not needed - removed google_update_client.cc and .h - removed bunch of #ifdefs TEST=all convered by UI tests already except [1] BUG=none [1] The only thing I don't see convered by test is the restart dialog ('woa! chrome crashed'). Review URL: http://codereview.chromium.org/345036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30934 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Convert dll_path_ to a std::wstring. This avoids having dll_path_ ↵jhawkins@chromium.org2009-10-211-5/+8
| | | | | | | | | | | uninitialized after the object is constructed. CID=1632 BUG=none TEST=none Review URL: http://codereview.chromium.org/306037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29730 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Pass strings by reference.jhawkins@chromium.org2009-10-211-2/+2
| | | | | | | | | CID=2635 BUG=none TEST=none Review URL: http://codereview.chromium.org/293058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29716 0039d316-1c4b-4281-b951-d872f2087c98
* NO CODE CHANGEdeanm@chromium.org2009-03-101-1/+0
| | | | | | | | | Normalize end of file newlines in chrome/. All files end in a single newline. Review URL: http://codereview.chromium.org/42015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11331 0039d316-1c4b-4281-b951-d872f2087c98
* * Check the presence of new_chrome.exe before using opv key for version.kuchhal@chromium.org2008-11-071-25/+34
| | | | | | Review URL: http://codereview.chromium.org/10214 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5035 0039d316-1c4b-4281-b951-d872f2087c98
* Implement the new mechanism we are going to use for handling Chromium updateskuchhal@chromium.org2008-11-071-4/+18
| | | | | | | | | | | | | | | | | | | | while it is in use. This should work for per user as well as system level installs (after some additional changes once Google Update changes are ready). The following scenarios should work now: - If Chromium is using two different profiles at the same time we do not switch chrome executables until all of them are closed. - The old version of Chromium can be run after a restart if the renaming of executables fails. - We will not use environment variable any more but we need to keep it until all the users get this change on their machines. - opv/rename registry keys and new_chrome.exe should always together. If one exist all three should exist because they are created and deleted as one atomic operation (as much as possible given laws of physics). BUG=1463346 Review URL: http://codereview.chromium.org/9436 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4949 0039d316-1c4b-4281-b951-d872f2087c98
* This fixes the following bugs1. http://b/issue?id=1447957 For machine ↵ananta@chromium.org2008-11-041-13/+2
| | | | | | | | installs we need to use a different version of the Omaha updater.2. http://b/issue?id=1447951 For Vista we need to elevate while performing the update operation. This only applies to machine installs. Update checks also instantiate the same COM object. However it does not need elevation.Bug=1447957, 1447951R=finnur, kuchhal Review URL: http://codereview.chromium.org/8221 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4705 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize Breakpad for Chromium as well.rahulk@google.com2008-08-291-0/+17
| | | | | | | BU=1296800 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1572 0039d316-1c4b-4281-b951-d872f2087c98
* Use a more compact license header in source files.license.bot2008-08-241-28/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1287 0039d316-1c4b-4281-b951-d872f2087c98
* Make chrome.exe read version from Software\Chromium instead of Google Update ↵rahulk@google.com2008-08-221-0/+90
keys when running Chromium. With this change now we can build a Chromium release that gets installed under Application Data\Chromium and actually runs. - Added a new file that has common functions used by google update client and chromium - Did some minor cleanup based on readability guidelines (alphabatical order etc). - We seem to be trying to avoid std::wstring at some places but are using it at other places. In future we should be just able to use std::wstring and get rid of StringCchDup. BUG=1296800 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1243 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-05 11:09:40 +0000