summaryrefslogtreecommitdiffstats
path: root/chrome/app/client_util.h
Commit message (Collapse)AuthorAgeFilesLines
* Rewrite of chrome.exe startup codecpu@chromium.org2009-11-041-30/+38
| | | | | | | | | | | | | | | | | | | | | | | A lot of cruft and repeated code has deposited over the years on chrome's initialization code. This CL makes it all much more clear and straightforward. There is no fundamental change of behavior except the order of certain things is different but it should not alter the observed operation. - chrome's and chromium load is fundamentally the same but most of the code was repeated - chrome's way to load the dll was incorrect: using a relative path with LOAD_WITH_ALTERED_SEARCH_PATH - Use of SearchPath() was dangerous and not needed - removed google_update_client.cc and .h - removed bunch of #ifdefs TEST=all convered by UI tests already except [1] BUG=none [1] The only thing I don't see convered by test is the restart dialog ('woa! chrome crashed'). Review URL: http://codereview.chromium.org/345036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30934 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Convert dll_path_ to a std::wstring. This avoids having dll_path_ ↵jhawkins@chromium.org2009-10-211-3/+3
| | | | | | | | | | | uninitialized after the object is constructed. CID=1632 BUG=none TEST=none Review URL: http://codereview.chromium.org/306037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29730 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Pass strings by reference.jhawkins@chromium.org2009-10-211-2/+2
| | | | | | | | | CID=2635 BUG=none TEST=none Review URL: http://codereview.chromium.org/293058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29716 0039d316-1c4b-4281-b951-d872f2087c98
* NO CODE CHANGEdeanm@chromium.org2009-03-101-1/+0
| | | | | | | | | Normalize end of file newlines in chrome/. All files end in a single newline. Review URL: http://codereview.chromium.org/42015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11331 0039d316-1c4b-4281-b951-d872f2087c98
* Re-do the way browser windows are shown:ben@chromium.org2008-11-141-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | - Remove the path from WinMain to the Browser object passing the show_command. For the Browser object, this is a problem since this value isn't portable. For the code in general it involves a lot of ugly wiring. It's completely unnecessary since the value is obtainable via GetStartupInfo. - Remove show_command plumbing from all over the place (session restore, web app launcher, etc) Change the way browser windows are constructed: - The browser constructor now takes just a type and a profile, and simply initializes the object. - Some configuration that used to be part of the constructor that was only used in one or two use cases (initial bounds, maximized state, web app name) are split into separate setters. - Window creation is split out into a separate step to be called post configuration. - Assorted static helper functions added to Browser to make construction of common types easy. - Remove Browser::Show in favor of BrowserWindow::Show - Adjust all callers to use the new helpers. Change the way ChromeViews restores window placement: - Split restored size determination from restored maximized determination. They are needed by the code at different times. Size restoration happens when the window is constructed and Window::SetInitialBounds is called. Maximized state restoration happens when the window is shown for the first time and SW_SHOWMAXIMIZED or SW_SHOWNORMAL is needed. Thus, replace WindowDelegate::RestoreWindowPosition with WindowDelegate::RestoreWindowBounds and WindowDelegate::RestoreMaximizedState. - Window::SetInitialBounds calls WindowDelegate::RestoreWindowBounds - Window::Show calls WindowDelegate::RestoreMaximizedState - Adjusts all WindowDelegate implementations that override RestoreWindowPosition to implement these new methods instead. - Move "playback/record" mode window size setting from browser_init to Browser::RestoreWindowBounds. - Provide a virtual function on Window called GetShowState that determines the default show state to be used when Window::Show is called. For most windows and dialogs this is SW_SHOWNORMAL. AeroGlassFrame/OpaqueFrame (the browser window frames) override this since they're the app's main windows to return the value provided by GetStartupInfo which gives the value from the app shortcut. http://crbug.com/3557 Review URL: http://codereview.chromium.org/10896 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5417 0039d316-1c4b-4281-b951-d872f2087c98
* This fixes the following bugs1. http://b/issue?id=1447957 For machine ↵ananta@chromium.org2008-11-041-3/+0
| | | | | | | | installs we need to use a different version of the Omaha updater.2. http://b/issue?id=1447951 For Vista we need to elevate while performing the update operation. This only applies to machine installs. Update checks also instantiate the same COM object. However it does not need elevation.Bug=1447957, 1447951R=finnur, kuchhal Review URL: http://codereview.chromium.org/8221 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4705 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize Breakpad for Chromium as well.rahulk@google.com2008-08-291-0/+8
| | | | | | | BU=1296800 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1572 0039d316-1c4b-4281-b951-d872f2087c98
* Use a more compact license header in source files.license.bot2008-08-241-28/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1287 0039d316-1c4b-4281-b951-d872f2087c98
* Make chrome.exe read version from Software\Chromium instead of Google Update ↵rahulk@google.com2008-08-221-0/+65
keys when running Chromium. With this change now we can build a Chromium release that gets installed under Application Data\Chromium and actually runs. - Added a new file that has common functions used by google update client and chromium - Did some minor cleanup based on readability guidelines (alphabatical order etc). - We seem to be trying to avoid std::wstring at some places but are using it at other places. In future we should be just able to use std::wstring and get rid of StringCchDup. BUG=1296800 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1243 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-29 20:22:25 +0000