summaryrefslogtreecommitdiffstats
path: root/chrome/app/client_util.h
Commit message (Collapse)AuthorAgeFilesLines
* Fixing issue for developer chrome launch.shrikant@chromium.org2014-02-281-1/+1
| | | | | | | | | | | Issue was related to how CHROME_VERSION environment variable gets set. BUG= R=cpu Review URL: https://codereview.chromium.org/183663005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254162 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup of windows launch codecpu@chromium.org2014-02-271-15/+11
| | | | | | | | | | | | | | | | | | This is a redo of https://codereview.chromium.org/142473002/ The windows startup code was handling aura and non-aura cases which require different startup logic in metro (immersive mode). Since we don't support the non-Aura logic we can get rid of a lot of code. Tbring gab for the installer constant addition. TBR=gab BUG=none Review URL: https://codereview.chromium.org/158403002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253709 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 249248 "Revert 248332 "hajimehoshi@chromium.org2014-02-061-9/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | > Revert 248332 > > This applies > https://codereview.chromium.org/142473002 > > Which got initially commited as > https://src.chromium.org/viewvc/chrome?view=rev&revision=247151 > > > > Revert 248331 "Revert 247156 "Revert 247151 "Cleanup of windows ..." > > > > Basically reverting 247151 which still breaks the tree. > > > > > > > Revert 247156 "Revert 247151 "Cleanup of windows launch code"" > > > > > > This re-enables 247151 because I can't repro it > > > so it is possible it was a temporary NaCL insanity and definitely > > > the x64 breakage was a flake as confirmed by try jobs. > > > > > > > > > > Revert 247151 "Cleanup of windows launch code" > > > > > > > > > Cleanup of windows launch code > > > > > > > > > > The windows startup code was handling aura and non-aura cases which > > > > > require different startup logic in metro (immersive mode). Since we > > > > > don't support the non-Aura logic we can get rid of a lot of code. > > > > > > > > > > Tbring gab for the installer constant addition. > > > > > > > > > > R=ananta@chromium.org, scottmg@chromium.org > > > > > TBR=gab > > > > > BUG=none > > > > > > > > > > Review URL: https://codereview.chromium.org/142473002 > > > > > > > > TBR=cpu@chromium.org > > > > > > > > Review URL: https://codereview.chromium.org/140123006 > > > > > > TBR=cpu@chromium.org > > > > > > Review URL: https://codereview.chromium.org/151683004 > > > > TBR=cpu@chromium.org > > > > Review URL: https://codereview.chromium.org/152033002 > > TBR=cpu@chromium.org > > Review URL: https://codereview.chromium.org/143473007 TBR=cpu@chromium.org Review URL: https://codereview.chromium.org/140383004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249271 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 248332 cpu@chromium.org2014-02-061-12/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This applies https://codereview.chromium.org/142473002 Which got initially commited as https://src.chromium.org/viewvc/chrome?view=rev&revision=247151 > Revert 248331 "Revert 247156 "Revert 247151 "Cleanup of windows ..." > > Basically reverting 247151 which still breaks the tree. > > > > Revert 247156 "Revert 247151 "Cleanup of windows launch code"" > > > > This re-enables 247151 because I can't repro it > > so it is possible it was a temporary NaCL insanity and definitely > > the x64 breakage was a flake as confirmed by try jobs. > > > > > > > Revert 247151 "Cleanup of windows launch code" > > > > > > > Cleanup of windows launch code > > > > > > > > The windows startup code was handling aura and non-aura cases which > > > > require different startup logic in metro (immersive mode). Since we > > > > don't support the non-Aura logic we can get rid of a lot of code. > > > > > > > > Tbring gab for the installer constant addition. > > > > > > > > R=ananta@chromium.org, scottmg@chromium.org > > > > TBR=gab > > > > BUG=none > > > > > > > > Review URL: https://codereview.chromium.org/142473002 > > > > > > TBR=cpu@chromium.org > > > > > > Review URL: https://codereview.chromium.org/140123006 > > > > TBR=cpu@chromium.org > > > > Review URL: https://codereview.chromium.org/151683004 > > TBR=cpu@chromium.org > > Review URL: https://codereview.chromium.org/152033002 TBR=cpu@chromium.org Review URL: https://codereview.chromium.org/143473007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249248 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 248331 "Revert 247156 "Revert 247151 "Cleanup of windows ..."cpu@chromium.org2014-02-011-9/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Basically reverting 247151 which still breaks the tree. > Revert 247156 "Revert 247151 "Cleanup of windows launch code"" > > This re-enables 247151 because I can't repro it > so it is possible it was a temporary NaCL insanity and definitely > the x64 breakage was a flake as confirmed by try jobs. > > > > Revert 247151 "Cleanup of windows launch code" > > > > > Cleanup of windows launch code > > > > > > The windows startup code was handling aura and non-aura cases which > > > require different startup logic in metro (immersive mode). Since we > > > don't support the non-Aura logic we can get rid of a lot of code. > > > > > > Tbring gab for the installer constant addition. > > > > > > R=ananta@chromium.org, scottmg@chromium.org > > > TBR=gab > > > BUG=none > > > > > > Review URL: https://codereview.chromium.org/142473002 > > > > TBR=cpu@chromium.org > > > > Review URL: https://codereview.chromium.org/140123006 > > TBR=cpu@chromium.org > > Review URL: https://codereview.chromium.org/151683004 TBR=cpu@chromium.org Review URL: https://codereview.chromium.org/152033002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248332 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 247156 "Revert 247151 "Cleanup of windows launch code""cpu@chromium.org2014-02-011-12/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This re-enables 247151 because I can't repro it so it is possible it was a temporary NaCL insanity and definitely the x64 breakage was a flake as confirmed by try jobs. > Revert 247151 "Cleanup of windows launch code" > > > Cleanup of windows launch code > > > > The windows startup code was handling aura and non-aura cases which > > require different startup logic in metro (immersive mode). Since we > > don't support the non-Aura logic we can get rid of a lot of code. > > > > Tbring gab for the installer constant addition. > > > > R=ananta@chromium.org, scottmg@chromium.org > > TBR=gab > > BUG=none > > > > Review URL: https://codereview.chromium.org/142473002 > > TBR=cpu@chromium.org > > Review URL: https://codereview.chromium.org/140123006 TBR=cpu@chromium.org Review URL: https://codereview.chromium.org/151683004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248331 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 247151 "Cleanup of windows launch code"cpu@chromium.org2014-01-251-9/+12
| | | | | | | | | | | | | | | | | | | | | | > Cleanup of windows launch code > > The windows startup code was handling aura and non-aura cases which > require different startup logic in metro (immersive mode). Since we > don't support the non-Aura logic we can get rid of a lot of code. > > Tbring gab for the installer constant addition. > > R=ananta@chromium.org, scottmg@chromium.org > TBR=gab > BUG=none > > Review URL: https://codereview.chromium.org/142473002 TBR=cpu@chromium.org Review URL: https://codereview.chromium.org/140123006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247156 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup of windows launch codecpu@chromium.org2014-01-251-12/+9
| | | | | | | | | | | | | | | | The windows startup code was handling aura and non-aura cases which require different startup logic in metro (immersive mode). Since we don't support the non-Aura logic we can get rid of a lot of code. Tbring gab for the installer constant addition. R=ananta@chromium.org, scottmg@chromium.org TBR=gab BUG=none Review URL: https://codereview.chromium.org/142473002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247151 0039d316-1c4b-4281-b951-d872f2087c98
* Add base:: to string16s in chrome/.dbeam@chromium.org2013-12-201-6/+6
| | | | | | | | | TBR=sky@chromium.org BUG=329295 Review URL: https://codereview.chromium.org/94013004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242048 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup chrome.dll loading.grt@chromium.org2013-07-011-3/+4
| | | | | | | | | | | | | | | * Include last error info when logging dll loading failures. * Update MainDllLoader::Load doc comment to match the code. * Replace MainDllLoader::GetVersion() with GetCurrentModuleVersion(), which looks in the resource rather than the registry. * Update MainDllLoader::Load and MetroDriver to use this new function. BUG=136808 R=cpu@chromium.org Review URL: https://chromiumcodereview.appspot.com/18362002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209522 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of strings headers in chrome/app/.avi@chromium.org2013-06-101-1/+1
| | | | | | | | | | BUG=247723 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/16320010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205256 0039d316-1c4b-4281-b951-d872f2087c98
* Cause chrome.exe to introspect to find the version of chrome.dll to load. ↵robertshield@chromium.org2012-08-071-7/+8
| | | | | | | | | | | | | | This should ensure that mismatched exe and dll versions never occur. Also, wstring -> string16. BUG=140779 TEST=Install Chrome, smash Omaha registry keys, Chrome still runs. Review URL: https://chromiumcodereview.appspot.com/10825213 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150282 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the rest of #pragma once in one big CL.ajwong@chromium.org2012-07-111-1/+0
| | | | | | | | | For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
* Two small changes so I can reuse the MainDllLoadercpu@chromium.org2012-04-021-5/+11
| | | | | | | | | | | For loading the metro_driver, now that is going to be in the version directory. BUG=118641 TEST=chrome starts. Review URL: https://chromiumcodereview.appspot.com/9956031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130196 0039d316-1c4b-4281-b951-d872f2087c98
* Write "did run" value to multi-install client state key as well, if it exists.robertshield@chromium.org2011-03-141-2/+6
| | | | | | | | | BUG=61609 TEST=Did run value gets written to the multi-install clientstate key as well as to the product client state key. Review URL: http://codereview.chromium.org/6648008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78057 0039d316-1c4b-4281-b951-d872f2087c98
* Use a struct instead of a union for SandboxInterfaceInfocpu@chromium.org2011-02-101-2/+2
| | | | | | | | | | BUG=72496 TEST=see bug Review URL: http://codereview.chromium.org/6483006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74514 0039d316-1c4b-4281-b951-d872f2087c98
* Add a --chrome-version switch to Chrome that serves a similar purpose to the ↵robertshield@chromium.org2010-11-161-2/+2
| | | | | | | | | | | | | | CHROME_VERSION environment variable since environment variables are unsuitable for Chrome Frame's needs. Also add some validation to the version numbers plucked from both the command line flag and the environment variable to reduce the chances of success of bogus-version number skulduggery. BUG=61609 TEST=Run Chrome with --chrome-version=a.b.c.d, observe that that version of chrome.dll is loaded. Review URL: http://codereview.chromium.org/4664004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66268 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-261-0/+1
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* r46025 reverted r46023 which caused a build break on chromeos.prasadt@chromium.org2010-04-301-0/+4
| | | | | | | | | | | | | | | This change reverts r46025 and fixes the build break which is just a one line change in chrome/browser/first_run_gtk.cc to move the definition of Upgrade::new_command_line_ to be inside a #if. Details on the change and code review feedback for the original CL can be found at http://codereview.chromium.org/1633021. BUG=40975 TEST=none Review URL: http://codereview.chromium.org/1691022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46103 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r46023: "Detect new instance of the browser when running in the ↵willchan@chromium.org2010-04-301-4/+0
| | | | | | | | | | background in persistent" Broke the build. Review URL: http://codereview.chromium.org/1718024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46025 0039d316-1c4b-4281-b951-d872f2087c98
* Detect new instance of the browser when running in the background in persistentprasadt@chromium.org2010-04-301-0/+4
| | | | | | | | | | | | | | | | | | mode, shutdown and restart the new instance. This is already done for Windows, this CL enables the functionality for Linux. We don't yet have a unit test for this. Local testing is done by: 1) Reducing the timer to 30 seconds. 2) Changing BrowserList::IsInPersistentMode to return true. 3) Setting BrowserProcessImpl::autoupdate_timer_ to 30 seconds interval. 4) Running "touch" command on chrome exe to pretend there is an update. BUG=40975 TEST=none Review URL: http://codereview.chromium.org/1633021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46023 0039d316-1c4b-4281-b951-d872f2087c98
* Reset the dr key if the toast experiment is cancelled.cpu@chromium.org2009-12-191-1/+5
| | | | | | | | | | | | | | TEST= run the toast experiment and cancel it. Then look at the dr key on HKEY_CURRENT_USER\Software\Google\Update\ClientState\{8A69D345-D564-463C-AFF1-A69D9E530F96} should be "0" BUG=30799 Review URL: http://codereview.chromium.org/502077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35028 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite of chrome.exe startup codecpu@chromium.org2009-11-041-30/+38
| | | | | | | | | | | | | | | | | | | | | | | A lot of cruft and repeated code has deposited over the years on chrome's initialization code. This CL makes it all much more clear and straightforward. There is no fundamental change of behavior except the order of certain things is different but it should not alter the observed operation. - chrome's and chromium load is fundamentally the same but most of the code was repeated - chrome's way to load the dll was incorrect: using a relative path with LOAD_WITH_ALTERED_SEARCH_PATH - Use of SearchPath() was dangerous and not needed - removed google_update_client.cc and .h - removed bunch of #ifdefs TEST=all convered by UI tests already except [1] BUG=none [1] The only thing I don't see convered by test is the restart dialog ('woa! chrome crashed'). Review URL: http://codereview.chromium.org/345036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30934 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Convert dll_path_ to a std::wstring. This avoids having dll_path_ ↵jhawkins@chromium.org2009-10-211-3/+3
| | | | | | | | | | | uninitialized after the object is constructed. CID=1632 BUG=none TEST=none Review URL: http://codereview.chromium.org/306037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29730 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Pass strings by reference.jhawkins@chromium.org2009-10-211-2/+2
| | | | | | | | | CID=2635 BUG=none TEST=none Review URL: http://codereview.chromium.org/293058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29716 0039d316-1c4b-4281-b951-d872f2087c98
* NO CODE CHANGEdeanm@chromium.org2009-03-101-1/+0
| | | | | | | | | Normalize end of file newlines in chrome/. All files end in a single newline. Review URL: http://codereview.chromium.org/42015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11331 0039d316-1c4b-4281-b951-d872f2087c98
* Re-do the way browser windows are shown:ben@chromium.org2008-11-141-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | - Remove the path from WinMain to the Browser object passing the show_command. For the Browser object, this is a problem since this value isn't portable. For the code in general it involves a lot of ugly wiring. It's completely unnecessary since the value is obtainable via GetStartupInfo. - Remove show_command plumbing from all over the place (session restore, web app launcher, etc) Change the way browser windows are constructed: - The browser constructor now takes just a type and a profile, and simply initializes the object. - Some configuration that used to be part of the constructor that was only used in one or two use cases (initial bounds, maximized state, web app name) are split into separate setters. - Window creation is split out into a separate step to be called post configuration. - Assorted static helper functions added to Browser to make construction of common types easy. - Remove Browser::Show in favor of BrowserWindow::Show - Adjust all callers to use the new helpers. Change the way ChromeViews restores window placement: - Split restored size determination from restored maximized determination. They are needed by the code at different times. Size restoration happens when the window is constructed and Window::SetInitialBounds is called. Maximized state restoration happens when the window is shown for the first time and SW_SHOWMAXIMIZED or SW_SHOWNORMAL is needed. Thus, replace WindowDelegate::RestoreWindowPosition with WindowDelegate::RestoreWindowBounds and WindowDelegate::RestoreMaximizedState. - Window::SetInitialBounds calls WindowDelegate::RestoreWindowBounds - Window::Show calls WindowDelegate::RestoreMaximizedState - Adjusts all WindowDelegate implementations that override RestoreWindowPosition to implement these new methods instead. - Move "playback/record" mode window size setting from browser_init to Browser::RestoreWindowBounds. - Provide a virtual function on Window called GetShowState that determines the default show state to be used when Window::Show is called. For most windows and dialogs this is SW_SHOWNORMAL. AeroGlassFrame/OpaqueFrame (the browser window frames) override this since they're the app's main windows to return the value provided by GetStartupInfo which gives the value from the app shortcut. http://crbug.com/3557 Review URL: http://codereview.chromium.org/10896 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5417 0039d316-1c4b-4281-b951-d872f2087c98
* This fixes the following bugs1. http://b/issue?id=1447957 For machine ↵ananta@chromium.org2008-11-041-3/+0
| | | | | | | | installs we need to use a different version of the Omaha updater.2. http://b/issue?id=1447951 For Vista we need to elevate while performing the update operation. This only applies to machine installs. Update checks also instantiate the same COM object. However it does not need elevation.Bug=1447957, 1447951R=finnur, kuchhal Review URL: http://codereview.chromium.org/8221 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4705 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize Breakpad for Chromium as well.rahulk@google.com2008-08-291-0/+8
| | | | | | | BU=1296800 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1572 0039d316-1c4b-4281-b951-d872f2087c98
* Use a more compact license header in source files.license.bot2008-08-241-28/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1287 0039d316-1c4b-4281-b951-d872f2087c98
* Make chrome.exe read version from Software\Chromium instead of Google Update ↵rahulk@google.com2008-08-221-0/+65
keys when running Chromium. With this change now we can build a Chromium release that gets installed under Application Data\Chromium and actually runs. - Added a new file that has common functions used by google update client and chromium - Did some minor cleanup based on readability guidelines (alphabatical order etc). - We seem to be trying to avoid std::wstring at some places but are using it at other places. In future we should be just able to use std::wstring and get rid of StringCchDup. BUG=1296800 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1243 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-30 18:53:27 +0000