| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
New mocks are attached to bug 44622. These changes replace the in-place editing of address and credit card records with a table of records and separate sheets for manipulating the record data. Changes to the layout of fields on the sheets has been done also.
AutoFillDialog.xib changes: Replaced disclosure based list of address and credit cards with an NSTableView of the same data. Added buttons for "Add", "Edit", and "Remove".
Replaced AutoFillAddressViewController.xib with sheet-based AutoFillAddressSheetController.xib.
Replaced AutoFillCreditCardViewController.xib with sheet-based AutoFillCreditCardSheetController.xib.
BUG=44621
TEST=AutoFillAddressModelTest,AutoFillAddressSheetControllerTest,AutoFillCreditCardModelTest,AutoFillCreditCardSheetControllerTest,AutoFillDialogControllerTest
Review URL: http://codereview.chromium.org/2673006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The new AutoFill dialog mocks eliminate the need for a "default" address and credit card. Removing code related to UI for these defaults. Nib changes: Removed the "Default" radio button from each of the Nibs.
BUG=44621
TEST=AutoFillDialogControllerTest.*:-AutoFillDialogControllerTest.DefaultsChangingLogic
Review URL: http://codereview.chromium.org/2466002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and to match Windows.
xib change: switch the default buttons to be radio buttons.
BUG=none
TEST=in autofill prefs, the "make this default" buttons should be radio buttons
Review URL: http://codereview.chromium.org/1528033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Nib change: in each nib, added a checkbox with the correct title and bindings to the file owner of enabled<=>canAlterDefault and value<=>isDefault
BUG=http://crbug.com/38263
TEST=as in bug
Review URL: http://codereview.chromium.org/1527022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
xib change: added tag to fields that are used for credit card numbers.
BUG=http://crbug.com/38259
TEST=as in bug
Review URL: http://codereview.chromium.org/1219009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
store. Changes to a user's address and credit card information are now persisted. Other changes are:
- Selectively disables the preferences "Setup autofill..." button when the PersonalDataManager is not available.
- Allows the user to add or remove address or credit card entries in the AutoFill dialog.
- The billing and shipping popup menus in the credit card entries now properly reflect the list of addresses.
Notes on nib changes:
- AutoFillAddressFormView.xib : added Delete button, wired to trigger |deleteAddress:| action.
- AutoFillDialog.xib changed window size to encompass new controls. Added "Add Address" and "Add Credit Card" buttons. Wired them up to |addNewAddress:| and |addNewCreditCard:| actions, respectively.
- Preferences.xib : |autoFillSettingsButton_| outlet wired up to facilitate disabling when no |PersonalDataManager| is available.
- AutoFillCreditCardFormView.xib : added "Delete" button and wired up to |deleteCreditCard:| action. Removed outlets to menus that were only there for temporary disablement reasons. Set up bindings for billing and shipping address menu items and for their selected item.
BUG=33029
TEST=unit_tests --gtest_filter=AutoFillDialogControllerTest.*
Note new: Google Test filter = AutoFillDialogControllerTest.*:AutoFillAddressModelTest.*:AutoFillAddressViewControllerTest.*:AutoFillCreditCardModelTest.*:AutoFillCreditCardViewControllerTest.*:DisclosureViewControllerTest.*:SectionSeparatorViewTest.*:VerticalLayoutViewTest.*
Review URL: http://codereview.chromium.org/650163
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
where the form is embedded within an NSScrollView. Also, when a disclosure view closes, its "content" should be disabled from the point-of-view of receiving tabbing focus.
Nib file changes add the new |detailsView_| outlet to disclosure views. Also changed text fields to AutoFillTextFields to pick up auto-scrolling behavior.
BUG=33029
TEST=unit_tests --gtest_filter=AutoFillDialogControllerTest.*
Review URL: http://codereview.chromium.org/606067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
hooked up to the back end yet. The UI demonstrates manipulation of one address and one credit card record. Eventually buttons will be added to add and remove additional records. The additions in this CL are:
- Preferences dialog has a new "Change autofill settings" button that triggers an autofill settings dialog.
- The autofill settings dialog now exists and allows the user to manipulate form autofill data. Specifically address information and credit card information.
- Each address or credit card record is presented in a disclosure view to allow for summary or detailed views of each record.
- The autofill dialog is layed out dynamically in a vertical list (ordered by y) using the VerticalLayoutView.
- Sections are delimited visually with the SectionSeparatorView. There are currently two sections, one for addresses and one for credit cards.
- Unit tests are present that exercise the invocation of the dialog and check basic functionality. Checks are performed to see that data is flowing from core profile and credit card data structures into Cocoa model data structures used for bindings internally by the UI.
- There are three .xib files (AutoFillDialog.xib, AutoFillAddressFormView.xib, and AutoFillCreditCardFormView.xib) that partition the dialog UI into distinct views, controllers, and model objects.
- Cocoa databinding is utilized to syncronize dependent parts of the UI.
- All strings are stored in internationalized form in .grd files and .xib files (with one small TODO execption, see below).
The things remaining to do are:
- Hook the UI up to the backend model, specifically the PersonalDataManager data.
- Add support for arbitrary number of address and credit card records. I.e. Add and Delete buttons.
- Scroll-to-Point support for autoscrolling when tabbing between fields.
- Billing and shipping address popups in the credit card section.
- Any validation of input (need to circle back with UI folks on this).
- Input validation unit tests.
- String concatenation of the summary label needs to be internationalized.
BUG=33029
TEST=none
Review URL: http://codereview.chromium.org/558066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38873 0039d316-1c4b-4281-b951-d872f2087c98
|