| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes the labels data entry fields on the AutoFill preferences dialog on Mac. Labels
are now derived fields so user input is not needed.
Nib changes made are AutoFillAddressSheet.xib: removed "Label" entry and status indicator, adjusted
layout to account for new space. AutoFillCreditCardSheet.xib: removed "Label" entry and status
indicator, adjusted layout to account for new space. AutoFillDialog.xib: removed the table header,
removed the "Label" column, adjusted sizing of remaining "Summary" column to account for new space,
move the buttons lower to top-align with table.
BUG=47430
TEST=AutoFillAddressModelTest.*, AutoFillCreditCardModelTest.*, AutoFillDialogText.*
Review URL: http://codereview.chromium.org/2813052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52707 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Implements changes based on review feedback with Jeff. Validation icons should not appear in phone and fax input fields until text is input. Credit card expiration date year dropdown should list 10 years at most. CVC input fields are removed.
Nib changes to AutoFillCreditCardSheet.xib removes the CVC entry, associated label, and resize / relayout dialog to account for removal.
BUG=46681, 46635, 46634
TEST=Manual testing, AutoFillDialogControllerTest.*, AutoFillAddressViewControllerTest.*, AutoFillCreditCardViewControllerTest.*
Review URL: http://codereview.chromium.org/2873002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50008 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
| |
Modifies entry labels with trailing colon for Mac UI. Using correct validation icons now. Nib changes for AutoFillAddressSheet.xib and AutoFillCreditCardSheet.xib: rearranges labels and entry fields to right align on label colons. Changes label font to be regular size and regular weight.
BUG=46504
TEST=manual inspection of AutoFill UI.
Review URL: http://codereview.chromium.org/2842002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
New mocks are attached to bug 44622. These changes replace the in-place editing of address and credit card records with a table of records and separate sheets for manipulating the record data. Changes to the layout of fields on the sheets has been done also.
AutoFillDialog.xib changes: Replaced disclosure based list of address and credit cards with an NSTableView of the same data. Added buttons for "Add", "Edit", and "Remove".
Replaced AutoFillAddressViewController.xib with sheet-based AutoFillAddressSheetController.xib.
Replaced AutoFillCreditCardViewController.xib with sheet-based AutoFillCreditCardSheetController.xib.
BUG=44621
TEST=AutoFillAddressModelTest,AutoFillAddressSheetControllerTest,AutoFillCreditCardModelTest,AutoFillCreditCardSheetControllerTest,AutoFillDialogControllerTest
Review URL: http://codereview.chromium.org/2673006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49274 0039d316-1c4b-4281-b951-d872f2087c98
|
