summaryrefslogtreecommitdiffstats
path: root/chrome/app/nibs/BookmarkBar.xib
Commit message (Collapse)AuthorAgeFilesLines
* Mac: Theme the bookmark bar on the new tab page.erg@chromium.org2009-10-091-7/+24
| | | | | | | | | | | | | | | | | - XIB change: The controller has a connection to buttonView_. - BrowserThemeProviderMac: Fix a bug where we weren't returning default colors; we returned nil instead. - The majority of the implementation is actually the cross platform NtpBackgroundUtil::PaintBackgroundDetachedMode. We do platform specific drawing on top of the background, though. TEST=BookmarkBarToolbarViewTest.DisplayAsFloatingBarWithNoImage TEST=BookmarkBarToolbarViewTest.DisplayAsFloatingBarWithBgImage BUG=http://crbug.com/17625 Review URL: http://codereview.chromium.org/266027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28560 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Fix bookmark bar resize issues.erg@chromium.org2009-10-061-4/+4
| | | | | | | | | | | | | Nib file changes: - Changed resize flags to pin the bookmark bar a fixed distance from the top of the window, not the bottom. BUG=23949 TEST=Resize the window, make sure the bookmark bar resizes correctly. Review URL: http://codereview.chromium.org/256078 Patch from rohitaro@chromium.org. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28121 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Implements the special bookmark bar on NTP.erg@chromium.org2009-10-061-32/+61
| | | | | | | | | | | | | Based mostly on Ben's patch, but made it compile, work, and descoped moving the bookmark bar around the view heiarchy. XIB modification: The root view is now a BookmarkBarToolbarView instead of an NSView and is [BookmarkBarController view]. BUG=17625 Review URL: http://codereview.chromium.org/246034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28074 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Eliminate unintended "menu" method overrides.viettrungluu@chromium.org2009-10-051-521/+48
| | | | | | | | | | | This had the bad effect of showing bad/strange menus upon right-click on various buttons or, worse, crashing. BUG=22148,23606 TEST=Right click on back/forwards buttons (after some navigation so that they're active), page/wrench buttons, and bookmark bar off-the-side button and make sure no menu is shown (and it that it doesn't crash). Also do so when the menu is active/highlighted with menu already showing. Review URL: http://codereview.chromium.org/251091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28064 0039d316-1c4b-4281-b951-d872f2087c98
* Make the no bookmarks text a small control so it doesn't stick out, this ↵thomasvl@chromium.org2009-10-011-8/+8
| | | | | | | | | | makes it more inline with windows and with the buttons when they do have bookmarks. TEST=Show bookmark bar with no bookmarks, font should be closer to the font bookmark buttons use. BUG=none Review URL: http://codereview.chromium.org/242094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27721 0039d316-1c4b-4281-b951-d872f2087c98
* Add "copy" to context menu on bookmark button.jrg@chromium.org2009-09-301-38/+537
| | | | | | | | | | BUG=http://crbug.com/16941 TEST=Right-click on bookmark button; pick copy. Go to any other app and paste. Make sure you got URL. Review URL: http://codereview.chromium.org/249048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27690 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Empty bookmark bar should show IDS_BOOKMARKS_NO_ITEMS.erg@chromium.org2009-09-221-9/+96
| | | | | | | | | | TEST=BookmarkBarControllerTest.DisplaysHelpMessageOnEmpty TEST=BookmarkBarControllerTest.HidesHelpMessageWithBookmark BUG=17360 Review URL: http://codereview.chromium.org/216052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26853 0039d316-1c4b-4281-b951-d872f2087c98
* (Mac) Display the bookmark bar off-the-side menu on mouse down. Also align ↵viettrungluu@chromium.org2009-09-041-72/+152
| | | | | | | | | | | | | | | | | | | the menu. (Basically, make it like Safari's button.) We make the button into a |MenuButton|, attach a fixed menu to it in the nib, and make the |BookmarkBarController| the delegate for this menu so that we can update the menu just before it's displayed. As a side effect, also fixes bug 20813. BUG=21093,20813 TEST=Make sure the bookmark bar off-the-side button works properly under a variety of circumstances, making sure the menu is properly aligned, etc. Review URL: http://codereview.chromium.org/199024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25507 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent mouse down events in the bookmark bar and download shelf from movingpaul@chromium.org2009-08-141-6/+14
| | | | | | | | | | | | the parent window around. BUG=19305 (http://crbug.com/19305) TEST=Make the download shelf and/or bookmark bar visible. Clicking and dragging on either one should not move the window around. Review URL: http://codereview.chromium.org/165500 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23409 0039d316-1c4b-4281-b951-d872f2087c98
* ObjC classes generated by the build and used in Xib files is already getting ↵thomasvl@chromium.org2009-08-111-12/+6
| | | | | | | | | | | | | | | | ugly, if they aren't built at build start, IB sometimes throws warnings about unknown things, so... - Use one class for the localizer and generate the table that drives it. - Update the generator script to process a list of xib files and generate one header. - Update the data within the GYP file to do this. - This might actually help overall size since it helps force one set of strings for each different window. - Switch to bsearch for table lookup since we have one, larger table now. TEST=none BUG=none Review URL: http://codereview.chromium.org/164260 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23017 0039d316-1c4b-4281-b951-d872f2087c98
* Deps roll to pull in new GTM.thomasvl@chromium.org2009-08-071-21/+88
| | | | | | | | | | | | | | | | | Bookmark localization (BookmarkBar, BookmarkEditor, and BookmarkNameFolder). Toolbar localization. TabView localization (the tab itself). Bookmark Editor window fixup: Align the labels to the front of the edit fields (ui guidelines). Make the labels auto size to their text and resize the window as needed. Make the buttons auto size to their strings and adjust to stay right pinned. Make the window resize in general correctly. BUG=16764 TEST=Try the Danish local, a bunch of this UI should localized, and the bookmark editor shouldn't truncate the labels or buttons. Review URL: http://codereview.chromium.org/160328 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22730 0039d316-1c4b-4281-b951-d872f2087c98
* Added menus for bookmark bar folders. This is NOT based on the Colejrg@chromium.org2009-07-231-32/+115
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | prototype; it is an attempt to get something functional in the short term, and have a visual baseline before doing something new. Added folder icons for bookmark bar folder buttons. Added an "off the side" button/menu for bookmark buttons which don't fit on the bar. Updated "Add page..." item to allow creating bookmarks in the folders (if selected over a folder button). BUG=http://crbug.com/8381 TEST=Here we go: 1) Make sure bookmark bar folders have the "folder" icon. 2) Right click on a folder --> Add Page, and add a bookmark. Make sure bookmark is now in the folder, not at the top level. 3) (Oh, you just implicitly verified you can open bookmark folders!) 4) Add 5 bookmarks then shrink the window thinner so all bookmark buttons don't fit. Make sure "off the right" button gets enabled (on right side of bar) and shows bookmarks in a pop-up menu (when clicked) that don't completely fit on the bar. 5) Make it super-wide so the all fit and make sure "off the right" button is disabled. 6) Add a bunch of bookmarks to a folder; make sure they all work. 7) Add nested folders (by editing the bookmark pref file and restarting Chrome) and make sure bookmark folder buttons have nested/cascading menus. Review URL: http://codereview.chromium.org/159286 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21479 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmark Bar Add Folder / Rename Folder dialog and controller.jrg@chromium.org2009-07-221-17/+26
| | | | | | | | | | | | TEST=Right click on bar --> Add Folder... Type a name and it shows up as a folder in the bookmark bar. (You can't do anything with it yet; sorry). Right click on folder name --> Edit... Make sure you can rename the folder. Review URL: http://codereview.chromium.org/159183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21293 0039d316-1c4b-4281-b951-d872f2087c98
* Implement bookmark editor. No tree display or hierarchy movement, butjrg@chromium.org2009-07-211-36/+42
| | | | | | | | | | | | | | | | | | name/url editing works. Get to the edotir from a context menu (Edit, Add Page). Also Implement Open All Bookmarks menu item. BUG=http://crbug.com/8381, http://crbug.com/17006 TEST=Add some bookmarks. Right-click on a bookmark and pick Edit. Test editing the name and URL. Make sure you can't add a bogus URL. Right-click on a bookmark or the bar and Add Page. Fill in name and URL fields to add a new bookmark. Right-click Open All Bookmarks and make sure it hoses your machine. Review URL: http://codereview.chromium.org/155874 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21241 0039d316-1c4b-4281-b951-d872f2087c98
* Move all the xib files out of the en.lproj in prep for starting to land real ↵thomasvl@chromium.org2009-07-201-0/+854
l10n support. Cleanup some tabs/indents in chrome.gyp BUG=16764 TEST=All UI still works Review URL: http://codereview.chromium.org/155800 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21109 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-04 01:18:20 +0000