| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
BUG=44773
TEST=none
Review URL: http://codereview.chromium.org/8143023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=88056
TEST=--multi-profiles while signed into sync and you don't get a strange UI.
Review URL: http://codereview.chromium.org/7313007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
xib changes: Removed browser window minSize and minContentSize from xib file. Instead, set the min size programmatically in BrowserWindowController::awakeFromNib in order to customize the min size depending on the browser type.
BUG=83985
TEST=BrowserWindowControllerTest.TestSetBounds and TestSetBoundsPopup
Review URL: http://codereview.chromium.org/7003063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Increases code reuse a bit. To make this work, give MenuButton a
-menuRect function, since ProfileMenuButton is larger than the
area it draws in.
Also potentially addresses the problem described inhttp://waffle.wootest.net/2007/08/07/popping-up-a-menu-in-cocoa/
which might be 10.5-only.
xib changes: Remove the old popup button-based PopupMenuButton, re-add
it by duplicating the new tab button, changing the resize anchor to the
upper-right corner, and changing the cell to ClickHoldButtonCell.
BUG=83169
TEST=none
Review URL: http://codereview.chromium.org/7061001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change switches to using the new high res icons instead of custom drawn buttons.
Changed buttons in BrowserWindow.xib and Toolbar.xib to use ImageButtonCell instead of GradientButtonCell.
Screenshot:
http://www.dropmocks.com/mUDXS
BUG=75812
TEST=Ran and verified that things looked ok. Made sure unit tests passed.
Review URL: http://codereview.chromium.org/6878023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new high res icon change may have caused a perf regression. To verify I'm reverting the following chnages:
commit 3a360c6b3d2fc174cb7597d6365cfc5418d1442b
r82326 Disable loading high res icons on Mac
commit 3c39226937a39d0042b8a794f13505c7a25ca58b
r82247 Fix reload button unit test
commit f87ab117fc159566868e71e4df5672852bebd718
r82245 Unregister toolbar view from window notifications
commit 0b287ba4a4ad5c19d901f973eb9af594dcf3dba1
r82239 Fix failing Mac unit tests
commit 8b681c46a139d12151323952c58122f6805d7597
r82236 Mac: Remove custom drawn buttons
commit 6ae8a2fe40485731b86267e362936db16b4c0706
r82209 Fix clang build break
commit e8a19d1e0c76f204c834318566e4206320583449
r82185 Add support for multi resolution icons
BUG=None
TEST=Compling
Review URL: http://codereview.chromium.org/6878077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change switches to using the new high res icons instead of custom drawn buttons.
Changed buttons in BrowserWindow.xib and Toolbar.xib to use ImageButtonCell instead of GradientButtonCell.
Screenshot:
http://www.dropmocks.com/mUDXS
BUG=75812
TEST=Ran and verified that things looked ok. Made sure unit tests passed.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is bascially a port of mirandac's multi-profile UI change from Windows to the Mac.
This change just adds the UI bits. It's not hooked up to the backend yet.
XIB Changes:
- Added a popup button the TabBar.
Screenshots:
https://docs.google.com/leaf?id=0B0Odde3V7EhWYTkxZGFmNzgtMTI5OC00MDRkLTkzZjAtYWM1NmRiNTM5ZWQz&hl=en
https://docs.google.com/leaf?id=0B0Odde3V7EhWMGM2ZjZkMTEtYjUzMC00YmQ2LThlZjktYzY1NGFhYzRmMjJi&hl=en
BUG=None
TEST=Ran. Verified that the button was positioned correctly. Verified that changing the current profile changed the name on the profile button.
Review URL: http://codereview.chromium.org/6696096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With all this file moving, many nib files had outdated paths in them.
I did:
1. A build of the "chrome" target
2. |open chrome/app/nibs/*.xib|
3. Wait for the communication between XCode and IB to cease
4. Hit Cmd-S Cmd-W for every nib window
This was with xcode 3.2.5 on OS X 10.6
57 files changed, 21802 insertions(+), 1258 deletions(-)
No intended behavior change.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6476021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
right/left of window widgets.
xib change: tab strip one pixel taller
BUG=70597
TEST=none
Review URL: http://codereview.chromium.org/6280017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=brettw
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
views directly. Remove references to the devtools and sidebar NSSplitViews from TabWindowController.
This also fixes the issue where the findbar and resize widget would disappear. For some reason, the NSSplitViews were indicating that they were opaque when instantiated in the xib files, but this does not happen when they are created programmatically.
Xib changes:
- BrowserWindow.xib no longer contains the two NSSplitViews.
BUG=55228,55441
TEST=All unittest should pass.
TEST=Findbar and resize widget should not disappear when scrolling.
Review URL: http://codereview.chromium.org/3436009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
adjustments
during tab change updates to eliminate UI flickering.
TabContents.xib changes: devtools and sidebar NSSplitViews removed (moved to BrowserWindow.xib),
contentsContainer_ view removed (now it's inserted at runtime).
BrowserWindow.xib chnages: devtools and sidebar NSSplitViews added into FastResizeView.
BUG=22717, 31633
TEST=Run unit_tests, browser_tests and interactive_ui_tests.
Open google.com in one tab (it's easy to spot content relayout on google.com), trigger an infobar
and content scroll bar on another tab (ru.wikipedia.org with translation infobar will do), switch
tabs back and forth. Content should not relayout, scroll bar should not "jump".
Open new tab and make sure bookmark bar is not always visible, open any site which triggers infobar
and big enough to show content scroll bar on another tab, switch tabs back and forth. Content should
not relayout, scroolbar should not "jump".
Repeat the tests above with sidebar opened on any of these tabs, page and sidebar content should not
relayout, sidebar should stay the same width, scrollbar should not "jump".
Repeat the tests above with devtools docked.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=53449
TEST=No visible impact. Everything should still work.
Review URL: http://codereview.chromium.org/3189026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57542 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the bounds of the button in the nib.
Nib change: Make the new tab button a subclass of NewTabButton instead of NSButton
BUG=45738
TEST=clicking new tab button still works as expected.
Review URL: http://codereview.chromium.org/3046016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Parameterize tab strip layout so it can be vertical in addition to horizontal without breaking up the code too much. Abstracted some of the side tab knowledge into TabWindowController with overrides in BrowserWindowController.
Nib change: added a SideTabStripView custom view to BrowserWindow and hooked it to an outlet. Renamed the outlets to better reflect both views.
BUG=44773
TEST=Tab layout, full screen, dragging tabs within and to other windows to make sure they reflow and draw correctly. Side tabs themselves are still behind a flag, but this cl touches many normal codepaths.
Review URL: http://codereview.chromium.org/2846028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50606 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Don't set the images in the xib since cocoa can't find them in the other bundle during tests (and maybe not during normal app runtime)
- Make sure the images are setup during view start.
- Create constants for the image names since some are used in more then one place.
BUG=30342
TEST=no longer get the error messages on test runs
Review URL: http://codereview.chromium.org/515061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I added a member variable and an accessor/mutator ... and hooked up that up in
the nib. Changes to BrowserWindow.xib: hook up the New Tab button to
|newTabButton| in TabBar.
Unit test fixed. Previously committed at r33758, reverted at r33761.
BUG=none
TEST=Make sure it builds, runs, and that the New Tab button still works.
Review URL: http://codereview.chromium.org/460058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33771 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
nib.
I added a member variable and an accessor/mutator ... and hooked up that up in
the nib. Changes to BrowserWindow.xib: hook up the New Tab button to
|newTabButton| in TabBar.
BUG=none
TEST=Make sure it builds, runs, and that the New Tab button still works.
Review URL: http://codereview.chromium.org/465042
TBR=viettrungluu@chromium.org
Review URL: http://codereview.chromium.org/465045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I added a member variable and an accessor/mutator ... and hooked up that up in
the nib. Changes to BrowserWindow.xib: hook up the New Tab button to
|newTabButton| in TabBar.
BUG=none
TEST=Make sure it builds, runs, and that the New Tab button still works.
Review URL: http://codereview.chromium.org/465042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/378035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
clipped rather than resized. Useful for when animations are running.
BUG=http://crbug.com/26857
TEST=Animations should still work. Infobar animations should be smoother. The web contents will clip or fill with white at the bottom while the animation is running, but should resize and draw correctly when the animation finishes.
Review URL: http://codereview.chromium.org/372056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BrowserWindow.xib change was to add newtab_p as the image for the alternate
state for the new tab button.
BUG=26205
TEST=1) mouse over the new tab button and it should highlight.
2) Click and hold on the new tab button and its state should change
3) Release, and watch new tab get created. Verify that new button state
changes appropriately
4) Create a full tab strip of tabs. Verify that button state stays
correct as you click on the new tab button and new tabs are created but
the button doesn't move.
5) Create 2 tabs, and move the mouse button into the newtab button.
See that it highlights. hit cmd-w to close a tab. As the newtab button
moves away from under the cursor make sure it loses its highlight.
Review URL: http://codereview.chromium.org/372009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
l10n support.
Cleanup some tabs/indents in chrome.gyp
BUG=16764
TEST=All UI still works
Review URL: http://codereview.chromium.org/155800
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21109 0039d316-1c4b-4281-b951-d872f2087c98
|