| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
warnings from the 10.6 toolchain.
BUG=none
TEST=less warnings on 10.6 builds, everything still works
Review URL: http://codereview.chromium.org/838005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=In English the autofill prefs don't word wrap.
Review URL: http://codereview.chromium.org/806002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
all the other checkboxes in under the hood.
BUG=37527
TEST=any translations with a really long button title should be more likely to have the similar right edge as the other checkboxes.
Review URL: http://codereview.chromium.org/700002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
NIB change: Added checkbox for pref into web content section of "Under the Hood" and moved other controls down to match.
BUG=37527
TEST=navigate to www.google.co.il using a branded build translate infobar should appear/not appear based on pref.
Review URL: http://codereview.chromium.org/722004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
store. Changes to a user's address and credit card information are now persisted. Other changes are:
- Selectively disables the preferences "Setup autofill..." button when the PersonalDataManager is not available.
- Allows the user to add or remove address or credit card entries in the AutoFill dialog.
- The billing and shipping popup menus in the credit card entries now properly reflect the list of addresses.
Notes on nib changes:
- AutoFillAddressFormView.xib : added Delete button, wired to trigger |deleteAddress:| action.
- AutoFillDialog.xib changed window size to encompass new controls. Added "Add Address" and "Add Credit Card" buttons. Wired them up to |addNewAddress:| and |addNewCreditCard:| actions, respectively.
- Preferences.xib : |autoFillSettingsButton_| outlet wired up to facilitate disabling when no |PersonalDataManager| is available.
- AutoFillCreditCardFormView.xib : added "Delete" button and wired up to |deleteCreditCard:| action. Removed outlets to menus that were only there for temporary disablement reasons. Set up bindings for billing and shipping address menu items and for their selected item.
BUG=33029
TEST=unit_tests --gtest_filter=AutoFillDialogControllerTest.*
Note new: Google Test filter = AutoFillDialogControllerTest.*:AutoFillAddressModelTest.*:AutoFillAddressViewControllerTest.*:AutoFillCreditCardModelTest.*:AutoFillCreditCardViewControllerTest.*:DisclosureViewControllerTest.*:SectionSeparatorViewTest.*:VerticalLayoutViewTest.*
Review URL: http://codereview.chromium.org/650163
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also introduce scaffolding for the actual content settings dialog.
xib changes:
+ Personal stuff
* Move "Clear browsing data" button to under the hood tab
* Move themes stuff up a bit to cover hole left by missing button
+ under the hood:
* Created "Content Settings..." button
* Got rid of cookie settings
* Moved stuff around
+ clear data:
* Added horizontal rule and flash player settings link, linked its action to
new method.
+ content settings:
* Added mostly empty window that contains "This is not implemented yet" label and a button that shows cookies (since I removed that from the prefs, so that it's still available). This window will be fleshed out very soon (in my next CL).
* The window _is_ set up for l10n
+ bubble xibs:
* Enable "Manage" links now that they open a window
Four screenshots at http://imgur.com/axGiR&78O8g&wgk3p&6oOHj
BUG=34656,34894
TEST="Clear data" button has moved from "Personal Stuff" to "Under the hood" in prefs. There's a "Content Settings" button next to it that opens a mostly empty window. The "Clear data" dialog now has a link to flash's privacy settings (which hang if one has the AdThwart extension installed, heh).
Review URL: http://codereview.chromium.org/650124
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Updated the text of the radio buttons.
* Added a button that opens the AutoFill dialog.
BUG=33025
TEST=manually
Patch from Thiago Farina <thiago.farina@gmail.com>
Review URL: http://codereview.chromium.org/579020
Review URL: http://codereview.chromium.org/610003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
hooked up to the back end yet. The UI demonstrates manipulation of one address and one credit card record. Eventually buttons will be added to add and remove additional records. The additions in this CL are:
- Preferences dialog has a new "Change autofill settings" button that triggers an autofill settings dialog.
- The autofill settings dialog now exists and allows the user to manipulate form autofill data. Specifically address information and credit card information.
- Each address or credit card record is presented in a disclosure view to allow for summary or detailed views of each record.
- The autofill dialog is layed out dynamically in a vertical list (ordered by y) using the VerticalLayoutView.
- Sections are delimited visually with the SectionSeparatorView. There are currently two sections, one for addresses and one for credit cards.
- Unit tests are present that exercise the invocation of the dialog and check basic functionality. Checks are performed to see that data is flowing from core profile and credit card data structures into Cocoa model data structures used for bindings internally by the UI.
- There are three .xib files (AutoFillDialog.xib, AutoFillAddressFormView.xib, and AutoFillCreditCardFormView.xib) that partition the dialog UI into distinct views, controllers, and model objects.
- Cocoa databinding is utilized to syncronize dependent parts of the UI.
- All strings are stored in internationalized form in .grd files and .xib files (with one small TODO execption, see below).
The things remaining to do are:
- Hook the UI up to the backend model, specifically the PersonalDataManager data.
- Add support for arbitrary number of address and credit card records. I.e. Add and Delete buttons.
- Scroll-to-Point support for autoscrolling when tabbing between fields.
- Billing and shipping address popups in the credit card section.
- Any validation of input (need to circle back with UI folks on this).
- Input validation unit tests.
- String concatenation of the summary label needs to be internationalized.
BUG=33029
TEST=none
Review URL: http://codereview.chromium.org/558066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the second half of http://codereview.chromium.org/597013.
TBR=pkasting
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/596027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=29819
TEST=Open settings dialog, go to "Personal Stuff" Tab, Import Data... button should function
Review URL: http://codereview.chromium.org/555065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
for the string changes that already landed. more work will be needed to make the window match the new wants, but this gets the tests passing again.
BUG=32719
TEST=unittests green up
Review URL: http://codereview.chromium.org/551103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Aligned left edges of sync status text and the relogin link text.
BUG=30159
TEST=manual testing
Review URL: http://codereview.chromium.org/542025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is a sync authentication error.
Changed sync group's layout behavior to VerticalToFit and added explanatory comment.
BUG=30159
TEST=tested with sync disabled, sync enabled, induced sync error, made sure UI looks right
Review URL: http://codereview.chromium.org/501101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
keychain access app.
Change to the xib is to hook up the button's target/action and enable it.
BUG=none
TEST=click the button, watch the app launch.
Review URL: http://codereview.chromium.org/523104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35795 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
IDS_OPTIONS_COOKIES_SHOWCOOKIES for Mac (evan is doing Linux).
BUG=31680
TEST=button should have correct name in preferences.
Review URL: http://codereview.chromium.org/524048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL creates the basic cookie management interface, allowing users to view
and delete cookies from Chromium. TODO: (1) Add the filtering by domain
capability. (2) Localize the NIB.
BUG=15360
TEST=Chromium-->Preferences-->Under the Hood-->Show Cookies. Also covered by unit tests.
Review URL: http://codereview.chromium.org/523025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Font settings can now be changed for serif, sans serif, and fixed width.
* The default encoding can now be changed via preferences.
* Language settings are not yet implemented. See http://crbug.com/23828
BUG=20845
TEST=Chromium-->Preferences-->Under the Hood-->Change font and language settings
Review URL: http://codereview.chromium.org/461005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removed explicitly set first responder that was causing autocalculate not to work.
Changes to Preferences.xib
Turned on the autorecalculate flag.
BUG=27781
TEST=repro steps in bug
Review URL: http://codereview.chromium.org/402041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These controls are only visible when sync is enabled. This isn't finished,
but it is enough to be usable.
Made RemoveViewFromView() handle top-most views. Also added
RemoveGroupFromView().
BUG=23073
TEST=manual testing, trybots
Review URL: http://codereview.chromium.org/380006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Add TitleCase versions of the menu policy strings (one in the range isn't used, but done to avoid more ifs in the GRD.
TEST=Since they are new strings, other langs will get English until we get them localized, but you can tell by them being in proper Title Case.
BUG=26844
Review URL: http://codereview.chromium.org/377009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Small shuffle to the basics page to make things look a little better
- Support for the three areas that get really wide in the prefs ui forcing the window wider, this will make sure nothing is clipped in any language.
BUG=26586
TEST=try french, german, etc. to make sure no buttons extend off the side of the prefs window.
Review URL: http://codereview.chromium.org/378012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Baselines match between labels and top control for:
- default browser (basics)
- browsing data (personal stuff)
- themes (personal stuff)
- The list for startup urls and the textbox for homepage are both indented to the start of the text on the radio they go with.
- The gap above the list for startup urls and the textbox for homepage and their radio buttons is the same.
BUG=26703
TEST=Baseline match, gap between radio and field/list is the same, field/list are left aligned
Review URL: http://codereview.chromium.org/362011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
prefs in non google chrome builds.
BUG=24425
TEST=Chroimum builds don't have the checkbox, chrome builds do. Chromium builds shouldn't have a gap where it was.
Review URL: http://codereview.chromium.org/363005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Make some vertical spacing in basics more consistent
- Make some vertical spacing in personal stuff more consistent
- Make the views a bit wider to avoid some clipping and wrapping in a few languages.
- A little code cleanup, no longer allow the pref views to be different widths, this resulted in some really odd looks, so we want to mange the layout ourselves up front (things not always being as wide as the window, etc).
TEST=window looks ok (given our strings it won't always look great, but shoot for ok).
BUG=26586
Review URL: http://codereview.chromium.org/351027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
objects so no code is needed.
TEST=the reset to defaults button is the right size in all languages.
BUG=20538
Review URL: http://codereview.chromium.org/345049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=a shade of grey now.
Review URL: http://codereview.chromium.org/348059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Make all the controls/labels wrap to the width they get.
- Make the content vertically shift as it is made to fit its strings.
- Add more spacing for the sections as listed in bugs.
- Consistent indents for the sections/subsections.
- Update the code to use constant naming (was was "under the hood" and some was "advanced" (just so it is clear they are talking about one thing, and not two).
- DEPS roll for GTM to pick up support for NSPathControl.
TEST=Under the hood content should fit in all languages.
BUG=20538
BUG=25595
BUG=25597
Review URL: http://codereview.chromium.org/355011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30825 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
See http://codereview.chromium.org/340045 for the original code.
This includes a newer version of GTM that solves the problem with nib loading on 10.6.
TEST=http://codereview.chromium.org/340045
BUG=none
Review URL: http://codereview.chromium.org/343082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
10.6 loads xibs differently, breaking GTMIBArray
TBR=mark@chromium.org
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- These two pages should now auto size vertically the labels.
- The label should be top aligned with controls in the group when the group is taller.
- The content should be vertically centered when the label is taller.
- All the textfields should always be tall enough to show content.
- Radios/checkbox should word wrap to show all their text.
- The spacing between groups is a little more even
- DEPS roll to pick up newer GTM with GTMIBArray.
- A bunch of changes in the XIB related to evening out spacing, adding the GTMIBArray for referencing stuff, etc.
Note: if a single radio word wraps all radios get space for that many lines, that's just how the OS does it and we aren't trying to change that (at the moment).
Note: some of the horizontal layouts can extend off the side of the window, that will be fixed in a future cl (once under the hood is also cleaned up).
TEST=see cl description for what should be working now.
BUG=20538
Review URL: http://codereview.chromium.org/340045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Preferences-->Under the Hood. Click on downloads path, don't get awkward blue focus ring.
Review URL: http://codereview.chromium.org/330028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=25594
TEST=background is white
Review URL: http://codereview.chromium.org/332011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=can type in the homepage box
BUG=24740
Review URL: http://codereview.chromium.org/289002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29293 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Stuff when the default theme is already set.
This change is for the Mac OS; Windows change in a separate patch.
BUG= http://crbug.com/18585
TEST= Install a default theme, note that button is disabled. Install a non-default theme, note that button is enabled. Rinse, repeat.
Review URL: http://codereview.chromium.org/278004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Make the scroller the width of the window.
- Resize the content so any wrapping text fields have the full width.
- Tweak the scroller so only bot bottom border shows.
BUG=20538
TEST=Under the hood prefs scroller is the width of the window and goes to the bottom of the toolbar.
Review URL: http://codereview.chromium.org/276019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
hood prefs.
BUG=24424
TEST=under the hood has a working learn more button in the privacy section.
Review URL: http://codereview.chromium.org/268028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add some new strings that didn't exit to the grd file needed by Mac prefs.
Update all the strings in the file to use the localizer.
BUG=20538
TEST=Almost all the pref strings should be localized, there area few new ones that won't show up localized until we do a TC run. The controls do *NOT* auto size yet, so there can be clipping/oversized controls.
Review URL: http://codereview.chromium.org/273001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add a toolbar instead of tabs.
- Make the window change size based on the content.
- Center the views to the widest of the subviews.
TEST=prefs window and all of the controls in it work.
BUG=20538
Review URL: http://codereview.chromium.org/242162
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=21414
TEST=Preferences-->Personal Stuff, "Get themes..." is a hyperlink.
Review URL: http://codereview.chromium.org/244047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Fiona Chong.
Review URL: http://codereview.chromium.org/243041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27596 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enable the download location path and the prompt-for-download settings.
BUG=22047
TEST=Preferences --> Under the hood, set download location, downloaded file is in new location.
TEST=Enable prompt for download location, download file, save panel comes up.
Review URL: http://codereview.chromium.org/239008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Creates a HyperlinkButtonCell that can be used in conjuction with a NSButton
to display the control as a hyperlink (blue underliend text), rather than
a normal Cocoa control.
* Switch the "Get themes..." button in Preferences to be one.
BUG=17989,21414
TEST=Preferences-->Personal Stuff, "Get themes..." is a hyperlink.
Review URL: http://codereview.chromium.org/248019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
of the universe used them".
BUG=22353
TEST=None
Review URL: http://codereview.chromium.org/210033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
platforms. This avoids us needed extra localization strings, and we'll look to pick up any new UI when it's done for all platforms.
Remove the autoseparating_menu since it is no longer used.
TEST=Prefs just has a reset button and no theme popup list.
BUG=none
Review URL: http://codereview.chromium.org/214011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Enable the Manage search engines button in Preferences
* New search engines can be added using the "+" button
* Existing search engines can be edited via double-click
* Existing search engines can be removed with the "-" button
* The "Make Default" button has the same behavior as the list box in the Basics
preferences "Default Search"
BUG=16187
TEST=Go to Preferences, click "Manage" next to "Default Search" and add/edit/remove engines.
Review URL: http://codereview.chromium.org/193040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a nib change. All I'm doing is reducing the width of the Under the
Hood contents from 472 to 466. 466 matches the available width of the scroll
view that it gets inserted to.
BUG=19114
TEST=Try to scroll horizontally with a Mighty Mouse ball or trackpad. It
should not be possible.
Review URL: http://codereview.chromium.org/171125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25251 0039d316-1c4b-4281-b951-d872f2087c98
|