| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
with the Sync Setup Wizard).
Added "Customize..." button in Sync group of "Personal Stuff" in Preferences. (Preferences.xib)
Added new customize sync dialog (SyncCustomize.xib) called by button above.
BUG=34209
TEST=manual
Review URL: http://codereview.chromium.org/1525007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
xib changes:
* Get rid of all GTMWidthBasedTweakers in the xib
* Change labels from "clip" to "wrap"
BUG=39390
TEST=See bug
Review URL: http://codereview.chromium.org/1605013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"Manage" and "Done.
xib changes: Anchor bubble view on right side, make it autoresize horizontally. Same for divider line, radio groups, and title. Make widthbased tweakers at bottom horizontally autoresize. Hook up manage and done buttons to controller.
BUG=39393
TEST=See bug.
Review URL: http://codereview.chromium.org/1527012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
xib changes: Change controls size in "Action" column from 'small' to 'regular'.
BUG=39818
TBR=trungl
Review URL: http://codereview.chromium.org/1609005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
xib changes:
Content settings window: Enable & hook up "exceptions" button.
The dialog is not "live" (i.e. if it's open while settings are deleted through the bubble, the window is only updated after closing & reopening it). It's not possible to do any editing in the window, only deleting. This matches windows/linux.
http://imgur.com/q7qMK
BUG=39818
TEST=Go to a few geolocation pages, click allow/deny. Then go to content settings->locations->exceptions, the visited pages should be listed.
Review URL: http://codereview.chromium.org/1566015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43610 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are two xibs in this change.
ExtensionInstallPrompt.xib: This handles the more common case of installing an extension with one or more permission warnings. There is an NSBox with room for the warnings which are separated by \n\n.
ExtensionInstallPromptNoWarnings.xib: It is also possible to install an extension with zero permission warnings. This is currently rare, but we hope to make it more common in the coming quarters. In this case, there is no NSBox and the layout is slightly different.
BUG=29633
Review URL: http://codereview.chromium.org/1540013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
team.
XIB changes:
* Make the button bar 35px tall.
* Change the buttons to have Rounded Textured style.
BUG=none
TEST=Chromium --> Preferences --> Basic --> [Manage]. Bottom button bar should have a textured appearance.
Review URL: http://codereview.chromium.org/1519014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changed the appearance of the window to incorporate Alcor's feedback (see bug).
xib changes: modified the layout, size and spacing of the buttons so that they look like this: http://img59.imageshack.us/img59/1087/picture5lr.png
BUG=38208
TEST=manual tests
Review URL: http://codereview.chromium.org/1584002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removes the star button from the toolbar entirely. Adds a
LocationBarImageView subclass for the star icon and wires it to the
RHS of the field. Adjust the bookmark bubble to move the arrow to the
RHS and position appropriately.
BookmarkBubble.xib: outlet to view so that controller can change the arrow from left to right.
Toolbar.xib: Move reload icon to where star was, remove star icon, adjust spacing. All spacing was adjusted to specific positions in the relevant inspector, not by mouse drag, so hopefully there's nothing awry there.
BUG=37865
TEST=No star icon on toolbar.
TEST=Optional home button adjustments should work right.
TEST=Star action in omnibox when showing an URL.
TEST=Star action can be clicked to bookmark current page.
TEST=Bookmark bubble arrow points at star like before.
TEST=Command-d brings up bookmark bubble.
TEST=Star action changes from blank to yellow depending on state.
TEST=Star action tooltip changes depending on state.
Review URL: http://codereview.chromium.org/1540009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
xib changes: added two new lines to the web database cookie prompt subview of the cookie details NSView, one for database description and one for expected database size. Wired bindings to the appropriate methods in the cookie details object in the same style as the existing fields.
Web database cookie prompt now looks like this: http://img208.imageshack.us/img208/9703/picture6j.png
BUG=36435
TEST=augmented unit tests and manual tests
Review URL: http://codereview.chromium.org/1582003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bar folders. E.g. supports DragAndDrop.
BUG=34910
TEST=Make sure you can DnD items to/from the "off the side" chevron.
Make sure context menus on those buttons work as well (e.g. delete).
Make sure the chevron is NOT draggable.
Make sure the chevron works properly as a "hover open" button when
dragging something else around; e.g. it pops open if you hover over
it. (It's small so this may take patience).
Drop a folder from the bar into itself. Make sure we don't crash.
xib change:
- chevron button is now BookmarkButton, not MenuButton.
Also has BookmarkButtonCell in it.
- "off the side" menu removed.
Review URL: http://codereview.chromium.org/1520003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add commandDispatch: to the firstResponder.
BUG=39317
TEST=right click on bookmark bar and choose "Always Show Bookmark Bar" command.
r=thomasvl
Review URL:http://codereview.chromium.org/1545007
Review URL: http://codereview.chromium.org/1545007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
not wrap poorly. Yes, this is fragile, but the only other path is to do like views and have constants for every language to force the sizes. :(
BUG=40008
TEST=see bug (auto fill prefs in English should not be wrapped)
Review URL: http://codereview.chromium.org/1559011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
another things to force the window wider.
Also put in replacement stub text in the sync status text field so it is always two lines at layout time, the code already set it to the correct state during initialization (prevents a DCHECK in some languages).
BUG=39391
TEST=see bug
Review URL: http://codereview.chromium.org/1535009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
window to match.
BUG=39388
TEST=see bug
Review URL: http://codereview.chromium.org/1602001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bookmark bar (except the "import bookmarks" link itself).
Xib change: hooked the bookmark bar context menu up to the width tweaker that holds the "import bookmarks" link.
BUG= 39362
TEST= in a browser with no bookmarks, try to right-click to the right of the "import bookmarks" link. The menu for bookmark creation should pop up.
Review URL: http://codereview.chromium.org/1385001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
xib changes:
- Added a new NSView for showing detailed information about appcaches in the cookie tree. The new view uses the same pattern as the existing views.
- Added bindings for the new view to control its visibility and the values displayed, also using the same style as the existing detail information subviews.
BUG=37459
TEST=new unit test and manual tests
Review URL: http://codereview.chromium.org/1555001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
red when the URL is not properly formed.
BUG=17612
TEST=Type an unacceptable character in the URL field or leave the URL field blank and observe a red background.
Review URL: http://codereview.chromium.org/837010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Do this by switching the text from a NSTextField to a NSTextView.
xib changes: Make text field an ordinary NSTextField instead of our own subclass, connect it to labelPlaceholder_ instead of to label_.
BUG=?,22187
TEST=Open an infobar with a link (e.g. the new geolocation infobars). The cursor should become a hand on hover, and clicking the info bar should no longer put a caret in there. Other infobars (e.g. "Flash plugin crashed" when you kill the flash process on youtube) should look exactly as before. The cursor should still not become an ibeam.
Review URL: http://codereview.chromium.org/1552001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
xib changes:
- Add a new subview to the details view for displaying appcache information in the cookie prompt. It is in the style of the existing views.
- The new view has a single info line for the manifest url.
- The label of this line is ^IDS_COOKIES_APPLICATION_CACHE_MANIFEST_LABEL
- The value is bound to content.details.manifestURL
- "hidden" binding set to content.details.shouldShowAppCachePromptDetailsView with a NSBNegateBoolean transformer OR selection.@count with a NSNegateBoolean transformer.
- Adjusted the layout of all of the details subviews, labels and values slightly to improve spacing and make it consistent
Screenshot of prompt for appcache available here:
http://img156.imageshack.us/img156/5941/picture2hj.png
http://img404.imageshack.us/img404/3747/picture3bi.png
Screenshot of adjusted cookie prompt with settable expiration:
http://img337.imageshack.us/img337/2296/picture4g.png
BUG=39288
TEST=manual testing, new unit tests
Review URL: http://codereview.chromium.org/1296005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
xib changes: Removed everything above the horizontal line and put an empty NSView there, as container for the geo stuff (maybe later, there should be only one xib file for all bubble types and the container should be filled from the bubble model in all cases. Not in this CL.)
http://imgur.com/AtXiq
BUG=11246
TEST=Start chromium with --enable-geolocation. Go to http://maxheapsize.com/static/html5geolocationdemo.html , click "Allow" or "Deny". Bubble should appear. It should behave like on windows or linux (except that it has buttons instead of links. We only use links for stuff that opens web pages on clicking on OS X.)
Review URL: http://codereview.chromium.org/1542001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
container. Also fixes an issue where the grippy was being shown when no Browser Actions were installed.
Known issue: You can drag the buttons outside of the container, even though they will recover by snapping back into place. This will be fixed in a further revision.
TEST=try dragging browser action buttons in order to reorder them.
BUG=26990
Review URL: http://codereview.chromium.org/1418003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The radio button seems to be non-functional; probably the backend probably isn't there yet.
xib changes: Added a location tab to contentsettings.xib, bind its radio buttons and normal button to the new methods in the controller. In the bubble, enable the "settings" button.
BUG=11246
TEST=content settings now has a "location" tab.
Review URL: http://codereview.chromium.org/1428002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
away, in case they try to call back later.
Xib file changes:
- Connect the loginButton_ and cancelButton_ IBOutlets.
BUG=29462
TEST=See test case in bug.
Review URL: http://codereview.chromium.org/1376001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
xib change: added tag to fields that are used for credit card numbers.
BUG=http://crbug.com/38259
TEST=as in bug
Review URL: http://codereview.chromium.org/1219009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For now, an in-progress version of the bubble/omnibox icon. The bubble shows up, but doesn't do much yet. The two buttons are disabled because they both don't do anything yet. Since this is behind a flag, I think checking in work-in-progress UI is fine.
Parts of this CL were merged in from http://codereview.chromium.org/1369002 . Ignore the files from that CL.
http://imgur.com/tWJhg
BUG=11246
TEST=Start chrome with --enable-geolocation, go to http://maxheapsize.com/static/html5geolocationdemo.html , click allow or deny, observe that an icon appears. Click icon, a bubble appears.
Review URL: http://codereview.chromium.org/1345005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We did the original abuse because we were past the 4.1 string freeze and needed
to add new features, but we can fix this for chrome 5.
TEST=The labels should be things like "Key:" instead of "Name:" and so on.
BUG=34669
Review URL: http://codereview.chromium.org/1317004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Preferences.
Nib changes: Change the "fonts and languages" string to refer to "fonts" only. Remove the "languages" tab from the "fonts and languages" xib.
BUG= 39008
TEST= open preferences in Mac. see no reference to languages in "Under the Hood".
Review URL: http://codereview.chromium.org/1306002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
instances.
BUG=37883
TEST=View->Encoding & page menu (in toolbar)->Encoding menus should exist and have the same title.
Review URL: http://codereview.chromium.org/1273001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As per Alcor's recommendations, customize the Mac cookie prompt so that it is a less like windows/linux but more "maccy": add application icon for modal dialog, change layout and make radio buttons in "remember" choice small rather than regular.
Also added unit tests.
xib changes:
- Add application icon to cookie prompt dialog, shifting all other elements to the right accordingly.
- Change the size of the radio buttons in the "remember" choice to be small rather than regular.
- Change the default text in in the information NSTextField to "Label" rather than a really long nonsensical debug string
- Move the details view to be below the accept/block buttons.
- Change the style of the disclosure control to be a button rather than triangle.
Before: http://img257.yfrog.com/img257/3066/picture3fx.png
After: http://img214.imageshack.us/img214/5553/picture9es.png and http://img200.imageshack.us/img200/1558/picture10pm.png
BUG=38208
TEST=manual testing, added unit test for remember/block/accept controls
Review URL: http://codereview.chromium.org/1102005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42597 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added the necessary code and madde xib changes to make it possible to select "When I close my browser" as the expiration for a cookie in the cookie prompt dialog.
xib changes:
- Add explicit outlet to details view controller for the layout tweaker so that can be called explicitly from code.
- Modify already existing popup menu for selecting cookie expiration to have the right menu items: item 1 is content.details.expires and item 2 is ^IDS_COOKIES_COOKIE_EXPIRES_SESSION.
- Wire the hidden binding of the expiration menu to the key value path content.details.canEditExpiration with a NSNegateBoolean transformer.
- Wire the visibility of the "expires" text in cookie details to the key value path content.details.canEditExpiration.
BUG=http://crbug.com/38405
TEST=manual testing, new units tests
Review URL: http://codereview.chromium.org/1134005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
links.
The link itself was added to the nib as an NSButton; the link and "no bookmarks" text were both embedded in a GTMWidthTweaker to keep them nicely positioned when localized.
BUG= 28753
TEST= create browser with empty profile or remove all bookmarks. Link should appear that creates a dialog box which allows you to import data from other browsers, as in Windows version.
Review URL: http://codereview.chromium.org/1246001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Mac part).
.xib change: Add hyperlink button with text "^IDS_PLUGIN_SELECTIVE_DISABLE" and
hooked up to -openPluginsPage: of file's owner.
BUG=736
TEST=Go to Content Settings -> Plug-ins and click on "Disable individual plug-ins..."; should get browser window with chrome://plugins/.
Review URL: http://codereview.chromium.org/1285002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactored code so that the class that encapsulates cookies details
is shared between the cookie tree and cookie prompt on the mac.
xib changes: Fixed the bindings in all of the subviews in the details view to use the new shared details class. Also added a currently hidden popup menu for selecting the cookie expiration time in the prompt details view--this needs to be wired up in a separate CL.
BUG=http://crbug.com/38348
TEST=added unit tests for the new class, manual testing of cookie tree and cookie prompt dialog
Review URL: http://codereview.chromium.org/1025003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- coding style fixes for ivars
- fixed some 10.6 toolchain warnings from the xib
- provide custom getters for two properties to always return false when the matching controls are hidden.
- Autosize the window to handle any possible l10n now
- Make headers, buttons, and all by the stats/breakpad checkbox force the window to grow as needed.
- Wrap the stats/breakpad checkbox to the resulting width (it will never fit otherwise).
- Layout/shuffling things based on the views that get hidden (no other browsers to import from, not stats pref).
BUG=37743
TEST=text isn't clipped in any language
Review URL: http://codereview.chromium.org/995002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24390
TEST=When *not* fullscreen, menu items (under View in main menu and in app menu) should be "Enter Full Screen"; when fullscreen, they should be "Exit Full Screen"; menu items should still work; keyboard shortcuts should still work.
Review URL: http://codereview.chromium.org/1011002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Set more checkboxes and radio to not scale the images, this removes warnings with the 10.6 toolchain.
- Remove an unneeded NSUserDefaultsController from the CookiePrompt xib.
BUG=none
TEST=everything still works
Review URL: http://codereview.chromium.org/979004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
10.6 toolchain.
BUG=none
TEST=everything still works
Review URL: http://codereview.chromium.org/997003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Set more checkboxes and radio to not scale the images, this removes warnings with the 10.6 toolchain.
- Remove an unneeded NSUserDefaultsController from the ContentSettings xib.
BUG=none
TEST=everything still works, less warnings building on 10.6
Review URL: http://codereview.chromium.org/1010002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rolled back MainMenu.xib to before r40905
<http://codereview.chromium.org/660438> and re-did the changes.
BUG=none
TEST=Open MainMenu.xib in Interface Builder; should be able to open Chrome main; should be able to save and re-open MainMenu.xib successfully. Show Full History menu should appear as after r40905 (at bottom of History menu, with favicon) and work properly.
Review URL: http://codereview.chromium.org/990001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41601 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Change in xib file disables "avoid empty selection" which leads to an item in the tree already being selected when the dialog opens.
BUG=http://crbug/38069
TEST=manual testing and existing flaky unit test FLAKY_RemoveButtonEnabled
Review URL: http://codereview.chromium.org/841004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41576 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
warnings from the 10.6 toolchain.
BUG=none
TEST=less warnings on 10.6 builds, everything still works
Review URL: http://codereview.chromium.org/838005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added two new xibs. The first is a cookie info view that is shared between the tree that shows browser data and the cookie modal prompt to block accepting cookies. The second is a window to replace the NSAlert modal dialog for the cookie prompt. Modified cookie tree code and added cookie prompt code to use new xibs.
Changed "hidden" handling of cookie detail view to use bindings rather than explicit code.
TODOs for http://crbug.com/36948 not in this CL:
- changing the expiration for cookies isn't implemented
TEST=manually testing of modal cookie prompt, new unit tests
BUG=http://crbug.com/36948
Review URL: http://codereview.chromium.org/669127
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=In English the autofill prefs don't word wrap.
Review URL: http://codereview.chromium.org/806002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
all the other checkboxes in under the hood.
BUG=37527
TEST=any translations with a really long button title should be more likely to have the similar right edge as the other checkboxes.
Review URL: http://codereview.chromium.org/700002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implements Mac Address Book "me" card integration with AutoFill feature. When the kAutoFillAuxiliaryProfilesEnabled preference is enabled, via the AutoFill preferences dialog, the active user's designated "me" card becomes available to AutoFill. That is, forms become aware of any name, address, email, and telephone number information residing in the user's "me" card. Small change to AutoFillDialog.xib to resize the preference check-box label width to accommodate new string.
BUG=36496
TEST=PersonalDataManagerTest
Review URL: http://codereview.chromium.org/668247
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
NIB change: Added checkbox for pref into web content section of "Under the Hood" and moved other controls down to match.
BUG=37527
TEST=navigate to www.google.co.il using a branded build translate infobar should appear/not appear based on pref.
Review URL: http://codereview.chromium.org/722004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Increase the number of Recently Closed items to 10.
* Move the "Show Full History" item to be at the end of the menu (XIB change).
BUG=37209
TEST=Open and navigate 12 tabs. Close 10 of them; History menu should be full. Close one more; history menu stays at 10.
TEST="Show Full History" is the last item in the menu.
Review URL: http://codereview.chromium.org/660438
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Adds a boolean preference to specify whether to use the Mac user's Address Book "me" card as a source of information for AutoFill addresses. This CL adds the Mac UI and the preference setup only. It does not cover the functionality for fetching the actual Address Book data. The changes to AutoFillDialog.xib add the checkbox UI and bind the checkbox to the |auxiliaryEnabled| property in the controller class. The |addressSection_| outlet is set to the spacer following the new checkbox. Unit tests are included for the addition of the preference at the mac dialog controller level.
BUG=36496
TEST=PersonalDataManagerTest, AutoFillDialogControllerTest
Review URL: http://codereview.chromium.org/668171
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40803 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also fix an unrelated TODO in this area.
xib change: Make ContentSettingsWindowController the NSTabView's delegate and hook the controller's IBOutlet up to the NSTabView.
BUG=36949
TEST=Open content settings via a blocked popups bubble. Popup tab should be selected. Select javascript tab, close window. Reopen window, javascript tab should still be selected.
Review URL: http://codereview.chromium.org/661354
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40362 0039d316-1c4b-4281-b951-d872f2087c98
|