summaryrefslogtreecommitdiffstats
path: root/chrome/app/nibs
Commit message (Collapse)AuthorAgeFilesLines
* Mac: remove cursor turd from About dialog.viettrungluu@chromium.org2009-11-201-644/+96
| | | | | | | | | | | | | (The cursor was displayed with full keyboard accessibility enabled.) Changes to About.xib: changed the class of the view containing the legal text to |AboutLegalTextView| (from |NSTextView|). BUG=25570 TEST=Enable Full Keyboard Access, All controls in System Preferences; look in the About Chromium/Google Chrome; there should be no cursor displayed (at the end of the text). Review URL: http://codereview.chromium.org/414028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32598 0039d316-1c4b-4281-b951-d872f2087c98
* Moved a whole pile of unittests over to CocoaTest.dmaclach@chromium.org2009-11-191-613/+73
| | | | | | | | | | | AboutIPC.xib - Connected up controller to its window and the window delegate to the controller. BUG=26484, 26484 TEST=See repro steps in bugs. Review URL: http://codereview.chromium.org/402066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32551 0039d316-1c4b-4281-b951-d872f2087c98
* Implement "Import Bookmarks and Settings".mrossetti@chromium.org2009-11-193-1703/+1431
| | | | | | | | | | | | | Changed to MainMenu.xib: Added a new menu item under the ^IDS_SHORT_PRODUCT_NAME menu with the name . This menu item has a tag of 40014 corredponsing to IDC_IMPORT_SETTINGS and is connected to the commandDispatch: action of the CrApplication (First Responder). Changes to Toolbar.xib: Added a new menu item with the name ^IDS_IMPORT_SETTINGS in the same manner as above. BUG=26157 TEST=Launch Chrome and inspect the current bookmarks and settings. With no browser window open and then with a browser window open choose the "Import Bookmarks and Settings..." menu option found under the "Chromium" menu. Also, with a browser window open, hoose the "Import Bookmarks and Settings..." menu option found under the page's tool menu. Select a browser from the popup, choose the items to be imported, and press OK. Then inspect the bookmarks and other settings to insure that the selected items have indeed been imported. Review URL: http://codereview.chromium.org/378036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32526 0039d316-1c4b-4281-b951-d872f2087c98
* Change the folder presentation in the Bookmark Editor and the Bookmark All ↵mrossetti@chromium.org2009-11-192-189/+718
| | | | | | | | | | | | | | Tabs dialogs to a tree view. Nib changes: Removed the NSBrowser and added an NSOutlineView. BUG=26647,26643,26718,27634 TEST=Bring up the bookmark editor by control-clicking in the bookmarks bar and selecting Add Page... or by selecting the Bookmark this Page... menu item found in the Bookmarks menu. Observe that the folder presentation is now a tree view. Select any folder and click New Folder to verify that new folders can be added. Double-click on the newly created folder to change its name. Added folders will not commit until OK is pressed, which will require that a bookmark actually be added. Also bring up the Bookmark All Tabs dialog by control-clicking in the tab bar with more than one tab open and verify that the folder structure is shown in a tree view. Review URL: http://codereview.chromium.org/393006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32441 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: implement Pin Tab.viettrungluu@chromium.org2009-11-181-2/+42
| | | | | | | | | | | | | | | | | | Note that, per Apple's HIG, the context menu alternates between Pin/Unpin Tab instead of toggling a checkmark. Changes to TabView.xib: - add Pin Tab item (to match Windows) Still to do: - dragging/dropping tabs needs visual feedback to indicate how pinned state will change (need input from UI team) - on Windows, you can pin a tab by dragging it slightly to the right of the rightmost pinned tab; this needs to be done BUG=25481 TEST=not yet Review URL: http://codereview.chromium.org/375010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32384 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: add Extensions to the Main Menu and to the Wrench Menu.viettrungluu@chromium.org2009-11-182-113/+910
| | | | | | | | | | | | | Changes to MainMenu.xib: Add Extensions (text: "^IDS_SHOW_EXTENSIONS_MAC", tag: IDC_MANAGE_EXTENSIONS, sends: -commandDispatch: to First Responder) to Main Menu -> Window, immediately below Downloads. Changes to Toolbar.xib: Add Extensions (text: "^IDS_SHOW_EXTENSIONS", others as above) to Wrench Menu, immediately below Downloads. Enable Extensions menu item when no browser window is open. BUG=25423 TEST=Make sure Extensions menu items in Main Menu -> Window and in the Wrench Menu work. Also make sure the former works when no browser window is open. Review URL: http://codereview.chromium.org/399072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32342 0039d316-1c4b-4281-b951-d872f2087c98
* Changes to BookmarkBubble.xib.dmaclach@chromium.org2009-11-182-764/+41
| | | | | | | | | | | | Removed explicitly set first responder that was causing autocalculate not to work. Changes to Preferences.xib Turned on the autorecalculate flag. BUG=27781 TEST=repro steps in bug Review URL: http://codereview.chromium.org/402041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32274 0039d316-1c4b-4281-b951-d872f2087c98
* Fix "open all" on a folder node to open only 'marks in that folder,jrg@chromium.org2009-11-151-723/+82
| | | | | | | | | | | | | | | | | | | | | | | | | | not ALL all. Make Delete and Rename enabled for folder context menu (but disabled for "Other Bookmarks"). nib changes (related to the context menus): - Telegate is the bookmark bar controller. - Switched type from NSMenu to BookmarkMenu. TEST=New window. Create folder "empty" with nothing in it. Create folder "two" with 2 bookmarks in it. Create a final bookmark in the top level of the bar. Context menu (right click) over all folders. Make sure Delete and Rename enabled for folders but not "Other Bookmarks". Make sure "Open All" (and friends) disabled over "empty", enabled over "two". "Open All" on "two" --> see 2 opened. "Open All" on the bar itself --> see 3 opened. Ditto for "Open all in new window" and "open all in incognito window". Create a new window. In new window, make sure folders have context menus. BUG=http://crbug.com/27522, http://crbug.com/27529 Review URL: http://codereview.chromium.org/391046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32029 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Animate the bookmark bar showing/hiding.viettrungluu@chromium.org2009-11-141-13/+238
| | | | | | | | | | | | | | | There's a huge refactoring of the bookmark bar controller in this CL, so that animation-related code is in only a few places (instead of scattered all over the place). Changes to BookmarkBar.xib: Since BookmarkBarToolbarView now inherits from AnimatableView, I had to hook up its delegate_ member to File's Owner (i.e., the BookmarkBarController). Not yet implemented: morphing between the detached bar (on the NTP) and anything else. BUG=25600 TEST=Go to a normal page, show/hide the bookmark bar (Shift-Cmd-B), watch it animate. Review URL: http://codereview.chromium.org/384105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31977 0039d316-1c4b-4281-b951-d872f2087c98
* Causes all info bubbles to fade in and out with an animation instead of justdmaclach@chromium.org2009-11-141-2/+2
| | | | | | | | | | | | | | appearing. Change to BookmarkBubble.xib was to make the window not show on creation. It will have more mods to it because of switching to IB on Snow Leopard. BUG=27464 TEST=Make the bookmark bubble appear and disappear by clicking on the star. Review URL: http://codereview.chromium.org/389027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31976 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes for Report Bug Dialog:mirandac@chromium.org2009-11-131-39/+69
| | | | | | | | | | | | | * Honor "send screenshot" checkbox * Save bug description and send screenshot state if user chooses "phishing report" function (that disables both); restore if the user goes back to a non-phishing bug. * Make bug report give consistent and correct values for bug type. BUG= 27283, 27282, 27281 TEST= Fill in data in bug description, toggle send screenshot "on". Move between "phishing" and non-phishing reports before sending. Note that description goes away and reappears appropriately. Review URL: http://codereview.chromium.org/385047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31906 0039d316-1c4b-4281-b951-d872f2087c98
* Initial change for the implementation of browser actions on the mac.andybons@chromium.org2009-11-121-49/+875
| | | | | | | | | | Popups are not implemented within this change. BUG=23881 TEST=Install a browser action extension on the mac. Observe that something actually happens in the UI. Review URL: http://codereview.chromium.org/366029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31803 0039d316-1c4b-4281-b951-d872f2087c98
* Re-added sync menu item to wrench menu.akalin@chromium.org2009-11-121-3/+58
| | | | | | | | | | | Menu item is right above "Preferences..." (with an extra separator). Menu item and separator is hidden if sync is not enabled. BUG=23073 TEST=manually Review URL: http://codereview.chromium.org/386020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31787 0039d316-1c4b-4281-b951-d872f2087c98
* Added Sync-related controls to Preferences pane under "Personal Stuff".akalin@chromium.org2009-11-121-7/+193
| | | | | | | | | | | | | | | These controls are only visible when sync is enabled. This isn't finished, but it is enough to be usable. Made RemoveViewFromView() handle top-most views. Also added RemoveGroupFromView(). BUG=23073 TEST=manual testing, trybots Review URL: http://codereview.chromium.org/380006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31775 0039d316-1c4b-4281-b951-d872f2087c98
* o Renames the bookmark bubble class to InfoBubble in a step to make it more ↵andybons@chromium.org2009-11-121-19/+19
| | | | | | | | | | | | reusable. o Adds the ability to position the arrow of the bubble on the top right as well as the top left (default). BUG=none TEST=Nothing should change visually. This is prep for use by browser action popups and the first run UI. Review URL: http://codereview.chromium.org/385060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31764 0039d316-1c4b-4281-b951-d872f2087c98
* Enable and implement last 2 items in bookmark bar context menu: "Openjrg@chromium.org2009-11-121-55/+539
| | | | | | | | | | | | | | | | | | | | | | | All In New Window" and "Open All In Incognito Window" (17616). Bookmark Folders have the bar context menu, not the bookmark context menu (26748). Disable bookmark manager item on bookmark contextual menus (26944). BUG=http://crbug.com/17616, http://crbug.com/26748, http://crbug.com/26944 TEST=Add some bookmarks. Make sure "Open All In New Window" and "Open All In Incognito Window" work from the bar context menu. Add a bookmark folder. Make sure the context menu of the folder is the bar conetxt menu, not the 'mark context menu. Make sure Bookmark Manager item is DISabled in both context menus. nib change: hook up actions in the "Open All Blah" items just like the normal "Open All". Review URL: http://codereview.chromium.org/373022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31748 0039d316-1c4b-4281-b951-d872f2087c98
* BookmarkBubble.xib - Change control from combobox to popup button. The ↵dmaclach@chromium.org2009-11-111-159/+847
| | | | | | | | | | | | | | massive changes due to the xib are due to editing the xib on SnowLeopard. Changes internals of bookmark bubble controller so that it will work correctly with items with the same name. BUG=27330 TEST=Create several bookmark folders and items using the bookmark bubble and verify that it is still working correctly. Review URL: http://codereview.chromium.org/384025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31719 0039d316-1c4b-4281-b951-d872f2087c98
* TBR: pkastingakalin@chromium.org2009-11-111-177/+29
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31710 0039d316-1c4b-4281-b951-d872f2087c98
* Grouped sync controls and remove them properly.akalin@chromium.org2009-11-111-157/+98
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31706 0039d316-1c4b-4281-b951-d872f2087c98
* Redid sync prefs.akalin@chromium.org2009-11-111-6/+192
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31705 0039d316-1c4b-4281-b951-d872f2087c98
* Added bookmark sync stuff to UI.akalin@chromium.org2009-11-111-21/+42
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31703 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] L10N cleanup of report a bugthomasvl@chromium.org2009-11-101-306/+302
| | | | | | | | | | | | | | - align the baselines of the controls - quick animation when changing the buttons so it is a little less sudden. While here: - don't update the button title while dragging through the menu, do it when done. - Fixed up some kvo binding to stop using the ivars directly since the controller has accessors TEST=baselines match, button updates after selection not during menu drags BUG=27275 Review URL: http://codereview.chromium.org/388006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31571 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Gets rid of "Fast Resize View"-related warnings in BrowserWindow.xib.rohitrao@chromium.org2009-11-091-2/+667
| | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/378035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31490 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] localize the cookie policy menu items.thomasvl@chromium.org2009-11-091-42/+21
| | | | | | | | | | Add TitleCase versions of the menu policy strings (one in the range isn't used, but done to avoid more ifs in the GRD. TEST=Since they are new strings, other langs will get English until we get them localized, but you can tell by them being in proper Title Case. BUG=26844 Review URL: http://codereview.chromium.org/377009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31480 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Adds a "fast resize mode" in which the RenderWidgetHostViewCocoa is ↵rohitrao@chromium.org2009-11-091-31/+38
| | | | | | | | | | clipped rather than resized. Useful for when animations are running. BUG=http://crbug.com/26857 TEST=Animations should still work. Infobar animations should be smoother. The web contents will clip or fill with white at the bottom while the animation is running, but should resize and draw correctly when the animation finishes. Review URL: http://codereview.chromium.org/372056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31472 0039d316-1c4b-4281-b951-d872f2087c98
* Xib needed to be updated to pick up new CrApplication path.dmaclach@chromium.org2009-11-091-6/+30
| | | | | | | | Changed Application over to type BrowserCrApplication from CrApplication. Review URL: http://codereview.chromium.org/376025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31453 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Theme "Show all downloads..." link.thakis@chromium.org2009-11-091-12/+12
| | | | | | | | | | | | | Refactor HyperlinkCell a bit and make it less crashy. This depends on http://codereview.chromium.org/377026 (the changes form that CL are contained in this CL too. Ignore them.) BUG=none TEST=Install theme, "Show all downloads..." color should change. Uninstall theme through installing the "classic" theme in the gallery, link should be blue again. Hit "Reset to default theme" in prefs, theme should still be blue. Open and close shelf a few times and change themes, nothing should crash. Review URL: http://codereview.chromium.org/371059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31429 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Make download shelf use GTM ui stuff.thakis@chromium.org2009-11-091-864/+317
| | | | | | | | | | | | | | | | | | | | xib changes (a bit more complicated than anticipated, because GTMUI decided to resize the image view to 0x0, since its image is only loaded in DownloadShelfController's awakeFromNib -- hence I couldn't make the image view a child of the width-based resizer): * Replace text view with a button that has a HyperlinkView cell * Change its text to ^IDS_SHOW_ALL_DOWNLOADS * Add localizer and ui localizer/layout tweaker objects * Put close button and new button into a width-based tweaker * Put item container and image view into a box * Let width-based tweaker resize said box No intended functionality change. This is a prerequisite for http://codereview.chromium.org/371059 . BUG=None TEST=download shelf still looks like it did before, resizing hides download items when the icon would touch them. Review URL: http://codereview.chromium.org/377026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31421 0039d316-1c4b-4281-b951-d872f2087c98
* Allow return key to add new line in description text field.mirandac@chromium.org2009-11-071-2/+10
| | | | | | | | | BUG= 26860 TEST= open bug report. enter multi-line description, using return to insert newlines. Review URL: http://codereview.chromium.org/374024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31388 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Wire Ctrl+Shift+I to DevTools, Ctrl+Shift+J to JavaScript console. ↵pfeldman@chromium.org2009-11-071-8/+7
| | | | | | This way modifiers are consistent on Mac and it makes sense on Windows/Linux. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31383 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: remove spurious toolbar context menu and associated crash.viettrungluu@chromium.org2009-11-071-737/+53
| | | | | | | | | | | | | | | The toolbar should not have a context menu, and it should decidedly not be hooked up to the Page menu. Changes to Toolbar.xib: - remove the connection from the Toolbar |menu| outlet (to the Page Menu) - connect Chrome UI Localizer's |yetAnotherObjectToLocalize_| outlet to the Page Menu BUG=26823 TEST=See bug. Also, make sure the toolbar does NOT have a context menu, and that the Page Menu is displayed correctly. Review URL: http://codereview.chromium.org/371049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31370 0039d316-1c4b-4281-b951-d872f2087c98
* [mac] Add "Paste and Match Style" to edit menuthakis@chromium.org2009-11-071-663/+135
| | | | | | | | | | | xib change: Added "^IDS_PASTE_MATCH_STYLE_MAC" to edit menu below paste with key equiv cmd-opt-shift-v, hooked up to pasteAsPlainText: on first responder. BUG=25205 TEST=Cmd-shift-v no longer pastes. Cmd-shift-opt-v does paste, _and_ blinks the menu. Review URL: http://codereview.chromium.org/371034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31330 0039d316-1c4b-4281-b951-d872f2087c98
* Add View:Developer:JavaScript Console, bind to command-shift-Cmark@chromium.org2009-11-062-69/+740
| | | | | | | | | | | | | | This is the Mac equivalent of r31225, http://codereview.chromium.org/377005 BUG=none TEST=Command-shift-C and View:Developer:JavaScript Console should bring up the Developer Tools in console mode. Command-option-J and View:Developer:Developer Tools should show the Developer Tools window not in console mode. The menu items should be visible in View:Developer and in the Page menu under Developer. Review URL: http://codereview.chromium.org/377017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31317 0039d316-1c4b-4281-b951-d872f2087c98
* Adds hover and pressed states for the newtab button on the Mac.dmaclach@chromium.org2009-11-061-4/+30
| | | | | | | | | | | | | | | | | | | | BrowserWindow.xib change was to add newtab_p as the image for the alternate state for the new tab button. BUG=26205 TEST=1) mouse over the new tab button and it should highlight. 2) Click and hold on the new tab button and its state should change 3) Release, and watch new tab get created. Verify that new button state changes appropriately 4) Create a full tab strip of tabs. Verify that button state stays correct as you click on the new tab button and new tabs are created but the button doesn't move. 5) Create 2 tabs, and move the mouse button into the newtab button. See that it highlights. hit cmd-w to close a tab. As the newtab button moves away from under the cursor make sure it loses its highlight. Review URL: http://codereview.chromium.org/372009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31316 0039d316-1c4b-4281-b951-d872f2087c98
* Added menu item for sync to wrench menu.akalin@chromium.org2009-11-061-4/+53
| | | | | | | | | | | | | | | Wrench menu item is right above "Preferences...". Chrome menu item will be added in a future CL right above "Clear Browsing Data...". Sync menu items are hidden if bookmark sync is disabled (the current default for OS X). UI decisions were made after consulting with Cole. Added code in browser_window_controller.mm to update sync menu item dynamically. Added unit tests. BUG=23073 TEST=manual testing, trybots, unittests Review URL: http://codereview.chromium.org/363017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31309 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 31284 - Added menu item for sync to wrench menu.willchan@chromium.org2009-11-061-53/+4
| | | | | | | | | | | | | | | | | | Wrench menu item is right above "Preferences...". Chrome menu item will be added in a future CL right above "Clear Browsing Data...". Sync menu items are hidden if bookmark sync is disabled (the current default for OS X). UI decisions were made after consulting with Cole. Added code in browser_window_controller.mm to update sync menu item dynamically. Added unit tests. BUG=23073 TEST=manual testing, trybots, unittests Review URL: http://codereview.chromium.org/363017 TBR=akalin@chromium.org Review URL: http://codereview.chromium.org/374017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31289 0039d316-1c4b-4281-b951-d872f2087c98
* Added menu item for sync to wrench menu.akalin@chromium.org2009-11-061-4/+53
| | | | | | | | | | | | | | | Wrench menu item is right above "Preferences...". Chrome menu item will be added in a future CL right above "Clear Browsing Data...". Sync menu items are hidden if bookmark sync is disabled (the current default for OS X). UI decisions were made after consulting with Cole. Added code in browser_window_controller.mm to update sync menu item dynamically. Added unit tests. BUG=23073 TEST=manual testing, trybots, unittests Review URL: http://codereview.chromium.org/363017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31284 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ReportBug dialog so that cancel button moves with the send button as it ↵mirandac@chromium.org2009-11-061-7/+24
| | | | | | | | | | | expands and contracts when its title changes. BUG= none TEST= Open report bug dialog; choose "Send phishing report" and note that cancel button moves as send button expands. Review URL: http://codereview.chromium.org/372021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31238 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Prefs l10n width tweaksthomasvl@chromium.org2009-11-061-39/+41
| | | | | | | | | | | - Small shuffle to the basics page to make things look a little better - Support for the three areas that get really wide in the prefs ui forcing the window wider, this will make sure nothing is clipped in any language. BUG=26586 TEST=try french, german, etc. to make sure no buttons extend off the side of the prefs window. Review URL: http://codereview.chromium.org/378012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31235 0039d316-1c4b-4281-b951-d872f2087c98
* Move cancel button to left to comply with Apple HIG. Bind Cancel button to ↵mirandac@chromium.org2009-11-061-5/+5
| | | | | | | | | | | ESC, and Send button to Return. BUG= 26874 TEST= use report bug dialog. note correct ui. Review URL: http://codereview.chromium.org/376006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31233 0039d316-1c4b-4281-b951-d872f2087c98
* Implement Bookmark All Tabs... Added an abstraction of ↵mrossetti@chromium.org2009-11-062-24/+865
| | | | | | | | | | | | | | | BookmarkEditorController called BookmarkEditorBaseController, from which BookmarkEditorController and the new BookmarkAllTabsController derive. The bookmark/folder name, URL and OK button now use bindings/KVO. Added BookmarkAllTabs.xib which is nearly identical to BookmarkEditor.xib. Changed unit test since an empty bookmark name is now acceptable. Added unit test for the Bookmark All Tabs... BookmarkEditor.xib changes: Removed the bookmark name and url as outlets and instead bound their values to controller's displayName and displayURL respectively. Bound the OK button enabling to the controller's okEnabled. BUG=25099 TEST=Open two or more tabs. Bring up a contextual menu by control-clicking on one of the tabs. Choose the Bookmark All Tabs... menu item. A dialog will be presented in which you can type a folder name and select the parent folder in which the new folder will be placed. By default, the most recently touched folder will be selected as the parent. Click OK. Now check to parent folder to see that the newly created folder has been added and then check within that folder to see that the open tabs have been added. Perform the above operation again only this time choose the Bookmark All Tabs... menu item found in the Bookmarks menu. Review URL: http://codereview.chromium.org/357005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31200 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Draw the results label correctly in the findbar.rohitrao@chromium.org2009-11-061-143/+75
| | | | | | | | | | | Adds common base classes (StyledTextField and StyledTextFieldCell) for both the find bar and omnibox text fields. BUG=http://crbug.com/19550 TEST=Findbar results label should not be overdrawn by find text. TEST=Autocomplete drawing (keyword, hint, lock icon) should not be affected. Review URL: http://codereview.chromium.org/319005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31186 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Adds animations for the download shelf.rohitrao@chromium.org2009-11-051-4/+33
| | | | | | | | | | | Nib file changes: - Connected DownloadShelfView's delegate_ to DownloadShelfController. BUG=http://crbug.com/25602 TEST=Download shelf should animate open/closed. Review URL: http://codereview.chromium.org/342083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31156 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up the menu outlet of the IDS_BOOKMARKS_NO_ITEMS to the bar menu.mrossetti@chromium.org2009-11-051-524/+46
| | | | | | | | | BUG=26069 TEST=With no bookmarks showing in the bar (The text "For quick access, place your bookkmarks here in the bookmarks bar." should be showing.) right-click on the "For quick access..." text. A contextual menu should appear and operate as when right-clicking on the bookmarks bar when the text is not being shown. Review URL: http://codereview.chromium.org/362021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31134 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Pref position cleanupthomasvl@chromium.org2009-11-041-23/+45
| | | | | | | | | | | | | | | - Baselines match between labels and top control for: - default browser (basics) - browsing data (personal stuff) - themes (personal stuff) - The list for startup urls and the textbox for homepage are both indented to the start of the text on the radio they go with. - The gap above the list for startup urls and the textbox for homepage and their radio buttons is the same. BUG=26703 TEST=Baseline match, gap between radio and field/list is the same, field/list are left aligned Review URL: http://codereview.chromium.org/362011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31020 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Remove the stats and crash report checkbox from the under the hood ↵thomasvl@chromium.org2009-11-041-1/+13
| | | | | | | | | | prefs in non google chrome builds. BUG=24425 TEST=Chroimum builds don't have the checkbox, chrome builds do. Chromium builds shouldn't have a gap where it was. Review URL: http://codereview.chromium.org/363005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30967 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Enables animations for the infobar. Changes the control flow for ↵rohitrao@chromium.org2009-11-031-178/+242
| | | | | | | | | | | | | | | infobar opening/closing to match Windows more closely. Nib file changes: - Embedded the InfoBarGradientView inside an AnimatableView. - Rebound [controller view] to the AnimatableView and added an infoBarView_ IBOutlet. - Bound the AnimatableView's delegate_ to the InfoBarController. BUG=http://crbug.com/25599 TEST=Infobars should animate in and out, except for during tab switches. Review URL: http://codereview.chromium.org/354008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30893 0039d316-1c4b-4281-b951-d872f2087c98
* Fix alignment of text and label in ReportBug nib.mirandac@chromium.org2009-11-031-20/+22
| | | | | | | | BUG= none TEST= none Review URL: http://codereview.chromium.org/342107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30890 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Prefs window sizing/spacing:thomasvl@chromium.org2009-11-031-66/+66
| | | | | | | | | | | | | - Make some vertical spacing in basics more consistent - Make some vertical spacing in personal stuff more consistent - Make the views a bit wider to avoid some clipping and wrapping in a few languages. - A little code cleanup, no longer allow the pref views to be different widths, this resulted in some really odd looks, so we want to mange the layout ourselves up front (things not always being as wide as the window, etc). TEST=window looks ok (given our strings it won't always look great, but shoot for ok). BUG=26586 Review URL: http://codereview.chromium.org/351027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30871 0039d316-1c4b-4281-b951-d872f2087c98
* Make page and wrench buttons have correct hover look.avi@chromium.org2009-11-031-629/+70
| | | | | | | | | | | | | xib changes: - cell tags changed to make them styled independently - button attribute "bordered" disabled BUG=http://crbug.com/25644 TEST=as in bug Review URL: http://codereview.chromium.org/341088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30869 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 06:30:33 +0000