| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=51729
TEST=see bug
Review URL: http://codereview.chromium.org/3145016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Run with --enable-resource-content-settings and --enable-click-to-play to enable.
TabSpecificContentSettings now keeps track of which resources were blocked. The content setting bubble displays those resource, and selecting the "allow radio buttons adds exceptions for these resources.
The infobar for non-sandboxed plug-ins now also shows a button to always allow the blocked plug-in on that site.
Screenshot of the plugin bubble: http://imgur.com/6npqv.png
Because we need to change the title and radio button labels depending on whether we track specific plug-ins, we copy them from the ContentSettingBubbleModel.
XIB changes: Add a text field for the blocked plug-ins to ContentBlockedPlugins.xib, hooked up to the |blockedResourcesField_| outlet.
BUG=39252,38432
TEST=manual
Review URL: http://codereview.chromium.org/2873104
TBR: bauerb@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Run with --enable-resource-content-settings and --enable-click-to-play to enable.
TabSpecificContentSettings now keeps track of which resources were blocked. The content setting bubble displays those resource, and selecting the "allow radio buttons adds exceptions for these resources.
The infobar for non-sandboxed plug-ins now also shows a button to always allow the blocked plug-in on that site.
Screenshot of the plugin bubble: http://imgur.com/6npqv.png
Because we need to change the title and radio button labels depending on whether we track specific plug-ins, we copy them from the ContentSettingBubbleModel.
XIB changes: Add a text field for the blocked plug-ins to ContentBlockedPlugins.xib, hooked up to the |blockedResourcesField_| outlet.
BUG=39252,38432
TEST=manual
Review URL: http://codereview.chromium.org/2873104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'm renaming the platform-specific content setting bubble classes to the uniform naming scheme content_setting_bubble_{views,gtk,cocoa}.{h,cc}
XIB changes: Rename ContentBlockedBubbleController in ContentBlocked*.xib to ContentSettingBubbleController.
BUG=none
TEST=everything compiles
Review URL: http://codereview.chromium.org/3099002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This changes the two-tone background to an even gradient and changes the push
state of the buttons to use the blue selected menu item color.
BUG=none
TEST=visual
Review URL: http://codereview.chromium.org/3072021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
XIB changes:
* Replace the edit item's segmented control with 3 buttons
* Make the root view of both items a MenuTrackedRootView
* Use the custom MenuTrackedButton for all the buttons
BUG=49356
TEST=Click open the Wrench menu, hold, and drag over the buttons and they perform their function.
Review URL: http://codereview.chromium.org/3072014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Toolbar.xib change brings browser-action container view out from under
Omnibox.
Push browser-action sizing code into controller to reduce exposed
constants. Make size consistent with other toolbar buttons. 4px
visual spacing from omnibox to first browser action (grippy in that
area), between browser actions, and last action to wrench menu.
browser_actions_overflow_Template.pdf resource for browser-action
chevron. Chevron same height as browser actions. Get rid of divider
between browser actions and wrench (future CL will integrate it into
chevron button). Chevron 4px from Omnibox or 2px from last browser
action, then 4px to wrench menu. Chevron button has hover like other
buttons.
BUG=50575
TEST=Browser-actions area still works right WRT spacing and rearranging and everything else.
Review URL: http://codereview.chromium.org/3012044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
click-to-play is enabled.
Screenshot: http://imgur.com/ZKsQB.png
XIB changes: Add a rounded rect button hooked up to |loadAllPlugins:| in the File's Owner and referenced by its |loadAllPluginsButton_| outlet, wrapped in a GTMWidthBasedTweaker.
BUG=49677
TEST=ContentSettingBubbleModelTest.*
Review URL: http://codereview.chromium.org/3015036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Partial revert of http://codereview.chromium.org/3046029 .
Toolbar.xib change to make Omnibox 27px tall again.
Omnibox font back to system size, shift baselines to match, inset
location icon additional pixel to look good WRT text spacing, adjust
ev and keyword bubbles to match, adjust popup to match.
BUG=50765, 50575
TEST=See 50765
Review URL: http://codereview.chromium.org/2806098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
view which provides an image based button that changes on hover and press.
Refer to the bug for screenshots of the current and desired UI.
Screenshot of what results from this patch is visible at http://www.corp.google.com/~johnnyg/49490patch.png
XIB change: change height of title bar, change bindings of buttons.
BUG=49190
TEST=notifications on the mac
Review URL: http://codereview.chromium.org/3014004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The XIB change re-introduces the cookie tab view item with the "ask" setting
as additinoal tab view item. The controller deletes the one not required
according to the command line flag.
BUG=50083
TEST=none
Review URL: http://codereview.chromium.org/3075013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54308 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Toolbar.xib changes:
- buttons from 31x27 to 29x29 so that the visual is 27x27.
- shift things left to take up opened space.
- omnibox to 29 pixels tall.
- wrench also to 29x29.
- all of that raised a single pixel to recenter.
- swap positions of home and reload.
Modify home-button-adjustment code to reflect rearranged
home/reload positions.
Increase Omnibox font size by one point to match increased field
height (and Windows Omnibox). Revise various font clients to
recognize this. Shift Omnibox baseline and other measurements to
account for increased height.
Shift globe/search icon in by one pixel so icons on both sides of
Omnibox are 4px from border. Matching shift in popup.
Fix EV-bubble to use appropriate green for text, rather than black.
Push out bubble to have a single-pixel space WRT Omnibox border.
Tighten corners to tuck into Omnibox corners. Handle different
lhs padding versus location icon (image should end up in same
spot, even though the bubble draws outside the image).
BUG=50575
TEST=none
Review URL: http://codereview.chromium.org/3046029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54188 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50378
TEST=none
Review URL: http://codereview.chromium.org/3018026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
XIB changes: Make the InfoBubbleView the same size as the NSView it's contained in.
BUG=50520
TEST=none
Review URL: http://codereview.chromium.org/3061024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
xib changes: Add menu item with shortcut cmd-f10 for now, connect it to -commandDispatch:. Connect app controller's new outlet to the new menu item.
BUG=50307
TEST=No changes by default. If --enable-expose-for-tabs is passed, a new menu item should be visible below "prev tab" in the window menu. It should be active for normal browser windows and fullscreen windows, but not if there are no browser windows around or if the current window is a popup window or a non-browser window (e.g. prefs). Clicking the menu item doesn't do anything yet. cmd-f10 should trigger the menu item, but it shouldn't if the cmdline flag isn't passed.
TEST2=Go to a page that is busy spinning some javascript (e.g. "javascript:while(1);"), give it focus, hit cmd-f10. Menu should blink immediately.
Review URL: http://codereview.chromium.org/3020035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53833 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49996
TEST=Visual
Review URL: http://codereview.chromium.org/3029026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
edit field
Changes the AutoFillTextField class to properly initialize obfuscated credit card text in text field on the credit card editor sheet. Adds additional unit tests to verify that obfuscated text appears to the user.
Nib changes: Adds outlet for the credit card number text field for use in unit tests.
BUG=49988
TEST=AutoFillDialogControllerTest.CreditCardDataMutation
Review URL: http://codereview.chromium.org/2878050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the bounds of the button in the nib.
Nib change: Make the new tab button a subclass of NewTabButton instead of NSButton
BUG=45738
TEST=clicking new tab button still works as expected.
Review URL: http://codereview.chromium.org/3046016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Preferences.xib changes: Connect Enabled of the proxies configuration button to
a getter in PreferencesWindowController.
BUG=49538
TEST=Unit test in pref_set_observer_unittest.cc, manually configure proxy policies, check advanced options page.
Review URL: http://codereview.chromium.org/3038013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the Mac side of http://codereview.chromium.org/2808053 .
Looks like this: http://imgur.com/leY4C.png
To provide user feedback, after an exception has been added, the exceptions window is shown.
XIB changes:
Add a button to the allowed cookies outline views to block cookies and two to the blocked cookies one to allow them; set the NSSplitView delegate to File's Owner.
Review URL: http://codereview.chromium.org/2884024
Patch from Bernhard Bauer <bauerb@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes the AutoFill dialog on Mac to support multi-select and delete of items
in the address and credit card table. The "Edit..." button disables when multiple
items are selected.
Nib changes in AutoFillDialog.xib: (1) Enables multi-select for the table view, (2) binds
the enabled state of the "Edit..." button to the new |multipleSelected| property, (3) connects edit button to outlet.
BUG=49344
TEST=AutoFillDialogControllerTest.DeleteMultiple.
Review URL: http://codereview.chromium.org/3039014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3033007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Swap the +/- zoom buttons so that minus is first.
* Invert the fullscreen arrows when in fullscreen mode.
BUG=49449
TEST=Visual
TEST=Wrench menu --> Enter full screen. Wrench menu now has inverted arrows to exit full screen.
Review URL: http://codereview.chromium.org/3008010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
o 4px between wrench menu and location bar/edge of window.
o 4px between reload button and location bar.
o Adjust size of wrench menu to be the same size as every other button.
o Fix bug where location bar would be too close to the wrench menu when disabling the last visible browser action.
BUG=46738,48678
TEST=visual
Review URL: http://codereview.chromium.org/3027005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes the labels data entry fields on the AutoFill preferences dialog on Mac. Labels
are now derived fields so user input is not needed.
Nib changes made are AutoFillAddressSheet.xib: removed "Label" entry and status indicator, adjusted
layout to account for new space. AutoFillCreditCardSheet.xib: removed "Label" entry and status
indicator, adjusted layout to account for new space. AutoFillDialog.xib: removed the table header,
removed the "Label" column, adjusted sizing of remaining "Summary" column to account for new space,
move the buttons lower to top-align with table.
BUG=47430
TEST=AutoFillAddressModelTest.*, AutoFillCreditCardModelTest.*, AutoFillDialogText.*
Review URL: http://codereview.chromium.org/2813052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=45230
TEST=CollectedCookiesTest.*
Review URL: http://codereview.chromium.org/3034007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
XIB changes: Rename radio enabled KVC getter, fix broken isPasswordMangerEnabled connection.
BUG=48469
TEST=Configure policies, check UI.
Review URL: http://codereview.chromium.org/2909014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
XIB changes: In ContentSettings.xib, remove the middle item from the radio button matrix in the cookies tab view item.
TEST=Open Preferences > Content Settings > Cookies, select "Block". Chrome shouldn't crash.
BUG=none
Review URL: http://codereview.chromium.org/2835040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Options dialog, in the Under the Personal Stuff section.
xib changes: added an enabled binding to the policy-controlled checkboxes in the "Personal Stuff" preference pane so that they can be disabled when their value is overridden by policy. The methods for the bindings are in the preference window controller.
BUG=44395
TEST=ConfigurationPolicyPrefStoreTest.* and ConfigurationPolicyProviderWinTest.* Manual tests: Set the policy externally. Check that the radio buttons and the "Show saved passwords" button in Options/Personal Stuff/Passwords are disabled. Also check that the check box is set/unset as done by the policy.
Review URL: http://codereview.chromium.org/2848039
Patch from Jean-Luc Brouillet <jeanluc@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52637 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=45230
TEST=CollectedCookiesTest.*
Review URL: http://codereview.chromium.org/2907003
TBR=jochen@chromium.org
Review URL: http://codereview.chromium.org/3016003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52505 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=45230
TEST=CollectedCookiesTest.*
Review URL: http://codereview.chromium.org/2907003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also makes changes to MenuController to support NIB-based initialization.
Screen shots: http://cl.ly/1cyU (en) and http://cl.ly/1cyE (ru).
BUG=47848
TEST=Click on Wrench menu and see buttons. Buttons perform their function.
Review URL: http://codereview.chromium.org/2923009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=1404
TEST=Hit cmd-shift-delete and the clear browsing data data dialog should come up.
Review URL: http://codereview.chromium.org/2980012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
--show-privacy-dashboard-link switch present.
XIB changes: added a new link to the sync group of the preferences dialog (required adding a continuation array). Slightly altered the spacing to fit.
BUG=48844
TEST=mac preferences pane with the above switch
Review URL: http://codereview.chromium.org/2891021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add "Features" label to source list.
xib change: Add some vertical space at the top of each tab, change outline view cell size to "small", hook up new outlet.
http://i.imgur.com/KGES6.png
BUG=45546
TEST=Content settings window still works: Current pane is still remembered, and opening the window from a bubble selects the right pane.
Review URL: http://codereview.chromium.org/2932009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
drawing code in r51367.
BUG=none
TEST=check logs. make sure that "Could not find image named 'close_bar'" is not present.
Review URL: http://codereview.chromium.org/2964001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
height). Replace the stop/reload images with ones that fit the weight better. Also replace the wrench menu icon.
BUG=none
TEST=make sure dat toolbar is TIGHT.
Review URL: http://codereview.chromium.org/2811047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
folders with regards to hover-open when hover-opening is active.
Makes the UI more consistent.
BUG=http://crbug.com/42167
xib change: set the chevron "off the side" button's delegate to File's Owner.
Review URL: http://codereview.chromium.org/2844046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chevron.png NOT deleted since it is still used on windows.
xib change: adjust off-the-side button's cell from "bottom justified"
to "centered" since new image is centered.
BUG=http://crbug.com/45742
TEST=Add bookmarks. See chevron. See chevron at "centered" vertically (with respect to bookmark text).
Review URL: http://codereview.chromium.org/2867048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Hold the reload button state change from stop to reload until the
mouse exits. Also short-circuit the stop message when the real state
should be reload. Also prevent multi-clicks from sending multiple
actions.
Toolbar.xib: reload button made kind of ReloadButton.
BUG=47184
TEST=Browse to a slow page, mouse over stop button. Should not go to reload button when throbber (in tab) stops.
TEST=After page loaded, click stop. Should not crash.
TEST=Hover over reload button. Command-r should start a reload and change the button to stop button.
Review URL: http://codereview.chromium.org/2847051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=45230
TEST=none
Review URL: http://codereview.chromium.org/2818046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
THIS CHANGES THE BEHAVIOR OF HOW PERMISSIONS WORK:
Previosly an infobar was shown every time an application requested notification permissions.
Now, this is shown only the first time an application requests permissions, and the choice is remembered thereafter. If the kDesktopNotificationDefaultContentSetting preference is set, no infobar is shown at all.
This CL also adds content settings UI to manage the exceptions list on mac, win, and linux.
xib changes: Add a new pane to the content settings tab view, with the right title, radio box strings, actions, and bindings.
BUG=45547
TEST=Go to a site that shows notifications. It should only ask for permissions once, and remember the user choice after that. Content Settings->Notifications->Exceptions should show the exceptions list. The content settings pane should be fully functional, and the radio button options ("don't ask") should have an effect on pages that weren't visited before.
Review URL: http://codereview.chromium.org/2825028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The link will pop up a dialog that displays the cookies blocked and accessed by the current page.
The XIB change adds a link-styled button (cell type HyperlinkButtonCell) below the title and above the horizontal line on the bubble with the text IDS_BLOCKED_COOKIES_INFO. The button action is hooked up to showMoreInfo: in the File's Owner.
BUG=45230
TEST=none
Review URL: http://codereview.chromium.org/2799012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
AutoFill dialog
These changes remove the AutoFill enabled radio buttons from the Preferences dialog and adds a single checkbox to the AutoFill dialog to do same. Preferences.xib changes by removing the radio buttons and moving other controls up. AutoFillDialog.xib adds checkbox to control AutoFill enabled preference. Also, other controls in AutoFillDialg.xib now bind their enabled states to the value of the enabled checkbox.
BUG=47435
TEST=AutoFillDialogControllerTest.AutoFillEnabled*
Review URL: http://codereview.chromium.org/2799054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also allow for editing them...
The XIB change adds a column at the end of the table with a NSCheckboxCell in it and the title IDS_EXCEPTIONS_OTR_HEADER
BUG=44480
TEST=manual
Review URL: http://codereview.chromium.org/2858032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
of leftover references to "merge and sync."
BUG=48125
TEST=Start up sync, change data types, stop sync, etc, nothing should break.
Review URL: http://codereview.chromium.org/2843019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Specifically,
geolocation_exceptions_window_controller => simple_content_exceptions_window_controller (mac)
geolocation_exceptions_view => simple_content_exceptions_view (win)
geolocation_content_exceptions_window => simple_content_exceptions_window (linux)
It's now easy to use it to show desktop notification exceptions as well.
No functionality change.
BUG=45547
TEST=geolocation exceptions dialog still works
Review URL: http://codereview.chromium.org/2835031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
derive from it.
No functionality change.
This will be used to share the content settings exceptions dialog code between geolocation and notifications.
BUG=45547
Review URL: http://codereview.chromium.org/2838037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
when mouse is inside. Fix to gradient button to not show border on mouseover when disabled. Adjust "overlap" between the toolbar and bookmark bar to allow for larger buttons w/out clipping.
Nib change: All buttons changed to not bordered, button cell tags are 0. Buttons are 31x31 and spread out a bit more.
BUG=44574
TEST=toolbar and bookmark bar appearance, hidden, always showing, and detached on NTP.
Review URL: http://codereview.chromium.org/2806041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=34627
TEST=none
Review URL: http://codereview.chromium.org/2803026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51088 0039d316-1c4b-4281-b951-d872f2087c98
|