| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Updated the text of the radio buttons.
* Added a button that opens the AutoFill dialog.
BUG=33025
TEST=manually
Patch from Thiago Farina <thiago.farina@gmail.com>
Review URL: http://codereview.chromium.org/579020
Review URL: http://codereview.chromium.org/610003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
where the form is embedded within an NSScrollView. Also, when a disclosure view closes, its "content" should be disabled from the point-of-view of receiving tabbing focus.
Nib file changes add the new |detailsView_| outlet to disclosure views. Also changed text fields to AutoFillTextFields to pick up auto-scrolling behavior.
BUG=33029
TEST=unit_tests --gtest_filter=AutoFillDialogControllerTest.*
Review URL: http://codereview.chromium.org/606067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
hooked up to the back end yet. The UI demonstrates manipulation of one address and one credit card record. Eventually buttons will be added to add and remove additional records. The additions in this CL are:
- Preferences dialog has a new "Change autofill settings" button that triggers an autofill settings dialog.
- The autofill settings dialog now exists and allows the user to manipulate form autofill data. Specifically address information and credit card information.
- Each address or credit card record is presented in a disclosure view to allow for summary or detailed views of each record.
- The autofill dialog is layed out dynamically in a vertical list (ordered by y) using the VerticalLayoutView.
- Sections are delimited visually with the SectionSeparatorView. There are currently two sections, one for addresses and one for credit cards.
- Unit tests are present that exercise the invocation of the dialog and check basic functionality. Checks are performed to see that data is flowing from core profile and credit card data structures into Cocoa model data structures used for bindings internally by the UI.
- There are three .xib files (AutoFillDialog.xib, AutoFillAddressFormView.xib, and AutoFillCreditCardFormView.xib) that partition the dialog UI into distinct views, controllers, and model objects.
- Cocoa databinding is utilized to syncronize dependent parts of the UI.
- All strings are stored in internationalized form in .grd files and .xib files (with one small TODO execption, see below).
The things remaining to do are:
- Hook the UI up to the backend model, specifically the PersonalDataManager data.
- Add support for arbitrary number of address and credit card records. I.e. Add and Delete buttons.
- Scroll-to-Point support for autoscrolling when tabbing between fields.
- Billing and shipping address popups in the credit card section.
- Any validation of input (need to circle back with UI folks on this).
- Input validation unit tests.
- String concatenation of the summary label needs to be internationalized.
BUG=33029
TEST=none
Review URL: http://codereview.chromium.org/558066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also, left-align fonts and vertical-align them so that their baseline lines up with the baseline of their labels.
BUG= 33296
TEST= adjust fonts and languages. name of font size should not be clipped.
Review URL: http://codereview.chromium.org/572046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=35302
TEST=manually test
Review URL: http://codereview.chromium.org/596047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the second half of http://codereview.chromium.org/597013.
TBR=pkasting
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/596027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add local storage getters to CookieTreeNode
* XIB: Embed cookie info labels into an NSView (inside the NSBox) and add
another for info NSView for local storage.
* Roll GTM r280:293
BUG=33068
TEST=Chromium-->Preferences-->Under the Hood-->Show cookies... Find and click on a local storage node. Info should be displayed.
Review URL: http://codereview.chromium.org/599003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38504 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=28184
TEST=None
Review URL: http://codereview.chromium.org/587013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
xib change: Change connection from "commandDispatch:" to "commandDispatchUsingModifiers:" for home button.
BUG=34900
TEST=Enable home button in "Basics" in the prefs. Cmd-clicking the home button should open home page in new tab.
Review URL: http://codereview.chromium.org/582009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38319 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
buttons.
o Adds initial BrowserActionsContainerView class that simply draws a right border at this time but will be used for more complex UI later.
o Alters Toolbar.xib to use the new view class instead of a plain NSView.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/565048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(xib change: enable 'preserve selection' in NSOutlineView.)
BUG=33333
TEST=BookmarkEditorBaseControllerTest.SelectedFolderDeleted et al
Review URL: http://codereview.chromium.org/566005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix breakage caused by <http://src.chromium.org/viewvc/chrome?view=rev&revision=37819>.
Changed tags for File->{Save Page As..., Email Page Location, Print...} and View->Text Encoding.
BUG=34463
TEST=Check that File->Save Page As... (and Cmd-S), File->Email Page Location, and View->Text Encoding work properly.
Review URL: http://codereview.chromium.org/566033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37994 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
checkmark icon next to Pause to alternating the words "Pause" and "Resume".
XIB change: unset the 'On Image' on the Pause button.
BUG=23069
TEST=Download large file and verify that the menu item says "Pause." Click "Pause" and the menu item should now say "Resume".
Review URL: http://codereview.chromium.org/563001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
xib change: Change "Focus Ring" from "Default" to "None" on both scroll view and contained table view.
This does not address the ring around the first column when tabbing through.
BUG=33699
TEST=Click row in table in task manager. The table should not have a focus ring.
Review URL: http://codereview.chromium.org/559004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
All I did was re-save in IB, no changes.
Review URL: http://codereview.chromium.org/557081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Adds ExtensionInstalledBubble.xib, which contains the framework for the bubble itself (icon view, close button, and three message fields).
BUG= 26974
TEST= Install an extension. Bubble should show same information as windows bubble.
Review URL: http://codereview.chromium.org/527012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Extract button dragging out of BookmarkButton into DraggableButton. Make BookmarkButton a subclass of DraggableButton. Create new class DownloadItemButton and make it a subclass of DraggableButton.
xib change: Make download item a DownloadItemButton instead of an NSButton.
BUG=15776
TEST=Download something, wait for it to complete, then drag it from the download shelf to somewhere. It should now work. Bookmarks should still be draggable in the bookmarks bar.
Review URL: http://codereview.chromium.org/180036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(Xib change: move left/right edges of outer splitview out 1 pixel.)
BUG=33119
TEST=none (visual appearance only)
Review URL: http://codereview.chromium.org/556048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37339 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
attribute of the button to the correct key.
BUG=33124
TEST=Check that the Certificate Information button is enabled on an https page.
Review URL: http://codereview.chromium.org/552171
Patch from Vernon Tang.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
XIB changes:
* Add an NSSearchField and adjust window size.
* Add an outlet for the NSOutlineView so we can clear the delegate to avoid
potential crashes during sheet closing.
* Change the control size of the NSOutlineView to small (looks better).
BUG=32328
TEST=Chromium-->Preferences-->Under the Hood-->Show cookies... Enter a domain or domain substring and, without hitting enter, results should be filtered.
Review URL: http://codereview.chromium.org/557002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32735
TEST=Hover cursor over +/-/gear buttons
Review URL: http://codereview.chromium.org/549143
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
xib changes: Set min window size to 300x200, change table view column resizing to "Uniform".
Give task manager columns min max widths.
BUG=33133,33134
TEST=See bugs.
Review URL: http://codereview.chromium.org/551148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37114 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=29819
TEST=Open settings dialog, go to "Personal Stuff" Tab, Import Data... button should function
Review URL: http://codereview.chromium.org/555065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
selection.
XIB change: Change the "Remove" button's |enabled| binding from just looking at
the count of the selection to FilesOwner.removeButtonEnabled.
BUG=32627
TEST=Covered by unit tests.
TEST=Open cookies manager. Select one item, make sure "Remove" is enabled.
TEST=Open cookies manager. Try to select two items. You shouldn't be able to.
Review URL: http://codereview.chromium.org/546102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
for the string changes that already landed. more work will be needed to make the window match the new wants, but this gets the tests passing again.
BUG=32719
TEST=unittests green up
Review URL: http://codereview.chromium.org/551103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32338
TEST=Preferences-->Under the Hood-->Show cookies... should now be localized.
Review URL: http://codereview.chromium.org/543128
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
direction for
the clear browsing data dialog.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/542126
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
double-click on entries to change their title.
BUG=32596
TEST=shouldn't be able to double-click a cookie to edit its title, browsing and clearing cookies should still work.
Review URL: http://codereview.chromium.org/553032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36688 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(Nib changes: Removed toolbar, added segmented control and pop-up button, removed focus highlighting for outline views.)
BUG=32442
TEST=Verify activation and behavior of + and - buttons and 'gear' menu items.
Review URL: http://codereview.chromium.org/543116
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36582 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make window size remembering mechanism easier to use and more compatible with windows's chrome profiles.
Nib changes: Unset "show at startup" so that the initial repositioning isn't visible.
BUG=32147
TEST=Move & size taskman window, quit chrome, reopen chrome. Size & pos should've stayed. Same for keyword editor. Page info dialog should behave as it did before.
Review URL: http://codereview.chromium.org/536086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Auto-expand the Cookies folder after expanding a domain-level folder
* XIB change: disable multiple selection (and removal) of cookies to prevent a crash
* Auto-select the next cookie after deletion
BUG=31678,32002,32022
TEST=Open cookies manager. Expand a domain and Cookies folder should auto-expand.
TEST=Open cookies manager. Should not be able to perform multiple selection or deletion.
TEST=Open cookies manager. Expand domain with multiple cookies. Delete the first cookie. Second cookie should now be selected.
Review URL: http://codereview.chromium.org/542091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The list views now match the Windows version: left one is a tree that only shows folders, right one is a flat list.
In BookmarkManager.xib: left pane changed to BookmarkTreeController, 'folder' column added to right outline view, toolbar added.
BUG=31969,32080
TEST=new unit tests on BookmarkManagerController, BookmarkItem, BookmarkTreeController.
Review URL: http://codereview.chromium.org/536063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is in preparation for adding Recents/Search. Apologies for the number of diffs, but most of them are basically just renaming, especially 'id' --> 'BookmarkItem*' and 'node'-->'item'.
The code now has a real Objective-C BookmarkItem class instead of using opaque 'id's. This allows all the C++ BookmarkNode calls to be collected into one source file. It will also in the future allow creating fake collections of bookmarks, necessary for the Recents and Search features.
Also some refactoring of the drag/clipboard code, which now uses a static array instead of an instance variable to hold dragged items; this will be necessary to handle moves between trees (coming in the next checkin.)
Minor xib changes: Shorten URLs in the middle not at the end, and remove borders of table/outline views.
BUG=32080
TEST=Added BookmarkItemTest, modified existing unit tests.
Review URL: http://codereview.chromium.org/551013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Aligned left edges of sync status text and the relogin link text.
BUG=30159
TEST=manual testing
Review URL: http://codereview.chromium.org/542025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Nib change: Changed data cell from NSFieldTextCell to NSButtonCell with checkbox style.
BUG=none
TEST=Go to wikipedia, cmd-click a couple links, enter "about:hang" in omnibox. After a while, the hung renderer dialog should show up and have a favicon for all the tabs you opened by cmd-clicking.
Review URL: http://codereview.chromium.org/545040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GTK.
NOTE: This change does not contain src/chrome/app/nibs/ClearBrowsingData.xib. It'll be edited by someone who knows about Mac.
BUG=none
TEST=The clear browser data dialog box should have a new option: Delete local storage"
Landing for Marcus
Original CL: http://codereview.chromium.org/524026
Review URL: http://codereview.chromium.org/542048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36098 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Nib change: Reduce row height, make scrollbars smaller.
Make text in task manager table slightly smaller.
Show in decimal digit for %cpu.
Show memory in KB/MB, not always in K.
Change update frequency from 1s to 2s to match Activity Monitor's default.
(all mac-only. ui team is fine with this.)
Finally, turn taskman on.
BUG=13156
TEST=Open task manager, look at it. Should look & feel similar to Activity Monitor.
Review URL: http://codereview.chromium.org/536038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is closed.
Also change how the controller is deallocated, which should fix a valgrind bug.
Nib change: Make TaskManagerWindowController the delegate of the window in the nib, so that its windowWillClose: gets called.
TFR=trungl
BUG=13156,30398
TEST=Open Activity Monitor, look at browser %cpu. Open chrome's task manager, note %cpu goes up slightly. Close task manager again, %cpu should go down again. Open task manager again, should still work.
Review URL: http://codereview.chromium.org/536026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is a sync authentication error.
Changed sync group's layout behavior to VerticalToFit and added explanatory comment.
BUG=30159
TEST=tested with sync disabled, sync enabled, induced sync error, made sure UI looks right
Review URL: http://codereview.chromium.org/501101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In an earlier checkin I had removed the images from the IB files that used HoverCloseButtons, relying on them to be set programmatically. It seems that this causes a flaky sizing problem when loading from a NIB, which only manifested in the DownloadShelf for some reason.
Also change DownloadShelf.xib so that the close button is a child of the main view, not of the GTMWidthTweaker, which seems to eat redraw messages.
BUG=31785
TEST=Try out the download shelf a few times. You need to quit the whole app a few times to ensure it doesn't come back.
Review URL: http://codereview.chromium.org/540001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Nib change: Connect "Task Manager" to first responder's commandDispatch:, give it tag 40005 (IDC_TASK_MANAGER in chrome/app/chrome_dll_resource.h), check "Enabled" checkbox (this has no effect, but is consistent with the rest of the nib).
Due to http://codereview.chromium.org/518085 , the task manager is still disabled, but it's easier to turn on after this CL (only one small change in browser.cc).
BUG=13156
TEST=Click View->Developer. "Task Manager" should still be disabled.
Review URL: http://codereview.chromium.org/541005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The changes to the xib are:
1. Autosave splitter position
2. Disable empty-selection in left table view, so it comes up with the first row
(bookmarks bar) selected
3. Wire up each table view as the other's nextKeyView.
4. Wire up right outline view as window's initialFirstResponder.
BUG=31844
TEST=none
Review URL: http://codereview.chromium.org/518089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35826 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
keychain access app.
Change to the xib is to hook up the button's target/action and enable it.
BUG=none
TEST=click the button, watch the app launch.
Review URL: http://codereview.chromium.org/523104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35795 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Change default system language. Re-launch Chromium. Then go to Chromium-->
Preferences-->Under the Hood-->Change font and language settings. Notice proper
localization.
Review URL: http://codereview.chromium.org/523074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
IDS_OPTIONS_COOKIES_SHOWCOOKIES for Mac (evan is doing Linux).
BUG=31680
TEST=button should have correct name in preferences.
Review URL: http://codereview.chromium.org/524048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
xib change: Deleted NSBox, added NSSplitView instead (with a thin divider and without any child views).
I added the devtools tabcontents to TabContentsController; windows and linux instead add it to the browser window and switch it on every tab change. What I've done makes more sense to me and might work better with a) dragging a tab with docked devtools into a new window and b) toggling fullscreen.
BUG=17368
TEST=
* Inspect element, click the "attach" item in the lower left corner. Devtools should attach to the tab. Click it again, should detach. Re-attach, switch tabs. Should only be in the tab it was attached to. Open another devtools window in another tab, should be attached there. Drag tab with attached devtools into a new window, should work.
* Inspect element with docked devtools, close devtools, inspect another element. devtools should open with the same size it had when it was closed, and should still be docked.
* Hover link with docked devtools. Status bubble should not overlap devtools.
* Go to http://www.pagetutor.com/keeper/http_authentication/index.html and make sure the http auth sheet still shows up
Review URL: http://codereview.chromium.org/526001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35576 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The change at http://codereview.chromium.org/484006 changed all the close buttons to use a single HoverCloseButton class, but this didn't work for the popup blocker. The reason is that all the initialization was done in awakeFromNib since in most other cases, the button was created in a nib, but was done with initWithFrame for the popup blocker case. I refactored the initialization code out into -initButton to be called from both initWithFrame and awakeFromNib.
I also removed the references to the images and alt images from each of the xib files. The images are specified in the class itself so it was redundant to have it in the xibs, and could probably cause confusion if we change the images later on.
BUG=16041
TEST=Ensure that the popup blocker button has rollover image changing, and that it works correctly still for TabView, InfoBar, and DownloadShelf
Review URL: http://codereview.chromium.org/521010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Most features are implemented, but Recents, Search and Undo are still missing.
MainMenu.xib: Just added "Bookmark Manager" menu item at top of "Bookmarks" menu.
BookmarkManager.xib: New file, containing Bookmark Manager panel, owned by BookmarkManagerController class.
BUG=13149
TEST=New unit tests for each new class.
Review URL: http://codereview.chromium.org/501073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35546 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL creates the basic cookie management interface, allowing users to view
and delete cookies from Chromium. TODO: (1) Add the filtering by domain
capability. (2) Localize the NIB.
BUG=15360
TEST=Chromium-->Preferences-->Under the Hood-->Show Cookies. Also covered by unit tests.
Review URL: http://codereview.chromium.org/523025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I forgot to do so when I deleted the corresponding code (in http://codereview.chromium.org/495004).
BUG=30178
TEST=Trybots (to make sure it builds).
Review URL: http://codereview.chromium.org/521020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35460 0039d316-1c4b-4281-b951-d872f2087c98
|