summaryrefslogtreecommitdiffstats
path: root/chrome/app/nibs
Commit message (Collapse)AuthorAgeFilesLines
* [Mac] Make cookie prompt dialog more Mac-likedanno@chromium.org2010-03-251-165/+219
| | | | | | | | | | | | | | | | | | | | | | | As per Alcor's recommendations, customize the Mac cookie prompt so that it is a less like windows/linux but more "maccy": add application icon for modal dialog, change layout and make radio buttons in "remember" choice small rather than regular. Also added unit tests. xib changes: - Add application icon to cookie prompt dialog, shifting all other elements to the right accordingly. - Change the size of the radio buttons in the "remember" choice to be small rather than regular. - Change the default text in in the information NSTextField to "Label" rather than a really long nonsensical debug string - Move the details view to be below the accept/block buttons. - Change the style of the disclosure control to be a button rather than triangle. Before: http://img257.yfrog.com/img257/3066/picture3fx.png After: http://img214.imageshack.us/img214/5553/picture9es.png and http://img200.imageshack.us/img200/1558/picture10pm.png BUG=38208 TEST=manual testing, added unit test for remember/block/accept controls Review URL: http://codereview.chromium.org/1102005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42597 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Allow user to change cookie expiration date in cookie promptdanno@chromium.org2010-03-251-20/+104
| | | | | | | | | | | | | | | | | Added the necessary code and madde xib changes to make it possible to select "When I close my browser" as the expiration for a cookie in the cookie prompt dialog. xib changes: - Add explicit outlet to details view controller for the layout tweaker so that can be called explicitly from code. - Modify already existing popup menu for selecting cookie expiration to have the right menu items: item 1 is content.details.expires and item 2 is ^IDS_COOKIES_COOKIE_EXPIRES_SESSION. - Wire the hidden binding of the expiration menu to the key value path content.details.canEditExpiration with a NSNegateBoolean transformer. - Wire the visibility of the "expires" text in cookie details to the key value path content.details.canEditExpiration. BUG=http://crbug.com/38405 TEST=manual testing, new units tests Review URL: http://codereview.chromium.org/1134005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42590 0039d316-1c4b-4281-b951-d872f2087c98
* Add "import bookmarks" link to bookmark bar when it is devoid of folders or ↵mirandac@chromium.org2010-03-241-83/+208
| | | | | | | | | | | | links. The link itself was added to the nib as an NSButton; the link and "no bookmarks" text were both embedded in a GTMWidthTweaker to keep them nicely positioned when localized. BUG= 28753 TEST= create browser with empty profile or remove all bookmarks. Link should appear that creates a dialog box which allows you to import data from other browsers, as in Windows version. Review URL: http://codereview.chromium.org/1246001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42530 0039d316-1c4b-4281-b951-d872f2087c98
* Add link to disable individual plug-ins in Plug-ins tab of Content Settings ↵viettrungluu@chromium.org2010-03-241-77/+815
| | | | | | | | | | | | | | (Mac part). .xib change: Add hyperlink button with text "^IDS_PLUGIN_SELECTIVE_DISABLE" and hooked up to -openPluginsPage: of file's owner. BUG=736 TEST=Go to Content Settings -> Plug-ins and click on "Disable individual plug-ins..."; should get browser window with chrome://plugins/. Review URL: http://codereview.chromium.org/1285002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42481 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Better code sharing between cookie tree and cookie promptdanno@chromium.org2010-03-181-164/+314
| | | | | | | | | | | | | | Refactored code so that the class that encapsulates cookies details is shared between the cookie tree and cookie prompt on the mac. xib changes: Fixed the bindings in all of the subviews in the details view to use the new shared details class. Also added a currently hidden popup menu for selecting the cookie expiration time in the prompt details view--this needs to be wired up in a separate CL. BUG=http://crbug.com/38348 TEST=added unit tests for the new class, manual testing of cookie tree and cookie prompt dialog Review URL: http://codereview.chromium.org/1025003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41949 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] First run dialog cleanupthomasvl@chromium.org2010-03-161-193/+238
| | | | | | | | | | | | | | | | - coding style fixes for ivars - fixed some 10.6 toolchain warnings from the xib - provide custom getters for two properties to always return false when the matching controls are hidden. - Autosize the window to handle any possible l10n now - Make headers, buttons, and all by the stats/breakpad checkbox force the window to grow as needed. - Wrap the stats/breakpad checkbox to the resulting width (it will never fit otherwise). - Layout/shuffling things based on the views that get hidden (no other browsers to import from, not stats pref). BUG=37743 TEST=text isn't clipped in any language Review URL: http://codereview.chromium.org/995002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41758 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: toggle between "Enter/Exit Full Screen" in menus.viettrungluu@chromium.org2010-03-161-1/+1
| | | | | | | | | BUG=24390 TEST=When *not* fullscreen, menu items (under View in main menu and in app menu) should be "Enter Full Screen"; when fullscreen, they should be "Exit Full Screen"; menu items should still work; keyboard shortcuts should still work. Review URL: http://codereview.chromium.org/1011002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41726 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] XIB cleanupthomasvl@chromium.org2010-03-164-29/+49
| | | | | | | | | | | - Set more checkboxes and radio to not scale the images, this removes warnings with the 10.6 toolchain. - Remove an unneeded NSUserDefaultsController from the CookiePrompt xib. BUG=none TEST=everything still works Review URL: http://codereview.chromium.org/979004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41723 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Remove image scaling settings on radios that causes a warning with ↵thomasvl@chromium.org2010-03-164-36/+84
| | | | | | | | | | 10.6 toolchain. BUG=none TEST=everything still works Review URL: http://codereview.chromium.org/997003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41716 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] XIB cleanupthomasvl@chromium.org2010-03-163-43/+42
| | | | | | | | | | | - Set more checkboxes and radio to not scale the images, this removes warnings with the 10.6 toolchain. - Remove an unneeded NSUserDefaultsController from the ContentSettings xib. BUG=none TEST=everything still works, less warnings building on 10.6 Review URL: http://codereview.chromium.org/1010002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41714 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: fix MainMenu.xib.viettrungluu@chromium.org2010-03-151-33/+858
| | | | | | | | | | | | Rolled back MainMenu.xib to before r40905 <http://codereview.chromium.org/660438> and re-did the changes. BUG=none TEST=Open MainMenu.xib in Interface Builder; should be able to open Chrome main; should be able to save and re-open MainMenu.xib successfully. Show Full History menu should appear as after r40905 (at bottom of History menu, with favicon) and work properly. Review URL: http://codereview.chromium.org/990001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41601 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: fix enabling of remove button in cookie tree when there is a selectiondanno@chromium.org2010-03-151-3/+2
| | | | | | | | | | Change in xib file disables "avoid empty selection" which leads to an item in the tree already being selected when the dialog opens. BUG=http://crbug/38069 TEST=manual testing and existing flaky unit test FLAKY_RemoveButtonEnabled Review URL: http://codereview.chromium.org/841004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41576 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Remove the image scaling on checkboxes and radios to kill a bunch of ↵thomasvl@chromium.org2010-03-121-25/+25
| | | | | | | | | | warnings from the 10.6 toolchain. BUG=none TEST=less warnings on 10.6 builds, everything still works Review URL: http://codereview.chromium.org/838005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41432 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] augment modal cookie prompt on mac to include details panedanno@chromium.org2010-03-123-1615/+3770
| | | | | | | | | | | | | | | | Added two new xibs. The first is a cookie info view that is shared between the tree that shows browser data and the cookie modal prompt to block accepting cookies. The second is a window to replace the NSAlert modal dialog for the cookie prompt. Modified cookie tree code and added cookie prompt code to use new xibs. Changed "hidden" handling of cookie detail view to use bindings rather than explicit code. TODOs for http://crbug.com/36948 not in this CL: - changing the expiration for cookies isn't implemented TEST=manually testing of modal cookie prompt, new unit tests BUG=http://crbug.com/36948 Review URL: http://codereview.chromium.org/669127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41408 0039d316-1c4b-4281-b951-d872f2087c98
* [MAC] Small tweak to avoid word wrap of auto fill prefs on English UI.thomasvl@chromium.org2010-03-101-18/+25
| | | | | | | | BUG=none TEST=In English the autofill prefs don't word wrap. Review URL: http://codereview.chromium.org/806002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41201 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Widen the translate checkbox so it's right edge has the same max as ↵thomasvl@chromium.org2010-03-091-4/+4
| | | | | | | | | | all the other checkboxes in under the hood. BUG=37527 TEST=any translations with a really long button title should be more likely to have the similar right edge as the other checkboxes. Review URL: http://codereview.chromium.org/700002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41042 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill Mac Address Book "me" card data translation.dhollowa@chromium.org2010-03-091-1/+1
| | | | | | | | | | | | Implements Mac Address Book "me" card integration with AutoFill feature. When the kAutoFillAuxiliaryProfilesEnabled preference is enabled, via the AutoFill preferences dialog, the active user's designated "me" card becomes available to AutoFill. That is, forms become aware of any name, address, email, and telephone number information residing in the user's "me" card. Small change to AutoFillDialog.xib to resize the preference check-box label width to accommodate new string. BUG=36496 TEST=PersonalDataManagerTest Review URL: http://codereview.chromium.org/668247 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41041 0039d316-1c4b-4281-b951-d872f2087c98
* Add enable/disable translate pref to "Under the Hood".jeremy@chromium.org2010-03-091-25/+89
| | | | | | | | | | | NIB change: Added checkbox for pref into web content section of "Under the Hood" and moved other controls down to match. BUG=37527 TEST=navigate to www.google.co.il using a branded build translate infobar should appear/not appear based on pref. Review URL: http://codereview.chromium.org/722004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41026 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Minor adjustments to the history menu, per the UI team.rsesek@chromium.org2010-03-081-118/+102
| | | | | | | | | | | | | * Increase the number of Recently Closed items to 10. * Move the "Show Full History" item to be at the end of the menu (XIB change). BUG=37209 TEST=Open and navigate 12 tabs. Close 10 of them; History menu should be full. Close one more; history menu stays at 10. TEST="Show Full History" is the last item in the menu. Review URL: http://codereview.chromium.org/660438 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40905 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill Mac preference for enabling Address Book "me" card usage.dhollowa@chromium.org2010-03-061-28/+139
| | | | | | | | | | | Adds a boolean preference to specify whether to use the Mac user's Address Book "me" card as a source of information for AutoFill addresses. This CL adds the Mac UI and the preference setup only. It does not cover the functionality for fetching the actual Address Book data. The changes to AutoFillDialog.xib add the checkbox UI and bind the checkbox to the |auxiliaryEnabled| property in the controller class. The |addressSection_| outlet is set to the spacer following the new checkbox. Unit tests are included for the addition of the preference at the mac dialog controller level. BUG=36496 TEST=PersonalDataManagerTest, AutoFillDialogControllerTest Review URL: http://codereview.chromium.org/668171 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40803 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Select right tab in content settings dialog.thakis@chromium.org2010-03-021-2/+22
| | | | | | | | | | | | | Also fix an unrelated TODO in this area. xib change: Make ContentSettingsWindowController the NSTabView's delegate and hook the controller's IBOutlet up to the NSTabView. BUG=36949 TEST=Open content settings via a blocked popups bubble. Popup tab should be selected. Select javascript tab, close window. Reopen window, javascript tab should still be selected. Review URL: http://codereview.chromium.org/661354 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40362 0039d316-1c4b-4281-b951-d872f2087c98
* Rename button from "Close" to "Done" on bookmark bubble and content bubbles.thakis@chromium.org2010-02-276-22/+62
| | | | | | | | | | | xib changes: Change ^IDS_CLOSE to ^IDS_DONE. BUG=36959 TEST=Open bookmark bubble. Button should read "Done". Go to popuptest.com, click "popups blocked" icon. Button in bubble should read "Done". Review URL: http://codereview.chromium.org/661235 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40202 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Content Settings Exceptions dialog.thakis@chromium.org2010-02-266-28/+947
| | | | | | | | | | | | | | | | | | | | | | | | | xib changes: ContentSettings.xib: Connect the various "Exceptions" buttons to their handlers and enable them. ContentBlocked*.xib: Now that exceptions can be edited, enable the radio buttons. ContentExceptionsWindow.xib: Add a xib with an exceptions window. Screenshot: http://imgur.com/fLwKA Screenshot on windows: http://imgur.com/UltQp Adding and editing exceptions doesn't work yet. I'll probably do this inline like in the bookmarks manager instead of with a sheet. BUG=34894 TEST=prefs->content settings->exceptions. if you set e.g. the cookie setting to "ask" and then say "remember" in the cookie dialog, these exceptions should show up in the cookie exceptions list. Likewise, if you use the radio group in the popup blocker bubble to override the blocking setting, that should show up there too. Also test this: 1.) Set cookie settings for www.tagesschau.de to "ask", leave window open 2.) Go to tagesschau.de 3.) In dialog, say "remember" and "block" 4.) in exceptions window, the setting should now say "block". Check that all buttons work as expected. Return should enter renaming mode for the current line, esc should stop editing, delete should delete the current line. Review URL: http://codereview.chromium.org/660150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40156 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill dialog UI polish. Based on feedback from thakis.dhollowa@chromium.org2010-02-261-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change to AutoFillDialog.xib was window anchoring flags to better position dialog in different window sizes on first run. > 1.) The initial position of the dialog is half off-screen on my 15'' MBP. It should probably be > more on the left. > Done. Auto centering now. > 2.) Furthermore, the dialog should autosave its position. See e.g. > keyword_editor_cocoa_controller.mm on how to do this (the |if (g_browser_process...)| block in > |initWithProfile| – it takes only a couple lines). > Done. > 3.) When clicking "Add an address", I find it weird that the new address starts in the collapsed > state. That makes it hard to see how to delete it again, and chances are that when I'm adding a > new address I want to edit it immediately. > Done. BUG=36441 TEST=see manual repro steps above. Review URL: http://codereview.chromium.org/660130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40075 0039d316-1c4b-4281-b951-d872f2087c98
* Translate Infobars for OS X.jeremy@chromium.org2010-02-251-709/+39
| | | | | | | | | | | Infobars.xib changes - Connect and fix class for close button since the translate infobar needs to know where it is to position the "Options" menu to it's left. BUG=34466 TEST=Translate infobars should continue to workon Windows. Review URL: http://codereview.chromium.org/594056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40034 0039d316-1c4b-4281-b951-d872f2087c98
* Custom "menus" for the bookmark bar folders. jrg@chromium.org2010-02-241-0/+886
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Full behavior: http://JRG_WRITE_FULL_DOC_AND_TEST_PLAN_TOMORROW BUG=17608 (and a slew of others) Brief details on how to test: - add some bookmarks and bookmark folders. - at a basic level, make sure bookmark folders feel like menus e.g. -- click to open -- can open "submenus" and sub-sub-menus -- can open (click on) bookmarks in any of these submenus - click-drag does NOT open a menu (different than Mac menus); it initiates a Drag - click on folder in bookmark bar initiates "hover open"; moving mouse over other folders will pop them open immediately (much like Mac menus) - Bookmark bar non-drag hover-open is immediate, but bookmark folder hover-open has a brief delay so quick "move down" a folder does not trigger them all to open while you travel (much like Mac menus). - DnD of bookmarks and folders on bookmark bar. - While doing DnD of bookmark, "hover" over a folder and see it open. - Bookmark folder menus have normal DnD "drop indicators" like the bookmark bar. - Can "hover open" a nested subfolder. - Can drag a bookmark from one deep sub-sub-folder to a different deep one. - Confirm buttons and folders in submenus are themed, both with the theme set at launch time and the theme we change to after launch. - Empty folders have an "(empty)" item which is not selectable. - Intentional delay in closing a sub-sub-folder when hovering over another one. E.g. When moving to a sub-sub-menu, 'brief' travel over a different submenu does not close the destination sub-menu. - can use bookmark context menus in folder "menus". - confirm DnD from "Other bookmarks" to any other random folder and vice versa. - While non-drag hover open is active, clicking anywhere other than the bookmark bar or folder (e.g. the main web view) turns it off. TODO: - random bugs (e.g. "add folder" over a folder doesn't put it in there) - (empty) needs to be revisited, both visually and for a drop indication - core animations instead of drop indicators - ... Review URL: http://codereview.chromium.org/551226 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39947 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Implement HTML5 database items in "Cookies and Other Data" dialog.evan@chromium.org2010-02-241-841/+475
| | | | | | | | | | | | | | Code changes to support a new variant of CocoaCookieTreeNode that displays the information about web databases. Changes to Cookies.xib: Added a new NSView "Database" in the existing information summary view for items selected in the cookie tree. This Database view provides the details for selected items that are web databases, and is in the same implement + layout style as the existing "Cookie" and "Local Storage" views. Added a key "databaseDescription" to the CocoaCookieTreeNode to support the display of the new node type. TEST=manual testing in the "Cookies and Other Data" dialog BUG=http://crbug.com/35191 Patch from Dan Clifford <danno@google.com>. Review URL: http://codereview.chromium.org/596058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39882 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for tab key view loop issue with Autofill dialog.dhollowa@chromium.org2010-02-241-1/+10
| | | | | | | | | | | | | | | | | | | | | | | | As sub-views got added and removed from the Autofill dialog the window's key view loop was not getting updated correctly. This manifested where tab cycling between text fields would not see the new address or credit card. After adding or removing an item we now tell the dialog's window to recompute the key view loop. Also including small cleanup to unit tests. Using scoped_nsobject<> at John's request. Also spotted that the dialog title was not internationalized properly. That is the change to AutoFillDialog.xib. Specifically, changed the dialog window title to be "^IDS_AUTOFILL_DIALOG_TITLE". BUG=36567 TEST=unit_tests --gtest_filter=AutoFillDialogControllerTest.*:AutoFillAddressModelTest.*:AutoFillAddressViewControllerTest.*:AutoFillCreditCardModelTest.*:AutoFillCreditCardViewControllerTest.*:DisclosureViewControllerTest.*:SectionSeparatorViewTest.*:VerticalLayoutViewTest.* TEST=1. Launch Chrome on Mac, 2. Open Preferences dialog, 3. Navigate to Personal Stuff panel, 4. Click on "Setup Autofill..." button, 5. Click in an address label text field, 6. Hit the tab key. 7. Create a new address with the "Add an Address" button, 8. Click in new address label text field, 9. Hit the tab key. Expect: focus to change to the next text field. Review URL: http://codereview.chromium.org/657036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39853 0039d316-1c4b-4281-b951-d872f2087c98
* These changes connect the AutoFill UI on the Mac with the back-end data ↵dhollowa@chromium.org2010-02-234-103/+388
| | | | | | | | | | | | | | | | | | | | | | | | store. Changes to a user's address and credit card information are now persisted. Other changes are: - Selectively disables the preferences "Setup autofill..." button when the PersonalDataManager is not available. - Allows the user to add or remove address or credit card entries in the AutoFill dialog. - The billing and shipping popup menus in the credit card entries now properly reflect the list of addresses. Notes on nib changes: - AutoFillAddressFormView.xib : added Delete button, wired to trigger |deleteAddress:| action. - AutoFillDialog.xib changed window size to encompass new controls. Added "Add Address" and "Add Credit Card" buttons. Wired them up to |addNewAddress:| and |addNewCreditCard:| actions, respectively. - Preferences.xib : |autoFillSettingsButton_| outlet wired up to facilitate disabling when no |PersonalDataManager| is available. - AutoFillCreditCardFormView.xib : added "Delete" button and wired up to |deleteCreditCard:| action. Removed outlets to menus that were only there for temporary disablement reasons. Set up bindings for billing and shipping address menu items and for their selected item. BUG=33029 TEST=unit_tests --gtest_filter=AutoFillDialogControllerTest.* Note new: Google Test filter = AutoFillDialogControllerTest.*:AutoFillAddressModelTest.*:AutoFillAddressViewControllerTest.*:AutoFillCreditCardModelTest.*:AutoFillCreditCardViewControllerTest.*:DisclosureViewControllerTest.*:SectionSeparatorViewTest.*:VerticalLayoutViewTest.* Review URL: http://codereview.chromium.org/650163 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39787 0039d316-1c4b-4281-b951-d872f2087c98
* Change find bar close button to use the standard hover close buttonfeldstein@chromium.org2010-02-231-34/+706
| | | | | | Review URL: http://codereview.chromium.org/652086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39750 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Implement most of the content settings dialog.thakis@chromium.org2010-02-221-74/+2315
| | | | | | | | | | | | | | | | xib changes: Added a tab view with all the UI, set up bindings for radio groups and checkboxes. Hooked up buttons. Missing for now: * "Exception" dialogs ("exception" buttons are disabled until then) * Some polish * The cookie "ask" dialog BUG=34894 TEST=Open content settings dialog. Set different things, click various things, and make sure they all have the expected effect. Review URL: http://codereview.chromium.org/652037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39601 0039d316-1c4b-4281-b951-d872f2087c98
* Add "Force Reload This Page" menu item on Mac.bauerb@chromium.org2010-02-221-5/+32
| | | | | | | | | | | | | | This CL adds a menu item "Force Reload This Page" with keyboard shortcut Command-Shift-R to the View menu in MainMenu.xib as an alternative, meaning it is shown instead of "Reload This Page" when the shift key is held down. BUG=36245 TEST=Open the view menu. Pressing shift should change "reload this page" into "force reload this page", which should do what it says. Also, Command-Shift-R should do the same thing. Astronomy picture of the day is a good test site for this. Review URL: http://codereview.chromium.org/651040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39594 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Move prefs around in preparation for the content settings window.thakis@chromium.org2010-02-228-351/+704
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also introduce scaffolding for the actual content settings dialog. xib changes: + Personal stuff * Move "Clear browsing data" button to under the hood tab * Move themes stuff up a bit to cover hole left by missing button + under the hood: * Created "Content Settings..." button * Got rid of cookie settings * Moved stuff around + clear data: * Added horizontal rule and flash player settings link, linked its action to new method. + content settings: * Added mostly empty window that contains "This is not implemented yet" label and a button that shows cookies (since I removed that from the prefs, so that it's still available). This window will be fleshed out very soon (in my next CL). * The window _is_ set up for l10n + bubble xibs: * Enable "Manage" links now that they open a window Four screenshots at http://imgur.com/axGiR&78O8g&wgk3p&6oOHj BUG=34656,34894 TEST="Clear data" button has moved from "Personal Stuff" to "Under the hood" in prefs. There's a "Content Settings" button next to it that opens a mostly empty window. The "Clear data" dialog now has a link to flash's privacy settings (which hang if one has the AdThwart extension installed, heh). Review URL: http://codereview.chromium.org/650124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39588 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Show content blocked bubbles.thakis@chromium.org2010-02-215-0/+4166
| | | | | | | | | | | | | | | | Two screenshots at http://imgur.com/5NDoC&pJJwP . xib changes: All 5 xibs contain a window of type InfoBubbleWindow with a custom InfoBubbleView. The view is connected to the controller's |bubble_| outlet. The controller is the window's |delegate|, and the window is the controller's |window|. The window is not visible at launch. It autorecalculates its key view loop. For the non-cookie xibs, the two buttons at the bottom are in GTMWidthBasedTweakers. Issues: * Clicking "blocked" icon with open bubble doesn't close the bubble BUG=35594,34894 TEST=Go to popuptest.com, start test. Click "Popups blocked" icon in omnibox. Bubble should appear. It should look sane in multiple locales (I tried English and German). The left button and the radio buttons are disabled at the moment, but the close button and the popup links should be functional. Review URL: http://codereview.chromium.org/650073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39581 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Implement the new AutoFill section of the Options dialog.jhawkins@chromium.org2010-02-171-2/+2
| | | | | | | | | | | | | | * Updated the text of the radio buttons. * Added a button that opens the AutoFill dialog. BUG=33025 TEST=manually Patch from Thiago Farina <thiago.farina@gmail.com> Review URL: http://codereview.chromium.org/579020 Review URL: http://codereview.chromium.org/610003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39251 0039d316-1c4b-4281-b951-d872f2087c98
* Adding UI behavioral improvements for managing tabbing between form fields ↵dhollowa@chromium.org2010-02-162-4/+92
| | | | | | | | | | | | | where the form is embedded within an NSScrollView. Also, when a disclosure view closes, its "content" should be disabled from the point-of-view of receiving tabbing focus. Nib file changes add the new |detailsView_| outlet to disclosure views. Also changed text fields to AutoFillTextFields to pick up auto-scrolling behavior. BUG=33029 TEST=unit_tests --gtest_filter=AutoFillDialogControllerTest.* Review URL: http://codereview.chromium.org/606067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39161 0039d316-1c4b-4281-b951-d872f2087c98
* Autofill dialog for the Mac. This is UI only at this point. The UI is not ↵dhollowa@chromium.org2010-02-124-67/+4220
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | hooked up to the back end yet. The UI demonstrates manipulation of one address and one credit card record. Eventually buttons will be added to add and remove additional records. The additions in this CL are: - Preferences dialog has a new "Change autofill settings" button that triggers an autofill settings dialog. - The autofill settings dialog now exists and allows the user to manipulate form autofill data. Specifically address information and credit card information. - Each address or credit card record is presented in a disclosure view to allow for summary or detailed views of each record. - The autofill dialog is layed out dynamically in a vertical list (ordered by y) using the VerticalLayoutView. - Sections are delimited visually with the SectionSeparatorView. There are currently two sections, one for addresses and one for credit cards. - Unit tests are present that exercise the invocation of the dialog and check basic functionality. Checks are performed to see that data is flowing from core profile and credit card data structures into Cocoa model data structures used for bindings internally by the UI. - There are three .xib files (AutoFillDialog.xib, AutoFillAddressFormView.xib, and AutoFillCreditCardFormView.xib) that partition the dialog UI into distinct views, controllers, and model objects. - Cocoa databinding is utilized to syncronize dependent parts of the UI. - All strings are stored in internationalized form in .grd files and .xib files (with one small TODO execption, see below). The things remaining to do are: - Hook the UI up to the backend model, specifically the PersonalDataManager data. - Add support for arbitrary number of address and credit card records. I.e. Add and Delete buttons. - Scroll-to-Point support for autoscrolling when tabbing between fields. - Billing and shipping address popups in the credit card section. - Any validation of input (need to circle back with UI folks on this). - Input validation unit tests. - String concatenation of the summary label needs to be internationalized. BUG=33029 TEST=none Review URL: http://codereview.chromium.org/558066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38873 0039d316-1c4b-4281-b951-d872f2087c98
* Make fonts not be clipped at large sizes in fonts and languages panel. ↵mirandac@chromium.org2010-02-121-815/+87
| | | | | | | | | | Also, left-align fonts and vertical-align them so that their baseline lines up with the baseline of their labels. BUG= 33296 TEST= adjust fonts and languages. name of font size should not be clipped. Review URL: http://codereview.chromium.org/572046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38860 0039d316-1c4b-4281-b951-d872f2087c98
* Add option to delete browsing history of the last hour.jochen@chromium.org2010-02-111-7/+28
| | | | | | | | | BUG=35302 TEST=manually test Review URL: http://codereview.chromium.org/596047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38721 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Mac compile by removing obsolete string and updating another.rsesek@chromium.org2010-02-101-117/+68
| | | | | | | | | | | | This is the second half of http://codereview.chromium.org/597013. TBR=pkasting BUG=none TEST=none Review URL: http://codereview.chromium.org/596027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38565 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Add local storage nodes to the cookie managerrsesek@chromium.org2010-02-091-536/+957
| | | | | | | | | | | | | | * Add local storage getters to CookieTreeNode * XIB: Embed cookie info labels into an NSView (inside the NSBox) and add another for info NSView for local storage. * Roll GTM r280:293 BUG=33068 TEST=Chromium-->Preferences-->Under the Hood-->Show cookies... Find and click on a local storage node. Info should be displayed. Review URL: http://codereview.chromium.org/599003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38504 0039d316-1c4b-4281-b951-d872f2087c98
* Change 'Import Bookmarks and Settings' menu item on Mac to have ellipses.mrossetti@chromium.org2010-02-091-901/+113
| | | | | | | | | BUG=28184 TEST=None Review URL: http://codereview.chromium.org/587013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38470 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Honor modifiers for clicks on home button.thakis@chromium.org2010-02-071-724/+46
| | | | | | | | | | | xib change: Change connection from "commandDispatch:" to "commandDispatchUsingModifiers:" for home button. BUG=34900 TEST=Enable home button in "Basics" in the prefs. Cmd-clicking the home button should open home page in new tab. Review URL: http://codereview.chromium.org/582009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38319 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] o Adds a slight drop shadow to the drawn images within Browser Action ↵andybons@chromium.org2010-02-051-93/+729
| | | | | | | | | | | | | buttons. o Adds initial BrowserActionsContainerView class that simply draws a right border at this time but will be used for more complex UI later. o Alters Toolbar.xib to use the new view class instead of a plain NSView. TEST=none BUG=none Review URL: http://codereview.chromium.org/565048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38278 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: fix crash deleting bookmark while bookmark editor is open.snej@chromium.org2010-02-041-0/+2
| | | | | | | | | | (xib change: enable 'preserve selection' in NSOutlineView.) BUG=33333 TEST=BookmarkEditorBaseControllerTest.SelectedFolderDeleted et al Review URL: http://codereview.chromium.org/566005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38139 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: fix menu IDs (Save Page As... and Text Encoding menu items).viettrungluu@chromium.org2010-02-031-151/+924
| | | | | | | | | | | | Fix breakage caused by <http://src.chromium.org/viewvc/chrome?view=rev&revision=37819>. Changed tags for File->{Save Page As..., Email Page Location, Print...} and View->Text Encoding. BUG=34463 TEST=Check that File->Save Page As... (and Cmd-S), File->Email Page Location, and View->Text Encoding work properly. Review URL: http://codereview.chromium.org/566033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37994 0039d316-1c4b-4281-b951-d872f2087c98
* To comply better with the Apple hig I changed the menu from showing a ↵thakis@chromium.org2010-02-031-37/+729
| | | | | | | | | | | | | checkmark icon next to Pause to alternating the words "Pause" and "Resume". XIB change: unset the 'On Image' on the Pause button. BUG=23069 TEST=Download large file and verify that the menu item says "Pause." Click "Pause" and the menu item should now say "Resume". Review URL: http://codereview.chromium.org/563001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37973 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Remove focus ring from table in task manager.thakis@chromium.org2010-02-011-3/+3
| | | | | | | | | | | | | xib change: Change "Focus Ring" from "Default" to "None" on both scroll view and contained table view. This does not address the ring around the first column when tabbing through. BUG=33699 TEST=Click row in table in task manager. The table should not have a focus ring. Review URL: http://codereview.chromium.org/559004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37735 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Fix IB warning about progressView_.thakis@chromium.org2010-02-011-732/+55
| | | | | | | | All I did was re-save in IB, no changes. Review URL: http://codereview.chromium.org/557081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37706 0039d316-1c4b-4281-b951-d872f2087c98
* ExtensionInstalledBubble for Mac.mirandac@chromium.org2010-01-311-0/+685
| | | | | | | | | | Adds ExtensionInstalledBubble.xib, which contains the framework for the bubble itself (icon view, close button, and three message fields). BUG= 26974 TEST= Install an extension. Bubble should show same information as windows bubble. Review URL: http://codereview.chromium.org/527012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37671 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-17 20:37:15 +0000