summaryrefslogtreecommitdiffstats
path: root/chrome/app/nibs
Commit message (Collapse)AuthorAgeFilesLines
* notification balloons: Remove views and cocoa implementations of ↵sadrul@chromium.org2014-04-101-555/+0
| | | | | | | | | | | | | | | BalloonCollection. In both aura/views and mac, notifications are done through the message-center. So the implementations of BalloonCollection are never used. So remove these. Only the GTK version of the implementation remains. BUG=354062, 361784 R=mukai@chromium.org, rsesek@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/231213003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262988 0039d316-1c4b-4281-b951-d872f2087c98
* Fix remaining SadTabView anti-aliasing issues.ccameron@chromium.org2014-03-181-165/+0
| | | | | | | | | | | | | | | | | | | | The SadTabView is in a strange situation where it is set up almost entirely programmatically, but yet it is still loaded through an xib. Remove the programmatically set up and arranged elements from the xib entirely, and allocate them manually. Use a subclass of NSTextField to with isOpaque overwritten to enable text anti-aliasing. Use NSTextField instead of NSTextView because the manual resizing code is written against NSTextField, and lines get broken in different places when switching to NSTextView. BUG=351456 Review URL: https://codereview.chromium.org/202783002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257707 0039d316-1c4b-4281-b951-d872f2087c98
* Make setting strings consistent in the 2nd personedwardjung@chromium.org2014-02-181-1/+1
| | | | | | | | BUG=156975 Review URL: https://codereview.chromium.org/156883006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251756 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Tabpose feature on mac, and supporting infrastructure (PaintAtSize)piman@chromium.org2014-02-141-41/+0
| | | | | | | | | | | | | | | | Tabpose has been behind a flag for 3 years, and UMA shows usage is very low. It is the unique user of the RenderWidgetSnapshotTaker, and the only user of RWH::PaintAtSize, which we want to remove. XIB changes: * Remove Tabpose menu entry "Show Tab Overview..." BUG=251960, 223336 R=cevans@chromium.org, jamesr@chromium.org, sky@chromium.org, viettrungluu@chromium.org Review URL: https://codereview.chromium.org/154083008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251439 0039d316-1c4b-4281-b951-d872f2087c98
* OneClickSigninBubbleView: Only show title if no error present.orenb@chromium.org2014-02-031-3/+13
| | | | | | | | | | | | | | | | | | For the error case: - Hide the "You're now signed in to Chrome" title. - Change "OK, got it!" to just "OK" XIB changes: - Connected the close (OK) button to the closeButton_ outlet, which was for some reason missing before. Screenshots (disregard text of errors; samples were used): - Mac: http://i.imgur.com/hPDAY8i.png - Views: http://i.imgur.com/ZM9ktga.png BUG=333988 Review URL: https://codereview.chromium.org/137563002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248618 0039d316-1c4b-4281-b951-d872f2087c98
* Make sideloaded (externally installed) extensions display webstore infordevlin.cronin@chromium.org2014-01-291-0/+0
| | | | | | | | | | | | | | | | Have sideloaded extensions pull data from the webstore (a la inline install) in order to give the users a better idea of what extension they are installing. Images worth 1000 words: http://imgur.com/zlexZeb,VljPXLz,WzT2ZOc#0 XIB changes: * rename 'app/nibs/ExtensionInstallPromptInline.xib' to 'app/nibs/ExtensionInstallPromptWebstoreData', since the same prompt is now used for inline prompts and for sideloaded extensions when webstore data is available. BUG=323063 Review URL: https://codereview.chromium.org/145153002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247604 0039d316-1c4b-4281-b951-d872f2087c98
* OneClickSigninBubbleView: Update the bubble form to reflect new bubble/orenb@chromium.org2014-01-091-24/+90
| | | | | | | | | | | | | | | | | | | | | | | | dialog UI design paradigm [Mac/Views]: - Add a title ("You're now signed in to Chromium!") - Modify "OK" button to say "OK, got it!" instead - Adjust margins and gaps according to spec. XIB changes: * Added a new NSTextField for the “You’re now signed in to Chromium” title. * Made the entire bubble taller (167 height) and wider (350 width) to accommodate new UI spec and to make room for the title text field. * Repositioned the Advanced link and the OK button in order to have 10 view units margin from the bottom and left/right edges (also for new UI spec). Screenshots: * Mac: http://i.imgur.com/qKWKwR4.png * Views: http://i.imgur.com/6fYmi42.png BUG=322593 R=thakis@chromium.org Review URL: https://codereview.chromium.org/107673002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243744 0039d316-1c4b-4281-b951-d872f2087c98
* Add groby to c/b/ui/cocoa/OWNERS!thakis@chromium.org2014-01-081-0/+1
| | | | | | | | | BUG=none NOTRY=true Review URL: https://codereview.chromium.org/128713005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243669 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Hook up the "Remove" button in the collected cookies dialog.rsesek@chromium.org2014-01-081-22/+183
| | | | | | | | | | | | | | | | | | This also resurrects the CookiesTreeModelObserverBridge (now called CookiesTreeControllerBridge) that I removed in r77477 along with the rest of the native preferences. The class is used to dynamically update the tree view in response to model changes. XIB changes: * Made the "Blocked" tab buttons use the constrained window style. * Matched the height of the NSOutlineView between the allowed and blocked tabs. BUG=168996 TEST=Go to google.com, click on the lock icon, click on "Show cookies", and remove site data from the Allowed pane. Review URL: https://codereview.chromium.org/128673002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243633 0039d316-1c4b-4281-b951-d872f2087c98
* Create hosted apps from any website for streamlined hosted apps.calamity@chromium.org2013-11-181-3/+3
| | | | | | | | | | | | | | | | | | This CL replaces the "Create application shortcuts" button in Wrench Menu > Tools with "Create app for this website" for the streamlined hosted app experience. Rather than creating shortcuts, this button creates a hosted app that points to the website. From there, the user can right click the hosted app and press "Create shortcuts" if they wish. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235012 Review URL: https://codereview.chromium.org/34533002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235623 0039d316-1c4b-4281-b951-d872f2087c98
* This CL refactors the code for the new password key icon in the omnibox and ↵npentrel@chromium.org2013-11-081-1190/+0
| | | | | | | | | | | | | | | | the password bubble that pops up from the icon. These will replace the password infobar. The code was previously nested in the code for the content settings but should be changed the functionality needed is too different and it is no content setting in any case. To refactor this code, some of the code resembles the code used for the zoom icon and bubble. Only the code for gtk and aura are refactored. The code for cocoa is removed for now and will be added again in another CL. BUG=261628 Review URL: https://codereview.chromium.org/35333002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233726 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Update the warnings UI for malicious downloads.asanka@chromium.org2013-11-051-23/+231
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When SafeBrowsing detects that a download is malicious, the user is only presented with a 'Dismiss' option. Additional options ('Learn more' and optionally 'Report', if applicable) are available from a context menu. This behavior has been available on the Windows build. This change brings the Mac UI up to parity. XIB Changes (DownloadItem.xib): * Add new controls for malicious downloads: * New GTMWidthBasedTweaker for managing the size of 'Dismiss' button connected to maliciousButtonTweaker: IBOutlet. * New 'Dismiss' push button connected to dismissMaliciousDownload: IBAction. * New disclosure button connected to showContextMenu: IBAction. * Change connection for GTMWidthBasedTweaker containing 'Discard' button to dangerousButtonTweaker: IBOutlet. * Anchor WidthBasedTweakers on the left instead of the right since the code assumes that the tweakers don't shift horizontally when the embedded buttons change size. * Change height of Insecure Download NSBox to match the height of the DownloadItemButton. * Adjust position of buttons for both dangerous and malicious downloads so that they are centered in the download shelf. BUG=235931 TEST=(1) Download something from a URL that is identified by SafeBrowsing as malicious. (2) Check that the download shelf displays a warning indicating that the download was malicious and that it was blocked. There should only be a "Dismiss" button and a disclosure button. (3) Click on the disclosure button. It should display a menu with a 'Learn more' item. Clicking on that item should open the SafeBrowsing help center article. (4) Click on the 'Dismiss' button. The warning should go away. If it was the only download, the shelf should also disappear. (5) Open chrome://downloads. The download should still be here with a 'Recover' option and a 'Remove' option. Original Review URL: https://codereview.chromium.org/40733005/ Review URL: https://codereview.chromium.org/57963005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232945 0039d316-1c4b-4281-b951-d872f2087c98
* New ScreenCaptureNotificationUI implementation for Cocoasergeyu@chromium.org2013-10-051-382/+0
| | | | | | | | | | | Reimplemented ScreenCaptureNotificationUICocoa to make it consisten with the Views implementation. BUG=190156 Review URL: https://codereview.chromium.org/25824002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227188 0039d316-1c4b-4281-b951-d872f2087c98
* Removing my self from OWNERSsail@chromium.org2013-09-301-1/+0
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/25313002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226006 0039d316-1c4b-4281-b951-d872f2087c98
* Drop-down menu added to the save password bubble behind flag according to ↵npentrel@chromium.org2013-09-241-30/+210
| | | | | | | | | | | | | | | | mocks. The menu gives the user the options "Nope" and "Never save passwords for this site" Changes to the xib file: Adding a small drop down symbol (a pop up button without borders) on top of the 'Nope' button. this drop down menu has the options 'Nope' and 'Never save passwords for this site' which the user can select. The menu items are linked to closeBubble: and blacklistBubble: respectively. Both will ultimately close the bubble. Screenshot: https://docs.google.com/a/google.com/file/d/0B_h2sAQjy6escll3ZGFodEIxOGs/edit?usp=sharing BUG=261628 Review URL: https://chromiumcodereview.appspot.com/24124003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224961 0039d316-1c4b-4281-b951-d872f2087c98
* Add remaining items to Chrome App menus. (Mac)jackhou@chromium.org2013-09-231-0/+4
| | | | | | | | | | | | | | | | | | | | | | These are disabled as they are not yet implemented. They are being added now primarily for aesthetic reasons, on advice from UX. Menu items added: <app> -> About <app> File -> New File -> Open File Menu items removed: Edit -> Find This also adds a new resource string for "New", and NSTags to various NSMenuItems in MainMenu.xib. BUG=168080, 276052 Review URL: https://chromiumcodereview.appspot.com/24153009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224687 0039d316-1c4b-4281-b951-d872f2087c98
* [cocoa] Save password bubblenpentrel@chromium.org2013-09-111-0/+1010
| | | | | | | | | | | | | XIB changes: * add ContentBlockedSavePassword.xib. This is almost the same as ContentBlockedMixedScript.xib except for the addition of an additional NSButtons and the deletion of the Done button. This is the cocoa implementation of the save password bubble. This code depends on another CL (https://codereview.chromium.org/22975006/). BUG=261628 Review URL: https://chromiumcodereview.appspot.com/24057008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222566 0039d316-1c4b-4281-b951-d872f2087c98
* Add Hide to app menu.jackhou@chromium.org2013-09-061-0/+1
| | | | | | | | | | | | | | | | | | | This adds "Hide <app>" to the app menu that is shown when an app window has focus. This also enables the Cmd+H shortcut. This also adds an IPC message to instruct the shim to hide. This also adds a command ID for Hide and a corresponding tag to MainMenu.xib. BUG=168080, 276052 TEST=Start an app. Press Cmd+H or select Hide from the main menu. The app should hide. Clicking the app's dock icon, or Cmd+Tab to the app should show it again. Review URL: https://chromiumcodereview.appspot.com/23514021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221676 0039d316-1c4b-4281-b951-d872f2087c98
* Replicate standard menus for apps.jackhou@chromium.org2013-08-301-0/+17
| | | | | | | | | | | | | | | | | | This maintains a duplicate set of menus for standard items. This enables keyboard shortcuts to work as expected when the Chrome menus are hidden. This also adds tags to various items in MainMenu.xib using existing and new entries from chrome_command_ids.h. The tags are used to look up items in the main menu. BUG=168080, 276052 TEST=When an app window is focused, the main menu should change to a set of menus relevant to apps. I.e. Chrome specific menus/items should be hidden. The item in the menus should behave as expected for the app. Review URL: https://chromiumcodereview.appspot.com/23005021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220659 0039d316-1c4b-4281-b951-d872f2087c98
* Mac InfoBar: Use cross platform infobar classessail@chromium.org2013-08-281-169/+0
| | | | | | | | | | | | | | | | | | Currently the Mac code has a dummy InfoBar implementation that it unused. This code replaces that with the cross platform implementation. Using the cross platform implementation means: - animation is now driven by the cross platform code - layout is now controlled by InfoBarContainer - InfoBarDelegate is now owned by InfoBar BUG=62154 TEST= TBR=thakis Review URL: https://chromiumcodereview.appspot.com/23338005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219956 0039d316-1c4b-4281-b951-d872f2087c98
* Make user name field of login dialog the first responder sail@chromium.org2013-08-131-10/+15
| | | | | | | | | | | | | | | XIB changes: - set the first responder of the window to be the user name text field. BUG=261622 TEST=Navigate to http://www.pagetutor.com/keeper/mystash/secretstuff.html Verify that the user name field has focus. Review URL: https://chromiumcodereview.appspot.com/22819003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217163 0039d316-1c4b-4281-b951-d872f2087c98
* Update chrome/app/nibs OWNERS after c/b/u/cocoa/OWNERS updates.rsesek@chromium.org2013-08-121-6/+1
| | | | | | | | | R=mark@chromium.org NOTRY=true Review URL: https://chromiumcodereview.appspot.com/22859002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217002 0039d316-1c4b-4281-b951-d872f2087c98
* Web MIDI: Implement icon image and bubbletoyoshim@chromium.org2013-08-091-0/+848
| | | | | | | | | | | | | | | | The last change to implement content settings for Web MIDI. With this change, the page will have an icon which indicate the page has a full control of MIDI devices or not. XIB changes: * add ContentBlockedMIDISysEx.xib. This is almost the same thing with ContentBlockedGeolocation.xib except for NSButtonCell's content IDS id. BUG=257618 Review URL: https://chromiumcodereview.appspot.com/18004004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216650 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Use cross platform model for download shelf context menu.asanka@chromium.org2013-07-261-449/+14
| | | | | | | | | | | | | | | | | | | | XIB changes: * Remove 'Completed Download' menu. * Remove 'Active Download' menu. BUG=28978 TEST=(1) Start a long download. (2) Open the drop down menu for the resulting download item. (3) Menu should have "Open When Done"/ "Always Open Files of This Type"/"Pause"/"Show in Finder"/ "Cancel" items. (4) Paused downloads should show "Resume" instead of "Pause". (5) Completed downloads should show "Open" instead of "Open When Done" and no "Pause"/"Resume" action. Review URL: https://chromiumcodereview.appspot.com/20057003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213865 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmark sync promo for Mac.fdoray@chromium.org2013-07-221-17/+105
| | | | | | | | | | | | | | | | | | | | | | | | | | Adds a bookmark sync promo at the bottom of the bookmark bubble. The promo is only shown to users that are not signed in. Clicking the link in the sync promo opens the sign in page. Screenshot: http://i.imgur.com/08v1KdE.png Changes to BookmarkBubble.xib - Add an empty NSView placeholder at the bottom of the root view. http://i.imgur.com/a0GQZ14.png - Connect IBOutlet syncPromoPlaceHolder_ from file owner (BookmarkBubbleController) to this placeholder. Design document: https://docs.google.com/a/google.com/document/d/1Jduor831szvkdq3cwlWrFw91a8Pzu1ynAs5hlGc7MvM/edit?usp=sharing TEST= 1. Open Chromium with the --enable-bookmark-sync-promo flag. 2. Make sure you are not signed in. 3. Open the bookmark bubble (click on the bookmark star or Command+D). Expected result: a sync promo is displayed at the bottom of the bookmark bubble. 4. Click the "Sign in" link in the sync promo. Expected result: the sign in page is loaded. BUG=244279 Review URL: https://chromiumcodereview.appspot.com/18313006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212911 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the integrated desktop Chrome To Mobile Service and UI.msw@chromium.org2013-07-181-1117/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove ChromeToMobile service, factory, unittests, and UI. Remove IDS_CHROME_TO_MOBILE* strings. Remove IDC_CHROME_TO_MOBILE_PAGE and adjust IDC values. Remove IDR_MOBILE and chrome/app/theme/*/mobile[_lit].png Remove browser frame and location bar callers, consts. Remove prefs::kChromeToMobileDeviceList from user profiles. Add code in c/b/prefs/browser_prefs.cc to clear this value. The UMA histograms will be removed in a related CL: https://chromereviews.googleplex.com/9087014/ WontFix'ed issues related to this code, listed for future reference: -Issue 120941: Chrome To Mobile: An error occured while sending the page. -Issue 154709: Last selected mobile device not stored and automatically reselected -Issue 154710: Ordering of mobile devices not consistent -Issue 156843: Only acknowledge invalidation after device search is finished in ChromeToMobileService -Issue 122183: Make ChromeToMobile API more testable, drop gmock. BUG=260121 TEST=Dead user pref is cleared, no compile failures/crashes. R=rfevang@chromium.org,battre@chromium.org,sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/19256007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212219 0039d316-1c4b-4281-b951-d872f2087c98
* Remove myself from various OWNERS files.viettrungluu@chromium.org2013-07-161-1/+0
| | | | | | | | | | NOTRY=true BUG=none R=brettw@chromium.org Review URL: https://codereview.chromium.org/19218003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211841 0039d316-1c4b-4281-b951-d872f2087c98
* Create a content setting for the multiple automatic downloads infobarbenjhayden@chromium.org2013-07-101-0/+1126
| | | | | | | | | | | | | | | | | | | | Clicking Allow on the infobar sets the content setting for that origin (protocol+host) to ALLOW; Deny sets it to BLOCK. Blocked/Allowed origins may be changed/cleared in chrome://settings > Show Advanced Settings > Privacy > Content Settings > Multiple Automatic Downloads Closing the infobar without clicking Allow or Deny cancels all pending automatic downloads without setting the content setting to BLOCK. Origins that are set to BLOCK are allowed one automatic download then no more, and the infobar is not shown. A button+label does appear in the location bar reading "Download blocked"; clicking on this button opens a popup containing radio buttons and link to chrome://settings/contentExceptions The default value of the content setting can be changed from ASK (which triggers the infobar) to ALLOW or BLOCK in chrome://settings/content Test url (Google-only): http://www/~benjhayden/multi.html BUG=166335 Review URL: https://chromiumcodereview.appspot.com/12476007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210954 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Add user's email address to SAML confirmation dialog and cleanup ↵noms@chromium.org2013-07-101-3/+3
| | | | | | | | | | | | | | | unused strings. Since this was the last leftover change related to the SAML dialogs, also clean up the now unused strings from the gtk and views dialogs. Xib changes: No default value for the dialog's title, as it is now always dynamically generated using the user's email address. BUG=222924 TEST=Go to gmail.com. Sign in with a test email address. On the Chrome signin interstitial, choose "Sign in to Chrome". You should get a confirmation dialog that asks you to confirm you want to sign in, and displays your email address.(see crbug.com/222924 for screenshot) Review URL: https://chromiumcodereview.appspot.com/18191017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210748 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac][Panels] Make it easier to minimize panels.rsesek@chromium.org2013-06-291-7/+7
| | | | | | | | | | | | | | | This enables window minimization of panels through the standard Cmd+M shortcut. If the panel is detached, it goes into the dock like a normal window, but if it's attached, then it will be minimized to the bottom of the screen. This also enables minimization behavior when the titlebar is double-clicked. BUG=104394,255139,177821 TEST=Double clicking on a panel titlebar minimizes it. Cmd+M does, too. Review URL: https://chromiumcodereview.appspot.com/18177010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209343 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Use 14 point lucida grande in Omniboxsail@chromium.org2013-06-211-17/+14
| | | | | | | | | | | | | | | | | | | | | | | | | This CL changes the omnibox font to 14 point lucida grande. This CL also changes the omnibox to be 2 pixel bigger and the toolbar to be 2 pixel bigger. (This was perviously behind an instant extended flag.) XIB Changes: - increase height of toolbar view by 1 - increase height of location bar view by 2 - move location bar view 1 pixel up Screenshots: http://i.imgur.com/IeFXlwS.png http://i.imgur.com/Z5eFRHY.png BUG=251978 NOTRY=true R=samarth@chromium.org, shess@chromium.org Review URL: https://codereview.chromium.org/17229009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207649 0039d316-1c4b-4281-b951-d872f2087c98
* Reuse IDS_BOOKMARK_ALL_TABS_DIALOG_TITLE in mac dialog as well.tfarina@chromium.org2013-06-181-1/+1
| | | | | | | | | | | | | This means the window title will not have the trailing elipses "..." anymore. TEST=open two or more tabs in a browser window. Press the shortcut equivalent to ctrl+shift+d on Mac, see the dialog opened. Observe that the window title reads "Bookmark All Tabs". R=thakis@chromium.org Review URL: https://chromiumcodereview.appspot.com/17192003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206941 0039d316-1c4b-4281-b951-d872f2087c98
* Instead of displaying a camera icon only display a microphone icon in the ↵xians@chromium.org2013-06-171-46/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | omnibox if the microphone stream is captured (but not the camera stream). It is a relanding CL of https://codereview.chromium.org/12706018, with some modifications on the UI. XIB changes: * Removed mediaMenusContainer_, since we will add the media menu(s) and reposition them programingly. chrome/app/theme/theme_resources.grd: TBR=sail@chromium.org BUG=172780 TEST=unit_tests --gtest_filter="*ContentSettingBubbleModelTest*" ./out/Debug/unit_tests --gtest_filter="*TabSpecificContentSettingsTest*" manual test (1) Visit https://www.corp.google.com/~henrika/no_crawl/webrtc/manual/peerconnection.html (2) Allow/Deny the audio or/and camera permission on the infobar. (3) Verify the UI correctly shows what permission is being accessed. Screenshots for the mic-only, camera-only, mic-and-camera access. http://imgur.com/2wVJ31A http://imgur.com/eTabsIN http://imgur.com/NxJI4we Review URL: https://chromiumcodereview.appspot.com/16370010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206704 0039d316-1c4b-4281-b951-d872f2087c98
* Display the list of retained files in the extension permissions dialog.sammc@chromium.org2013-06-081-1/+1
| | | | | | | | | | | | | | | | | | | | The dialog allows the user to revoke access for the app, restarting it if it's currently running. If the app/extension has not retained access to any files, the dialog is unchanged. [Mac] XIB change: - Enable "Show Vertical Scroller" for the scroll view. Dialog screenshots: https://code.google.com/p/chromium/issues/detail?id=224684#c6 BUG=224684 TEST=Install an app that uses chrome.fileSystem.retainEntry and open a file with it. In chrome://extensions/ click the permissions link for that app. The filename should be listed. Review URL: https://chromiumcodereview.appspot.com/15943007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205028 0039d316-1c4b-4281-b951-d872f2087c98
* The Advanced Link should not be displayed for the signin error bubblenoms@chromium.org2013-05-161-1/+1
| | | | | | | | | | | XIB changes: the informativePlaceHolder (used by the Learn More link) was very wide, and when moved down, covered the OK button. It is now less wide. BUG=237770 TEST=Ensure that you have two different profiles. In one profile, sign in with an email address. The confirmation bubble should have, on the bottom line, an Advanced link/OK button. In the second profile, try to sign in with the same email address. The error bubble should not have an Advanced link, and the OK button should be aligned at the bottom with the Learn More link Review URL: https://chromiumcodereview.appspot.com/15051004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200590 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Display a native bubble (instead of the JS one) after the web signin flow. noms@chromium.org2013-05-021-102/+79
| | | | | | | | | | | | | | | | | XIB changes: Deleted "Undo" button from the Bubble dialog, and copied the InformativePlaceholderText from chrome/app/nibs/OneClickSigninDialog.xib, which allows the "Learn More" link to be displayed. Part of a 3 CL Voltron, along with: [Win] https://codereview.chromium.org/13979003/ [GTK] https://codereview.chromium.org/14258007/ (branched off https://codereview.chromium.org/13979003/) BUG=119728 TEST=Open Chrome. Delete all your profiles, so that you have a fresh one. Open a new tab, and press the "sign in" link in the top right corner. Sign in. Upon completion, this should show a native popup bubble, anchored off the wrench menu. If you try to log in with the same email in another profile, the bubble should display a sad error message. Check out the issue description for screenshots. Review URL: https://chromiumcodereview.appspot.com/13845022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197769 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Adding new logging for one click confirmation dialog.noms@chromium.org2013-04-291-12/+8
| | | | | | | | | | | | | (branched off: https://codereview.chromium.org/14348030/) Fixed Close button functionality (was previously calling -ok when it shouldn't start sync) XIB changes: Added new event handler (onClickClose) for the Close button click (it was previously calling -ok). BUG=235187 Review URL: https://chromiumcodereview.appspot.com/14414005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197033 0039d316-1c4b-4281-b951-d872f2087c98
* Fix max XIB version to be 4.6.x for realz.asvitkine@chromium.org2013-04-261-3/+3
| | | | | | | | BUG=none Review URL: https://codereview.chromium.org/14516005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196738 0039d316-1c4b-4281-b951-d872f2087c98
* Update max Xcode version in XIB presubmit.asvitkine@chromium.org2013-04-251-1/+1
| | | | | | | | | BUG=none TEST=Files saved with Xcode 4.6.x don't trigger presubmit. Review URL: https://codereview.chromium.org/14060023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196490 0039d316-1c4b-4281-b951-d872f2087c98
* Add asvitkine chrome/app/nibs/OWNERS.asvitkine@chromium.org2013-04-251-0/+1
| | | | | | | | BUG=none Review URL: https://codereview.chromium.org/13877024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196459 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 195543 "Increase panel icon height to be as tall as titlebar"dimich@chromium.org2013-04-251-1/+1
| | | | | | | | | | | | | | | | > Increase panel icon height to be as tall as titlebar > > TBR=rsesek@chromium.org > BUG=233753 > TEST=Manual test by launching panel and verifying its icon > > Review URL: https://codereview.chromium.org/13835008 TBR=jianli@chromium.org Review URL: https://codereview.chromium.org/13979013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196280 0039d316-1c4b-4281-b951-d872f2087c98
* Increase panel icon height to be as tall as titlebarjianli@chromium.org2013-04-221-1/+1
| | | | | | | | | | TBR=rsesek@chromium.org BUG=233753 TEST=Manual test by launching panel and verifying its icon Review URL: https://codereview.chromium.org/13835008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195543 0039d316-1c4b-4281-b951-d872f2087c98
* Consolidate the IDS_BOOKMARK_CURRENT_PAGE_MAC string used for "Bookmark This ↵tfarina@chromium.org2013-04-061-1/+1
| | | | | | | | | | | | | | | Page..." message. This change unifies IDS_BOOKMARK_CURRENT_PAGE_MAC and IDS_BOOKMARK_STAR into a single one called IDS_BOOKMARK_THIS_PAGE that is defined for both non title-case and title-case. BUG=225602 R=sky@chromium.org,erg@chromium.org,thakis@chromium.org Review URL: https://chromiumcodereview.appspot.com/13671006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192742 0039d316-1c4b-4281-b951-d872f2087c98
* mac: Fix bookmark bar docking animation if the user has no bookmarks.thakis@chromium.org2013-04-041-30/+14
| | | | | | | | | | | | | | | | xib changes: Pin buttonView_, [buttonView_ noItemTextfield], and [buttonView_ importBookmarksButton] to both top and bottom, so that they stay centered when changing the height of the bookmarks bar during the Instant Extended bookmark bar docking animation on the NTP. BUG=225827 TEST=Open NTP with no bookmarks, hit cmd-shift-b, watch bookmarks bar animation. Watch bookmarks bar animation. "For quick access, ..." text stays centered and animates nicely instead of jumping around. Review URL: https://codereview.chromium.org/13611002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192336 0039d316-1c4b-4281-b951-d872f2087c98
* Wrench Icon: Cocoa button cellsail@chromium.org2013-04-031-143/+17
| | | | | | | | | | | | | | | | | | | The wrench icon will no longer show status using a badge. Instead, the icon color will change to indicate status. This CL adds a NSButton cell to draw the wrench button icon. XIB changes: * Change class of wrench button cell from ClickHoldButtonCell to WrenchToolbarButtonCell. Screenshot: http://i.imgur.com/OfZA4uE.png Video: https://docs.google.com/file/d/0B0Odde3V7EhWelB6ZEgwcE03ckk/edit?usp=sharing BUG=180107 TEST=Ran Chrome with --simulate-upgrade. Verified that no badge was shown and that the wrench icon was colored. Review URL: https://chromiumcodereview.appspot.com/13375016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191948 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] DownloadShelf should be notified when autoclosing.asanka@chromium.org2013-04-011-56/+21
| | | | | | | | | | | | | | | | | | | | | | | | | If the download shelf is already hidden, then the autoclosing logic on Mac wouldn't notify the DownloadShelf. If the shelf was hidden temporarily due to the browser entering fullscreen mode, then the shelf would be restored on exiting fullscreen mode. Also fix UMA logging of download shelf closures on Mac and assorted cleanup. XIB changes: * Connect close button to |-handleClose:| instead of |-hide:|. BUG=222360 TEST=(1) Download something that is marked for opening automatically (e.g. a browser extension). (2) Enter fullscreen mode before download completes. (3) Wait for download to complete. (4) Exit fullscreen mode. The download shelf should be hidden. Review URL: https://chromiumcodereview.appspot.com/12995025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191618 0039d316-1c4b-4281-b951-d872f2087c98
* Reland "i18n-fixlet: Make IDS_APPMENU_TOOLTIP branding sp..."tfarina@chromium.org2013-03-241-1/+1
| | | | | | | | | | | | | | | | It was reverted because I didn't update chrome/app/nibs/Toolbar.xib which thus broke Mac builders. It was reverted in r189260 - https://codereview.chromium.org/12491022. The original patch was r189242 - https://chromiumcodereview.appspot.com/12909002 R=tony@chromium.org,sail@chromium.org TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/12611021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190291 0039d316-1c4b-4281-b951-d872f2087c98
* Improve appearance of media content settings bubble layout on Macgrunell@chromium.org2013-03-231-16/+8
| | | | | | | | | | | | | | | | | | | | | | | | Code changes: - Space between device buttons is decreased. - Device button labels are right aligned. - Device button label text is vertically aligned to the device button text baseline. XIB changes: - Divider moved up 2px. - Custom view height changed from 52px to 45px. The XIB changes gives the following effect: - Space above divider is decreased. - Space below divider is increased. Screenshots in bug. BUG=223065 TEST=See bug. Review URL: https://chromiumcodereview.appspot.com/12893012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190090 0039d316-1c4b-4281-b951-d872f2087c98
* Copy remoting notification bar to chrome and use it for screen capture API.sergeyu@chromium.org2013-03-231-0/+382
| | | | | | | | | | | | | | | | | Chrome must show notification bar when screen capture API is used to capture the screen. This CL reuses the notification bar that's currently used by remoting host (see src/remoting/host/disconnect_window*). The new files are mostly copy of the existing code in remoting (except different names). The plan is to keep it temporarily and replace it with something better before the API is enabled for everybody. BUG=190156 Review URL: https://chromiumcodereview.appspot.com/12453019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190041 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: "Import bookmarks..." right click shouldn't bring up context menu.asvitkine@chromium.org2013-03-191-14/+0
| | | | | | | | | | | | | | XIB changes: Changed class of the import button item back to NSButton and unhooked the barView_ outlet. BUG=214212 TEST=Right click on "Import bookmarks..." links in an empty BMB. No context menu should be shown. Review URL: https://chromiumcodereview.appspot.com/12538012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188887 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-14 23:00:44 +0000